coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: soc/amd: Fix generating SMBIOS Type 17
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25304 ) Change subject: soc/amd: Fix generating SMBIOS Type 17 ...................................................................... Patch Set 17: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/24292/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/70023/ : SUCCESS -- To view, visit https://review.coreboot.org/25304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I076bc3f965f81a9374c8976da48c7fdce014dc0c Gerrit-Change-Number: 25304 Gerrit-PatchSet: 17 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 17:08:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: include/memory_info.h: Change serial number field from 5 bytes to 4
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25343 ) Change subject: include/memory_info.h: Change serial number field from 5 bytes to 4 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24293/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70024/ : SUCCESS -- To view, visit https://review.coreboot.org/25343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc58ad9ea4cdd2abe06a170a39b1f32680e7b299 Gerrit-Change-Number: 25343 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 17:07:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/riscv: Store mprv bit in size_t
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25625 ) Change subject: arch/riscv: Store mprv bit in size_t ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24291/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70022/ : SUCCESS -- To view, visit https://review.coreboot.org/25625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I003c1b88b4493681dc9b6178ac785be330203ef5 Gerrit-Change-Number: 25625 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 16:53:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/riscv: Store mprv bit in size_t
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25625 ) Change subject: arch/riscv: Store mprv bit in size_t ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/24290/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/70021/ : SUCCESS -- To view, visit https://review.coreboot.org/25625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I003c1b88b4493681dc9b6178ac785be330203ef5 Gerrit-Change-Number: 25625 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 16:21:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/riscv: Store mprv bit in size_t
by Jonathan Neuschäfer (Code Review) 12 Apr '18

12 Apr '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/25625 Change subject: arch/riscv: Store mprv bit in size_t ...................................................................... arch/riscv: Store mprv bit in size_t CSRs are XLEN bits wide (i.e. the same width as general purpose registers), so size_t seems a little more correct than int. This change doesn't affect functionality because MSTATUS_MPRV already fits in 31 bits. Change-Id: I003c1b88b4493681dc9b6178ac785be330203ef5 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/include/vm.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/25625/1 diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index fd0a2c9..a30d6bb 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -42,7 +42,7 @@ static inline type name(type *p); \ static inline type name(type *p) \ { \ - int mprv = MSTATUS_MPRV; \ + size_t mprv = MSTATUS_MPRV; \ type value; \ asm ( \ "csrs mstatus, %1\n" \ @@ -57,7 +57,7 @@ static inline void name(type *p, type value); \ static inline void name(type *p, type value) \ { \ - int mprv = MSTATUS_MPRV; \ + size_t mprv = MSTATUS_MPRV; \ asm ( \ "csrs mstatus, %0\n" \ STRINGIFY(insn) " %1, 0(%2)\n" \ -- To view, visit https://review.coreboot.org/25625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I003c1b88b4493681dc9b6178ac785be330203ef5 Gerrit-Change-Number: 25625 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: soc/amd: Fix generating SMBIOS Type 17
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25304 ) Change subject: soc/amd: Fix generating SMBIOS Type 17 ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24289/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70020/ : SUCCESS -- To view, visit https://review.coreboot.org/25304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I076bc3f965f81a9374c8976da48c7fdce014dc0c Gerrit-Change-Number: 25304 Gerrit-PatchSet: 16 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 15:55:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/uart/pl011.c Add write support
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25623 ) Change subject: drivers/uart/pl011.c Add write support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24288/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70019/ : SUCCESS -- To view, visit https://review.coreboot.org/25623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a33b3cd4b333fb244bc55747014a301021e25e0 Gerrit-Change-Number: 25623 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer Gerrit-Reviewer: Marcello Sylvester Bauer Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 15:38:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/uart/pl011.c Add write support
by Marcello Sylvester Bauer (Code Review) 12 Apr '18

12 Apr '18

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/25623 ) Change subject: drivers/uart/pl011.c Add write support ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/25623/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25623/1//COMMIT_MSG@7 PS1, Line 7: drivers/uart/pl011.c Add write support > pl011: Done https://review.coreboot.org/#/c/25623/1/src/drivers/uart/pl011.c File src/drivers/uart/pl011.c: https://review.coreboot.org/#/c/25623/1/src/drivers/uart/pl011.c@47 PS1, Line 47: while (read32(&regs->fr) & PL011_UARTFR_RXFE) > braces not neccessary Done -- To view, visit https://review.coreboot.org/25623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a33b3cd4b333fb244bc55747014a301021e25e0 Gerrit-Change-Number: 25623 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer Gerrit-Reviewer: Marcello Sylvester Bauer Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 15:30:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/uart/pl011.c Add write support
by Marcello Sylvester Bauer (Code Review) 12 Apr '18

12 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25623 to look at the new patch set (#2). Change subject: drivers/uart/pl011.c Add write support ...................................................................... drivers/uart/pl011.c Add write support Change-Id: I5a33b3cd4b333fb244bc55747014a301021e25e0 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M src/drivers/uart/pl011.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/25623/2 -- To view, visit https://review.coreboot.org/25623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a33b3cd4b333fb244bc55747014a301021e25e0 Gerrit-Change-Number: 25623 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: mb/scaleway/tagada: Document what the selected SMBIOS enclosure type ...
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25624 ) Change subject: mb/scaleway/tagada: Document what the selected SMBIOS enclosure type means ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24286/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70017/ : SUCCESS -- To view, visit https://review.coreboot.org/25624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdf4184c8db9cfed4863d9e9f3b714d67f44a4bd Gerrit-Change-Number: 25624 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 15:01:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018