coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: Revert "mb/google/reef: Override USB2 phy settings"
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25630 ) Change subject: Revert "mb/google/reef: Override USB2 phy settings" ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70035/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/24307/ : SUCCESS -- To view, visit https://review.coreboot.org/25630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6de44d5240393409d9ec5835a9de0c23453300f7 Gerrit-Change-Number: 25630 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Apr 2018 07:41:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Revert "mb/google/coral: add usb2 phy setting override for some varia...
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25629 ) Change subject: Revert "mb/google/coral: add usb2 phy setting override for some variants" ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70033/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/24306/ : SUCCESS -- To view, visit https://review.coreboot.org/25629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie987061e27996b0acc8345bf9aadb42d2c940808 Gerrit-Change-Number: 25629 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Apr 2018 07:40:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25564 ) Change subject: mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24305/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70032/ : SUCCESS -- To view, visit https://review.coreboot.org/25564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b7ae34ee64f19ef783a8c1571831b2293105a18 Gerrit-Change-Number: 25564 Gerrit-PatchSet: 7 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 07:36:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: check DPTF_TSR0_ACTIVE_AC* in _ACx methods
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25614 ) Change subject: soc/intel/skylake: check DPTF_TSR0_ACTIVE_AC* in _ACx methods ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24304/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70031/ : SUCCESS -- To view, visit https://review.coreboot.org/25614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e36ce94f714ff13f8ccee65992d7a9c7e0bb5b2 Gerrit-Change-Number: 25614 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 07:36:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Include MP services header for UDK2017 supporte...
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25628 ) Change subject: drivers/intel/fsp2_0: Include MP services header for UDK2017 supported platform ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24303/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70030/ : SUCCESS -- To view, visit https://review.coreboot.org/25628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5add8e533dfd3f6d03abf7b2ca1a83f81f1c5920 Gerrit-Change-Number: 25628 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Apr 2018 06:48:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Include MP services header for UDK2017 supporte...
by Subrata Banik (Code Review) 12 Apr '18

12 Apr '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/25628 Change subject: drivers/intel/fsp2_0: Include MP services header for UDK2017 supported platform ...................................................................... drivers/intel/fsp2_0: Include MP services header for UDK2017 supported platform Change-Id: I5add8e533dfd3f6d03abf7b2ca1a83f81f1c5920 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/25628/1 diff --git a/src/drivers/intel/fsp2_0/include/fsp/soc_binding.h b/src/drivers/intel/fsp2_0/include/fsp/soc_binding.h index 94abe78..7d3a102 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/soc_binding.h +++ b/src/drivers/intel/fsp2_0/include/fsp/soc_binding.h @@ -30,6 +30,11 @@ #include <FirmwareVersionInfoHob.h> #endif +#if CONFIG_UDK_VERSION >= CONFIG_UDK_2017_VERSION +#include <PiPei.h> +#include <Ppi/MpServices.h> +#endif + #pragma pack(pop) #endif -- To view, visit https://review.coreboot.org/25628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5add8e533dfd3f6d03abf7b2ca1a83f81f1c5920 Gerrit-Change-Number: 25628 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25564 ) Change subject: mb/google/poppy/variants/nami: Enable DPTF and configure DPTF parameters ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/70029/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/24302/ : SUCCESS -- To view, visit https://review.coreboot.org/25564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b7ae34ee64f19ef783a8c1571831b2293105a18 Gerrit-Change-Number: 25564 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 05:56:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/cpu/cpulib: Add function to get cpu_slot based...
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25627 ) Change subject: soc/intel/common/block/cpu/cpulib: Add function to get cpu_slot based on APIC ID ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24301/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70028/ : SUCCESS -- To view, visit https://review.coreboot.org/25627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9172a4938f25998755593524122b787e9b00294 Gerrit-Change-Number: 25627 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Apr 2018 05:34:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/cpu/cpulib: Add function to get cpu_slot based...
by Subrata Banik (Code Review) 12 Apr '18

12 Apr '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/25627 Change subject: soc/intel/common/block/cpu/cpulib: Add function to get cpu_slot based on APIC ID ...................................................................... soc/intel/common/block/cpu/cpulib: Add function to get cpu_slot based on APIC ID This function make use of mp_get_apic_id() function to return cpu_slot else retrun -1 on failure. BRANCH=none BUG=b:74436746 TEST=Able to get cpu_slot based on running APs Change-Id: Ib9172a4938f25998755593524122b787e9b00294 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/include/intelblocks/cpulib.h 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/25627/1 diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index ed1ba0f..b435e73 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -18,6 +18,8 @@ #include <arch/io.h> #include <console/console.h> #include <cpu/intel/turbo.h> +#include <cpu/x86/lapic.h> +#include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <delay.h> @@ -334,3 +336,17 @@ msr.hi = pat >> 32; wrmsr(MSR_IA32_PAT, msr); } + +/* Get the working processor number by APIC ID */ +int cpu_get_processor_number(uint32_t *cpu_slot) +{ + int i; + + for (i = 0; i < CONFIG_MAX_CPUS; i++) { + if (mp_get_apic_id(i) == lapicid()) { + *cpu_slot = i; + return 0; + } + } + return -1; +} diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h index 0c7f2c4..37bcb59 100644 --- a/src/soc/intel/common/block/include/intelblocks/cpulib.h +++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h @@ -164,4 +164,8 @@ /* Set PAT MSR */ void set_pat(uint64_t pat); + +/* Get the working processor number by APIC ID */ +int cpu_get_processor_number(uint32_t *cpu_slot); + #endif /* SOC_INTEL_COMMON_BLOCK_CPULIB_H */ -- To view, visit https://review.coreboot.org/25627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9172a4938f25998755593524122b787e9b00294 Gerrit-Change-Number: 25627 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: vendorcode/amd/pi/00670F00..AGESA.c remove headers
by build bot (Jenkins) (Code Review) 12 Apr '18

12 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25626 ) Change subject: vendorcode/amd/pi/00670F00..AGESA.c remove headers ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24300/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/70027/ : SUCCESS -- To view, visit https://review.coreboot.org/25626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic38424d489dcc37a4074159e33fca0d49c71f701 Gerrit-Change-Number: 25626 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 21:42:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018