HARSHAPRIYA N has posted comments on this change. ( https://review.coreboot.org/25334 )
Change subject: Eve: NHLT changes to enable Windows use audio codecs
......................................................................
Patch Set 1: Code-Review-1
--
To view, visit https://review.coreboot.org/25334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13110f4d42e140aa1356ed0b6a6127943b6e800
Gerrit-Change-Number: 25334
Gerrit-PatchSet: 1
Gerrit-Owner: HARSHAPRIYA N <harshapriya.n(a)intel.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 01:42:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25331
to look at the new patch set (#2).
Change subject: soc/intel/common/block: add VMX support
......................................................................
soc/intel/common/block: add VMX support
Enable VMX (and SMX) if supported by CPU and enabled in board
devicetree. Check lock bit unset before enabling VMX.
Change-Id: Ic57eac45e9c65baa4479735c6d70a7eb685f080e
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/soc/intel/common/block/include/intelblocks/msr.h
A src/soc/intel/common/block/include/intelblocks/vmx.h
A src/soc/intel/common/block/vmx/Kconfig
A src/soc/intel/common/block/vmx/Makefile.inc
A src/soc/intel/common/block/vmx/vmx.c
5 files changed, 126 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/25331/2
--
To view, visit https://review.coreboot.org/25331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic57eac45e9c65baa4479735c6d70a7eb685f080e
Gerrit-Change-Number: 25331
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Vaibhav Shankar has posted comments on this change. ( https://review.coreboot.org/25312 )
Change subject: mainboard/google/meowth: Disable debug consent
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/25312/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/25312/1//COMMIT_MSG@13
PS1, Line 13: None
> Submit a partner issue and list the partner issue bug number here for tracking purpose.
Done
https://review.coreboot.org/#/c/25312/1/src/mainboard/google/zoombini/varia…
File src/mainboard/google/zoombini/variants/meowth/devicetree.cb:
https://review.coreboot.org/#/c/25312/1/src/mainboard/google/zoombini/varia…
PS1, Line 9: DBC over USB 3.0 port only
> Update this comment too.
Done
--
To view, visit https://review.coreboot.org/25312
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f
Gerrit-Change-Number: 25312
Gerrit-PatchSet: 1
Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 22 Mar 2018 23:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Nick Vaccaro, Bora Guvendik, build bot (Jenkins), Lijian Zhao, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25312
to look at the new patch set (#2).
Change subject: mainboard/google/meowth: Disable debug consent
......................................................................
mainboard/google/meowth: Disable debug consent
This patch disables debug consent in the devicetree. When debug
conset is set to DBC by default, it prevents some clocks from turning
off during S0ix. This blocks S0ix entry.
BUG=76163091
TEST=enter S0ix and check if slp_s0 is asserted
Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f
Signed-off-by: Vaibhav Shankar <vaibhav.shankar(a)intel.com>
---
M src/mainboard/google/zoombini/variants/meowth/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/25312/2
--
To view, visit https://review.coreboot.org/25312
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05001a41b13e7784c34fa8f1f773fb94bbdcd01f
Gerrit-Change-Number: 25312
Gerrit-PatchSet: 2
Gerrit-Owner: Vaibhav Shankar <vaibhav.shankar(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Hannah Williams,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25333
to look at the new patch set (#2).
Change subject: mb/octopus: Disable PCIE NPK device
......................................................................
mb/octopus: Disable PCIE NPK device
BUG = chrome-os-partner:76115112
TEST = Build for Octopus
Change-Id: I8fe3a36dac2eff2225dacb0e6e16500a5750261e
Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com>
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/25333/2
--
To view, visit https://review.coreboot.org/25333
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8fe3a36dac2eff2225dacb0e6e16500a5750261e
Gerrit-Change-Number: 25333
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>