Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/25337
Change subject: mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF methos
......................................................................
mb/google/poppy/variant/nautilus: Turn off MIPI camera in PMOF methos
This change remove work-around code for the power issue of MIPI and
USB cameras on previous board revision. With the work-around code,
PMOF ACPI methos cannot turn off MIPI camera. So we need to remove
it.
BUG=b:74214248
BRANCH=poppy
TEST=emerge-nautilus coreboot
Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd
Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/25337/1
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
index b74fba9..5eaf5b7 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
@@ -39,14 +39,7 @@
Method (PMOF, 0, Serialized) {
/* Make Sure all PMIC outputs are off. */
If (LEqual (VSIC, Zero)) {
- /*
- * On Nautilus Pre-EVT/EVT, the USB and MIPI share the
- * same power source, before HW fix in DVT, temporarily
- * disabled turn off 3V3_VDD
- */
-#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)
CTXS(EN_PP3300_DX_CAM)
-#endif
}
}
--
To view, visit https://review.coreboot.org/25337
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7becaf61de364f82976ec0be7f8c9e4ef1a7aedd
Gerrit-Change-Number: 25337
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com>
Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/25336
Change subject: mb/google/poppy: Mask the leftmost 16 bits of board_sku_id
......................................................................
mb/google/poppy: Mask the leftmost 16 bits of board_sku_id
We use uint32_t(4 bytes) to read sku id from EC, but get the wrong
value of higher 16 bits.
BUG=b:74177699
BRANCH=poppy
TEST=Verify SKU ID value by mosys or ectool cbi command.
Change-Id: Id831b7c30ad9f02328292700622bfc485a374fdc
Signed-off-by: amanda_hwang <amanda_hwang(a)compal.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/mainboard.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/25336/1
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c
index 4fc3d88..2d5079d 100644
--- a/src/mainboard/google/poppy/variants/nami/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c
@@ -33,7 +33,7 @@
return sku_id;
if (google_chromeec_cbi_get_sku_id(&id))
return SKU_UNKNOWN;
- sku_id = id;
+ sku_id = id & 0xFFFF;
return sku_id;
}
--
To view, visit https://review.coreboot.org/25336
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id831b7c30ad9f02328292700622bfc485a374fdc
Gerrit-Change-Number: 25336
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Kin Wai Ng has posted comments on this change. ( https://review.coreboot.org/25335 )
Change subject: fsp/fsp2_0/coffeelake: Add Coffeelake FSP UPD Headers
......................................................................
Patch Set 1:
This patch should be merged before this:
https://review.coreboot.org/#/c/coreboot/+/25121/
--
To view, visit https://review.coreboot.org/25335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id92d99915bda89dd475f393a48adee60bbaee80f
Gerrit-Change-Number: 25335
Gerrit-PatchSet: 1
Gerrit-Owner: Kin Wai Ng <kin.wai.ng(a)intel.com>
Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 07:08:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25334 )
Change subject: Eve: NHLT changes to enable Windows use audio codecs
......................................................................
Patch Set 1: Verified-1
Build Failed
https://qa.coreboot.org/job/coreboot-gerrit/68960/ : FAILURE
https://qa.coreboot.org/job/coreboot-checkpatch/23323/ : SUCCESS
--
To view, visit https://review.coreboot.org/25334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13110f4d42e140aa1356ed0b6a6127943b6e800
Gerrit-Change-Number: 25334
Gerrit-PatchSet: 1
Gerrit-Owner: HARSHAPRIYA N <harshapriya.n(a)intel.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com>
Gerrit-Reviewer: Ryan Cui <rcui(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 01:51:22 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes