coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 35: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67724/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22227/ : SUCCESS -- To view, visit https://review.coreboot.org/22374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 35 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 13:39:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: console: Introduce a way for mainboard to override the loglevel
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23712 ) Change subject: console: Introduce a way for mainboard to override the loglevel ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67723/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22226/ : SUCCESS -- To view, visit https://review.coreboot.org/23712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6cc72b8fe5c4c50a6f83ce80e6440b078eec6e2 Gerrit-Change-Number: 23712 Gerrit-PatchSet: 5 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 13:37:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 34: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67722/ : UNSTABLE -- To view, visit https://review.coreboot.org/22374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 34 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 13:18:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 33: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67721/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22225/ : SUCCESS -- To view, visit https://review.coreboot.org/22374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 33 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 13:10:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by Philipp Deppenwiese (Code Review) 20 Feb '18

20 Feb '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 32: (14 comments) https://review.coreboot.org/#/c/22374/25//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22374/25//COMMIT_MSG@12 PS25, Line 12: * Fix TPM1 missing kconfig option for boards with TPM 1.2. > This wasn't missing, it's intentional. […] okay got it. https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/Kconfig File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/Kconfig@1… PS25, Line 117: depends on TPM2 > Can also be used with TPM1, I think. […] Done https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/memory_in… File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/memory_in… PS25, Line 38: #if IS_ENABLED(CONFIG_FSP2_0_USES_TPM_MRC_HASH) > Do not #ifdef out code just because it won't be used. Just do […] Done https://review.coreboot.org/#/c/22374/25/src/security/tpm/Kconfig File src/security/tpm/Kconfig: https://review.coreboot.org/#/c/22374/25/src/security/tpm/Kconfig@70 PS25, Line 70: > This Kconfig doesn't do anything anymore after your previous patch. Either implement it or drop it. Done https://review.coreboot.org/#/c/22374/25/src/security/tpm/Kconfig@78 PS25, Line 78: Power off machine while waiting for CR50 update to take effect. > ditto Done https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss.h File src/security/tpm/tss.h: https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss.h@25 PS25, Line 25: #if (IS_ENABLED(CONFIG_TPM1) || IS_ENABLED(CONFIG_TPM2)) > You should not #ifdef out header definitions unless there's a specific reason. […] Done https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss.h@86 PS25, Line 86: #endif > Should be fixed in the previous CL already. Done https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss/cr50/tss.c File src/security/tpm/tss/cr50/tss.c: https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss/cr50/tss.c@1 PS25, Line 1: /* > I wonder if this is the best name/location for it... […] good point, let me fix that https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss/tcg-1.2/tss_s… File src/security/tpm/tss/tcg-1.2/tss_structures.h: https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss/tcg-1.2/tss_s… PS25, Line 17: #define TPM_PCR_DIGEST 20 > ... […] Fixed see secdata_tpm.c comment https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss/tcg-2.0/tss.c File src/security/tpm/tss/tcg-2.0/tss.c: https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss/tcg-2.0/tss.c… PS25, Line 19: void *tpm_process_command(TPM_CC command, void *command_body); > Let's put this in a real header somewhere. […] Done https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss_error_message… File src/security/tpm/tss_error_messages.h: https://review.coreboot.org/#/c/22374/25/src/security/tpm/tss_error_message… PS25, Line 12: TSS_ERROR_MESSAGES_H_ > nit: error_*messages* doesn't really fit for this file anymore. Maybe just tss_errors. […] Ack https://review.coreboot.org/#/c/22374/25/src/security/vboot/secdata_mock.c File src/security/vboot/secdata_mock.c: https://review.coreboot.org/#/c/22374/25/src/security/vboot/secdata_mock.c@… PS25, Line 75: VB2_SUCCESS > These changes aren't really correct, most of these functions in the non-mock implementation still us […] This code belongs to vboot2 IMHO it should return vboot error codes instead of tpm error codes. Especially if we talk about interfaces.. https://review.coreboot.org/#/c/22374/25/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c: https://review.coreboot.org/#/c/22374/25/src/security/vboot/secdata_tpm.c@56 PS25, Line 56: #define RETURN_ON_FAILURE(tpm_cmd) do { \ > I think it would be better to just move this to the existing #if...TPM2 block below. […] Done https://review.coreboot.org/#/c/22374/25/src/security/vboot/secdata_tpm.c@1… PS25, Line 104: B2_SUCCESS) > Why did this get renamed? tlcl_extend() in it's current form can only take digests of exactly this l […] we have TPM 1.2 and 2.0 support. Both have a min size of 20 bytes because of SHA-1. I moved TPM_PCR_MIN_DIGEST to the common area -- To view, visit https://review.coreboot.org/22374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 32 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 13:06:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/scaleway/tagada: Add bmcInfo interface
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23813 ) Change subject: mb/scaleway/tagada: Add bmcInfo interface ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67718/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22222/ : SUCCESS -- To view, visit https://review.coreboot.org/23813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4351aa11b08bdf65e14706b261c532bbf8837aed Gerrit-Change-Number: 23813 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 11:19:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Implement console loglevel override using bmcInfo
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23814 ) Change subject: mb/scaleway/tagada: Implement console loglevel override using bmcInfo ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67720/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22224/ : SUCCESS -- To view, visit https://review.coreboot.org/23814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0093cfafe7eaa4a4381e67c9b871fdf28abc470d Gerrit-Change-Number: 23814 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 11:18:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Override baudrate with bmcInfo
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23815 ) Change subject: mb/scaleway/tagada: Override baudrate with bmcInfo ...................................................................... Patch Set 3: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67719/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22223/ : SUCCESS -- To view, visit https://review.coreboot.org/23815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd93b64ef91a569127a0713fdb499dff2a1f11db Gerrit-Change-Number: 23815 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 11:16:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: driver/uart: Introduce a way for mainboard to override the baudrate
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23713 ) Change subject: driver/uart: Introduce a way for mainboard to override the baudrate ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67713/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22217/ : SUCCESS -- To view, visit https://review.coreboot.org/23713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I970ee788bf90b9e1a8c6ccdc5eee8029d9af0ecc Gerrit-Change-Number: 23713 Gerrit-PatchSet: 4 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 11:12:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: console: Introduce a way for mainboard to override the loglevel
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23712 ) Change subject: console: Introduce a way for mainboard to override the loglevel ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67716/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22220/ : SUCCESS -- To view, visit https://review.coreboot.org/23712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6cc72b8fe5c4c50a6f83ce80e6440b078eec6e2 Gerrit-Change-Number: 23712 Gerrit-PatchSet: 4 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 11:11:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018