coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: Include <sys/io.h> in intelmetool/intelmetool.c
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23834 ) Change subject: Include <sys/io.h> in intelmetool/intelmetool.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67755/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22256/ : SUCCESS -- To view, visit https://review.coreboot.org/23834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia27203cf47b9be3f7bf1ad422c8f490caeae8f56 Gerrit-Change-Number: 23834 Gerrit-PatchSet: 1 Gerrit-Owner: Ivan J. <parazyd(a)dyne.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 10:07:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Include <sys/io.h> in intelmetool/intelmetool.c
by Ivan J. (Code Review) 21 Feb '18

21 Feb '18

Ivan J. has uploaded this change for review. ( https://review.coreboot.org/23834 Change subject: Include <sys/io.h> in intelmetool/intelmetool.c ...................................................................... Include <sys/io.h> in intelmetool/intelmetool.c This allows compiling the program using musl-libc, since otherwise iopl(2) is undeclared. Change-Id: Ia27203cf47b9be3f7bf1ad422c8f490caeae8f56 Signed-off-by: Ivan J. <parazyd(a)dyne.org> --- M util/intelmetool/intelmetool.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/23834/1 diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index 0b0e509..14cb035 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -18,6 +18,7 @@ #include <unistd.h> #include <string.h> #include <cpuid.h> +#include <sys/io.h> #ifdef __NetBSD__ #include <machine/sysarch.h> -- To view, visit https://review.coreboot.org/23834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia27203cf47b9be3f7bf1ad422c8f490caeae8f56 Gerrit-Change-Number: 23834 Gerrit-PatchSet: 1 Gerrit-Owner: Ivan J. <parazyd(a)dyne.org>

1 0

Change in coreboot[master]: [WIP]mb/octopus: Add gpio configs for communities
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23799 ) Change subject: [WIP]mb/octopus: Add gpio configs for communities ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67754/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22255/ : SUCCESS -- To view, visit https://review.coreboot.org/23799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc16edd96f4ef6d55f3a99b195bf4920929b1578 Gerrit-Change-Number: 23799 Gerrit-PatchSet: 4 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 06:58:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]mb/octopus: Add gpio configs for communities
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23799 ) Change subject: [WIP]mb/octopus: Add gpio configs for communities ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67753/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22254/ : SUCCESS -- To view, visit https://review.coreboot.org/23799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc16edd96f4ef6d55f3a99b195bf4920929b1578 Gerrit-Change-Number: 23799 Gerrit-PatchSet: 3 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 06:47:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]mb/octopus: Add gpio configs for communities
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23799 ) Change subject: [WIP]mb/octopus: Add gpio configs for communities ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67752/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22253/ : SUCCESS -- To view, visit https://review.coreboot.org/23799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc16edd96f4ef6d55f3a99b195bf4920929b1578 Gerrit-Change-Number: 23799 Gerrit-PatchSet: 2 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 06:43:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23833 ) Change subject: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67751/ : SUCCESS -- To view, visit https://review.coreboot.org/23833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2a85a719997157f52b0eab7254689f5a56ba05b Gerrit-Change-Number: 23833 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 05:52:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

1 0

Change in coreboot[master]: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES
by Furquan Shaikh (Code Review) 21 Feb '18

21 Feb '18

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/23833 ) Change subject: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES ...................................................................... soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES SKL/KBL PCH does not support legacy devices. This change removes the setting of ACPI_FADT_LEGACY_DEVICES flag in FADT for SKL/KBL. It helps Linux kernel to disable controllers required to support legacy devices only e.g. i8237 DMA controller. BUG=b:72679357 Change-Id: Ie2a85a719997157f52b0eab7254689f5a56ba05b Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/skylake/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/23833/2 -- To view, visit https://review.coreboot.org/23833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie2a85a719997157f52b0eab7254689f5a56ba05b Gerrit-Change-Number: 23833 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES
by Furquan Shaikh (Code Review) 21 Feb '18

21 Feb '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23833 Change subject: soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES ...................................................................... soc/intel/skylake: Do not set ACPI_FADT_LEGACY_DEVICES SKL/KBL PCH does not support legacy devices. This change removes the setting of ACPI_FADT_LEGACY_DEVICES flag in FADT for SKL/KBL. BUG=b:72679357 Change-Id: Ie2a85a719997157f52b0eab7254689f5a56ba05b Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/skylake/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/23833/1 diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index a0be5f5..6e1a886 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -267,7 +267,7 @@ fadt->day_alrm = 0xd; fadt->mon_alrm = 0x00; fadt->century = 0x00; - fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES; + fadt->iapc_boot_arch = 0; if (!IS_ENABLED(CONFIG_NO_FADT_8042)) fadt->iapc_boot_arch |= ACPI_FADT_8042; -- To view, visit https://review.coreboot.org/23833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2a85a719997157f52b0eab7254689f5a56ba05b Gerrit-Change-Number: 23833 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/meowth: enable PCH iSCLK
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23368 ) Change subject: mainboard/google/meowth: enable PCH iSCLK ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67749/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22251/ : SUCCESS -- To view, visit https://review.coreboot.org/23368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e44e3748c9b37c8f60adcc47a866d445d77cfaa Gerrit-Change-Number: 23368 Gerrit-PatchSet: 12 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 23:32:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018