coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mb/google/kahlee: Add grunt cr50 support
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23514 ) Change subject: mb/google/kahlee: Add grunt cr50 support ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66841/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21434/ : SUCCESS -- To view, visit https://review.coreboot.org/23514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id55ce3364ea4acdb62782758e5bcb2a167286cb9 Gerrit-Change-Number: 23514 Gerrit-PatchSet: 3 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 16:26:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
by Lin Huang (Code Review) 31 Jan '18

31 Jan '18

Lin Huang has posted comments on this change. ( https://review.coreboot.org/23515 ) Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c File src/soc/rockchip/rk3399/saradc.c: https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74 PS1, Line 74: udelay(SARADC_DELAY_PU); > Please test multiple combinations (e.g. 4MHz 2 samples, 8MHz 4 samples, etc. […] Hmm, i do not have the device can repro this issue, i ask　manufacturer　help to test, and if want to repro this issue, need to put the device into 0C ambient tempterature　for 3 or 4 hours, so it may take long time to do the test. Anyway, we will try to do more test. -- To view, visit https://review.coreboot.org/23515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Gerrit-Change-Number: 23515 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 07:40:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
by Julius Werner (Code Review) 31 Jan '18

31 Jan '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23515 ) Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c File src/soc/rockchip/rk3399/saradc.c: https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74 PS1, Line 74: udelay(SARADC_DELAY_PU); > i will modify it to 4M and do the test again. Please test multiple combinations (e.g. 4MHz 2 samples, 8MHz 4 samples, etc.) and also try to find a better understanding about the nature of the problem with your hardware engineers, so we can prove whether a certain way of sampling should work or not. In particular, please try to clarify if both delaying for more than two samples *and* reducing the sample frequency is equally necessary to resolve the problem... if only one of them helps, we don't need to waste boot time on the other. -- To view, visit https://review.coreboot.org/23515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Gerrit-Change-Number: 23515 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 07:19:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
by Lin Huang (Code Review) 31 Jan '18

31 Jan '18

Lin Huang has posted comments on this change. ( https://review.coreboot.org/23515 ) Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c File src/soc/rockchip/rk3399/saradc.c: https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74 PS1, Line 74: udelay(SARADC_DELAY_PU); > This jumps from 250us to 8ms, which puts it well within the "uncomfortable" range of boot delays for […] i will modify it to 4M and do the test again. -- To view, visit https://review.coreboot.org/23515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Gerrit-Change-Number: 23515 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 07:09:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
by Julius Werner (Code Review) 31 Jan '18

31 Jan '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23515 ) Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/23515/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23515/1//COMMIT_MSG@13 PS1, Line 13: I assume this is BUG=b:70692504? And please also mark it with BRANCH=gru. https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c File src/soc/rockchip/rk3399/saradc.c: https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74 PS1, Line 74: udelay(SARADC_DELAY_PU); This jumps from 250us to 8ms, which puts it well within the "uncomfortable" range of boot delays for me. Remember that we eat this 5 or so times per boot, so this is a whooping 40ms. Is it really necessary to do such an extreme change to fix this issue? I think if this delay went up to only 1ms per call (that's still 4 times as much as right now!), like with 4 samples delay at 4MHz, I'd be okay with it. If you really need this to be that long, then I think we need to factor an init_saradc() function out so that we at least only have to eat the delay once per ADC. But that would get more complicated again because we may need to RW-update this onto older RO firmware, so I'd really rather not go there... -- To view, visit https://review.coreboot.org/23515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Gerrit-Change-Number: 23515 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 06:57:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: fsp_header: Cannonlake WW50 github header
by Subrata Banik (Code Review) 31 Jan '18

31 Jan '18

Subrata Banik has abandoned this change. ( https://review.coreboot.org/23013 ) Change subject: fsp_header: Cannonlake WW50 github header ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ic82356a5c6f52558ca58a7645c34deb9a604c3ec Gerrit-Change-Number: 23013 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: vendorcode: Add FirmwareVersionInfoHob header for CNL
by Subrata Banik (Code Review) 31 Jan '18

31 Jan '18

Subrata Banik has abandoned this change. ( https://review.coreboot.org/23014 ) Change subject: vendorcode: Add FirmwareVersionInfoHob header for CNL ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Iae571e703ee7bd0e7f9557e2dcf9cae4e6f18a98 Gerrit-Change-Number: 23014 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: fsp2_0: Add support for Firmware version info
by Subrata Banik (Code Review) 31 Jan '18

31 Jan '18

Subrata Banik has abandoned this change. ( https://review.coreboot.org/23016 ) Change subject: fsp2_0: Add support for Firmware version info ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I5fb9c6dc04558a4ac08526c2504b4cb14b8f9628 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Cannonlake make use of fvi information
by Subrata Banik (Code Review) 31 Jan '18

31 Jan '18

Subrata Banik has abandoned this change. ( https://review.coreboot.org/23017 ) Change subject: soc/intel/cannonlake: Cannonlake make use of fvi information ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I5d89c91079aa39fd0e792adfb6e63edd69cf3c4e Gerrit-Change-Number: 23017 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: payloads/external/GRUB2: Build only for supported architectures
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23171 ) Change subject: payloads/external/GRUB2: Build only for supported architectures ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21433/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66840/ : SUCCESS -- To view, visit https://review.coreboot.org/23171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ef2020b2acb4cd008a57a2372734674f8b84a36 Gerrit-Change-Number: 23171 Gerrit-PatchSet: 5 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 04:16:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
232
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018