coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23515 ) Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21432/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66839/ : SUCCESS -- To view, visit https://review.coreboot.org/23515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Gerrit-Change-Number: 23515 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 04:07:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
by Lin Huang (Code Review) 31 Jan '18

31 Jan '18

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/23515 Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ...................................................................... rockchip/rk3399: add the delay time between saradc power up and start command We found when ambient temperature low, with now saradc frequency and the delay time between saradc power up and start command, there may get wrong adc value, then get the wrong ramid or boardid, so lower the saradc frequency and add the delay time between power up and start command. Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/soc/rockchip/rk3399/saradc.c 1 file changed, 3 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/23515/1 diff --git a/src/soc/rockchip/rk3399/saradc.c b/src/soc/rockchip/rk3399/saradc.c index d70c966..a068b80 100644 --- a/src/soc/rockchip/rk3399/saradc.c +++ b/src/soc/rockchip/rk3399/saradc.c @@ -46,20 +46,12 @@ /* SARADC_DATA, 10[0:9] bits */ #define DATA_MASK 0x3FF -/* The max clk is 13 MHz, we also recommended that - * the sample rate(=clk/13) should be > 500KHz. - * So choose 8MHz, that 8MHz/13 = 615.38KHz > 500KHz. - */ -#define SARADC_HZ (8*MHz) - -/* TRM(V0.3 Part 1 Page 366) said there is a delay between - * power up and start command, default value is 2 src clk. - * Let delay 2 src clk here, in ns(udelay). - */ -#define SARADC_DELAY_PU (1 * 1000 * 1000 * 1000 / SARADC_HZ * 2) +#define SARADC_HZ (1*MHz) #define SARADC_MAX_CHANNEL 6 +#define SARADC_DELAY_PU (1 * 1000 * 1000 * 1000 / SARADC_HZ * 8) + u32 get_saradc_value(u32 chn) { u32 adc_value; -- To view, visit https://review.coreboot.org/23515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337 Gerrit-Change-Number: 23515 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: mb/google/kahlee: Add grunt cr50 support
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23514 ) Change subject: mb/google/kahlee: Add grunt cr50 support ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/66837/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/21430/ : SUCCESS -- To view, visit https://review.coreboot.org/23514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id55ce3364ea4acdb62782758e5bcb2a167286cb9 Gerrit-Change-Number: 23514 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 03:52:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Implement hashing function in TSS
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22735 ) Change subject: security/tpm: Implement hashing function in TSS ...................................................................... Patch Set 25: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21429/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66835/ : SUCCESS -- To view, visit https://review.coreboot.org/22735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib84513e8cbfe1ef11f495b873de0331178915c59 Gerrit-Change-Number: 22735 Gerrit-PatchSet: 25 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 03:47:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 25: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66836/ : SUCCESS -- To view, visit https://review.coreboot.org/22374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 25 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 03:43:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee: Add grunt cr50 support
by Justin TerAvest (Code Review) 31 Jan '18

31 Jan '18

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/23514 Change subject: mb/google/kahlee: Add grunt cr50 support ...................................................................... mb/google/kahlee: Add grunt cr50 support This commit adds an entry for H1/Cr50 into the devicetree for setting up ACPI entries for H1 communication. BUG=b:69250772 TEST=See probe messages in dmesg Change-Id: Id55ce3364ea4acdb62782758e5bcb2a167286cb9 Signed-off-by: Justin TerAvest <teravest(a)chromium.org> --- M src/mainboard/google/kahlee/variants/grunt/devicetree.cb 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/23514/1 diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index d2453a1..95de8b8 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -81,6 +81,14 @@ device pci 18.4 on end device pci 18.5 on end end #domain + device mmio 0xfedc3000 on + chip drivers/i2c/tpm + register "hid" = ""GOOG0005"" + register "desc" = ""Cr50 TPM"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + device i2c 50 on end + end + end device mmio 0xfedc5000 on chip drivers/i2c/generic register "hid" = ""ELAN0001"" -- To view, visit https://review.coreboot.org/23514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id55ce3364ea4acdb62782758e5bcb2a167286cb9 Gerrit-Change-Number: 23514 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: security/tpm: Implement hashing function in TSS
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22735 ) Change subject: security/tpm: Implement hashing function in TSS ...................................................................... Patch Set 24: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21428/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66833/ : SUCCESS -- To view, visit https://review.coreboot.org/22735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib84513e8cbfe1ef11f495b873de0331178915c59 Gerrit-Change-Number: 22735 Gerrit-PatchSet: 24 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 03:21:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Add support to display FSP version info Hob
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23386 ) Change subject: drivers/intel/fsp2_0: Add support to display FSP version info Hob ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21426/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66831/ : SUCCESS -- To view, visit https://review.coreboot.org/23386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib749e49a9f263d85947b60d4c445faf8c37f5931 Gerrit-Change-Number: 23386 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 02:26:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: CannonaLake make use of FVI information
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23387 ) Change subject: soc/intel/cannonlake: CannonaLake make use of FVI information ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21427/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66832/ : SUCCESS -- To view, visit https://review.coreboot.org/23387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfcac0002998e8a6594bb6dfc68b2577f62ddbff Gerrit-Change-Number: 23387 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 02:23:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Make use of Resource Type macro from EDK code
by build bot (Jenkins) (Code Review) 31 Jan '18

31 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23356 ) Change subject: drivers/intel/fsp2_0: Make use of Resource Type macro from EDK code ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21423/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66828/ : SUCCESS -- To view, visit https://review.coreboot.org/23356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If022eb29550a9310b095bff6130b02fb0a25ef7a Gerrit-Change-Number: 23356 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 02:22:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
232
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018