coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 31: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15846/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60644/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 31 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Sep 2017 01:05:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 18 Sep '17

18 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 40: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15845/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60643/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 40 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 18 Sep 2017 01:05:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/quanta/it8518: add missing HID to SIO device
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21580 ) Change subject: ec/quanta/it8518: add missing HID to SIO device ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15844/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60642/ : SUCCESS -- To view, visit https://review.coreboot.org/21580 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61d7341c15483f8e1fe0e485a25591ceb92eaae1 Gerrit-Change-Number: 21580 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 19:40:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/quanta/it8518: correct ACPI battery data fed into ToString()
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21579 ) Change subject: ec/quanta/it8518: correct ACPI battery data fed into ToString() ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15843/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60641/ : SUCCESS -- To view, visit https://review.coreboot.org/21579 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9 Gerrit-Change-Number: 21579 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 19:37:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/quanta/it8518: add missing HID to SIO device
by Matt DeVillier (Code Review) 17 Sep '17

17 Sep '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21580 Change subject: ec/quanta/it8518: add missing HID to SIO device ...................................................................... ec/quanta/it8518: add missing HID to SIO device The ACPI spec requires devices with children to have an HID, and Windows enforces this strictly. Without the SIO device having an HID, Windows will not detect the attached PS2 keyboard and trackpad. Therefore, add the proper HID. TEST: boot Windows on google/stout, observe PS2 keyboard and trackpad detected and functional. Change-Id: I61d7341c15483f8e1fe0e485a25591ceb92eaae1 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/ec/quanta/it8518/acpi/superio.asl 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/21580/1 diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl index 1bd0a39..e912e04 100644 --- a/src/ec/quanta/it8518/acpi/superio.asl +++ b/src/ec/quanta/it8518/acpi/superio.asl @@ -17,6 +17,7 @@ Device (SIO) { + Name (_HID, EisaId("PNP0A05")) Name (_UID, 0) Name (_ADR, 0) -- To view, visit https://review.coreboot.org/21580 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I61d7341c15483f8e1fe0e485a25591ceb92eaae1 Gerrit-Change-Number: 21580 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: ec/quanta/it8518: correct ACPI battery data fed into ToString()
by Matt DeVillier (Code Review) 17 Sep '17

17 Sep '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21579 Change subject: ec/quanta/it8518: correct ACPI battery data fed into ToString() ...................................................................... ec/quanta/it8518: correct ACPI battery data fed into ToString() ToString() requires the input buffer data to be null-terminated, but the data returned by the EC is not, leading Windows to fail to report any battery data at all. Correct this by concatenating a null terminator (0x00) to the end of the buffer data before inputting to ToString() where needed TEST: boot Windows on google/stout, observe battery data reported correctly. Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/21579/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 1f37f13..862e907 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -185,7 +185,7 @@ // // Battery Type - Device Chemistry // - Store (ToString (SBCH), Index (PBIF, 11)) + Store (ToString (Concatenate(SBCH, 0x00)), Index (PBIF, 11)) // // Information ID 5 - @@ -196,7 +196,7 @@ // // OEM Information - Manufacturer Name // - Store (ToString (SBMN), Index (PBIF, 12)) + Store (ToString (Concatenate(SBMN, 0x00)), Index (PBIF, 12)) // // Information ID 6 - @@ -207,7 +207,7 @@ // // Model Number - Device Name // - Store (ToString (SBDN), Index (PBIF, 9)) + Store (ToString (Concatenate(SBDN, 0x00)), Index (PBIF, 9)) Return (PBIF) } -- To view, visit https://review.coreboot.org/21579 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9 Gerrit-Change-Number: 21579 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 39: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15839/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60639/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 39 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 16:36:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 24: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15840/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60637/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 24 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 16:32:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 30: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15841/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60638/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 30 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 16:31:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: Refactor some code
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21511 ) Change subject: ifdtool: Refactor some code ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60636/ : SUCCESS -- To view, visit https://review.coreboot.org/21511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98965711e4cb9792e5cc86cc4c1035559e0274f5 Gerrit-Change-Number: 21511 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 16:29:54 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017