coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: amd/stoneyridge: Enable SMM in TSEG
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21501 ) Change subject: amd/stoneyridge: Enable SMM in TSEG ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60758/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15956/ : SUCCESS -- To view, visit https://review.coreboot.org/21501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dc03ed27d0d109ab919a4f0861de9c7420d03ce Gerrit-Change-Number: 21501 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:58:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/x86/smm: Add define for AMD64 save area
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21499 ) Change subject: cpu/x86/smm: Add define for AMD64 save area ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60756/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15955/ : SUCCESS -- To view, visit https://review.coreboot.org/21499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a051066b142cccae3d2c7df33be11994bafaae0 Gerrit-Change-Number: 21499 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:51:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Simplify memory hole calculation
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21496 ) Change subject: amd/stoneyridge: Simplify memory hole calculation ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60753/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15951/ : SUCCESS -- To view, visit https://review.coreboot.org/21496 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id15a88897e29bff28ab7c498dc4d3818834f08b2 Gerrit-Change-Number: 21496 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:49:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/amd/amdfam15: Add misc. SMM definitions
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21500 ) Change subject: cpu/amd/amdfam15: Add misc. SMM definitions ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60757/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15954/ : SUCCESS -- To view, visit https://review.coreboot.org/21500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad702bbdb459a09f9fef60d8280bb2684e365f4b Gerrit-Change-Number: 21500 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:49:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Update LPC lib
by Ravishankar Sarawadi (Code Review) 19 Sep '17

19 Sep '17

Hello Subrata Banik, Bora Guvendik, build bot (Jenkins), Lijian Zhao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21605 to look at the new patch set (#6). Change subject: soc/intel/common/block: Update LPC lib ...................................................................... soc/intel/common/block: Update LPC lib Add support for following functionality: 1. Setup PCH LPC interrupt routing. 2. Setup generic IO decoder range settings. 3. Enable CLKRUN_EN for power gating LPC. Change-Id: Ib9359765f7293210044b411db49163df0418070a Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/lpc_lib.h M src/soc/intel/common/block/lpc/lpc_lib.c 2 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/21605/6 -- To view, visit https://review.coreboot.org/21605 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib9359765f7293210044b411db49163df0418070a Gerrit-Change-Number: 21605 Gerrit-PatchSet: 6 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: amd/stoneyridge: Convert MP init to mp_init_with_smm
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21498 ) Change subject: amd/stoneyridge: Convert MP init to mp_init_with_smm ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60755/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15953/ : SUCCESS -- To view, visit https://review.coreboot.org/21498 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie54295cb00c6835947456e8818a289b7eb260914 Gerrit-Change-Number: 21498 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:36:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Update LPC lib
by Lijian Zhao (Code Review) 19 Sep '17

19 Sep '17

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/21605 ) Change subject: soc/intel/common/block: Update LPC lib ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/21605 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9359765f7293210044b411db49163df0418070a Gerrit-Change-Number: 21605 Gerrit-PatchSet: 5 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:35:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Remove EXT_CONF_SUPPORT check
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21497 ) Change subject: amd/stoneyridge: Remove EXT_CONF_SUPPORT check ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60754/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15952/ : SUCCESS -- To view, visit https://review.coreboot.org/21497 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic58c47fc5f568d17f5027c96d4152b0e5b3e1d14 Gerrit-Change-Number: 21497 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:31:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable common LPC IP
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20120 ) Change subject: soc/intel/skylake: Enable common LPC IP ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60752/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15950/ : SUCCESS -- To view, visit https://review.coreboot.org/20120 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042e459fb7c07f024a7f6a5fe7da13eb5f0dd688 Gerrit-Change-Number: 20120 Gerrit-PatchSet: 10 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 23:21:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Make UMA memory cacheable
by Marshall Dawson (Code Review) 19 Sep '17

19 Sep '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21606 Change subject: amd/stoneyridge: Make UMA memory cacheable ...................................................................... amd/stoneyridge: Make UMA memory cacheable Use reserved_ram_resource to help ensure the UMA memory is typed as WB. BUG=b:65856868 Change-Id: Ifa54d9b1c206d2ee6dc4b8f90b445a6820ceb8fd Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/northbridge.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/21606/1 diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 0a740cb..ec48a47 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -490,7 +490,14 @@ " limitk=%08llx\n", mmio_basek, basek, limitk); } - add_uma_resource_below_tolm(dev, 7); + /* UMA is not set up yet, but infer the base & size to make cacheable */ + uint32_t uma_base = restore_top_of_low_cacheable(); + if (uma_base != bsp_topmem()) { + uint32_t uma_size = bsp_topmem() - uma_base; + printk(BIOS_INFO, "%s: uma size 0x%08x, memory start 0x%08x\n", + __func__, uma_size, uma_base); + reserved_ram_resource(dev, 7, uma_base / KiB, uma_size / KiB); + } for (link = dev->link_list ; link ; link = link->next) if (link->children) -- To view, visit https://review.coreboot.org/21606 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa54d9b1c206d2ee6dc4b8f90b445a6820ceb8fd Gerrit-Change-Number: 21606 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017