coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: amd/pi/hudson: Convert 48Mhz en to read/write32
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21033 ) Change subject: amd/pi/hudson: Convert 48Mhz en to read/write32 ...................................................................... Patch Set 4: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58872/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14230/ : SUCCESS -- To view, visit https://review.coreboot.org/21033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e09757e5eea1eaf9b76921ad032ad2b79c14c5 Gerrit-Change-Number: 21033 Gerrit-PatchSet: 4 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 16:26:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Add Raydium touch screen support
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21083 ) Change subject: google/snappy: Add Raydium touch screen support ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58867/ : SUCCESS -- To view, visit https://review.coreboot.org/21083 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8852e38f01f82b80c2c9718b93baf5894dbd745b Gerrit-Change-Number: 21083 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 16:25:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Check UART index
by Marshall Dawson (Code Review) 18 Aug '17

18 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21096 to look at the new patch set (#2). Change subject: soc/amd/stoneyridge: Check UART index ...................................................................... soc/amd/stoneyridge: Check UART index Verify that the caller to uart_platform_base() sends a valid index. The Stoney Ridge APU has only two internal UARTs. BUG=b:62201567 Change-Id: I9432571712bae15a604f4280ea5e0f81fd68604d Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/uart.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/21096/2 -- To view, visit https://review.coreboot.org/21096 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9432571712bae15a604f4280ea5e0f81fd68604d Gerrit-Change-Number: 21096 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Check UART index
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21096 ) Change subject: soc/amd/stoneyridge: Check UART index ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58868/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14226/ : SUCCESS -- To view, visit https://review.coreboot.org/21096 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9432571712bae15a604f4280ea5e0f81fd68604d Gerrit-Change-Number: 21096 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 16:15:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Check UART index
by Marshall Dawson (Code Review) 18 Aug '17

18 Aug '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21096 Change subject: soc/amd/stoneyridge: Check UART index ...................................................................... soc/amd/stoneyridge: Check UART index Verify that the caller to uart_platform_base() sends a valid index. The Stoney Ridge APU has only two internal UARTs. Change-Id: I9432571712bae15a604f4280ea5e0f81fd68604d Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/uart.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/21096/1 diff --git a/src/soc/amd/stoneyridge/uart.c b/src/soc/amd/stoneyridge/uart.c index 9cc0c94..016d77b 100644 --- a/src/soc/amd/stoneyridge/uart.c +++ b/src/soc/amd/stoneyridge/uart.c @@ -13,11 +13,13 @@ * GNU General Public License for more details. */ +#include <assert.h> #include <console/uart.h> #include <soc/southbridge.h> uintptr_t uart_platform_base(int idx) { + assert(idx <= 1 && idx >= 0); return (uintptr_t)(APU_UART0_BASE + 0x2000 * (idx & 1)); } -- To view, visit https://review.coreboot.org/21096 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9432571712bae15a604f4280ea5e0f81fd68604d Gerrit-Change-Number: 21096 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Enable power button SMI when jumping to payload
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21082 ) Change subject: soc/intel/skylake: Enable power button SMI when jumping to payload ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58865/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14225/ : SUCCESS -- To view, visit https://review.coreboot.org/21082 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc52dc0103555602c23e09660bc38bb4bfddbc11 Gerrit-Change-Number: 21082 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 15:55:51 +0000 Gerrit-HasComments: No

1 0

Change in libhwbase[master]: posix file: Add procedure to query the size of a file
by Nico Huber (Code Review) 18 Aug '17

18 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21095 ) Change subject: posix file: Add procedure to query the size of a file ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21095 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b31e90ca98dc09185463ce467a70770e0f222d Gerrit-Change-Number: 21095 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 18 Aug 2017 15:48:47 +0000 Gerrit-HasComments: No

1 0

Change in libhwbase[master]: gnat.adc: Allow exception handlers in pure Ada code
by Nico Huber (Code Review) 18 Aug '17

18 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21094 ) Change subject: gnat.adc: Allow exception handlers in pure Ada code ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21094 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eb658f2ee0f55bb4f04da58e0e99bc9fc6780a5 Gerrit-Change-Number: 21094 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 18 Aug 2017 15:48:39 +0000 Gerrit-HasComments: No

1 0

Change in libhwbase[master]: posix file: Add procedure to query the size of a file
by Nico Huber (Code Review) 18 Aug '17

18 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21095 Change subject: posix file: Add procedure to query the size of a file ...................................................................... posix file: Add procedure to query the size of a file Change-Id: Ib3b31e90ca98dc09185463ce467a70770e0f222d Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M ada/posix/hw-file.adb M common/hw-file.ads 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/95/21095/1 diff --git a/ada/posix/hw-file.adb b/ada/posix/hw-file.adb index e2384be..dd9d7f3 100644 --- a/ada/posix/hw-file.adb +++ b/ada/posix/hw-file.adb @@ -14,6 +14,7 @@ with Interfaces.C; with Interfaces.C.Strings; +with Ada.Directories; with HW.Debug; @@ -68,4 +69,18 @@ pragma Debug (not Success, Debug.New_Line); end Map; + procedure Size (Length : out Natural; Path : String) + with + SPARK_Mode => Off + is + use type Ada.Directories.File_Size; + Res_Size : Ada.Directories.File_Size; + begin + Res_Size := Ada.Directories.Size (Path); + Length := Natural (Res_Size); + exception + when others => + Length := 0; + end Size; + end HW.File; diff --git a/common/hw-file.ads b/common/hw-file.ads index 9dbfcf7..bc2242c 100644 --- a/common/hw-file.ads +++ b/common/hw-file.ads @@ -39,4 +39,8 @@ Pre => (Readable or Writable) and (if Map_Copy then Readable and not Writable); + -- Sets `Length` to the size of the file given by `Path` or 0 if an + -- error occurs. + procedure Size (Length : out Natural; Path : String); + end HW.File; -- To view, visit https://review.coreboot.org/21095 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3b31e90ca98dc09185463ce467a70770e0f222d Gerrit-Change-Number: 21095 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libhwbase[master]: gnat.adc: Allow exception handlers in pure Ada code
by Nico Huber (Code Review) 18 Aug '17

18 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21094 Change subject: gnat.adc: Allow exception handlers in pure Ada code ...................................................................... gnat.adc: Allow exception handlers in pure Ada code Change-Id: I5eb658f2ee0f55bb4f04da58e0e99bc9fc6780a5 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M gnat.adc 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/94/21094/1 diff --git a/gnat.adc b/gnat.adc index e9a1c80..3494eba 100644 --- a/gnat.adc +++ b/gnat.adc @@ -1,7 +1,6 @@ pragma Restrictions (No_Allocators); pragma Restrictions (No_Calendar); pragma Restrictions (No_Dispatch); -pragma Restrictions (No_Exception_Handlers); pragma Restrictions (No_Fixed_Point); pragma Restrictions (No_Floating_Point); pragma Restrictions (No_Implicit_Dynamic_Code); -- To view, visit https://review.coreboot.org/21094 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5eb658f2ee0f55bb4f04da58e0e99bc9fc6780a5 Gerrit-Change-Number: 21094 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017