coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: google/cyan: convert to variant configuration
by Paul Menzel (Code Review) 21 Aug '17

21 Aug '17

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/21126 ) Change subject: google/cyan: convert to variant configuration ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://review.coreboot.org/#/c/21126/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21126/1//COMMIT_MSG@9 PS1, Line 9: Setup The verb is spelled with a space: Set up. https://review.coreboot.org/#/c/21126/1//COMMIT_MSG@20 PS1, Line 20: were are https://review.coreboot.org/#/c/21126/1//COMMIT_MSG@21 PS1, Line 21: were are -- To view, visit https://review.coreboot.org/21126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9 Gerrit-Change-Number: 21126 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 08:50:48 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: nb/intel/*/northbridge.c: add a final() to trigger finalize_smm() at ...
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: nb/intel/*/northbridge.c: add a final() to trigger finalize_smm() at boot time ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58990/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14337/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 08:35:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/*/northbridge.c: add a final() to trigger finalize_smm() at ...
by Bill XIE (Code Review) 21 Aug '17

21 Aug '17

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/21129 Change subject: nb/intel/*/northbridge.c: add a final() to trigger finalize_smm() at boot time ...................................................................... nb/intel/*/northbridge.c: add a final() to trigger finalize_smm() at boot time Several registers inside intel northbridge from nehalem should be locked down during boot and s3 resume. coreboot do have a function implemented in src/northbridge/intel/*/finalize.c to be called during an #SMI triggered with outb(APM_CNT_FINALIZE, APM_CNT), but currently this #SMI is only triggered during s3 resume, and not during boot. This problem has beed discussed in https://mail.coreboot.org/pipermail/coreboot/2017-August/084924.html . I believe that a final() function inside struct chip_operations is a good place to do the lockdown during boot time. Only the change on sandybridge is well tested. Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/northbridge/intel/fsp_sandybridge/northbridge.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/nehalem/northbridge.c M src/northbridge/intel/sandybridge/northbridge.c 4 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/21129/1 diff --git a/src/northbridge/intel/fsp_sandybridge/northbridge.c b/src/northbridge/intel/fsp_sandybridge/northbridge.c index a565b8d..d3eb670 100644 --- a/src/northbridge/intel/fsp_sandybridge/northbridge.c +++ b/src/northbridge/intel/fsp_sandybridge/northbridge.c @@ -33,6 +33,7 @@ #include "northbridge.h" #include <fsp_util.h> #include <cpu/intel/smm/gen1/smi.h> +#include <cpu/x86/smm.h> static int bridge_revision_id = -1; @@ -352,7 +353,17 @@ } } +static void final(void *chip_info) +{ + /* + * Trigger APM_CNT_FINALIZE to lock down several + * registers on the northbridge. + */ + outb(APM_CNT_FINALIZE, APM_CNT); +} + struct chip_operations northbridge_intel_fsp_sandybridge_ops = { CHIP_NAME("Intel i7 (SandyBridge/IvyBridge) integrated Northbridge") .enable_dev = enable_dev, + .final = final, }; diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index 32be916..5defba2 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -480,7 +480,17 @@ } } +static void final(void *chip_info) +{ + /* + * Trigger APM_CNT_FINALIZE to lock down several + * registers on the northbridge. + */ + outb(APM_CNT_FINALIZE, APM_CNT); +} + struct chip_operations northbridge_intel_haswell_ops = { CHIP_NAME("Intel i7 (Haswell) integrated Northbridge") .enable_dev = enable_dev, + .final = final, }; diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c index b09460c..581c3a2 100644 --- a/src/northbridge/intel/nehalem/northbridge.c +++ b/src/northbridge/intel/nehalem/northbridge.c @@ -33,6 +33,7 @@ #include "chip.h" #include "nehalem.h" #include <cpu/intel/smm/gen1/smi.h> +#include <cpu/x86/smm.h> static int bridge_revision_id = -1; @@ -322,7 +323,17 @@ } } +static void final(void *chip_info) +{ + /* + * Trigger APM_CNT_FINALIZE to lock down several + * registers on the northbridge. + */ + outb(APM_CNT_FINALIZE, APM_CNT); +} + struct chip_operations northbridge_intel_nehalem_ops = { CHIP_NAME("Intel i7 (Nehalem) integrated Northbridge") - .enable_dev = enable_dev, + .enable_dev = enable_dev, + .final = final, }; diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 3c0b9ec..aa67db7 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -32,6 +32,7 @@ #include "chip.h" #include "sandybridge.h" #include <cpu/intel/smm/gen1/smi.h> +#include <cpu/x86/smm.h> static int bridge_revision_id = -1; @@ -540,7 +541,17 @@ } } +static void final(void *chip_info) +{ + /* + * Trigger APM_CNT_FINALIZE to lock down several + * registers on the northbridge. + */ + outb(APM_CNT_FINALIZE, APM_CNT); +} + struct chip_operations northbridge_intel_sandybridge_ops = { CHIP_NAME("Intel SandyBridge/IvyBridge integrated Northbridge") .enable_dev = enable_dev, + .final = final, }; -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com>

1 0

Change in coreboot[master]: google/cyan: convert to variant configuration
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21126 ) Change subject: google/cyan: convert to variant configuration ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58988/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14335/ : SUCCESS -- To view, visit https://review.coreboot.org/21126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9 Gerrit-Change-Number: 21126 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 06:11:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/braswell: select GENERIC_GPIO_LIB
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21125 ) Change subject: soc/intel/braswell: select GENERIC_GPIO_LIB ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58986/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14333/ : SUCCESS -- To view, visit https://review.coreboot.org/21125 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9b0c6513f10b252bf0a5014bd038d24879421be Gerrit-Change-Number: 21125 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 06:06:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Increase RO coreboot size on flash
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21124 ) Change subject: google/cyan: Increase RO coreboot size on flash ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58984/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14331/ : SUCCESS -- To view, visit https://review.coreboot.org/21124 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86bea538a7b82367ea6ddbd3fe3efb1b1c0078d Gerrit-Change-Number: 21124 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 06:05:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/reks: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21128 ) Change subject: google/reks: add new board as variant of cyan baseboard ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58989/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14336/ : SUCCESS -- To view, visit https://review.coreboot.org/21128 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac9e2b5661aa33e12927f4cb84ebaee36522a385 Gerrit-Change-Number: 21128 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 05:58:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Remove support for pre-EVT board
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21123 ) Change subject: google/cyan: Remove support for pre-EVT board ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58985/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14332/ : SUCCESS -- To view, visit https://review.coreboot.org/21123 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b32da8064e0743cc9c5df02ce7d3441459ee8f Gerrit-Change-Number: 21123 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 05:57:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by Matt DeVillier (Code Review) 21 Aug '17

21 Aug '17

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/21127 ) Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21127/1/src/mainboard/google/cyan/romstage.c File src/mainboard/google/cyan/romstage.c: https://review.coreboot.org/#/c/21127/1/src/mainboard/google/cyan/romstage.… PS1, Line 25: not sure how this got added, will remove in inevitable follow-on patch set -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 05:56:25 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/cyan: Fix Touchscreen Interrupt
by build bot (Jenkins) (Code Review) 21 Aug '17

21 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21122 ) Change subject: google/cyan: Fix Touchscreen Interrupt ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58983/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14330/ : SUCCESS -- To view, visit https://review.coreboot.org/21122 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c4b029851e321feeedf713186976fbec42dd82e Gerrit-Change-Number: 21122 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Aug 2017 05:54:51 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017