coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: libpayload: Add pci_free_dev() and some boilerplate
by Nico Huber (Code Review) 11 Aug '17

11 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20955 Change subject: libpayload: Add pci_free_dev() and some boilerplate ...................................................................... libpayload: Add pci_free_dev() and some boilerplate Add just enough code and boilerplate to keep it compatible with future libflashrom. Change-Id: If0d46fab141da525f8f115d3f6045a8c417569eb Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M payloads/libpayload/include/pci/pci.h M payloads/libpayload/libpci/libpci.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/20955/1 diff --git a/payloads/libpayload/include/pci/pci.h b/payloads/libpayload/include/pci/pci.h index ee79d45..da6d026 100644 --- a/payloads/libpayload/include/pci/pci.h +++ b/payloads/libpayload/include/pci/pci.h @@ -88,7 +88,14 @@ struct pci_dev *devices; }; +enum pci_access_type { /* dummy for code compatibility */ + PCI_ACCESS_AUTO, + PCI_ACCESS_I386_TYPE1, + PCI_ACCESS_MAX +}; + struct pci_access { + unsigned int method; /* dummy for code compatibility */ struct pci_dev *devices; }; @@ -108,5 +115,6 @@ void pci_filter_init(struct pci_access*, struct pci_filter*); void pci_scan_bus(struct pci_access*); struct pci_dev *pci_get_dev(struct pci_access*, u16, u8, u8, u8); +void pci_free_dev(struct pci_dev *); #endif diff --git a/payloads/libpayload/libpci/libpci.c b/payloads/libpayload/libpci/libpci.c index f715666..82203a1 100644 --- a/payloads/libpayload/libpci/libpci.c +++ b/payloads/libpayload/libpci/libpci.c @@ -219,3 +219,8 @@ cur->func = func; return cur; } + +void pci_free_dev(struct pci_dev *const dev) +{ + free(dev); +} -- To view, visit https://review.coreboot.org/20955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If0d46fab141da525f8f115d3f6045a8c417569eb Gerrit-Change-Number: 20955 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: util/cbmem, util/cbfstool: resolve macro errors on FreeBSD
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20924 ) Change subject: util/cbmem, util/cbfstool: resolve macro errors on FreeBSD ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58426/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13834/ : SUCCESS -- To view, visit https://review.coreboot.org/20924 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ec9bc7fea72aa69a41439e002f381bd5e5b6bc6 Gerrit-Change-Number: 20924 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Aug 2017 10:06:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbmem, util/cbfstool: resolve macro errors on FreeBSD
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20924 ) Change subject: util/cbmem, util/cbfstool: resolve macro errors on FreeBSD ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58425/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13833/ : SUCCESS -- To view, visit https://review.coreboot.org/20924 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ec9bc7fea72aa69a41439e002f381bd5e5b6bc6 Gerrit-Change-Number: 20924 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Aug 2017 10:01:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Remove unused systemagent registers
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20942 ) Change subject: soc/intel/cannonlake: Remove unused systemagent registers ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58422/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13830/ : SUCCESS -- To view, visit https://review.coreboot.org/20942 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13b9c83097fc98183ea138c9087b5fc7834efd58 Gerrit-Change-Number: 20942 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 11 Aug 2017 09:27:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Provide option to use Common MP Init
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20895 ) Change subject: soc/intel/apollolake: Provide option to use Common MP Init ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58424/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13832/ : SUCCESS -- To view, visit https://review.coreboot.org/20895 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35d012785000d3f3bfcc34138cda9cd4591559f6 Gerrit-Change-Number: 20895 Gerrit-PatchSet: 5 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Aug 2017 09:24:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add proper support to enable UART2 in 16550 mode
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20940 ) Change subject: soc/intel/cannonlake: Add proper support to enable UART2 in 16550 mode ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58423/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13831/ : SUCCESS -- To view, visit https://review.coreboot.org/20940 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief58fdcb8a91f9951a48c3bd7490b1c7fee17e48 Gerrit-Change-Number: 20940 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 11 Aug 2017 09:24:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: common/block/lpss: Add CLK read function into LPSS common
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20938 ) Change subject: common/block/lpss: Add CLK read function into LPSS common ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58420/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13828/ : SUCCESS -- To view, visit https://review.coreboot.org/20938 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I420919ad9154c4cf426bc232c5eb59d95fd698d2 Gerrit-Change-Number: 20938 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 11 Aug 2017 09:21:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Initialize struct member to 0
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20941 ) Change subject: soc/intel/cannonlake: Initialize struct member to 0 ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58419/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13827/ : SUCCESS -- To view, visit https://review.coreboot.org/20941 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b95d31bfb1d2e9af1704a28dacb9cfd1cdcb50 Gerrit-Change-Number: 20941 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 11 Aug 2017 09:18:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Add proper support to enable UART2 in 16550 mode
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20939 ) Change subject: soc/intel/skylake: Add proper support to enable UART2 in 16550 mode ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58421/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13829/ : SUCCESS -- To view, visit https://review.coreboot.org/20939 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f23fef4522743efd49167afb04d56032e16e417 Gerrit-Change-Number: 20939 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Fri, 11 Aug 2017 09:18:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by build bot (Jenkins) (Code Review) 11 Aug '17

11 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20495 ) Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58418/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13826/ : SUCCESS -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 5 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)chromium.org> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Aug 2017 08:39:34 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017