coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: payloads/external/iPXE: Add more Kconfig options
by Patrick Rudolph (Code Review) 26 Jul '17

26 Jul '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20782 Change subject: payloads/external/iPXE: Add more Kconfig options ...................................................................... payloads/external/iPXE: Add more Kconfig options Add two now options: * Disable the promt "Press Ctrl+B for the iPXE command line..." Add a boolean that disable the initial 2 second timeout. * Include a script that is executed instead of showing a shell Allows to add a script that will be included into the iPXE ROM. Tested on Lenovo T500. Change-Id: Ie1083d8571d9d1f1c7c71659fb6ff0de2eecad0e Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M payloads/external/Makefile.inc M payloads/external/iPXE/Kconfig M payloads/external/iPXE/Makefile 3 files changed, 58 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20782/1 diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 6bc1651..d47256e 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -191,7 +191,9 @@ ifeq ($(CONFIG_BUILD_IPXE),y) PXE_ROM_FILE:=payloads/external/iPXE/ipxe/ipxe.rom endif - +ifeq ($(CONFIG_PXE_ADD_SCRIPT),y) +PXE_CONFIG_SCRIPT:=$(abspath $(patsubst "%",%,$(CONFIG_PXE_SCRIPT))) +endif ifeq ($(CONFIG_CONSOLE_SERIAL)$(CONFIG_DRIVERS_UART_8250IO),yy) IPXE_UART=COM$(call int-add,$(CONFIG_UART_FOR_CONSOLE) 1) endif @@ -200,7 +202,7 @@ pci$(CONFIG_PXE_ROM_ID).rom-file := $(PXE_ROM_FILE) pci$(CONFIG_PXE_ROM_ID).rom-type := raw -payloads/external/iPXE/ipxe/ipxe.rom ipxe: $(DOTCONFIG) +payloads/external/iPXE/ipxe/ipxe.rom ipxe: $(DOTCONFIG) $(PXE_CONFIG_SCRIPT) $(MAKE) -C payloads/external/iPXE all \ CROSS_COMPILE="$(CROSS_COMPILE_$(ARCH-ramstage-y))" \ PXE_ROM_PCI_ID=$(PXE_ROM_PCI_ID) \ @@ -209,4 +211,7 @@ CONSOLE_SERIAL=$(CONFIG_CONSOLE_SERIAL)$(CONFIG_DRIVERS_UART_8250IO) \ IPXE_UART=$(IPXE_UART) \ CONFIG_TTYS0_BAUD=$(CONFIG_TTYS0_BAUD) \ + CONFIG_SCRIPT=$(PXE_CONFIG_SCRIPT) \ + CONFIG_HAS_SCRIPT=$(CONFIG_PXE_ADD_SCRIPT) \ + CONFIG_PXE_NO_PROMT=$(CONFIG_PXE_NO_PROMT) \ MFLAGS= MAKEFLAGS= diff --git a/payloads/external/iPXE/Kconfig b/payloads/external/iPXE/Kconfig index 8211410..e17e731 100644 --- a/payloads/external/iPXE/Kconfig +++ b/payloads/external/iPXE/Kconfig @@ -78,5 +78,32 @@ Under GNU/Linux you can run `lspci -nn` to list the IDs of your PCI devices. +config PXE_NO_PROMT + bool "Do not show prompt to boot from PXE" + default n + depends on BUILD_IPXE + help + Dont wait for the user to press Ctrl-B. + The PXE still can be run as it shows up in SeaBIOS's payload list. + +config PXE_ADD_SCRIPT + bool "Embedded iPXE script for automated provisioning" + depends on BUILD_IPXE + default n + help + Enable to embed a script that is run instead of a iPXE shell. + + +config PXE_SCRIPT + string "Embedded iPXE script for automated provisioning" + depends on PXE_ADD_SCRIPT + default "" + help + Path to a script that is embedded into the iPXE binary. + Example: startup.ipxe + + Uses the ipxe script instead showing the promt: + "Press Ctrl-B to start iPXE..." + endmenu endif diff --git a/payloads/external/iPXE/Makefile b/payloads/external/iPXE/Makefile index a8b1245..b4b7dbe 100644 --- a/payloads/external/iPXE/Makefile +++ b/payloads/external/iPXE/Makefile @@ -54,15 +54,38 @@ sed 's|#define\s*COMCONSOLE.*|#define COMCONSOLE $(IPXE_UART)|' "$(project_dir)/src/config/serial.h" > "$(project_dir)/src/config/serial.h.tmp" sed 's|#define\s*COMSPEED.*|#define COMSPEED $(CONFIG_TTYS0_BAUD)|' "$(project_dir)/src/config/serial.h.tmp" > "$(project_dir)/src/config/serial.h" endif +ifeq ($(CONFIG_HAS_SCRIPT),$(CONFIG_PXE_NO_PROMT),y) + cp "$(project_dir)/src/config/general.h" "$(project_dir)/src/config/general.h.cb" +endif +ifeq ($(CONFIG_HAS_SCRIPT),y) + sed 's|//#define\s*IMAGE_SCRIPT.*|#define IMAGE_SCRIPT|' "$(project_dir)/src/config/general.h" > "$(project_dir)/src/config/general.h.tmp" + mv "$(project_dir)/src/config/general.h.tmp" "$(project_dir)/src/config/general.h" +endif +ifeq ($(CONFIG_PXE_NO_PROMT),y) + sed 's|#define\s*BANNER_TIMEOUT.*|#define BANNER_TIMEOUT 0|' "$(project_dir)/src/config/general.h" > "$(project_dir)/src/config/general.h.tmp" + mv "$(project_dir)/src/config/general.h.tmp" "$(project_dir)/src/config/general.h" +endif -build: config +build: config $(CONFIG_SCRIPT) +ifeq ($(CONFIG_HAS_SCRIPT),y) + echo " MAKE $(project_name) $(TAG-y) EMBED=$(CONFIG_SCRIPT)" + $(MAKE) -C $(project_dir)/src bin/$(PXE_ROM_PCI_ID).rom EMBED=$(CONFIG_SCRIPT) +else echo " MAKE $(project_name) $(TAG-y)" $(MAKE) -C $(project_dir)/src bin/$(PXE_ROM_PCI_ID).rom +endif cp $(project_dir)/src/bin/$(PXE_ROM_PCI_ID).rom $(project_dir)/ipxe.rom ifeq ($(CONSOLE_SERIAL),yy) cp "$(project_dir)/src/config/console.h.cb" "$(project_dir)/src/config/console.h" cp "$(project_dir)/src/config/serial.h.cb" "$(project_dir)/src/config/serial.h" endif +ifeq ($(CONFIG_HAS_SCRIPT),y) + cp "$(project_dir)/src/config/general.h.cb" "$(project_dir)/src/config/general.h" +endif +ifeq ($(CONFIG_PXE_NO_PROMT),y) + cp "$(project_dir)/src/config/general.h.cb" "$(project_dir)/src/config/general.h" +endif + clean: test -d $(project_dir) && $(MAKE) -C $(project_dir)/src veryclean || exit 0 -- To view, visit https://review.coreboot.org/20782 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie1083d8571d9d1f1c7c71659fb6ff0de2eecad0e Gerrit-Change-Number: 20782 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Correct gpio definition
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20775 ) Change subject: soc/intel/cannonlake: Correct gpio definition ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57856/ : SUCCESS -- To view, visit https://review.coreboot.org/20775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I717d1ffba8e6722543f4cf8083fe6145fa85e184 Gerrit-Change-Number: 20775 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 16:58:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Documentation: Add binary extraction documentation
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20753 ) Change subject: Documentation: Add binary extraction documentation ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57855/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13304/ : SUCCESS -- To view, visit https://review.coreboot.org/20753 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia31b01afc66789f95c7d21a0d41b532bc19a6430 Gerrit-Change-Number: 20753 Gerrit-PatchSet: 3 Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 16:49:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/gitconfig: update pre-commit script
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20781 ) Change subject: util/gitconfig: update pre-commit script ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57854/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13303/ : SUCCESS -- To view, visit https://review.coreboot.org/20781 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I142610b6fc984b2b14fd6c634bc4e7f2880ba987 Gerrit-Change-Number: 20781 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 16:44:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/gitconfig: update pre-commit script
by Martin Roth (Code Review) 26 Jul '17

26 Jul '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20781 Change subject: util/gitconfig: update pre-commit script ...................................................................... util/gitconfig: update pre-commit script The previous pre-commit script generates an error when a commit doesn't actually generate a patch file. This happens in rare instances when the only change in a patch is to update file permissions. Update the pre-commit script to verify that there's actually a patch before calling checkpatch. Also print that we're running checkpatch so that it doesn't look like odd failures come from lint-stable. Fixes Bug #132 - Problem with `lint-stable` when changing mode of file Change-Id: I142610b6fc984b2b14fd6c634bc4e7f2880ba987 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M util/gitconfig/pre-commit 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/20781/1 diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit index 70cd6ea..257f696 100755 --- a/util/gitconfig/pre-commit +++ b/util/gitconfig/pre-commit @@ -1,3 +1,9 @@ #!/bin/sh %MAKE% lint-stable -git diff --cached | util/lint/checkpatch.pl --no-signoff -q - + +PATCHDIFF=$(git diff --cached) +if echo "$PATCHDIFF" | grep -q "@@"; then + echo + echo "Running checkpatch" + echo "$PATCHDIFF" | util/lint/checkpatch.pl --no-signoff -q - +fi -- To view, visit https://review.coreboot.org/20781 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I142610b6fc984b2b14fd6c634bc4e7f2880ba987 Gerrit-Change-Number: 20781 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Enable common SMM code for SKL
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19440 ) Change subject: soc/intel/skylake: Enable common SMM code for SKL ...................................................................... Patch Set 22: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57853/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13302/ : SUCCESS -- To view, visit https://review.coreboot.org/19440 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdbde4cf39703ce10283715d2a28e501de489aae Gerrit-Change-Number: 19440 Gerrit-PatchSet: 22 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 16:16:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Documentation: Add binary extraction documentation
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20753 ) Change subject: Documentation: Add binary extraction documentation ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57852/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13301/ : SUCCESS -- To view, visit https://review.coreboot.org/20753 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia31b01afc66789f95c7d21a0d41b532bc19a6430 Gerrit-Change-Number: 20753 Gerrit-PatchSet: 2 Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 16:00:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/external/tianocore: build UEFI payload
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15057 ) Change subject: payloads/external/tianocore: build UEFI payload ...................................................................... Patch Set 27: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57851/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/13300/ : SUCCESS -- To view, visit https://review.coreboot.org/15057 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9719ca5c39fccb856dfe096d449760a937d51fd1 Gerrit-Change-Number: 15057 Gerrit-PatchSet: 27 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Maurice Ma Gerrit-Reviewer: Maurice Ma <mauricexma(a)gmail.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Pablo Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Prabal Saha <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 15:54:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8460p
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20501 ) Change subject: mainboard/hp: Add HP Elitebook 8460p ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57847/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13299/ : SUCCESS -- To view, visit https://review.coreboot.org/20501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 Gerrit-Change-Number: 20501 Gerrit-PatchSet: 5 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 13:39:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 2570p
by build bot (Jenkins) (Code Review) 26 Jul '17

26 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20489 ) Change subject: mainboard/hp: Add HP Elitebook 2570p ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57846/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13298/ : SUCCESS -- To view, visit https://review.coreboot.org/20489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f3cd124fc676d49add59e9f0a07f70a6bb0fff0 Gerrit-Change-Number: 20489 Gerrit-PatchSet: 8 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Jul 2017 13:35:21 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017