coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: arch/x86/assembly_entry: align stack for car_stage_entry
by Marshall Dawson (Code Review) 10 Jul '17

10 Jul '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/20528 Change subject: arch/x86/assembly_entry: align stack for car_stage_entry ...................................................................... arch/x86/assembly_entry: align stack for car_stage_entry At process _start, the stack is expected to be aligned to a 16-byte boundary. Upon entry to any function the stack frame must have the end of any arguments also aligned. In other words the value of %esp+4 or %rsp+8 is always a multiple of 16 (1). Change the method for executing car_stage_entry from jmp to call. This should keep the stack aligned regardless of a 32- or 64-bit build. Although 4-byte alignment is the minimum requirement for i386, some AMD platforms use SSE instructions which expect 16-byte. 1) http://wiki.osdev.org/System_V_ABI See "Initial Stack and Register State" and "The Stack Frame" in the supplements. Change-Id: I8a15514f551a8e17e9fe77b8402fe0d2b106972e Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/arch/x86/assembly_entry.S 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/20528/1 diff --git a/src/arch/x86/assembly_entry.S b/src/arch/x86/assembly_entry.S index 56a5b63..465c02f 100644 --- a/src/arch/x86/assembly_entry.S +++ b/src/arch/x86/assembly_entry.S @@ -63,7 +63,7 @@ jz debug_spinloop #endif - jmp car_stage_entry + call car_stage_entry /* This is here for linking purposes. */ .weak car_stage_entry -- To view, visit https://review.coreboot.org/20528 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8a15514f551a8e17e9fe77b8402fe0d2b106972e Gerrit-Change-Number: 20528 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add GNVS
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20275 ) Change subject: soc/amd/stoneyridge: Add GNVS ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56753/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12310/ : SUCCESS -- To view, visit https://review.coreboot.org/20275 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ecab92181bfe60e7b6c6e91ffb9fa843345352f Gerrit-Change-Number: 20275 Gerrit-PatchSet: 10 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:42:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Save VBNV data to CMOS
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19847 ) Change subject: google/kahlee: Save VBNV data to CMOS ...................................................................... Patch Set 16: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56750/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12307/ : SUCCESS -- To view, visit https://review.coreboot.org/19847 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50b45e687a1a1c71838bcc390212b28d7e634a19 Gerrit-Change-Number: 19847 Gerrit-PatchSet: 16 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:42:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Enable TPM
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19848 ) Change subject: google/kahlee: Enable TPM ...................................................................... Patch Set 18: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56751/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12308/ : SUCCESS -- To view, visit https://review.coreboot.org/19848 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab92259ebeaa40937309fad05cc45d9ca6d41357 Gerrit-Change-Number: 19848 Gerrit-PatchSet: 18 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:42:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Set DDI port 2 to DP
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19846 ) Change subject: google/kahlee: Set DDI port 2 to DP ...................................................................... Patch Set 16: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56749/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12306/ : SUCCESS -- To view, visit https://review.coreboot.org/19846 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5e57e01d4f0073ac50533c1b04a95bcae67473 Gerrit-Change-Number: 19846 Gerrit-PatchSet: 16 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:41:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add Realtek audio codec ASL
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19845 ) Change subject: google/kahlee: Add Realtek audio codec ASL ...................................................................... Patch Set 16: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56748/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12305/ : SUCCESS -- To view, visit https://review.coreboot.org/19845 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60b256f68372c9d17d67c9cb2accaca616a0b9a5 Gerrit-Change-Number: 19845 Gerrit-PatchSet: 16 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:41:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add ASL for Elan touchpad
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19844 ) Change subject: google/kahlee: Add ASL for Elan touchpad ...................................................................... Patch Set 15: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56747/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12304/ : SUCCESS -- To view, visit https://review.coreboot.org/19844 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3fc8c8855b0296f43a502e81143498d663468ec Gerrit-Change-Number: 19844 Gerrit-PatchSet: 15 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:41:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: southbridge/pi/hudson: Fix GPIO bank1 control definition
by Marshall Dawson (Code Review) 10 Jul '17

10 Jul '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/20527 Change subject: southbridge/pi/hudson: Fix GPIO bank1 control definition ...................................................................... southbridge/pi/hudson: Fix GPIO bank1 control definition Change-Id: I3ef3ea3ea22faa0152d99923da2e57517ab3d0be Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/southbridge/amd/pi/hudson/gpio.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/20527/1 diff --git a/src/southbridge/amd/pi/hudson/gpio.h b/src/southbridge/amd/pi/hudson/gpio.h index 3863ed2..4aa8119 100644 --- a/src/southbridge/amd/pi/hudson/gpio.h +++ b/src/southbridge/amd/pi/hudson/gpio.h @@ -59,7 +59,7 @@ #define GPIO_42 (GPIO_BANK0_CONTROL + 0xA8) /* GPIO_64 - GPIO_127 */ -#define GPIO_BANK1 (CONTROL AMD_SB_ACPI_MMIO_ADDR + 0x1600) +#define GPIO_BANK1_CONTROL (CONTROL AMD_SB_ACPI_MMIO_ADDR + 0x1600) #define GPIO_64 (GPIO_BANK1_CONTROL + 0x00) #define GPIO_65 (GPIO_BANK1_CONTROL + 0x04) #define GPIO_66 (GPIO_BANK1_CONTROL + 0x08) -- To view, visit https://review.coreboot.org/20527 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3ef3ea3ea22faa0152d99923da2e57517ab3d0be Gerrit-Change-Number: 20527 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: google/kahlee: Set SERIRQ to continuous mode
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19840 ) Change subject: google/kahlee: Set SERIRQ to continuous mode ...................................................................... Patch Set 15: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56743/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12301/ : SUCCESS -- To view, visit https://review.coreboot.org/19840 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If77c91fde2bd0f4da85413879fefb753ae6297de Gerrit-Change-Number: 19840 Gerrit-PatchSet: 15 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:40:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Remove conflicting AAHB IRQ ASL
by build bot (Jenkins) (Code Review) 10 Jul '17

10 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19842 ) Change subject: google/kahlee: Remove conflicting AAHB IRQ ASL ...................................................................... Patch Set 15: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56745/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12302/ : SUCCESS -- To view, visit https://review.coreboot.org/19842 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefaf33cfb2babc29d35b5372fc3a338a72c78a4a Gerrit-Change-Number: 19842 Gerrit-PatchSet: 15 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 00:40:25 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017