coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: driver/intel/wifi: Update wifi wake source in elog
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20455 ) Change subject: driver/intel/wifi: Update wifi wake source in elog ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56816/ : SUCCESS -- To view, visit https://review.coreboot.org/20455 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d42c5c81e0a3f7a3f94c3f6b7d2ebdf029d1aff Gerrit-Change-Number: 20455 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 13:23:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Log wakes due to PCIE root port
by Naresh Solanki (Code Review) 11 Jul '17

11 Jul '17

Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/20532 Change subject: soc/intel/skylake: Log wakes due to PCIE root port ...................................................................... soc/intel/skylake: Log wakes due to PCIE root port When wake happens due to PME on PCIE root port, then update the same in elog. BUG=b:36992859 TEST=Build for Soraka, Verify resume due to PME on root port is updated in elog. Change-Id: I879a7c332e62ab598942b29d31bad84619b35ea7 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/soc/intel/skylake/elog.c 1 file changed, 41 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/20532/1 diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index fde8be2..69bc25e 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -200,20 +200,6 @@ static const struct pme_status_info pme_status_info[] = { { PCH_DEVFN_HDA, 0x54, ELOG_WAKE_SOURCE_PME_HDA }, { PCH_DEVFN_GBE, 0xcc, ELOG_WAKE_SOURCE_PME_GBE }, - { PCH_DEVFN_EMMC, 0x84, ELOG_WAKE_SOURCE_PME_EMMC }, - { PCH_DEVFN_SDCARD, 0x84, ELOG_WAKE_SOURCE_PME_SDCARD }, - { PCH_DEVFN_PCIE1, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE1 }, - { PCH_DEVFN_PCIE2, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE2 }, - { PCH_DEVFN_PCIE3, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE3 }, - { PCH_DEVFN_PCIE4, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE4 }, - { PCH_DEVFN_PCIE5, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE5 }, - { PCH_DEVFN_PCIE6, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE6 }, - { PCH_DEVFN_PCIE7, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE7 }, - { PCH_DEVFN_PCIE8, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE8 }, - { PCH_DEVFN_PCIE9, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE9 }, - { PCH_DEVFN_PCIE10, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE10 }, - { PCH_DEVFN_PCIE11, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE11 }, - { PCH_DEVFN_PCIE12, 0xa4, ELOG_WAKE_SOURCE_PME_PCIE12 }, { PCH_DEVFN_SATA, 0x74, ELOG_WAKE_SOURCE_PME_SATA }, { PCH_DEVFN_CSE, 0x54, ELOG_WAKE_SOURCE_PME_CSE }, { PCH_DEVFN_CSE_2, 0x54, ELOG_WAKE_SOURCE_PME_CSE2 }, @@ -228,7 +214,7 @@ if (!dev) continue; - val = pci_read_config16(dev, pme_status_info[i].reg_offset); + val = pci_read_config32(dev, pme_status_info[i].reg_offset); if ((val == 0xFFFF) || !(val & PME_STS_BIT)) continue; @@ -239,6 +225,43 @@ if (!dev_found) elog_add_event_wake(ELOG_WAKE_SOURCE_PME_INTERNAL, 0); +} + +#define RP_PME_STS_BIT (1 << 16) +static void pch_log_rp_wake_source(void) +{ + size_t i; + device_t dev; + uint32_t val; + + static const struct pme_status_info pme_status_info[] = { + { PCH_DEVFN_PCIE1, 0x60, ELOG_WAKE_SOURCE_PME_PCIE1 }, + { PCH_DEVFN_PCIE2, 0x60, ELOG_WAKE_SOURCE_PME_PCIE2 }, + { PCH_DEVFN_PCIE3, 0x60, ELOG_WAKE_SOURCE_PME_PCIE3 }, + { PCH_DEVFN_PCIE4, 0x60, ELOG_WAKE_SOURCE_PME_PCIE4 }, + { PCH_DEVFN_PCIE5, 0x60, ELOG_WAKE_SOURCE_PME_PCIE5 }, + { PCH_DEVFN_PCIE6, 0x60, ELOG_WAKE_SOURCE_PME_PCIE6 }, + { PCH_DEVFN_PCIE7, 0x60, ELOG_WAKE_SOURCE_PME_PCIE7 }, + { PCH_DEVFN_PCIE8, 0x60, ELOG_WAKE_SOURCE_PME_PCIE8 }, + { PCH_DEVFN_PCIE9, 0x60, ELOG_WAKE_SOURCE_PME_PCIE9 }, + { PCH_DEVFN_PCIE10, 0x60, ELOG_WAKE_SOURCE_PME_PCIE10 }, + { PCH_DEVFN_PCIE11, 0x60, ELOG_WAKE_SOURCE_PME_PCIE11 }, + { PCH_DEVFN_PCIE12, 0x60, ELOG_WAKE_SOURCE_PME_PCIE12 }, + }; + + for (i = 0; i < ARRAY_SIZE(pme_status_info); i++) { + dev = dev_find_slot(0, pme_status_info[i].devfn); + + if (!dev) + continue; + + val = pci_read_config32(dev, pme_status_info[i].reg_offset); + + if ((val == 0xFFFFFFFF) || !(val & RP_PME_STS_BIT)) + continue; + + pch_log_add_elog_event(&pme_status_info[i], dev); + } } static void pch_log_wake_source(struct chipset_power_state *ps) @@ -263,6 +286,9 @@ if (ps->gpe0_sts[GPE_STD] & PME_B0_STS) pch_log_pme_internal_wake_source(); + /* PCIE Root Port */ + pch_log_rp_wake_source(); + /* SMBUS Wake */ if (ps->gpe0_sts[GPE_STD] & SMB_WAK_STS) elog_add_event_wake(ELOG_WAKE_SOURCE_SMBUS, 0); -- To view, visit https://review.coreboot.org/20532 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I879a7c332e62ab598942b29d31bad84619b35ea7 Gerrit-Change-Number: 20532 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com>

1 0

Change in coreboot[master]: driver/intel/wifi: Update wifi wake source in elog
by Naresh Solanki (Code Review) 11 Jul '17

11 Jul '17

Naresh Solanki has uploaded a new patch set (#3). ( https://review.coreboot.org/20455 ) Change subject: driver/intel/wifi: Update wifi wake source in elog ...................................................................... driver/intel/wifi: Update wifi wake source in elog In S3 resume, wifi is one of the wake sources. If elog is enabled in config, then log wifi wakes in elog. BUG=b:36992859 TEST= Build for Soraka. Do WoWlan during S3. Verify elog having update on wake due to Wifi. Change-Id: I7d42c5c81e0a3f7a3f94c3f6b7d2ebdf029d1aff Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/drivers/intel/wifi/wifi.c M src/include/elog.h 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/20455/3 -- To view, visit https://review.coreboot.org/20455 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7d42c5c81e0a3f7a3f94c3f6b7d2ebdf029d1aff Gerrit-Change-Number: 20455 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/soraka: Do not reset PMIC during sleep
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20264 ) Change subject: mb/google/soraka: Do not reset PMIC during sleep ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56815/ : SUCCESS -- To view, visit https://review.coreboot.org/20264 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582 Gerrit-Change-Number: 20264 Gerrit-PatchSet: 10 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ruben Rodriguez Buchillon <coconutruben(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 12:34:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Do not reset PMIC during sleep
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20264 ) Change subject: mb/google/soraka: Do not reset PMIC during sleep ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56814/ : SUCCESS -- To view, visit https://review.coreboot.org/20264 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582 Gerrit-Change-Number: 20264 Gerrit-PatchSet: 9 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ruben Rodriguez Buchillon <coconutruben(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 11:06:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Perform PCR read after all PCR write
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20461 ) Change subject: soc/intel/skylake: Perform PCR read after all PCR write ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56813/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12366/ : SUCCESS -- To view, visit https://review.coreboot.org/20461 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3d567aab517b16ff99a526fc29c2d71bf4042d0 Gerrit-Change-Number: 20461 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 10:45:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Remove “disable SaGv” in recovery mode flow
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20516 ) Change subject: soc/intel/skylake: Remove “disable SaGv” in recovery mode flow ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56812/ : SUCCESS -- To view, visit https://review.coreboot.org/20516 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d094a8b6d78ea3bf8f929870a4a179495c29c78 Gerrit-Change-Number: 20516 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 10:41:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Remove “disable SaGv” in recovery mode flow
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20516 ) Change subject: soc/intel/skylake: Remove “disable SaGv” in recovery mode flow ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56811/ : SUCCESS -- To view, visit https://review.coreboot.org/20516 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d094a8b6d78ea3bf8f929870a4a179495c29c78 Gerrit-Change-Number: 20516 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 09:14:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: abuild: give --silent the silent treatment
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20390 ) Change subject: abuild: give --silent the silent treatment ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56808/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12363/ : SUCCESS -- To view, visit https://review.coreboot.org/20390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c1f8bffc2048a79de58cdc2a70651796db6ba6 Gerrit-Change-Number: 20390 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 06:21:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: add wacom touchscreen support
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20476 ) Change subject: mainboard/google/soraka: add wacom touchscreen support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56807/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12362/ : SUCCESS -- To view, visit https://review.coreboot.org/20476 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbae4782c6442149cda57d23c61ed87546621bb Gerrit-Change-Number: 20476 Gerrit-PatchSet: 3 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 06:01:46 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017