coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: mb/apple/macbook21: Add ACPI C3 state
by Arthur Heymans (Code Review) 07 Jun '17

07 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20083 ) Change subject: mb/apple/macbook21: Add ACPI C3 state ...................................................................... Patch Set 1: Code-Review-2 UNTESTED on either macbook21 and imac52 -- To view, visit https://review.coreboot.org/20083 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b391825a0e79bddb9aa4c914153a9bac2f20155 Gerrit-Change-Number: 20083 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 07 Jun 2017 07:51:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/apple/macbook21: Add ACPI C3 state
by Arthur Heymans (Code Review) 07 Jun '17

07 Jun '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20083 Change subject: mb/apple/macbook21: Add ACPI C3 state ...................................................................... mb/apple/macbook21: Add ACPI C3 state This needs the clockgen to be reconfigured. Values are taken while running vendor firmware (smbus device at offset 0x69 using smbus block read) Change-Id: I0b391825a0e79bddb9aa4c914153a9bac2f20155 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/apple/macbook21/devicetree.cb M src/mainboard/apple/macbook21/mainboard.c 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/20083/1 diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb index b6e61eb..bc03e01 100644 --- a/src/mainboard/apple/macbook21/devicetree.cb +++ b/src/mainboard/apple/macbook21/devicetree.cb @@ -109,6 +109,15 @@ end device pci 1f.3 on # SMBUS subsystemid 0x8086 0x7270 + chip drivers/i2c/ck505 + register "nregs" = "20" + register "regs" = "{0x77, 0x77, 0x2d, + 0x00, 0x21, 0x10, 0x3b, 0x06, 0x07, + 0x0f, 0xf0, 0x01, 0x1e, 0x7f, 0x80, + 0x80, 0x10, 0x08, 0x04, 0x01 }" + device i2c 69 on end + end + end end end diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c index eb74ec1..1e8ca8a 100644 --- a/src/mainboard/apple/macbook21/mainboard.c +++ b/src/mainboard/apple/macbook21/mainboard.c @@ -62,6 +62,22 @@ .addrh = 0, } }, + { + .ctype = 3, + .latency = 1, + .power = 250, + .resource = { + .space_id = ACPI_ADDRESS_SPACE_FIXED, + .bit_width = ACPI_FFIXEDHW_VENDOR_INTEL, + .bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT, + { + .resv = 0, + }, + /* C3 gets automatically upgraded by SB *// + .addrl = 0x20, + .addrh = 0, + } + }, }; int get_cst_entries(acpi_cstate_t **entries) -- To view, visit https://review.coreboot.org/20083 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0b391825a0e79bddb9aa4c914153a9bac2f20155 Gerrit-Change-Number: 20083 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: drvs/intel/wifi/wifi: Fix regression
by Patrick Rudolph (Code Review) 07 Jun '17

07 Jun '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20082 Change subject: drvs/intel/wifi/wifi: Fix regression ...................................................................... drvs/intel/wifi/wifi: Fix regression Fix regression introduced by Change-Id: I8b5c916f1a04742507dc1ecc9a20c19d3822b18c In case the regular PCI path is taken, there're no chip_ops and the code will segfault. The bug was covered by other bugs that caused this code to never execute. Don't assume the chip_operations path was taken and instead define the device name, to be used all over the code. Tested on Lenovo T430 and wifi card 8086:0085. Change-Id: I84e804f033bcd3af1a7f76670275fdf5159d381f Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/intel/wifi/wifi.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20082/1 diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index 15cb2c1..dbffea1 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -26,6 +26,8 @@ #include <wrdd.h> #include "chip.h" +#define DEVICE_NAME "Intel WiFi" + #if IS_ENABLED(CONFIG_GENERATE_SMBIOS_TABLES) static int smbios_write_wifi(struct device *dev, int *handle, unsigned long *current) @@ -145,7 +147,7 @@ acpigen_write_scope(path); acpigen_write_device(acpi_device_name(dev)); acpigen_write_name_integer("_UID", 0); - acpigen_write_name_string("_DDN", dev->chip_ops->name); + acpigen_write_name_string("_DDN", DEVICE_NAME); /* Address */ address = PCI_SLOT(dev->path.pci.devfn) & 0xffff; @@ -186,7 +188,7 @@ acpigen_pop_len(); /* Scope */ printk(BIOS_INFO, "%s.%s: %s %s\n", path, acpi_device_name(dev), - dev->chip_ops->name, dev_path(dev)); + DEVICE_NAME, dev_path(dev)); } static const char *intel_wifi_acpi_name(struct device *dev) @@ -235,6 +237,6 @@ } struct chip_operations drivers_intel_wifi_ops = { - CHIP_NAME("Intel WiFi") + CHIP_NAME(DEVICE_NAME) .enable_dev = &intel_wifi_enable }; -- To view, visit https://review.coreboot.org/20082 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84e804f033bcd3af1a7f76670275fdf5159d381f Gerrit-Change-Number: 20082 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: soc/intel/skylake: [WIP] Use common/block/gpio
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19201 ) Change subject: soc/intel/skylake: [WIP] Use common/block/gpio ...................................................................... Patch Set 9: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/55056/ : FAILURE -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 9 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2017 07:26:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18305 ) Change subject: nb/i945/raminit: Use common ddr2 decode functions ...................................................................... Patch Set 46: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10737/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55054/ : SUCCESS -- To view, visit https://review.coreboot.org/18305 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3 Gerrit-Change-Number: 18305 Gerrit-PatchSet: 46 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2017 07:25:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: [WIP] Use common/block/gpio
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19201 ) Change subject: soc/intel/skylake: [WIP] Use common/block/gpio ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/55055/ : FAILURE -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 8 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2017 07:24:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: [WIP] Use common/block/gpio
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19201 ) Change subject: soc/intel/skylake: [WIP] Use common/block/gpio ...................................................................... Patch Set 7: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/55053/ : FAILURE -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 7 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2017 07:21:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: [WIP] Use common/block/gpio
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19201 ) Change subject: soc/intel/skylake: [WIP] Use common/block/gpio ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/55052/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/10736/ : SUCCESS -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 6 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2017 07:19:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: [WIP] Use common/block/gpio
by Hannah Williams (Code Review) 07 Jun '17

07 Jun '17

Hello Barnali Sarkar, Subrata Banik, V Sowmya, sowmya v, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19201 to look at the new patch set (#6). Change subject: soc/intel/skylake: [WIP] Use common/block/gpio ...................................................................... soc/intel/skylake: [WIP] Use common/block/gpio Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/gpio.h M src/mainboard/google/poppy/variants/baseboard/gpio.c M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/acpi/gpio.asl M src/soc/intel/skylake/acpi/pch.asl M src/soc/intel/skylake/bootblock/uart.c M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/gpio.c M src/soc/intel/skylake/include/soc/gpio.h M src/soc/intel/skylake/include/soc/gpio_defs.h M src/soc/intel/skylake/include/soc/gpio_pch_h_defs.h M src/soc/intel/skylake/include/soc/gpio_soc_defs.h M src/soc/intel/skylake/pmutil.c 14 files changed, 409 insertions(+), 707 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/19201/6 -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 6 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Use common systemagent code
by build bot (Jenkins) (Code Review) 07 Jun '17

07 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19795 ) Change subject: soc/intel/apollolake: Use common systemagent code ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10734/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/55050/ : SUCCESS -- To view, visit https://review.coreboot.org/19795 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15a3b2fc46ec9063b54379d41996b9a1d612cfd2 Gerrit-Change-Number: 19795 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 07 Jun 2017 06:37:28 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017