coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: pcengines/apu2: Add IVRS table generation
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15165 ) Change subject: pcengines/apu2: Add IVRS table generation ...................................................................... Patch Set 12: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53382/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9188/ : SUCCESS -- To view, visit https://review.coreboot.org/15165 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b5b421098f29163d6ae98527de152c8046b1d9 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Initialize IOMMU device
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15186 ) Change subject: nb/amd/pi/00730F01: Initialize IOMMU device ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53383/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/9189/ : SUCCESS -- To view, visit https://review.coreboot.org/15186 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12d3ed35770ee06626f884db23004652084c88c0 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Dave Frodin <dave.frodin(a)se-eng.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Add initial native IVRS support
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 ) Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53381/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9187/ : SUCCESS -- To view, visit https://review.coreboot.org/15164 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Provide common block fast_spi_flash_ctrlr
by Martin Roth (Code Review) 05 May '17

05 May '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19575 ) Change subject: soc/intel/common: Provide common block fast_spi_flash_ctrlr ...................................................................... soc/intel/common: Provide common block fast_spi_flash_ctrlr Now that we have a common block driver for fast spi flash controller, provide spi_ctrlr structure that can be used by different platforms for defining the bus-ctrlr mapping. Only cs 0 is considered valid. Change-Id: I7228ae885018d1e23e6e80dd8ce227b0d99d84a6 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> Reviewed-on: https://review.coreboot.org/19575 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/apollolake/spi.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/block/include/intelblocks/fast_spi.h M src/soc/intel/skylake/spi.c 4 files changed, 25 insertions(+), 36 deletions(-) Approvals: Aaron Durbin: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/intel/apollolake/spi.c b/src/soc/intel/apollolake/spi.c index 87d4d01..9a651ee 100644 --- a/src/soc/intel/apollolake/spi.c +++ b/src/soc/intel/apollolake/spi.c @@ -15,28 +15,11 @@ */ #include <console/console.h> +#include <intelblocks/fast_spi.h> #include <spi-generic.h> -/* SPI controller managing the fast SPI. */ -static int fast_spi_ctrlr_setup(const struct spi_slave *dev) -{ - if ((dev->bus != 0) && (dev->cs != 0)) { - printk(BIOS_ERR, "%s: Unsupported device " - "bus=0x%x,cs=0x%x!\n", __func__, dev->bus, dev->cs); - return -1; - } - - printk(BIOS_INFO, "%s: Found controller for device " - "(bus=0x%x,cs=0x%x)!!\n", __func__, dev->bus, dev->cs); - return 0; -} - -static const struct spi_ctrlr fast_spi_ctrlr = { - .setup = fast_spi_ctrlr_setup, -}; - const struct spi_ctrlr_buses spi_ctrlr_bus_map[] = { - { .ctrlr = &fast_spi_ctrlr, .bus_start = 0, .bus_end = 0 }, + { .ctrlr = &fast_spi_flash_ctrlr, .bus_start = 0, .bus_end = 0 }, }; const size_t spi_ctrlr_bus_map_count = ARRAY_SIZE(spi_ctrlr_bus_map); diff --git a/src/soc/intel/common/block/fast_spi/fast_spi_flash.c b/src/soc/intel/common/block/fast_spi/fast_spi_flash.c index 3babf91..27a4bb7 100644 --- a/src/soc/intel/common/block/fast_spi/fast_spi_flash.c +++ b/src/soc/intel/common/block/fast_spi/fast_spi_flash.c @@ -350,3 +350,18 @@ return 0; } + +static int fast_spi_flash_ctrlr_setup(const struct spi_slave *dev) +{ + if (dev->cs != 0) { + printk(BIOS_ERR, "%s: Invalid CS for fast SPI bus=0x%x,cs=0x%x!\n", + __func__, dev->bus, dev->cs); + return -1; + } + + return 0; +} + +const struct spi_ctrlr fast_spi_flash_ctrlr = { + .setup = fast_spi_flash_ctrlr_setup, +}; diff --git a/src/soc/intel/common/block/include/intelblocks/fast_spi.h b/src/soc/intel/common/block/include/intelblocks/fast_spi.h index 2b80c49..e4bddc4 100644 --- a/src/soc/intel/common/block/include/intelblocks/fast_spi.h +++ b/src/soc/intel/common/block/include/intelblocks/fast_spi.h @@ -64,4 +64,10 @@ */ void fast_spi_early_init(uintptr_t spi_base_address); +/* + * Fast SPI flash controller structure to allow SoCs to define bus-controller + * mapping. + */ +extern const struct spi_ctrlr fast_spi_flash_ctrlr; + #endif /* SOC_INTEL_COMMON_BLOCK_FAST_SPI_H */ diff --git a/src/soc/intel/skylake/spi.c b/src/soc/intel/skylake/spi.c index e11e13f..e575e6e 100644 --- a/src/soc/intel/skylake/spi.c +++ b/src/soc/intel/skylake/spi.c @@ -20,28 +20,13 @@ #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/spi.h> +#include <intelblocks/fast_spi.h> #include <intelblocks/gspi.h> #include <soc/ramstage.h> #include <spi-generic.h> -/* SPI controller managing the flash-device SPI. */ -static int flash_spi_ctrlr_setup(const struct spi_slave *dev) -{ - if ((dev->bus != 0) || (dev->cs != 0)) { - printk(BIOS_ERR, "%s: Unsupported device bus=0x%x,cs=0x%x!\n", - __func__, dev->bus, dev->cs); - return -1; - } - - return 0; -} - -static const struct spi_ctrlr flash_spi_ctrlr = { - .setup = flash_spi_ctrlr_setup, -}; - const struct spi_ctrlr_buses spi_ctrlr_bus_map[] = { - { .ctrlr = &flash_spi_ctrlr, .bus_start = 0, .bus_end = 0 }, + { .ctrlr = &fast_spi_flash_ctrlr, .bus_start = 0, .bus_end = 0 }, #if !ENV_SMM { .ctrlr = &gspi_ctrlr, .bus_start = 1, .bus_end = 1 + (CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX - 1)}, -- To view, visit https://review.coreboot.org/19575 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7228ae885018d1e23e6e80dd8ce227b0d99d84a6 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Initialize IOMMU device
by Philipp Deppenwiese (Code Review) 05 May '17

05 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/15186 to look at the new patch set (#6). Change subject: nb/amd/pi/00730F01: Initialize IOMMU device ...................................................................... nb/amd/pi/00730F01: Initialize IOMMU device Change-Id: I12d3ed35770ee06626f884db23004652084c88c0 --- M src/cpu/amd/pi/heapmanager.c M src/include/device/pci_ids.h M src/northbridge/amd/pi/00730F01/Makefile.inc A src/northbridge/amd/pi/00730F01/iommu.c M src/northbridge/amd/pi/agesawrapper.c 5 files changed, 66 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/15186/6 -- To view, visit https://review.coreboot.org/15186 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12d3ed35770ee06626f884db23004652084c88c0 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Dave Frodin <dave.frodin(a)se-eng.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: pcengines/apu2: Add IVRS table generation
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15165 ) Change subject: pcengines/apu2: Add IVRS table generation ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53380/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9186/ : SUCCESS -- To view, visit https://review.coreboot.org/15165 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b5b421098f29163d6ae98527de152c8046b1d9 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Add initial native IVRS support
by Philipp Deppenwiese (Code Review) 05 May '17

05 May '17

Hello Timothy Pearson, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/15164 to look at the new patch set (#11). Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ...................................................................... nb/amd/pi/00730F01: Add initial native IVRS support Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineering.com> --- M src/mainboard/amd/db-ft3b-lc/acpi_tables.c M src/mainboard/amd/olivehillplus/acpi_tables.c M src/mainboard/bap/ode_e21XX/acpi_tables.c M src/mainboard/pcengines/apu2/acpi_tables.c M src/northbridge/amd/pi/00730F01/northbridge.c 5 files changed, 232 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/15164/11 -- To view, visit https://review.coreboot.org/15164 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Add initial native IVRS support
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 ) Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53379/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9185/ : SUCCESS -- To view, visit https://review.coreboot.org/15164 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function
by Martin Roth (Code Review) 05 May '17

05 May '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19535 ) Change subject: drivers/pc80/tpm: Fix missing tis_close() function ...................................................................... drivers/pc80/tpm: Fix missing tis_close() function tis_close() must be called after tis_open() otherwise the locked locality isn't released and the sessions hangs. Tested=PC Engines APU2 Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-on: https://review.coreboot.org/19535 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/pc80/tpm/romstage.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Patrick Rudolph: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/pc80/tpm/romstage.c b/src/drivers/pc80/tpm/romstage.c index a257ba1..5531458 100644 --- a/src/drivers/pc80/tpm/romstage.c +++ b/src/drivers/pc80/tpm/romstage.c @@ -215,7 +215,6 @@ if (tis_open()) return; - if (s3resume) { /* S3 Resume */ printk(BIOS_SPEW, "TPM: Resume\n"); @@ -226,6 +225,7 @@ * in S3, so it's already initialized. */ printk(BIOS_DEBUG, "TPM: Already initialized.\n"); + tis_close(); return; } } else { @@ -234,6 +234,8 @@ response, sizeof(response)); } + tis_close(); + if (result == TPM_SUCCESS) { printk(BIOS_SPEW, "TPM: OK.\n"); return; -- To view, visit https://review.coreboot.org/19535 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Add initial native IVRS support
by Philipp Deppenwiese (Code Review) 05 May '17

05 May '17

Hello Timothy Pearson, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/15164 to look at the new patch set (#10). Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ...................................................................... nb/amd/pi/00730F01: Add initial native IVRS support Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineering.com> --- M src/mainboard/amd/db-ft3b-lc/acpi_tables.c M src/mainboard/amd/olivehillplus/acpi_tables.c M src/mainboard/bap/ode_e21XX/acpi_tables.c M src/mainboard/pcengines/apu2/acpi_tables.c M src/northbridge/amd/pi/00730F01/northbridge.c 5 files changed, 231 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/15164/10 -- To view, visit https://review.coreboot.org/15164 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017