coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/intel/common/block: correct apollolake device ids
by Martin Roth (Code Review) 06 May '17

06 May '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19600 ) Change subject: soc/intel/common/block: correct apollolake device ids ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19600 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d74d95ec6b516c4d8354a714b2b302557743fe0 Gerrit-PatchSet: 1 Gerrit-Project: … [View More]

1 0

Change in coreboot[master]: intel/common/block: Fix incorrect defines
by Furquan Shaikh (Code Review) 06 May '17

06 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19601 ) Change subject: intel/common/block: Fix incorrect defines ...................................................................... Patch Set 1: Aaron has uploaded a fix for this: https://review.coreboot.org/#/c/19600/ -- To view, visit https://review.coreboot.org/19601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: … [View More]

1 0

Change in coreboot[master]: soc/intel/common/block:[WIP] Add GPIO common code
by Hannah Williams (Code Review) 06 May '17

06 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18917 to look at the new patch set (#18). Change subject: soc/intel/common/block:[WIP] Add GPIO common code ...................................................................... soc/intel/common/block:[WIP] Add GPIO common code Here are some differences between APL and SKL GPIO registers DW0: PMODE: SKL[11:10] and APL[12:10] RXTXENCFG: APL[21:20] and RSVD in SKL PREGFRXSEL: APL[24]… [View More] and RSVD in SKL DW1: SKL only has INTSEL and TERM whereas APL and GLK share same bit definitions for rest of the bits that are reserved in SKL EVMAP and EVOUTEN are not there on SKL DW1_PAD_TOL has been used only in SKL Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- A src/soc/intel/common/block/gpio/Kconfig A src/soc/intel/common/block/gpio/Makefile.inc A src/soc/intel/common/block/gpio/gpio.c A src/soc/intel/common/block/include/intelblocks/gpio.h A src/soc/intel/common/block/include/intelblocks/gpio_defs.h 5 files changed, 807 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/18917/18 -- To view, visit https://review.coreboot.org/18917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c Gerrit-PatchSet: 18 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Dhaval Sharma <dhaval.v.sharma(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> [View Less]

1 0

Change in coreboot[master]: intel/common/block: Fix incorrect defines
by build bot (Jenkins) (Code Review) 06 May '17

06 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19601 ) Change subject: intel/common/block: Fix incorrect defines ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53391/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9196/ : SUCCESS -- To view, visit https://review.coreboot.org/19601 To unsubscribe, visit https://review.coreboot.org/… [View More]

1 0

Change in coreboot[master]: intel/common/block: Fix incorrect defines
by Martin Roth (Code Review) 06 May '17

06 May '17

Martin Roth has uploaded a new change for review. ( https://review.coreboot.org/19601 ) Change subject: intel/common/block: Fix incorrect defines ...................................................................... intel/common/block: Fix incorrect defines These #defines were part of a patch train where they were changed from ...APOLLOLAKE... to ...APL... Unfortunately, the follow-on commits in the train were not updated or rebased, so this issue wasn't caught until they were merged. … [View More]

1 0

Change in coreboot[master]: inteltool: Add dumping of full PCR ports
by Youness Alaoui (Code Review) 06 May '17

06 May '17

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19593 ) Change subject: inteltool: Add dumping of full PCR ports ...................................................................... Patch Set 1: (3 comments) I didn't finish reviewing this but I thought better to post it now than wait until after the weekend. https://review.coreboot.org/#/c/19593/1/util/inteltool/Makefile File util/inteltool/Makefile: Line 25: CFLAGS ?= -O2 -g -Wall -W -I$(top)/src/… [View More]

1 0

Change in coreboot[master]: drivers/spi: Re-factor spi_crop_chunk
by coreboot org (Code Review) 06 May '17

06 May '17

coreboot org has posted comments on this change. ( https://review.coreboot.org/19386 ) Change subject: drivers/spi: Re-factor spi_crop_chunk ...................................................................... Patch Set 8: Gigabyte GA-G41M-ES2L: Target OFFLINE. Test ABORTED. Asus P5GC-MX: Target OFFLINE. Test ABORTED. -- To view, visit https://review.coreboot.org/19386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: … [View More]

1 0

Change in coreboot[master]: soc/intel/common/block: correct apollolake device ids
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19600 ) Change subject: soc/intel/common/block: correct apollolake device ids ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53390/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9195/ : SUCCESS -- To view, visit https://review.coreboot.org/19600 To unsubscribe, visit https://review.… [View More]

1 0

Change in coreboot[master]: soc/intel/common/block: correct apollolake device ids
by Furquan Shaikh (Code Review) 05 May '17

05 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19600 ) Change subject: soc/intel/common/block: correct apollolake device ids ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19600 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d74d95ec6b516c4d8354a714b2b302557743fe0 Gerrit-PatchSet: 1 Gerrit-Project: … [View More]

1 0

Change in coreboot[master]: pcengines/apu2: Add IVRS table generation
by build bot (Jenkins) (Code Review) 05 May '17

05 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15165 ) Change subject: pcengines/apu2: Add IVRS table generation ...................................................................... Patch Set 14: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53389/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9194/ : SUCCESS -- To view, visit https://review.coreboot.org/15165 To unsubscribe, visit https://review.coreboot.… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017