Hello Julius Werner,
I'd like you to do a code review. Please visit
https://review.coreboot.org/19699
to review the following change.
Change subject: rockchip: rk3399: remove the delay for enableing SSC
......................................................................
rockchip: rk3399: remove the delay for enableing SSC
The hang was caused by deassert the reset before, it had been delayed 20us
fixing the hang issue.
So we can remove this delay for now.
Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Signed-off-by: Caesar Wang <wxt(a)rock-chips.com>
---
M src/soc/rockchip/rk3399/clock.c
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/19699/1
diff --git a/src/soc/rockchip/rk3399/clock.c b/src/soc/rockchip/rk3399/clock.c
index 944ca6f..7e205d2 100644
--- a/src/soc/rockchip/rk3399/clock.c
+++ b/src/soc/rockchip/rk3399/clock.c
@@ -356,11 +356,6 @@
{
u32 divval;
- /*
- * TODO find the root cause why is the delay needed, otherwise sometimes
- * hang somewhere with reboot tests.
- */
- udelay(30);
assert(dpll_cfg->refdiv && dpll_cfg->refdiv <= 6);
/*
--
To view, visit https://review.coreboot.org/19699
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/18917
to look at the new patch set (#26).
Change subject: soc/intel/common/block:[WIP] Add GPIO common code
......................................................................
soc/intel/common/block:[WIP] Add GPIO common code
Here are some differences between APL and SKL GPIO registers
DW0:
PMODE: SKL[11:10] and APL[12:10]
RXTXENCFG: APL[21:20] and RSVD in SKL
PREGFRXSEL: APL[24] and RSVD in SKL
DW1: SKL only has INTSEL and TERM whereas APL and GLK share same bit
definitions for rest of the bits that are reserved in SKL
(e.g. IoStandby state and term)
EVMAP and EVOUTEN are not there on SKL
DW1_PAD_TOL has been used only in SKL
Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c
Signed-off-by: Hannah Williams <hannah.williams(a)intel.com>
---
A src/soc/intel/common/block/gpio/Kconfig
A src/soc/intel/common/block/gpio/Makefile.inc
A src/soc/intel/common/block/gpio/gpio.c
A src/soc/intel/common/block/include/intelblocks/gpio.h
A src/soc/intel/common/block/include/intelblocks/gpio_defs.h
5 files changed, 824 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/18917/26
--
To view, visit https://review.coreboot.org/18917
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c
Gerrit-PatchSet: 26
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com>
Gerrit-Reviewer: Dhaval Sharma <dhaval.v.sharma(a)intel.com>
Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Marc Herbert <marc.herbert(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com>
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/19698 )
Change subject: detachables: Add invert parameter
......................................................................
Patch Set 3: Code-Review-1
ok, hold off on code reviewing this as Randall just asked me to change a lot of the patch already.
--
To view, visit https://review.coreboot.org/19698
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide6893a26f19eb2490377d4d53366ad145a9e6e3
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No