coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 16 May '17

16 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19692/3/src/mainboard/google/poppy/spd/hyni… File src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex: PS3, Line 7: 00 00 Offset 0x7E & 0x7F are CRC. -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 16 May '17

16 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19692/3/src/mainboard/google/poppy/spd/hyni… File src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex: PS3, Line 9: 42 4B > I think one of the fields in the SPD is checksum? I haven't check what offs Will check & revert back. -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/soraka: Update camera sensor for soraka
by build bot (Jenkins) (Code Review) 16 May '17

16 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19639 ) Change subject: mb/google/soraka: Update camera sensor for soraka ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53672/ : SUCCESS -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS
by Furquan Shaikh (Code Review) 16 May '17

16 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19684 ) Change subject: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/19684 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I396aa1a3e89507c90e17229a986de5d2c0887c9c Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Update camera sensor for soraka
by Naresh Solanki (Code Review) 16 May '17

16 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19639 ) Change subject: mb/google/soraka: Update camera sensor for soraka ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19639/2//COMMIT_MSG Commit Message: PS2, Line 7: Camera sensor > camera sensor Done -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/soraka: Update camera sensor for soraka
by Naresh Solanki (Code Review) 16 May '17

16 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19639 to look at the new patch set (#3). Change subject: mb/google/soraka: Update camera sensor for soraka ...................................................................... mb/google/soraka: Update camera sensor for soraka Soraka uses OV 13858 sensor. Hence update the same. Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/mainboard/google/poppy/variants/soraka/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/19639/3 -- To view, visit https://review.coreboot.org/19639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4dd39a25da47e379cca3f8748250b3ce1ff61e50 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by build bot (Jenkins) (Code Review) 16 May '17

16 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53671/ : SUCCESS -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Furquan Shaikh (Code Review) 16 May '17

16 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19692/3/src/mainboard/google/poppy/spd/hyni… File src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex: PS3, Line 9: 42 4B I think one of the fields in the SPD is checksum? I haven't check what offset that is at, but we will have to ensure that it is updated as well. -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 16 May '17

16 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19692/2//COMMIT_MSG Commit Message: PS2, Line 10: Coreboot > Please all lowercase: coreboot. Done -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 16 May '17

16 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19692 to look at the new patch set (#3). Change subject: mb/google/poppy: Update SPD data ...................................................................... mb/google/poppy: Update SPD data Though SPD is rightly selected (i.e., H9CCNNNBKTALBR-NUD), it displays wrong part number during boot in coreboot logs. So correct part number info within the SPD. TEST= Build for Soraka & make sure part number is rightly printed. Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/19692/3 -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017