Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19477
to look at the new patch set (#9).
Change subject: rockchip/rk3399: Add MIPI driver
......................................................................
rockchip/rk3399: Add MIPI driver
This patch configures clock for mipi and then
adds mipi driver for support innolux-p079zca
mipi panel in rk3399 scarlet.
Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Signed-off-by: Nickey Yang <nickey.yang(a)rock-chips.com>
---
M src/soc/rockchip/common/include/soc/vop.h
M src/soc/rockchip/common/vop.c
M src/soc/rockchip/rk3399/Makefile.inc
M src/soc/rockchip/rk3399/chip.h
M src/soc/rockchip/rk3399/clock.c
M src/soc/rockchip/rk3399/display.c
M src/soc/rockchip/rk3399/include/soc/addressmap.h
M src/soc/rockchip/rk3399/include/soc/clock.h
A src/soc/rockchip/rk3399/include/soc/mipi.h
A src/soc/rockchip/rk3399/mipi.c
10 files changed, 803 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/19477/9
--
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang(a)rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nickey.yang(a)rock-chips.com
nickey.yang(a)rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19477 )
Change subject: rockchip/rk3399: Add MIPI driver
......................................................................
Patch Set 7:
> Thank you. So from this it seems pretty clear that this is a
> panel-specific delay between SLPOUT (I assume this is
> EXIT_SLEEP_MODE?) and DISON (SET_DISPLAY_ON?). In that case,
> everything in my last two comments applies: you should probably
> move the delay to where you have the msleep(12) right now. It's
> probably fine to reduce it to 120ms again if the datasheet
> explicitly says that. I see no justification for an msleep(12)
> anywhere else, so unless you know a good reason for it you can
> probably leave it out. Also, since this is a panel-specific value
> it needs to come from devicetree.cb and get passed in to the
> function as I described.
Hi
see https://drive.google.com/file/d/0BxD4piBE3rdlaGRQcVZkM1lubnc/view?usp=shari…
I'm sorry to have uploaded an old Datasheet.
new is here.
when i remove T7,panel does not work.
--
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang(a)rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nickey.yang(a)rock-chips.com
Gerrit-HasComments: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19477
to look at the new patch set (#8).
Change subject: rockchip/rk3399: Add MIPI driver
......................................................................
rockchip/rk3399: Add MIPI driver
This patch configures clock for mipi and then
adds mipi driver for support innolux-p079zca
mipi panel in rk3399 scarlet.
Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Signed-off-by: Nickey Yang <nickey.yang(a)rock-chips.com>
---
M src/soc/rockchip/common/include/soc/vop.h
M src/soc/rockchip/common/vop.c
M src/soc/rockchip/rk3399/Makefile.inc
M src/soc/rockchip/rk3399/chip.h
M src/soc/rockchip/rk3399/clock.c
M src/soc/rockchip/rk3399/display.c
M src/soc/rockchip/rk3399/include/soc/addressmap.h
M src/soc/rockchip/rk3399/include/soc/clock.h
A src/soc/rockchip/rk3399/include/soc/mipi.h
A src/soc/rockchip/rk3399/mipi.c
10 files changed, 803 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/19477/8
--
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang(a)rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul(a)chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nickey.yang(a)rock-chips.com
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19699 )
Change subject: rockchip: rk3399: remove the delay for enabling SSC
......................................................................
Patch Set 2: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/53667/ : SUCCESS
--
To view, visit https://review.coreboot.org/19699
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Caesar Wang has uploaded a new patch set (#2). ( https://review.coreboot.org/19699 )
Change subject: rockchip: rk3399: remove the delay for enabling SSC
......................................................................
rockchip: rk3399: remove the delay for enabling SSC
The hang was caused by deassert the reset before, it had been delayed 20us
fixing the hang issue.
So we can remove this delay for now.
Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Signed-off-by: Caesar Wang <wxt(a)rock-chips.com>
---
M src/soc/rockchip/rk3399/clock.c
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/19699/2
--
To view, visit https://review.coreboot.org/19699
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>