coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: [WIP]ec/lenovo/h8: console: Panic on death
by build bot (Jenkins) (Code Review) 16 May '17

16 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19696 ) Change subject: [WIP]ec/lenovo/h8: console: Panic on death ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9428/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53651/ : SUCCESS -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]ec/lenovo/h8: console: Panic on death
by Patrick Rudolph (Code Review) 16 May '17

16 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19696 to look at the new patch set (#2). Change subject: [WIP]ec/lenovo/h8: console: Panic on death ...................................................................... [WIP]ec/lenovo/h8: console: Panic on death Call h8_panic to signal critical failure. Guard some functions in romstage. Move static functions to enable romstage guard. Build h8.c in romstage, too. Tested on Lenovo T500. Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/console/die.c M src/ec/lenovo/h8/Makefile.inc M src/ec/lenovo/h8/h8.c 3 files changed, 23 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/19696/2 -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]ec/lenovo/h8: Add panic method
by Patrick Rudolph (Code Review) 16 May '17

16 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19695 to look at the new patch set (#2). Change subject: [WIP]ec/lenovo/h8: Add panic method ...................................................................... [WIP]ec/lenovo/h8: Add panic method Flash all LEDs and play beep code 10. To be used for critical events like death. Add two additional LED IDs. Tested on Lenovo T500. Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org --- M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/h8.h 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/19695/2 -- To view, visit https://review.coreboot.org/19695 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/cbmem: mmap underflow on low addresses
by Julius Werner (Code Review) 16 May '17

16 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19679 ) Change subject: util/cbmem: mmap underflow on low addresses ...................................................................... Patch Set 3: > $ sudo ./cbmem -l > Failed to mmap /dev/mem: Operation not permitted EPERM means you're violating STRICT_DEVMEM, that check happens before the crash. Either compile a kernel without STRICT_DEVMEM or try this on a machine where the relevant physical address range would not be normal memory. -- To view, visit https://review.coreboot.org/19679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32b0c15b2f1aa43fc57656d5d2d5f0e4e90e94ef Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: vexpress: change to write32
by Patrick Rudolph (Code Review) 16 May '17

16 May '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19685 ) Change subject: vexpress: change to write32 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/19685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcc83328441ccfb34ee63a7406d26e393633c21 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge: Use macros to determine min and max of...
by Patrick Rudolph (Code Review) 16 May '17

16 May '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19691 ) Change subject: nb/intel/sandybridge: Use macros to determine min and max of timA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19691 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4387a4f4092053dab273191a73edb0ef31a79f6 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]ec/lenovo/h8: Panic on die
by build bot (Jenkins) (Code Review) 16 May '17

16 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19696 ) Change subject: [WIP]ec/lenovo/h8: Panic on die ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9426/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53648/ : SUCCESS -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Make raminit less verbose with CONFIG_DEBUG_RA...
by Arthur Heymans (Code Review) 16 May '17

16 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18924 ) Change subject: nb/intel/x4x: Make raminit less verbose with CONFIG_DEBUG_RAM_SETUP ...................................................................... Patch Set 3: Hmm apparently I removed the hexdump in https://review.coreboot.org/#/c/19143/ -- To view, visit https://review.coreboot.org/18924 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b484cf1f1d296823df0473e852d9d07ca20246 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]ec/lenovo/h8: Add panic method
by build bot (Jenkins) (Code Review) 16 May '17

16 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19695 ) Change subject: [WIP]ec/lenovo/h8: Add panic method ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9425/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53649/ : SUCCESS -- To view, visit https://review.coreboot.org/19695 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]ec/lenovo/h8: Panic on die
by Patrick Rudolph (Code Review) 16 May '17

16 May '17

Patrick Rudolph has uploaded a new change for review. ( https://review.coreboot.org/19696 ) Change subject: [WIP]ec/lenovo/h8: Panic on die ...................................................................... [WIP]ec/lenovo/h8: Panic on die Panic on die method. Useful to signal something realy bad happend happend, like failed raminit. Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/console/die.c M src/ec/lenovo/h8/h8.c M src/include/console/console.h 3 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/19696/1 diff --git a/src/console/die.c b/src/console/die.c index ea46f51..5b15081 100644 --- a/src/console/die.c +++ b/src/console/die.c @@ -21,10 +21,15 @@ #ifndef __ROMCC__ #define NORETURN __attribute__((noreturn)) +void __attribute__ ((weak)) ec_panic(void) +{ +} + /* Report a fatal error */ void NORETURN die(const char *msg) { printk(BIOS_EMERG, "%s", msg); + ec_panic(); halt(); } #endif diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 272caf1..528f431 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -165,6 +165,12 @@ ec_write(H8_LED_CONTROL, H8_LED_CONTROL_BLINK | i); } +/* called by die() */ +void ec_panic(void) +{ + h8_panic(); +} + u8 h8_build_id_and_function_spec_version(char *buf, u8 buf_len) { u8 i, c; diff --git a/src/include/console/console.h b/src/include/console/console.h index d89d747..b283fe4 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -41,6 +41,7 @@ /* this function is weak and can be overridden by a mainboard function. */ void mainboard_post(u8 value); void __attribute__ ((noreturn)) die(const char *msg); +void __attribute__ ((weak)) ec_panic(void); #define __CONSOLE_ENABLE__ \ ((ENV_BOOTBLOCK && IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)) || \ -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017