Martin Roth has posted comments on this change. ( https://review.coreboot.org/19759 )
Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/19759/8/src/soc/intel/common/block/gpio/Kco…
File src/soc/intel/common/block/gpio/Kconfig:
Line 14: #config in SOC directory
> This doesn't work when the name of the directory comes after 'common'. The
If desired, that could be fixed by moving the soc/intel/common/Kconfig file under a subdirectory and adding an explicit source line just for soc/intel/common/*/Kconfig before the rest of the SOC Kconfig files get sourced.
We'd probably want to move all of the source files that currently reside in intel/common into a subdirectory as well.
--
To view, visit https://review.coreboot.org/19759
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes