coreboot-gerrit April 2017

coreboot-gerrit@coreboot.org

1 participants
4151 discussions

Change in coreboot[master]: abuild: add timeless build command line parameter
by Philippe Mathieu-Daudé (Code Review) 01 Apr '17

01 Apr '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19034 ) Change subject: abuild: add timeless build command line parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b4c027ccf3e5563dbf4598a0d1fb5e83a5985a Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by build bot (Jenkins) (Code Review) 01 Apr '17

01 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18011 ) Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/7002/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51031/ : SUCCESS -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo/t430: Add Thinkpad T430 support
by Patrick Rudolph (Code Review) 01 Apr '17

01 Apr '17

Hello Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18011 to look at the new patch set (#3). Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ...................................................................... mainboard/lenovo/t430: Add Thinkpad T430 support TODO: * Implement USB port mapping * Check devicetree * Test all hardware Fixed and tested since intial commit: * Native gfx init broken due to wrong devicetree * No EC events due to wrong devicetree * No internal flashing possible due to missing SPI registers * Fan always running at maxiumum due to wrong devicetree Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- A src/mainboard/lenovo/t430/Kconfig A src/mainboard/lenovo/t430/Kconfig.name A src/mainboard/lenovo/t430/Makefile.inc A src/mainboard/lenovo/t430/acpi/ec.asl A src/mainboard/lenovo/t430/acpi/platform.asl A src/mainboard/lenovo/t430/acpi/superio.asl A src/mainboard/lenovo/t430/acpi_tables.c A src/mainboard/lenovo/t430/board_info.txt A src/mainboard/lenovo/t430/cmos.default A src/mainboard/lenovo/t430/cmos.layout A src/mainboard/lenovo/t430/devicetree.cb A src/mainboard/lenovo/t430/dock.c A src/mainboard/lenovo/t430/dsdt.asl A src/mainboard/lenovo/t430/gpio.c A src/mainboard/lenovo/t430/hda_verb.c A src/mainboard/lenovo/t430/mainboard.c A src/mainboard/lenovo/t430/romstage.c A src/mainboard/lenovo/t430/smihandler.c A src/mainboard/lenovo/t430/thermal.h 19 files changed, 1,049 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/18011/3 -- To view, visit https://review.coreboot.org/18011 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5403cfb80a57753e873c570d95ca535cf5f45630 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: cpu/intel/model_106cx: Add tsc_freq_mhz() function
by Sumeet R Pawnikar (Code Review) 01 Apr '17

01 Apr '17

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/19067 ) Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c File src/cpu/intel/model_106cx/tsc_freq.c: PS1, Line 4: 2014 Need to correct this to 2017 PS1, Line 29: 400 >From where this value came ? can we use macro for this ? PS1, Line 32: 533 same as above comment. -- To view, visit https://review.coreboot.org/19067 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb6074f3f097d7e6fc501a376754a05eb9e4faa0 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: [NOTFORMERGE]sb/intel/i82801gx: Make smbus_block_read availa...
by build bot (Jenkins) (Code Review) 01 Apr '17

01 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18927 ) Change subject: [NOTFORMERGE]sb/intel/i82801gx: Make smbus_block_read available in romstage ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/7001/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51030/ : SUCCESS -- To view, visit https://review.coreboot.org/18927 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d768a2ba128329168f26445a4fca6921c0c8642 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/model_106cx: Add tsc_freq_mhz() function
by Arthur Heymans (Code Review) 01 Apr '17

01 Apr '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19067 ) Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c File src/cpu/intel/model_106cx/tsc_freq.c: > > you mean model_2065x ? 1067x does not seem to have this function/file. I think cbmem on 1067x uses a sys file which is not available on 106cx -- To view, visit https://review.coreboot.org/19067 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb6074f3f097d7e6fc501a376754a05eb9e4faa0 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: [NOTFORMERGE]sb/intel/i82801gx: Make smbus_block_read availa...
by Arthur Heymans (Code Review) 01 Apr '17

01 Apr '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18927 to look at the new patch set (#5). Change subject: [NOTFORMERGE]sb/intel/i82801gx: Make smbus_block_read available in romstage ...................................................................... [NOTFORMERGE]sb/intel/i82801gx: Make smbus_block_read available in romstage Using block_read might speed things up compared to reading each byte one by one. Change-Id: I6d768a2ba128329168f26445a4fca6921c0c8642 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/i945/raminit.c M src/southbridge/intel/i82801gx/early_smbus.c M src/southbridge/intel/i82801gx/i82801gx.h M src/southbridge/intel/i82801gx/smbus.c M src/southbridge/intel/i82801gx/smbus.h 5 files changed, 62 insertions(+), 56 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/18927/5 -- To view, visit https://review.coreboot.org/18927 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6d768a2ba128329168f26445a4fca6921c0c8642 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: Build system: Make jenkins target to check for changes
by build bot (Jenkins) (Code Review) 01 Apr '17

01 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19035 ) Change subject: Build system: Make jenkins target to check for changes ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/51029/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/7000/ : SUCCESS -- To view, visit https://review.coreboot.org/19035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie603f80c6f2b2a656df22b4a569a0f82a1237636 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: abuild: add timeless build command line parameter
by build bot (Jenkins) (Code Review) 01 Apr '17

01 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19034 ) Change subject: abuild: add timeless build command line parameter ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6999/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51028/ : SUCCESS -- To view, visit https://review.coreboot.org/19034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b4c027ccf3e5563dbf4598a0d1fb5e83a5985a Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: Build system: Make jenkins target to check for changes
by Martin Roth (Code Review) 01 Apr '17

01 Apr '17

Martin Roth has uploaded a new change for review. ( https://review.coreboot.org/19035 ) Change subject: Build system: Make jenkins target to check for changes ...................................................................... Build system: Make jenkins target to check for changes -add --timeless argument to what-jenkins-does builds -add jenkins-compare-last makefile target that checks out the previous commit and rebuilds all platforms, then compares the checksums of all of the platforms looking for anything that's changed. Change-Id: Ie603f80c6f2b2a656df22b4a569a0f82a1237636 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Makefile M Makefile.inc 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19035/1 diff --git a/Makefile b/Makefile index 701a146..cd85475 100644 --- a/Makefile +++ b/Makefile @@ -113,7 +113,7 @@ NOCOMPILE:=1 endif ifneq ($(MAKECMDGOALS),) -ifneq ($(filter %config %clean cross% clang iasl gnumake lint% help% what-jenkins-does,$(MAKECMDGOALS)),) +ifneq ($(filter %config %clean cross% clang iasl gnumake lint% help% what-jenkins-does jenkins-compare-last,$(MAKECMDGOALS)),) NOCOMPILE:=1 endif ifeq ($(MAKECMDGOALS), %clean) diff --git a/Makefile.inc b/Makefile.inc index 5ab3524..2f77d7d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1055,10 +1055,28 @@ CPUS?=4 what-jenkins-does: util/lint/lint lint-stable --junit - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x -X $(top)/abuild-chromeos.xml - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) + util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x -X $(top)/abuild-chromeos.xml -o coreboot-builds-chromeos --timeless + util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) --timeless (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml + +jenkins-compare-last: GIT=$(shell [ -e "$(top)/.git" ] && command -v git) +jenkins-compare-last: GITCOMMIT=$(shell if [ -n "$(GIT)" ]; then $(GIT) log HEAD --format="%h" -n 1; fi ) +jenkins-compare-last: what-jenkins-does + if [ -z "$(GITCOMMIT)" ]; then \ + echo "Error: Could not get previous commit to compare."; false; \ + fi + echo "********** BUILDING PARENT COMMIT **********" + $(GIT) checkout HEAD^ + util/abuild/abuild -B $(if $(JENKINS_NOCCACHE),,-y) -z -c $(CPUS) -p $(JENKINS_PAYLOAD) -x -o coreboot-builds-chromeos --timeless + util/abuild/abuild -B $(if $(JENKINS_NOCCACHE),,-y) -z -c $(CPUS) -p $(JENKINS_PAYLOAD) --timeless + $(GIT) checkout $(GITCOMMIT) + echo "********** Finished Building Parent Commit **********" + DIFFS="$$(sort coreboot-builds-chromeos/platform_checksums | uniq -c | grep -v '^ *2 ' | sed 's/.*coreboot-/coreboot-/' | sort | uniq; \ + sort coreboot-builds/platform_checksums | uniq -c | grep -v '^ *2' | sed 's/.*coreboot-/coreboot-/' | sort | uniq )" + if [ -z "$$DIFFS" ]; then echo "All platforms unchanged"; \ + else echo "Platforms with differences:"; echo "$$DIFFS"; \ + fi -- To view, visit https://review.coreboot.org/19035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie603f80c6f2b2a656df22b4a569a0f82a1237636 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2017