coreboot-gerrit April 2017

coreboot-gerrit@coreboot.org

1 participants
4151 discussions

Change in coreboot[master]: Build system: Make jenkins target to check for changes
by build bot (Jenkins) (Code Review) 02 Apr '17

02 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19035 ) Change subject: Build system: Make jenkins target to check for changes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/7007/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51038/ : SUCCESS -- To view, visit https://review.coreboot.org/19035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie603f80c6f2b2a656df22b4a569a0f82a1237636 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/abuild: Save checksums of build files
by build bot (Jenkins) (Code Review) 02 Apr '17

02 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19033 ) Change subject: util/abuild: Save checksums of build files ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/7005/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51036/ : SUCCESS -- To view, visit https://review.coreboot.org/19033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: Makefile.inc: Move shared abuild options into a variable
by Martin Roth (Code Review) 02 Apr '17

02 Apr '17

Martin Roth has uploaded a new change for review. ( https://review.coreboot.org/19070 ) Change subject: Makefile.inc: Move shared abuild options into a variable ...................................................................... Makefile.inc: Move shared abuild options into a variable With 4 calls to abuild, move the common command line parameters into a variable that can be shared between all of the invocations. Change-Id: I5cdf2f343bd28424b7cc1dfc6ca132a9fb9e6554 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Makefile.inc 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/19070/1 diff --git a/Makefile.inc b/Makefile.inc index c8660b6..14c9537 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1053,10 +1053,11 @@ viatool JENKINS_PAYLOAD?=none CPUS?=4 +JENKINS_ABUILD_OPTIONS=-B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) --timeless what-jenkins-does: util/lint/lint lint-stable --junit - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x -X $(top)/abuild-chromeos.xml --timeless --checksum $(top)/checksums_chromeos - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) --timeless --checksum $(top)/checksums + util/abuild/abuild $(JENKINS_ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos.xml --checksum $(top)/checksums_chromeos + util/abuild/abuild $(JENKINS_ABUILD_OPTIONS) --checksum $(top)/checksums (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml @@ -1071,8 +1072,8 @@ fi echo "********** BUILDING PARENT COMMIT **********" $(GIT) checkout HEAD^ - util/abuild/abuild -B $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x --timeless --checksum $(top)/checksums_chromeos - util/abuild/abuild -B $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) --timeless --checksum $(top)/checksums + util/abuild/abuild $(JENKINS_ABUILD_OPTIONS) -x --checksum $(top)/checksums_chromeos + util/abuild/abuild $(JENKINS_ABUILD_OPTIONS) --checksum $(top)/checksums $(GIT) checkout $(GITCOMMIT) echo "********** Finished Building Parent Commit **********" DIFFS="$$(sort $(top)/checksums_chromeos_platform | uniq -c | grep -v '^ *2 ' | sed 's/.*coreboot-/coreboot-/' | sort | uniq; \ -- To view, visit https://review.coreboot.org/19070 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5cdf2f343bd28424b7cc1dfc6ca132a9fb9e6554 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: Build system: Make jenkins target to check for changes
by Martin Roth (Code Review) 02 Apr '17

02 Apr '17

Hello Philippe Mathieu-Daudé, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19035 to look at the new patch set (#2). Change subject: Build system: Make jenkins target to check for changes ...................................................................... Build system: Make jenkins target to check for changes -add --timeless argument to what-jenkins-does builds - Add jenkins-compare-last makefile target that checks out the previous commit and rebuilds all platforms, then compares the checksums of all of the platforms and configs looking for anything that's changed. - Add timeless & checksum arguments to the what-jenkins-does target to supply good checksums to compare against. - The timeless argument was previously being supplied as an environment variable on the jenkins server. That can be removed with this change. Change-Id: Ie603f80c6f2b2a656df22b4a569a0f82a1237636 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Makefile M Makefile.inc 2 files changed, 26 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19035/2 -- To view, visit https://review.coreboot.org/19035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie603f80c6f2b2a656df22b4a569a0f82a1237636 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: abuild: add timeless build command line parameter
by Martin Roth (Code Review) 02 Apr '17

02 Apr '17

Hello Philippe Mathieu-Daudé, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19034 to look at the new patch set (#2). Change subject: abuild: add timeless build command line parameter ...................................................................... abuild: add timeless build command line parameter Update ABUILD_VERSION for the timeless & checksum parameters. Change-Id: I96b4c027ccf3e5563dbf4598a0d1fb5e83a5985a Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M util/abuild/abuild 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/19034/2 -- To view, visit https://review.coreboot.org/19034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I96b4c027ccf3e5563dbf4598a0d1fb5e83a5985a Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: util/abuild: Save checksums of build files
by Martin Roth (Code Review) 02 Apr '17

02 Apr '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19033 to look at the new patch set (#3). Change subject: util/abuild: Save checksums of build files ...................................................................... util/abuild: Save checksums of build files - Add --checksum command line parameter to specify a base path and filename for the checksums to be saved into. - Save checkums of each platform into the specified file appended with "_platform" - Save a sha256 checksum of the sorted config.h into the base file appended with "_config" Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M util/abuild/abuild 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/19033/3 -- To view, visit https://review.coreboot.org/19033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id24dc4b10afbd35cdb8750f75b934419e6e80290 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: Makefile.inc: Fix jenkins build of nvramcui & coreinfo
by build bot (Jenkins) (Code Review) 02 Apr '17

02 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19069 ) Change subject: Makefile.inc: Fix jenkins build of nvramcui & coreinfo ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/7004/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/51035/ : SUCCESS -- To view, visit https://review.coreboot.org/19069 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d81ebabebe5d8b5f79ae63f8a5f388430e06754 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: Makefile.inc: Fix jenkins build of nvramcui & coreinfo
by Martin Roth (Code Review) 02 Apr '17

02 Apr '17

Martin Roth has uploaded a new change for review. ( https://review.coreboot.org/19069 ) Change subject: Makefile.inc: Fix jenkins build of nvramcui & coreinfo ...................................................................... Makefile.inc: Fix jenkins build of nvramcui & coreinfo With COREBOOT_BUILD_DIR set, nvramcui & coreinfo were getting built in the wrong location, causing those builds to fail. Also, because they were built in the wrong location, the build failures were not detected by jenkins which was looking for the junit.xml files under the payloads directory. Change-Id: I9d81ebabebe5d8b5f79ae63f8a5f388430e06754 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/19069/1 diff --git a/Makefile.inc b/Makefile.inc index 5ab3524..573d927 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1059,6 +1059,6 @@ util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) - $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml - $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml + unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml + unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml -- To view, visit https://review.coreboot.org/19069 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d81ebabebe5d8b5f79ae63f8a5f388430e06754 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/apollolake: [WIP] Use common/block/gpio
by Hannah Williams (Code Review) 01 Apr '17

01 Apr '17

Hannah Williams has uploaded a new patch set (#4). ( https://review.coreboot.org/19068 ) Change subject: soc/apollolake: [WIP] Use common/block/gpio ...................................................................... soc/apollolake: [WIP] Use common/block/gpio This patch depends on PCR common code Add SOC_INTEL_COMMON_BLOCK_PCR to Kconfig Code changes to gpio_table in mainboard/google/reef/variants/baseboard/gpio.c is incomplete Change-Id: I3533526832e940d135625130b41286fe729963ba Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/google/reef/variants/baseboard/gpio.c M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/acpi/gpio.asl M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.h M src/soc/intel/apollolake/gpio.c M src/soc/intel/apollolake/include/soc/gpio.h D src/soc/intel/apollolake/include/soc/gpio_defs.h M src/soc/intel/apollolake/lpc_lib.c M src/soc/intel/apollolake/uart_early.c 10 files changed, 638 insertions(+), 1,059 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/19068/4 -- To view, visit https://review.coreboot.org/19068 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3533526832e940d135625130b41286fe729963ba Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: soc/apollolake: [WIP] Use common/block/gpio
by Hannah Williams (Code Review) 01 Apr '17

01 Apr '17

Hannah Williams has uploaded a new patch set (#3). ( https://review.coreboot.org/19068 ) Change subject: soc/apollolake: [WIP] Use common/block/gpio ...................................................................... soc/apollolake: [WIP] Use common/block/gpio This patch depends on PCR common code Add SOC_INTEL_COMMON_BLOCK_PCR to Kconfig Code changes to gpio_table in mainboard/google/reef/variants/baseboard/gpio.c is incomplete Change-Id: I3533526832e940d135625130b41286fe729963ba Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/google/reef/variants/baseboard/gpio.c M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/acpi/gpio.asl M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.h M src/soc/intel/apollolake/gpio.c M src/soc/intel/apollolake/include/soc/gpio.h D src/soc/intel/apollolake/include/soc/gpio_defs.h M src/soc/intel/apollolake/lpc_lib.c M src/soc/intel/apollolake/uart_early.c 10 files changed, 645 insertions(+), 1,066 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/19068/3 -- To view, visit https://review.coreboot.org/19068 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3533526832e940d135625130b41286fe729963ba Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2017