coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/cannonlake: Fix UART2 serial log broken issue
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22862 ) Change subject: soc/intel/cannonlake: Fix UART2 serial log broken issue ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64531/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19321/ : SUCCESS -- To view, visit https://review.coreboot.org/22862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f9df5e8d6490090ed65b06bdd0b40f824d36a8a Gerrit-Change-Number: 22862 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 14 Dec 2017 18:12:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/gitconfig: Make gitconfig a bash script
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22857 ) Change subject: util/gitconfig: Make gitconfig a bash script ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19319/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64529/ : SUCCESS -- To view, visit https://review.coreboot.org/22857 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bc8cf688a3ad211b57c8ca0e6b1e86c82dc6a37 Gerrit-Change-Number: 22857 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 17:56:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/glkrvp: Enable Touchpad
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22627 ) Change subject: mb/glkrvp: Enable Touchpad ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19318/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64528/ : SUCCESS -- To view, visit https://review.coreboot.org/22627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Gerrit-Change-Number: 22627 Gerrit-PatchSet: 3 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 17:53:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/glkrvp: Enable Touchpad
by Shaunak Saha (Code Review) 14 Dec '17

14 Dec '17

Shaunak Saha has uploaded a new patch set (#3). ( https://review.coreboot.org/22627 ) Change subject: mb/glkrvp: Enable Touchpad ...................................................................... mb/glkrvp: Enable Touchpad This patch enables the APLS touchpad in glkrvp platform. TEST= Boot and test touchpad works. Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb 3 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22627/3 -- To view, visit https://review.coreboot.org/22627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Gerrit-Change-Number: 22627 Gerrit-PatchSet: 3 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/stoneyridge/bootblock/bootblock.c: Fix unused value
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22873 ) Change subject: soc/amd/stoneyridge/bootblock/bootblock.c: Fix unused value ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19317/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64527/ : SUCCESS -- To view, visit https://review.coreboot.org/22873 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a1eae52722606a9e871e26faa7927e207102ae8 Gerrit-Change-Number: 22873 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 17:14:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge/bootblock/bootblock.c: Fix unused value
by Richard Spiegel (Code Review) 14 Dec '17

14 Dec '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22873 Change subject: soc/amd/stoneyridge/bootblock/bootblock.c: Fix unused value ...................................................................... soc/amd/stoneyridge/bootblock/bootblock.c: Fix unused value In function load_smu_fw1(), variable base receives one value and is immediately overwritten. Remove the first line, as it's useless. This fixes CID 1383612 BUG=b:70620140 TEST=Build kahlee and boot. Change-Id: I1a1eae52722606a9e871e26faa7927e207102ae8 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/stoneyridge/bootblock/bootblock.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/22873/1 diff --git a/src/soc/amd/stoneyridge/bootblock/bootblock.c b/src/soc/amd/stoneyridge/bootblock/bootblock.c index 030c990..f70b6d9 100644 --- a/src/soc/amd/stoneyridge/bootblock/bootblock.c +++ b/src/soc/amd/stoneyridge/bootblock/bootblock.c @@ -91,7 +91,6 @@ u32 base, limit; /* Open a posted hole from 0x80000000 : 0xfed00000-1 */ - base = 0x80000000; base = (0x80000000 >> 8) | MMIO_WE | MMIO_RE; limit = (ALIGN_DOWN(HPET_BASE_ADDRESS - 1, 64 * KiB) >> 8); pci_write_config32(SOC_ADDR_DEV, D18F1_MMIO_LIMIT0_LO, limit); -- To view, visit https://review.coreboot.org/22873 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a1eae52722606a9e871e26faa7927e207102ae8 Gerrit-Change-Number: 22873 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: security/tpm: Add TPM measurement code
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22867 ) Change subject: security/tpm: Add TPM measurement code ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19315/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64525/ : SUCCESS -- To view, visit https://review.coreboot.org/22867 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 16:34:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22872 ) Change subject: security/crypto: Add crypto primitives for hashing data ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19316/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64526/ : SUCCESS -- To view, visit https://review.coreboot.org/22872 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 16:22:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by build bot (Jenkins) (Code Review) 14 Dec '17

14 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22872 ) Change subject: security/crypto: Add crypto primitives for hashing data ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64524/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19314/ : SUCCESS -- To view, visit https://review.coreboot.org/22872 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Dec 2017 15:54:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Add TPM measurement code
by Philipp Deppenwiese (Code Review) 14 Dec '17

14 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22867 to look at the new patch set (#4). Change subject: security/tpm: Add TPM measurement code ...................................................................... security/tpm: Add TPM measurement code * Adapt TSS hash_complete function * Add TCPA ACPI log functionality in TSS * Add TSPI functions for measuring and hashing data * Fix small coding style issues Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/security/tpm/tspi.h M src/security/tpm/tspi/tspi.c M src/security/tpm/tss.h M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-1.2/tss_structures.h M src/security/tpm/tss/tcg-2.0/tss.c 6 files changed, 197 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/22867/4 -- To view, visit https://review.coreboot.org/22867 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017