coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix SATA configs again
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22918 ) Change subject: mb/google/poppy/variants/nami: Fix SATA configs again ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19486/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64704/ : SUCCESS -- To view, visit https://review.coreboot.org/22918 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied6adabdc1d2458972bde628616a198cd41f9f3e Gerrit-Change-Number: 22918 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 11:39:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_F3 as NC
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22917 ) Change subject: mb/google/poppy: Configure GPP_F3 as NC ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19485/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64705/ : SUCCESS -- To view, visit https://review.coreboot.org/22917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Gerrit-Change-Number: 22917 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 11:37:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22916 ) Change subject: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19484/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64703/ : SUCCESS -- To view, visit https://review.coreboot.org/22916 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa181322011a4b8947ecd0fa44dcf790b0d8f657 Gerrit-Change-Number: 22916 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 11:34:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22916 ) Change subject: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64701/ : ABORTED -- To view, visit https://review.coreboot.org/22916 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa181322011a4b8947ecd0fa44dcf790b0d8f657 Gerrit-Change-Number: 22916 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 11:25:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_F3 as NC
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22917 ) Change subject: mb/google/poppy: Configure GPP_F3 as NC ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64702/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19483/ : SUCCESS -- To view, visit https://review.coreboot.org/22917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Gerrit-Change-Number: 22917 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 11:25:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix SATA configs again
by Furquan Shaikh (Code Review) 17 Dec '17

17 Dec '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22918 Change subject: mb/google/poppy/variants/nami: Fix SATA configs again ...................................................................... mb/google/poppy/variants/nami: Fix SATA configs again This change really fixes the SataMode to select non-RAID mode and enables SATA which was incorrectly disabled in a71276b (mb/google/poppy/variants/nami: Fix SataMode configuration in devicetree). BUG=b:70160119 Change-Id: Ied6adabdc1d2458972bde628616a198cd41f9f3e Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/22918/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 08bdda7..4c50799 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -27,9 +27,9 @@ # FSP Configuration register "ProbelessTrace" = "0" register "EnableLan" = "0" - register "EnableSata" = "0" + register "EnableSata" = "1" register "SataSalpSupport" = "1" - register "SataMode" = "1" + register "SataMode" = "0" register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[1]" = "1" register "EnableAzalia" = "1" -- To view, visit https://review.coreboot.org/22918 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ied6adabdc1d2458972bde628616a198cd41f9f3e Gerrit-Change-Number: 22918 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP
by Furquan Shaikh (Code Review) 17 Dec '17

17 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22916 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP ...................................................................... mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP Nami uses DEVSLP1 and not DEVSLP0. This change updates the GPIO configuration for DEVSLP to match the latest version of schematics. BUG=b:70160119 Change-Id: Ifa181322011a4b8947ecd0fa44dcf790b0d8f657 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/nami/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/22916/2 -- To view, visit https://review.coreboot.org/22916 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifa181322011a4b8947ecd0fa44dcf790b0d8f657 Gerrit-Change-Number: 22916 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_F3 as NC
by Furquan Shaikh (Code Review) 17 Dec '17

17 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22917 to look at the new patch set (#2). Change subject: mb/google/poppy: Configure GPP_F3 as NC ...................................................................... mb/google/poppy: Configure GPP_F3 as NC GPP_F3 is not connected on poppy or any of its variants. This change configures GPP_F3 as NC on poppy and all the variants. BUG=b:70160119 Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/baseboard/gpio.c M src/mainboard/google/poppy/variants/nami/gpio.c M src/mainboard/google/poppy/variants/nautilus/gpio.c M src/mainboard/google/poppy/variants/soraka/gpio.c 4 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/22917/2 -- To view, visit https://review.coreboot.org/22917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Gerrit-Change-Number: 22917 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_F3 as NC
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22917 ) Change subject: mb/google/poppy: Configure GPP_F3 as NC ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19482/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64700/ : SUCCESS -- To view, visit https://review.coreboot.org/22917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Gerrit-Change-Number: 22917 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 11:09:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_F3 as NC
by Furquan Shaikh (Code Review) 17 Dec '17

17 Dec '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22917 Change subject: mb/google/poppy: Configure GPP_F3 as NC ...................................................................... mb/google/poppy: Configure GPP_F3 as NC GPP_F3 is not connected on poppy or any of its variants. This change configures GPP_F3 as NC on poppy and all the variants. BUG=b:70160119 Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/baseboard/gpio.c M src/mainboard/google/poppy/variants/nami/gpio.c M src/mainboard/google/poppy/variants/nautilus/gpio.c M src/mainboard/google/poppy/variants/soraka/gpio.c 4 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/22917/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c index 1689fc2..237f391 100644 --- a/src/mainboard/google/poppy/variants/baseboard/gpio.c +++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c @@ -265,8 +265,8 @@ PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP), /* F2 : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */ PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP), - /* F3 : I2S2_RXD */ - PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP), + /* F3 : I2S2_RXD ==> NC */ + PAD_CFG_NC(GPP_F3), /* F4 : I2C2_SDA ==> PCH_I2C2_CAM_PMIC_1V8_SDA */ PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1), /* F5 : I2C2_SCL ==> PCH_I2C2_CAM_PMIC_1V8_SCL */ diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index eaafe04..6e13de8 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -265,8 +265,8 @@ PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP), /* F2 : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */ PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP), - /* F3 : I2S2_RXD */ - PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP), + /* F3 : I2S2_RXD ==> NC */ + PAD_CFG_NC(GPP_F3), /* F4 : I2C2_SDA ==> I2C_2_SDA */ PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1), /* F5 : I2C2_SCL ==> I2C_2_SCL */ diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c index d1dc18a..ca05ae9 100644 --- a/src/mainboard/google/poppy/variants/nautilus/gpio.c +++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c @@ -265,8 +265,8 @@ PAD_CFG_GPI(GPP_F1, NONE, DEEP), /* F2 : I2S2_TXD ==> CHP1_I2S2_PCH_TX_SPKR_RX_R */ PAD_CFG_GPI(GPP_F2, NONE, DEEP), - /* F3 : I2S2_RXD */ - PAD_CFG_GPI(GPP_F3, NONE, DEEP), + /* F3 : I2S2_RXD ==> NC */ + PAD_CFG_NC(GPP_F3), /* F4 : I2C2_SDA ==> CHP1_I2C2_CAM_PMIC_SDA */ PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1), /* F5 : I2C2_SCL ==> CHP1_I2C2_CAM_PMIC_SCL */ diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c index e172712..50bac4b 100644 --- a/src/mainboard/google/poppy/variants/soraka/gpio.c +++ b/src/mainboard/google/poppy/variants/soraka/gpio.c @@ -265,8 +265,8 @@ PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP), /* F2 : I2S2_TXD ==> I2S2_PCH_TX_SPKR_RX_R */ PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP), - /* F3 : I2S2_RXD */ - PAD_CFG_GPI_GPIO_DRIVER(GPP_F3, NONE, DEEP), + /* F3 : I2S2_RXD ==> NC */ + PAD_CFG_NC(GPP_F3), /* F4 : I2C2_SDA ==> PCH_I2C2_CAM_PMIC_1V8_SDA */ PAD_CFG_NF_1V8(GPP_F4, NONE, DEEP, NF1), /* F5 : I2C2_SCL ==> PCH_I2C2_CAM_PMIC_1V8_SCL */ -- To view, visit https://review.coreboot.org/22917 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I303276ab9546d56c846755fa3a6142978f6b8c92 Gerrit-Change-Number: 22917 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017