coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: mainboard/ms7721: Fix HWM/Superio settings
by Renze Nicolai (Code Review) 18 Dec '17

18 Dec '17

Renze Nicolai has uploaded this change for review. ( https://review.coreboot.org/22922 Change subject: mainboard/ms7721: Fix HWM/Superio settings ...................................................................... mainboard/ms7721: Fix HWM/Superio settings This patch allows the temperature sensors to function. Change-Id: I6491171eacc0c9848ba86ba7a62ec440226aae36 Signed-off-by: Renze Nicolai <renze(a)rnplus.nl> --- M src/mainboard/msi/ms7721/devicetree.cb M src/superio/fintek/f71869ad/chip.h M src/superio/fintek/f71869ad/f71869ad_hwm.c 3 files changed, 19 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/22922/1 diff --git a/src/mainboard/msi/ms7721/devicetree.cb b/src/mainboard/msi/ms7721/devicetree.cb index d46eb84..9b76149 100644 --- a/src/mainboard/msi/ms7721/devicetree.cb +++ b/src/mainboard/msi/ms7721/devicetree.cb @@ -68,14 +68,16 @@ # HWM configuration registers register "hwm_smbus_address" = "0x98" register "hwm_smbus_control_reg" = "0x02" - register "hwm_fan_type_sel_reg" = "0x00" + register "hwm_fan_type_sel_reg" = "0x10" register "hwm_fan1_temp_adj_rate_reg" = "0x33" - register "hwm_fan_mode_sel_reg" = "0x07" + register "hwm_fan_mode_sel_reg" = "0x15" register "hwm_fan1_idx_rpm_mode" = "0x0e" register "hwm_fan1_seg1_speed_count" = "0xff" register "hwm_fan1_seg2_speed_count" = "0x0e" register "hwm_fan1_seg3_speed_count" = "0x07" register "hwm_fan1_temp_map_sel" = "0x8c" + register "hwm_temp_sensor_type" = "0x08" + device pnp 4e.00 off end device pnp 4e.01 on # COM1 io 0x60 = 0x3f8 @@ -92,7 +94,7 @@ irq 0xf0 = 0x44 # PRT Mode Select Register end device pnp 4e.04 on # Hardware Monitor - io 0x60 = 0x600 + io 0x60 = 0x225 irq 0x70 = 0 end device pnp 4e.05 on # KBC @@ -141,9 +143,16 @@ #irq 0x83 = 0x00 # GPIO7 drive enable end - device pnp 4e.07 on end # WDT - device pnp 4e.08 off end # CIR - device pnp 4e.0a on end # PME + device pnp 4e.07 on end # WDT + device pnp 4e.08 off end # CIR + device pnp 4e.0a on # PME + irq 0xe0 = 0x80 + irq 0xe1 = 0xc0 + irq 0xe2 = 0x0c + irq 0xe8 = 0x00 #Wakeup Enable [RI2, -, RI1, RING, GP, TIMEOUT, MOUSE, KB] + irq 0xf8 = 0x1c #Led VCC Mode Select + irq 0xf9 = 0x15 #Led VSB Mode Select + end end # f71869ad end #device pci 14.3 # LPC device pci 14.4 on end # PCI 0x4384 (PCI slot on board) diff --git a/src/superio/fintek/f71869ad/chip.h b/src/superio/fintek/f71869ad/chip.h index 4e4323e..7424e9a 100644 --- a/src/superio/fintek/f71869ad/chip.h +++ b/src/superio/fintek/f71869ad/chip.h @@ -37,6 +37,7 @@ uint8_t hwm_fan1_seg2_speed_count; uint8_t hwm_fan1_seg3_speed_count; uint8_t hwm_fan1_temp_map_sel; + uint8_t hwm_temp_sensor_type; }; #endif /* SUPERIO_FINTEK_F71869AD_CHIP_H */ diff --git a/src/superio/fintek/f71869ad/f71869ad_hwm.c b/src/superio/fintek/f71869ad/f71869ad_hwm.c index d253e5f..e7d6483 100644 --- a/src/superio/fintek/f71869ad/f71869ad_hwm.c +++ b/src/superio/fintek/f71869ad/f71869ad_hwm.c @@ -50,6 +50,7 @@ #define HWM_FAN1_SEG2_SPEED_COUNT 0xAB #define HWM_FAN1_SEG3_SPEED_COUNT 0xAC #define HWM_FAN1_TEMP_MAP_SEL 0xAF +#define HWM_TEMP_SENSOR_TYPE 0x6B /* note: multifunc registers need to be tweaked before here */ void f71869ad_hwm_init(struct device *dev) @@ -97,6 +98,8 @@ pnp_write_index(port, HWM_FAN1_SEG1_SPEED_COUNT, conf->hwm_fan1_seg1_speed_count); pnp_write_index(port, HWM_FAN1_SEG2_SPEED_COUNT, conf->hwm_fan1_seg2_speed_count); pnp_write_index(port, HWM_FAN1_SEG3_SPEED_COUNT, conf->hwm_fan1_seg3_speed_count); + /* Temperature sensor type */ + pnp_write_index(port, HWM_TEMP_SENSOR_TYPE, conf->hwm_temp_sensor_type); pnp_exit_conf_mode(dev); } -- To view, visit https://review.coreboot.org/22922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6491171eacc0c9848ba86ba7a62ec440226aae36 Gerrit-Change-Number: 22922 Gerrit-PatchSet: 1 Gerrit-Owner: Renze Nicolai <renze(a)rnplus.nl>

1 0

Change in coreboot[master]: drivers/mrc_cache: Add missing include file to mrc_cache.h
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22921 ) Change subject: drivers/mrc_cache: Add missing include file to mrc_cache.h ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19491/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64710/ : SUCCESS -- To view, visit https://review.coreboot.org/22921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I940beac45eb43e804bc84fead7d5337a1c4e2ac1 Gerrit-Change-Number: 22921 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 21:36:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/mrc_cache: Add missing include file to mrc_cache.h
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22921 ) Change subject: drivers/mrc_cache: Add missing include file to mrc_cache.h ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64709/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19490/ : SUCCESS -- To view, visit https://review.coreboot.org/22921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I940beac45eb43e804bc84fead7d5337a1c4e2ac1 Gerrit-Change-Number: 22921 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 21:26:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/mrc_cache: Add missing include file to mrc_cache.h
by Marshall Dawson (Code Review) 17 Dec '17

17 Dec '17

Marshall Dawson has uploaded a new patch set (#2). ( https://review.coreboot.org/22921 ) Change subject: drivers/mrc_cache: Add missing include file to mrc_cache.h ...................................................................... drivers/mrc_cache: Add missing include file to mrc_cache.h Add region.h for use by the struct region_device * in the mrc_cache_get_current() prototype. BUG=b:69614064 Change-Id: I940beac45eb43e804bc84fead7d5337a1c4e2ac1 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/include/mrc_cache.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/22921/2 -- To view, visit https://review.coreboot.org/22921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I940beac45eb43e804bc84fead7d5337a1c4e2ac1 Gerrit-Change-Number: 22921 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: drivers/mrc_cache: Add missing include file to mrc_cache.h
by Marshall Dawson (Code Review) 17 Dec '17

17 Dec '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/22921 Change subject: drivers/mrc_cache: Add missing include file to mrc_cache.h ...................................................................... drivers/mrc_cache: Add missing include file to mrc_cache.h Add region.h for use by the struct region_device * in the mrc_cache_get_current() prototype. BUG=b:69614064 Change-Id: I940beac45eb43e804bc84fead7d5337a1c4e2ac1 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/include/mrc_cache.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/22921/1 diff --git a/src/include/mrc_cache.h b/src/include/mrc_cache.h index 4511fc3..d719e35 100644 --- a/src/include/mrc_cache.h +++ b/src/include/mrc_cache.h @@ -18,6 +18,7 @@ #include <stddef.h> #include <stdint.h> +#include <region.h> enum { MRC_TRAINING_DATA, -- To view, visit https://review.coreboot.org/22921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I940beac45eb43e804bc84fead7d5337a1c4e2ac1 Gerrit-Change-Number: 22921 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22919 ) Change subject: mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19489/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64708/ : SUCCESS -- To view, visit https://review.coreboot.org/22919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eef971d49508bcd94d5d1cf2b70395b7cd80b1c Gerrit-Change-Number: 22919 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 20:54:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_B8 for WLAN_PE_RST
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22920 ) Change subject: mb/google/poppy: Configure GPP_B8 for WLAN_PE_RST ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19488/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64707/ : SUCCESS -- To view, visit https://review.coreboot.org/22920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a88e67d5a22f8a39427c95821ffee4f2fd717fa Gerrit-Change-Number: 22920 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 17:51:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Configure GPP_B8 for WLAN_PE_RST
by Furquan Shaikh (Code Review) 17 Dec '17

17 Dec '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22920 Change subject: mb/google/poppy: Configure GPP_B8 for WLAN_PE_RST ...................................................................... mb/google/poppy: Configure GPP_B8 for WLAN_PE_RST BUG=b:62726961 Change-Id: I5a88e67d5a22f8a39427c95821ffee4f2fd717fa Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/22920/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c index 237f391..a0dbbee 100644 --- a/src/mainboard/google/poppy/variants/baseboard/gpio.c +++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c @@ -78,8 +78,8 @@ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* B7 : SRCCLKREQ2# ==> WWAN_PCIE_CLKREQ_L */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), - /* B8 : SRCCLKREQ3# ==> NC */ - PAD_CFG_NC(GPP_B8), + /* B8 : SRCCLKREQ3# ==> WLAN_PE_RST */ + PAD_CFG_GPO(GPP_B8, 0, RSMRST), /* B9 : SRCCLKREQ4# ==> NC */ PAD_CFG_NC(GPP_B9), /* B10 : SRCCLKREQ5# ==> NC */ -- To view, visit https://review.coreboot.org/22920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5a88e67d5a22f8a39427c95821ffee4f2fd717fa Gerrit-Change-Number: 22920 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: [TOTEST]mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID
by build bot (Jenkins) (Code Review) 17 Dec '17

17 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22919 ) Change subject: [TOTEST]mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19487/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64706/ : SUCCESS -- To view, visit https://review.coreboot.org/22919 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eef971d49508bcd94d5d1cf2b70395b7cd80b1c Gerrit-Change-Number: 22919 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Dec 2017 12:46:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [TOTEST]mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID
by Arthur Heymans (Code Review) 17 Dec '17

17 Dec '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/22919 Change subject: [TOTEST]mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID ...................................................................... [TOTEST]mb/lenovo/x200/dock.asl: Issue DOCK ACPI events based on Dock ID Some Dock events only need to happen based on the Dock Id (which functions as a presence detect GPIO). Inspired by vendor bios DSDT. This fixes ACPI undock events on every power unplug even when undock. Change-Id: I1eef971d49508bcd94d5d1cf2b70395b7cd80b1c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/x200/acpi/dock.asl 1 file changed, 37 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/22919/1 diff --git a/src/mainboard/lenovo/x200/acpi/dock.asl b/src/mainboard/lenovo/x200/acpi/dock.asl index 0c7c9ab..197f298 100644 --- a/src/mainboard/lenovo/x200/acpi/dock.asl +++ b/src/mainboard/lenovo/x200/acpi/dock.asl @@ -41,6 +41,24 @@ { Return (\_SB.PCI0.LPCB.EC.DKR1) } + + Name (G_ID, 0xFFFFFFFF) + /* Returns 0x7 (dock present) or 0x3 (dock absent) */ + Method(GGID, 0, NotSerialized) + { + Store(G_ID, Local0) + if (LEqual(Local0, 0xFFFFFFFF)) + { + Store(Or (Or (GP02, ShiftLeft(GP03, 1)), + ShiftLeft(GP04, 2)), Local0) + If (LEqual(Local0, 0x00)) + { + Store(0x03, Local0) + } + Store(Local0, G_ID) + } + return (Local0) + } } } @@ -63,7 +81,11 @@ Method(_Q50, 0, NotSerialized) { - Notify(\_SB.DOCK, 3) + Store(\_SB.DOCK.GGID (), Local0) + if (LNotEqual(Local0, 0x07)) + { + Notify(\_SB.DOCK, 3) + } } Method(_Q58, 0, NotSerialized) @@ -73,6 +95,19 @@ Method(_Q5A, 0, NotSerialized) { - Notify(\_SB.DOCK, 3) + Store(\_SB.DOCK.GGID (), Local0) + if (LEqual(Local0, 0x07)) + { + Notify(\_SB.DOCK, 3) + } + if (LEqual(Local0, 0x03)) + { + Sleep(0x64) + Store(DKR1, Local1) + if (LEqual(Local1, 1)) + { + Notify(\_SB.DOCK, 0) + } + } } } -- To view, visit https://review.coreboot.org/22919 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1eef971d49508bcd94d5d1cf2b70395b7cd80b1c Gerrit-Change-Number: 22919 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017