coreboot-gerrit October 2017

coreboot-gerrit@coreboot.org

1 participants
1771 discussions

Change in coreboot[master]: buildgcc: Update binutils to 2.29.1
by build bot (Jenkins) (Code Review) 02 Oct '17

02 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20806 ) Change subject: buildgcc: Update binutils to 2.29.1 ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61404/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/372/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16541/ : SUCCESS -- To view, visit https://review.coreboot.org/20806 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25134dbadf07a2f0cb356c8ac8f2c612a957d176 Gerrit-Change-Number: 20806 Gerrit-PatchSet: 7 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 09:56:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [TEST]drivers/net/r8168: Add customized nic led function
by Arthur Heymans (Code Review) 02 Oct '17

02 Oct '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21839 ) Change subject: [TEST]drivers/net/r8168: Add customized nic led function ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c File src/drivers/net/r8168.c: https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224 PS2, Line 224: #if better avoid preprocessor and just do "if (!IS_ENABLED(...)) return;" https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224 PS2, Line 224: defined IS_ENABED https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@231 PS2, Line 231: CONFIG_RTL8168_CUSTOMIZED_LED please use devicetree parameters instead of Kconfig. -- To view, visit https://review.coreboot.org/21839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Gerrit-Change-Number: 21839 Gerrit-PatchSet: 2 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: T.H. Lin <T.H_Lin(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 08:25:59 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: [TEST]drivers/net/r8168: Add customized nic led function
by build bot (Jenkins) (Code Review) 02 Oct '17

02 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21839 ) Change subject: [TEST]drivers/net/r8168: Add customized nic led function ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61403/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16539/ : SUCCESS -- To view, visit https://review.coreboot.org/21839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Gerrit-Change-Number: 21839 Gerrit-PatchSet: 2 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: T.H. Lin <T.H_Lin(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 05:44:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [TEST]drivers/net/r8168: Add customized nic led function
by Wisley Chen (Code Review) 02 Oct '17

02 Oct '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21839 to look at the new patch set (#2). Change subject: [TEST]drivers/net/r8168: Add customized nic led function ...................................................................... [TEST]drivers/net/r8168: Add customized nic led function The nic led behavior can be customized by different LED pin configuration. Applied the patch, we can add RTL8168_CUSTOMIZED_LED two bytes hex value by different board to cutomize led behavior. Refer to spec, bit[3:0] is for PINLED0, bit[7:4] is for PINLED1, bit[11:8] is for PINLED2, and bit[15:12] is for feature control. TEST= add RTL8168_CUSTOMIZED_LED in mainboard/fizz/Kconfig, build/boot on fizz, and check nic led behavior change. Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/drivers/net/r8168.c 1 file changed, 30 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/21839/2 -- To view, visit https://review.coreboot.org/21839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Gerrit-Change-Number: 21839 Gerrit-PatchSet: 2 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [TEST]drivers/net/r8168: Add customized nic led function
by build bot (Jenkins) (Code Review) 02 Oct '17

02 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21839 ) Change subject: [TEST]drivers/net/r8168: Add customized nic led function ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61402/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16538/ : SUCCESS -- To view, visit https://review.coreboot.org/21839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Gerrit-Change-Number: 21839 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 05:17:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [TEST]drivers/net/r8168: Add customized nic led function
by Wisley Chen (Code Review) 02 Oct '17

02 Oct '17

Wisley Chen has uploaded this change for review. ( https://review.coreboot.org/21839 Change subject: [TEST]drivers/net/r8168: Add customized nic led function ...................................................................... [TEST]drivers/net/r8168: Add customized nic led function The nic led behavior can be customized by different LED pin configuration. Applied the patch, we can add RTL8168_CUSTOMIZED_LED two bytes hex value by different board to cutomize led behavior. Refer to spec, bit[3:0] is for PINLED0, bit[7:4] is for PINLED1, bit[11:8] is for PINLED2, and bit[15:12] is for feature control. TEST= add RTL8168_CUSTOMIZED_LED in mainboard/fizz/Kconfig, build/boot on fizz, and check nic led behavior change. Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/drivers/net/r8168.c 1 file changed, 30 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/21839/1 diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c index 3727ccd..acbb4d3 100644 --- a/src/drivers/net/r8168.c +++ b/src/drivers/net/r8168.c @@ -40,6 +40,7 @@ #define CFG_9346 0x50 #define CFG_9346_LOCK 0x00 #define CFG_9346_UNLOCK 0xc0 +#define CFG_LED 0x18 /** * search: Find first instance of string in a given region @@ -211,6 +212,32 @@ printk(BIOS_DEBUG, "done\n"); } +/** + * The customizable LED operation is via IO register offset 0x18~0x19 + * Bit[3:0]: LED Select for PINLED0 + * Bit[7:4]: LED Select for PINLED1 + * Bit[11:8]: LED Select for PINLED2 + * Bit[15:12]: LED Feature Control + */ +static void program_led(struct device *dev, u16 io_base) +{ +#if defined(CONFIG_RTL8168_CUSTOMIZED_LED) + printk(BIOS_DEBUG, "r8168: Programming led..."); + + /* Disable register protection */ + outb(CFG_9346_UNLOCK, io_base + CFG_9346); + + /* Set LED Behavior */ + printk(BIOS_INFO, "r8168 customized led value=0x%04x\n", CONFIG_RTL8168_CUSTOMIZED_LED); + outl(CONFIG_RTL8168_CUSTOMIZED_LED, io_base + CFG_LED); + inl(io_base + CFG_LED); + + /* Lock config regs */ + outb(CFG_9346_LOCK, io_base + CFG_9346); + printk(BIOS_DEBUG, "done\n"); +#endif +} + static void r8168_init(struct device *dev) { /* Get the resource of the NIC mmio */ @@ -223,9 +250,10 @@ /* Program MAC address based on CBFS "macaddress" containing * a string AA:BB:CC:DD:EE:FF */ - if (io_base) + if (io_base) { program_mac_address(dev, io_base); - else + program_led(dev, io_base); + } else printk(BIOS_ERR, "r8168: Error cant find MMIO resource\n"); } -- To view, visit https://review.coreboot.org/21839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 Gerrit-Change-Number: 21839 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com>

1 0

Change in coreboot[master]: nb/intel/sandybridge: Refactor dram_dimm_mapping()
by Arthur Heymans (Code Review) 01 Oct '17

01 Oct '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21823 ) Change subject: nb/intel/sandybridge: Refactor dram_dimm_mapping() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21823 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I124a6bc338c2589fab66ca91bf53139b4413d10b Gerrit-Change-Number: 21823 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 16:33:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge: Refactor dram_dimm_mapping()
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21823 ) Change subject: nb/intel/sandybridge: Refactor dram_dimm_mapping() ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61401/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16537/ : SUCCESS -- To view, visit https://review.coreboot.org/21823 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I124a6bc338c2589fab66ca91bf53139b4413d10b Gerrit-Change-Number: 21823 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 16:25:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge: Refactor dram_dimm_mapping()
by Nico Huber (Code Review) 01 Oct '17

01 Oct '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21823 Change subject: nb/intel/sandybridge: Refactor dram_dimm_mapping() ...................................................................... nb/intel/sandybridge: Refactor dram_dimm_mapping() Remove no-op statements and code-rephrasing comments, apply some cosmetic changes to improve readability. Change-Id: I124a6bc338c2589fab66ca91bf53139b4413d10b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 20 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/21823/1 diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 3e69f4d..b734036 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -295,49 +295,39 @@ void dram_dimm_mapping(ramctr_timing *ctrl) { - u32 reg, val32; int channel; dimm_info *info = &ctrl->info; FOR_ALL_CHANNELS { - dimm_attr *dimmA = 0; - dimm_attr *dimmB = 0; - reg = 0; - val32 = 0; + dimm_attr *dimmA, *dimmB; + u32 reg = 0; + if (info->dimm[channel][0].size_mb >= info->dimm[channel][1].size_mb) { - // dimm 0 is bigger, set it to dimmA dimmA = &info->dimm[channel][0]; dimmB = &info->dimm[channel][1]; - reg |= (0 << 16); + reg |= 0 << 16; } else { - // dimm 1 is bigger, set it to dimmA dimmA = &info->dimm[channel][1]; dimmB = &info->dimm[channel][0]; - reg |= (1 << 16); + reg |= 1 << 16; } - // dimmA - if (dimmA && (dimmA->ranks > 0)) { - val32 = dimmA->size_mb / 256; - reg = (reg & ~0xff) | val32; - val32 = dimmA->ranks - 1; - reg = (reg & ~0x20000) | (val32 << 17); - val32 = (dimmA->width / 8) - 1; - reg = (reg & ~0x80000) | (val32 << 19); - } - // dimmB - if (dimmB && (dimmB->ranks > 0)) { - val32 = dimmB->size_mb / 256; - reg = (reg & ~0xff00) | (val32 << 8); - val32 = dimmB->ranks - 1; - reg = (reg & ~0x40000) | (val32 << 18); - val32 = (dimmB->width / 8) - 1; - reg = (reg & ~0x100000) | (val32 << 20); - } - reg = (reg & ~0x200000) | (1 << 21); // rank interleave - reg = (reg & ~0x400000) | (1 << 22); // enhanced interleave - // Save MAD-DIMM register + if (dimmA && (dimmA->ranks > 0)) { + reg |= dimmA->size_mb / 256; + reg |= (dimmA->ranks - 1) << 17; + reg |= (dimmA->width / 8 - 1) << 19; + } + + if (dimmB && (dimmB->ranks > 0)) { + reg |= (dimmB->size_mb / 256) << 8; + reg |= (dimmB->ranks - 1) << 18; + reg |= (dimmB->width / 8 - 1) << 20; + } + + reg |= 1 << 21; /* rank interleave */ + reg |= 1 << 22; /* enhanced interleave */ + if ((dimmA && (dimmA->ranks > 0)) || (dimmB && (dimmB->ranks > 0))) { ctrl->mad_dimm[channel] = reg; -- To view, visit https://review.coreboot.org/21823 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I124a6bc338c2589fab66ca91bf53139b4413d10b Gerrit-Change-Number: 21823 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: nb/intel/x4x: Change memory layout to improve MTRR
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21634 ) Change subject: nb/intel/x4x: Change memory layout to improve MTRR ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61400/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16536/ : SUCCESS -- To view, visit https://review.coreboot.org/21634 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b5ea04d9b7d5494a30aa7156d8c17170e77b8ad Gerrit-Change-Number: 21634 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 13:58:59 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2017