Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12720
-gerrit
commit 92b6eeb0ac3427b38b4fdfa6effe5d4199da756c
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Mon Dec 14 16:36:45 2015 -0800
abuild: Use 12 lines of context for errors
The current default of 6 lines leaves us with no context
about the actual error:
*** ERROR: 3 warnings encountered, and warnings are errors.
coreboot-gerrit/util/kconfig/Makefile:38: recipe for target 'oldconfig' failed
make[1]: *** [oldconfig] Error 1
make[1]: Leaving directory 'coreboot-gerrit'
Change-Id: I67e7d740e7b3b1c66005dc1bf50557a20bc15428
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
util/abuild/abuild | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/abuild/abuild b/util/abuild/abuild
index cddcb57..ebd1842 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -40,7 +40,7 @@ if [ -d "$XGCCPATH" ] && [[ ":$PATH:" != *":$XGCCPATH:"* ]]; then
fi
# Lines of error context to be printed in FAILURE case
-CONTEXT=6
+CONTEXT=12
# Configure-only mode
configureonly=0
@@ -223,7 +223,6 @@ function create_config
if [ "$quiet" == "false" ]; then printf " $MAINBOARD config created.\n"; fi
return 0
else
- # Does this ever happen?
if [ "$quiet" == "false" ]; then printf "$MAINBOARD config creation FAILED!\nLog excerpt:\n"; fi
tail -n $CONTEXT $build_dir/config.log 2> /dev/null || tail -$CONTEXT $build_dir/config.log
return 1
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/10012
-gerrit
commit 92d6d7ec297a164632c01b8debd868f1916ecaba
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Mon Apr 27 13:40:16 2015 -0700
cpu/x86: Kconfig cleanups
Sort some Kconfig options
Change-Id: I25ea327ed151e18ccb5d13626d44925d2a253d08
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
src/cpu/x86/Kconfig | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig
index 94225a3..d8f338d 100644
--- a/src/cpu/x86/Kconfig
+++ b/src/cpu/x86/Kconfig
@@ -1,7 +1,16 @@
+# TODO These two options look too similar
config PARALLEL_CPU_INIT
bool
default n
+config PARALLEL_MP
+ def_bool n
+ help
+ This option uses common MP infrastructure for bringing up APs
+ in parallel. It additionally provides a more flexible mechanism
+ for sequencing the steps of bringing up the APs.
+
+
config UDELAY_IO
bool
default y if !UDELAY_LAPIC && !UDELAY_TSC && !UDELAY_TIMER2
@@ -39,11 +48,14 @@ config TSC_MONOTONIC_TIMER
help
Expose monotonic time using the TSC.
-config UDELAY_TIMER2
+# This option is used in code but never selected.
+config TSC_CALIBRATE_WITH_IO
bool
+ depends on UDELAY_TSC
default n
-config TSC_CALIBRATE_WITH_IO
+# This option is used in code but never selected.
+config UDELAY_TIMER2
bool
default n
@@ -121,13 +133,6 @@ config PLATFORM_USES_FSP1_0
Selected for Intel processors/platform combinations that use the
Intel Firmware Support Package (FSP) 1.0 for initialization.
-config PARALLEL_MP
- def_bool n
- help
- This option uses common MP infrastructure for bringing up APs
- in parallel. It additionally provides a more flexible mechanism
- for sequencing the steps of bringing up the APs.
-
config BACKUP_DEFAULT_SMM_REGION
def_bool n
help
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/10012
-gerrit
commit 7264c94b09a3992b5e09c47e5fcd1054cf7a1137
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Mon Apr 27 13:40:16 2015 -0700
cpu/x86: Kconfig cleanups
Sort some Kconfig options
Change-Id: I25ea327ed151e18ccb5d13626d44925d2a253d08
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
src/cpu/x86/Kconfig | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig
index 94225a3..d8f338d 100644
--- a/src/cpu/x86/Kconfig
+++ b/src/cpu/x86/Kconfig
@@ -1,7 +1,16 @@
+# TODO These two options look too similar
config PARALLEL_CPU_INIT
bool
default n
+config PARALLEL_MP
+ def_bool n
+ help
+ This option uses common MP infrastructure for bringing up APs
+ in parallel. It additionally provides a more flexible mechanism
+ for sequencing the steps of bringing up the APs.
+
+
config UDELAY_IO
bool
default y if !UDELAY_LAPIC && !UDELAY_TSC && !UDELAY_TIMER2
@@ -39,11 +48,14 @@ config TSC_MONOTONIC_TIMER
help
Expose monotonic time using the TSC.
-config UDELAY_TIMER2
+# This option is used in code but never selected.
+config TSC_CALIBRATE_WITH_IO
bool
+ depends on UDELAY_TSC
default n
-config TSC_CALIBRATE_WITH_IO
+# This option is used in code but never selected.
+config UDELAY_TIMER2
bool
default n
@@ -121,13 +133,6 @@ config PLATFORM_USES_FSP1_0
Selected for Intel processors/platform combinations that use the
Intel Firmware Support Package (FSP) 1.0 for initialization.
-config PARALLEL_MP
- def_bool n
- help
- This option uses common MP infrastructure for bringing up APs
- in parallel. It additionally provides a more flexible mechanism
- for sequencing the steps of bringing up the APs.
-
config BACKUP_DEFAULT_SMM_REGION
def_bool n
help
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13773
-gerrit
commit 0b871f477ab52eed2ef4fa2057e56f4e1be267c6
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Wed Feb 24 00:03:27 2016 +0100
Partly revert "lzma: Port size-checking ulzman() version to coreboot"
This partly reverts a25b5d257dbfbff808b19bf8c48565435e6bef9d.
Revert the change in `src/lib/lzmadecode.c` as it increases the boot
time to ramstage by 150 ms on the ASRock E350M1.
There seems to be some special case with the flash ROM access. Until
this has been figured out, revert the change.
Change-Id: Icc480c41cda77526256ba1761b29a24def48400e
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/lib/lzmadecode.c | 7 ++-----
src/lib/selfboot.c | 24 ++++--------------------
2 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/src/lib/lzmadecode.c b/src/lib/lzmadecode.c
index fbf1596..ada7226 100644
--- a/src/lib/lzmadecode.c
+++ b/src/lib/lzmadecode.c
@@ -29,12 +29,9 @@
#define kBitModelTotal (1 << kNumBitModelTotalBits)
#define kNumMoveBits 5
-/* Use 32-bit reads whenever possible to avoid bad flash performance. Fall back
- * to byte reads for last 4 bytes since RC_TEST returns an error when BufferLim
- * is *reached* (not surpassed!), meaning we can't allow that to happen while
- * there are still bytes to decode from the algorithm's point of view. */
+/* Use 32-bit reads whenever possible to avoid bad flash performance. */
#define RC_READ_BYTE (look_ahead_ptr < 4 ? look_ahead.raw[look_ahead_ptr++] \
- : ((((uintptr_t) Buffer & 3) || ((SizeT) (BufferLim - Buffer) <= 4)) ? (*Buffer++) \
+ : ((((uintptr_t) Buffer & 3) || ((SizeT) (BufferLim - Buffer) < 4)) ? (*Buffer++) \
: ((look_ahead.dw = *(UInt32 *)Buffer), (Buffer += 4), (look_ahead_ptr = 1), look_ahead.raw[0])))
#define RC_INIT2 Code = 0; Range = 0xFFFFFFFF; \
diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c
index 7d3e2dd..60cda6a 100644
--- a/src/lib/selfboot.c
+++ b/src/lib/selfboot.c
@@ -14,7 +14,6 @@
* GNU General Public License for more details.
*/
-#include <commonlib/compression.h>
#include <console/console.h>
#include <cpu/cpu.h>
#include <endian.h>
@@ -26,7 +25,6 @@
#include <lib.h>
#include <bootmem.h>
#include <program_loading.h>
-#include <timestamp.h>
static const unsigned long lb_start = (unsigned long)&_program;
static const unsigned long lb_end = (unsigned long)&_eprogram;
@@ -116,9 +114,6 @@ static int relocate_segment(unsigned long buffer, struct segment *seg)
if (!overlaps_coreboot(seg))
return 0;
- if (!arch_supports_bounce_buffer())
- die ("bounce buffer not supported");
-
start = seg->s_dstaddr;
middle = start + seg->s_filesz;
end = start + seg->s_memsz;
@@ -383,23 +378,12 @@ static int load_self_segments(
/* Copy data from the initial buffer */
if (ptr->s_filesz) {
unsigned char *middle, *end;
- size_t len = ptr->s_filesz;
- size_t memsz = ptr->s_memsz;
+ size_t len;
+ len = ptr->s_filesz;
switch(ptr->compression) {
case CBFS_COMPRESS_LZMA: {
printk(BIOS_DEBUG, "using LZMA\n");
- timestamp_add_now(TS_START_ULZMA);
- len = ulzman(src, len, dest, memsz);
- timestamp_add_now(TS_END_ULZMA);
- if (!len) /* Decompression Error. */
- return 0;
- break;
- }
- case CBFS_COMPRESS_LZ4: {
- printk(BIOS_DEBUG, "using LZ4\n");
- timestamp_add_now(TS_START_ULZ4F);
- len = ulz4fn(src, len, dest, memsz);
- timestamp_add_now(TS_END_ULZ4F);
+ len = ulzma(src, dest);
if (!len) /* Decompression Error. */
return 0;
break;
@@ -413,7 +397,7 @@ static int load_self_segments(
printk(BIOS_INFO, "CBFS: Unknown compression type %d\n", ptr->compression);
return -1;
}
- end = dest + memsz;
+ end = dest + ptr->s_memsz;
middle = dest + len;
printk(BIOS_SPEW, "[ 0x%08lx, %08lx, 0x%08lx) <- %08lx\n",
(unsigned long)dest,
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13773
-gerrit
commit e92208dee84b19e7bb018371314ce065fab09a64
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Wed Feb 24 00:03:27 2016 +0100
Partly revert "lzma: Port size-checking ulzman() version to coreboot"
This partly reverts a25b5d257dbfbff808b19bf8c48565435e6bef9d.
Revert the change in `src/lib/lzmadecode.c` as it increases the boot
time to ramstage by 150 ms on the ASRock E350M1.
There seems to be some special case with the flash ROM access. Until
this has been figured out, revert the change.
Change-Id: Icc480c41cda77526256ba1761b29a24def48400e
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/lib/lzmadecode.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/lib/lzmadecode.c b/src/lib/lzmadecode.c
index fbf1596..ada7226 100644
--- a/src/lib/lzmadecode.c
+++ b/src/lib/lzmadecode.c
@@ -29,12 +29,9 @@
#define kBitModelTotal (1 << kNumBitModelTotalBits)
#define kNumMoveBits 5
-/* Use 32-bit reads whenever possible to avoid bad flash performance. Fall back
- * to byte reads for last 4 bytes since RC_TEST returns an error when BufferLim
- * is *reached* (not surpassed!), meaning we can't allow that to happen while
- * there are still bytes to decode from the algorithm's point of view. */
+/* Use 32-bit reads whenever possible to avoid bad flash performance. */
#define RC_READ_BYTE (look_ahead_ptr < 4 ? look_ahead.raw[look_ahead_ptr++] \
- : ((((uintptr_t) Buffer & 3) || ((SizeT) (BufferLim - Buffer) <= 4)) ? (*Buffer++) \
+ : ((((uintptr_t) Buffer & 3) || ((SizeT) (BufferLim - Buffer) < 4)) ? (*Buffer++) \
: ((look_ahead.dw = *(UInt32 *)Buffer), (Buffer += 4), (look_ahead_ptr = 1), look_ahead.raw[0])))
#define RC_INIT2 Code = 0; Range = 0xFFFFFFFF; \