coreboot-gerrit November 2016

coreboot-gerrit@coreboot.org

1 participants
1666 discussions

New patch to review for coreboot: nb/x4x: Fix raminit unconditionally resetting
by Arthur Heymans 30 Nov '16

30 Nov '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17659 -gerrit commit 897a61ab55f7201da7d0046cbf2f019d81671de4 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Wed Nov 30 18:40:38 2016 +0100 nb/x4x: Fix raminit unconditionally resetting The raminit only succeeds when it starts from a cold boot. To achieve this it unconditionally did a cold reset. This patch uses the sticky scratchpad MCHBAR to issue a cold reset only when not started from a cold boot. It also adds a 2s delay before reset because some disk drives expect a warm reboot when the OS wants to reboot and therefore are not shut down properly / in time. If the drive is unexpectedly powered off which happens during a cold reset, it can cause data loss. Giving the drive 2 extra seconds can work around this issue. (A proper fix would be to fix the raminit such that it works on a hot reset) Change-Id: I6063dd6aed908558155d2523f35d7241ff1f4fde Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/northbridge/intel/x4x/raminit_ddr2.c | 11 +++++++++-- src/northbridge/intel/x4x/x4x.h | 2 +- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/northbridge/intel/x4x/raminit_ddr2.c b/src/northbridge/intel/x4x/raminit_ddr2.c index b3ee34a..bfc918e 100644 --- a/src/northbridge/intel/x4x/raminit_ddr2.c +++ b/src/northbridge/intel/x4x/raminit_ddr2.c @@ -259,9 +259,15 @@ static void checkreset_ddr2(struct sysinfo *s) u8 pmcon2; u8 reset = 0; + if ((MCHBAR16(SSKPD_MCHBAR) == 0xCAFE)) { + printk(BIOS_DEBUG, "Waiting for disks to timeout...\n"); + mdelay(2000); + reset = 1; + } + pmcon2 = pci_read_config8(PCI_DEV(0, 0x1f, 0), 0xa2); - if (!(pmcon2 & 0x80)) { - pmcon2 |= 0x80; + if (pmcon2 & 0x80) { + pmcon2 &= ~0x80; pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, pmcon2); reset = 1; @@ -2058,4 +2064,5 @@ void raminit_ddr2(struct sysinfo *s) MCHBAR32(0xa30) = MCHBAR32(0xa30) | (1 << 26); printk(BIOS_DEBUG, "Done ddr2\n"); + MCHBAR16(SSKPD_MCHBAR) = 0xCAFE; } diff --git a/src/northbridge/intel/x4x/x4x.h b/src/northbridge/intel/x4x/x4x.h index e4eb8dd..3f6baa4 100644 --- a/src/northbridge/intel/x4x/x4x.h +++ b/src/northbridge/intel/x4x/x4x.h @@ -97,7 +97,7 @@ #define CLKCFG_MEMCLK_MASK (7 << CLKCFG_MEMCLK_SHIFT) #define CLKCFG_UPDATE (1 << 12) -#define SSKPD_MCHBAR 0x0c1c +#define SSKPD_MCHBAR 0x0c20 #define SSKPD_CLK_SHIFT 0 #define SSKPD_CLK_MASK (7 << SSKPD_CLK_SHIFT)

1 0

New patch to review for coreboot: util/lint: add check for auto-included headers
by Martin Roth 30 Nov '16

30 Nov '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17658 -gerrit commit 4f6ddcc3e7f0a1829132e3ea2688a41a90521993 Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 30 10:29:39 2016 -0700 util/lint: add check for auto-included headers Since we've removed them from the tree, add a check to keep them out. Change-Id: I2995da765fee8796a297963d54a1c34f56376efe Signed-off-by: Martin Roth <martinroth(a)google.com> --- util/lint/lint-stable-019-header-files | 35 ++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/util/lint/lint-stable-019-header-files b/util/lint/lint-stable-019-header-files new file mode 100755 index 0000000..66bf580 --- /dev/null +++ b/util/lint/lint-stable-019-header-files @@ -0,0 +1,35 @@ +#!/bin/sh +# This file is part of the coreboot project. +# +# Copyright (C) 2016 Google Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# DESCR: Check for auto-included headers + +LC_ALL=C export LC_ALL + +INCLUDED_DIRS='^src/' +EXCLUDED_FILES='src/include/kconfig.h' + +HEADER_FILES="k*config rules" + +# Use git grep if the code is in a git repo, otherwise use grep. +if [ -n "$(command -v git)" ] && [ -d .git ]; then + GREP_FILES="git grep -n" +else + GREP_FILES="grep -rn" +fi + +for header in $HEADER_FILES; do + ${GREP_FILES} "#\s*include\s\+[\"<]\s*${header}\.h\s*[\">]" | \ + grep "$INCLUDED_DIRS" | \ + grep -v "$EXCLUDED_FILES"; \ +done \ No newline at end of file

1 0

Patch merged into coreboot/master: sb/intel/lynxpoint: add missing I2C ACPI SSCN/FMCN methods
by gerrit＠coreboot.org 30 Nov '16

30 Nov '16

the following patch was just integrated into master: commit 0eb9103f5d6d0015c4384e812a67b346d8d9f107 Author: Prabal Saha <coolstarorganization(a)gmail.com> Date: Thu Jul 14 12:34:33 2016 -0700 sb/intel/lynxpoint: add missing I2C ACPI SSCN/FMCN methods The SSCN and FMCN methods provide the optimal HCNT/LCNT timing values to the driver, and are necessary when using I2C devices (eg, trackpad and touchscreen) in ACPI (vs PCI) mode. Add these methods using the timing values from Broadwell, which work for Haswell/Lynxpoint as well. TEST: build google/peppy with trackpad/touchscreen devices in ACPI mode, observe proper operation under Windows [8.1/10] and Linux [Mint 18] Change-Id: I25f07ac474b041358315530e5f391bb33d9c4d04 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/17620 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Prabal Saha <coolstarorganization(a)gmail.com> See https://review.coreboot.org/17620 for details. -gerrit

1 0

Patch set updated for coreboot: abuild: Build saved config files
by Martin Roth 30 Nov '16

30 Nov '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17590 -gerrit commit 8eec5e296833c041fa86ce3a9bf0c844e164ebe0 Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 23 18:47:53 2016 -0700 abuild: Build saved config files Update abuild to allow for building saved miniconfig files. If one or more config files exist for a platform under coreboot/configs, they will be built instead of the automatically generated default config. The config filename needs to start with "config.$VENDOR_$BOARD" to be picked up by the abuild script. - Update to version 0.10.0 - Add -d parameter to specify the saved config file directory - Break split 2nd half of create_config function into update_config to set the payload for saved config files. - Unset new payload Kconfig options that could be set in a saved config file. - Update a bunch of MAINBOARD variable names to BUILD_NAME since the build name isn't necessarily the same as the mainboard name. - Split build_target into two functions - build_target and build_config because one mainboard can now build multiple configurations. - Update remove target and call it directly from build_target() instead of from build_targets() Change-Id: I1a276d3e507b178f7dcd9dc125fa9c59f1ab47bd Signed-off-by: Martin Roth <martinroth(a)google.com> --- util/abuild/abuild | 241 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 162 insertions(+), 79 deletions(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index a2a428b..c0f8d5e 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -16,8 +16,8 @@ #set -x # Turn echo on.... -ABUILD_DATE="Oct 13, 2015" -ABUILD_VERSION="0.9.4" +ABUILD_DATE="Nov 23, 2016" +ABUILD_VERSION="0.10.0" TOP=$PWD @@ -51,6 +51,9 @@ failed=0 # default: single CPU build cpus=1 +# change with -d <directory> +configdir="$TOP/configs" + # One might want to adjust these in case of cross compiling for i in make gmake gnumake nonexistant_make; do $i --version 2>/dev/null |grep "GNU Make" >/dev/null && break @@ -173,72 +176,112 @@ function normalize_target function create_config { - local MAINBOARD=$1 + local BUILD_NAME=$1 + local build_dir=$2 - local build_dir=$TARGET/${MAINBOARD} local config_file=${build_dir}/config.build - local board_srcdir=$(mainboard_directory ${MAINBOARD}) + local board_srcdir=$(mainboard_directory ${BUILD_NAME}) + local defconfig_file=${build_dir}/config.$(echo "${BUILD_NAME}" | tr '[:upper:]' '[:lower:]').default + + mkdir -p ${build_dir} + mkdir -p $TARGET/sharedutils + + if [ "$quiet" == "false" ]; then printf " Creating config file for $BUILD_NAME... \n"; fi + printf "CONFIG_VENDOR_$(mainboard_vendor ${BUILD_NAME})=y\n" > ${config_file} + printf "CONFIG_BOARD_${BUILD_NAME}=y\n" >> ${config_file} + grep "select[\t ]*ARCH" ${ROOT}/src/mainboard/${board_srcdir}/Kconfig | \ + sed "s,^.*$ARCH_.*$[^A-Z0-9_]*,CONFIG_\1=y," >> ${config_file} + printf "CONFIG_MAINBOARD_DIR=\"${board_srcdir}\"\n" >> ${config_file} + + update_config "$BUILD_NAME" "$build_dir" "$config_file" - # get a working payload for the board if we have one. - # the --payload option expects a directory containing + ret=$? + if [ $ret -eq 0 ]; then + if [ "$quiet" == "false" ]; then printf " $BUILD_NAME config created.\n"; fi + return 0 + else + # Does this ever happen? + if [ "$quiet" == "false" ]; then printf "$BUILD_NAME config creation FAILED!\nLog excerpt:\n"; fi + tail -n $CONTEXT $build_dir/config.log 2> /dev/null || tail -$CONTEXT $build_dir/config.log + return 1 + fi +} + +function update_config +{ + local BUILD_NAME=$1 + local build_dir=$2 + local config_file=$3 + + # get a working payload for the board if we have one. + # the --payload option expects a directory containing # a shell script payload.sh # Usage: payload.sh [BOARD] # the script returns an absolute path to the payload binary. - if [ -f $payloads/payload.sh ]; then - local PAYLOAD=`sh $payloads/payload.sh $MAINBOARD` + if [ -f "$payloads/payload.sh" ]; then + local PAYLOAD=$(sh "$payloads/payload.sh" "$BUILD_NAME") if [ $? -gt 0 ]; then echo "problem with payload" exit 1 fi - if [ "$quiet" == "false" ]; then printf "Using payload $PAYLOAD\n"; fi + if [ "$quiet" == "false" ]; then printf "Using payload %s\n" "$PAYLOAD"; fi elif [ "$payloads" = "none" ]; then local PAYLOAD=none fi - mkdir -p ${build_dir} - mkdir -p $TARGET/sharedutils - - if [ "$quiet" == "false" ]; then printf " Creating config file for $MAINBOARD... \n"; fi - printf "CONFIG_VENDOR_$(mainboard_vendor ${MAINBOARD})=y\n" > ${config_file} - printf "CONFIG_BOARD_${MAINBOARD}=y\n" >> ${config_file} - grep "select[\t ]*ARCH" ${ROOT}/src/mainboard/${board_srcdir}/Kconfig | \ - sed "s,^.*$ARCH_.*$[^A-Z0-9_]*,CONFIG_\1=y," >> ${config_file} - printf "CONFIG_MAINBOARD_DIR=\"${board_srcdir}\"\n" >> ${config_file} if [ "$PAYLOAD" = "none" ]; then - printf "CONFIG_PAYLOAD_NONE=y\n" >> ${config_file} + { + echo "CONFIG_PAYLOAD_NONE=y" + echo "# CONFIG_PAYLOAD_SEABIOS is not set" + echo "# CONFIG_PAYLOAD_ELF is not set" + echo "# CONFIG_PAYLOAD_BAYOU is not set" + echo "# CONFIG_PAYLOAD_FILO is not set" + echo "# CONFIG_PAYLOAD_GRUB2 is not set" + echo "# CONFIG_PAYLOAD_OPENBIOS is not set" + echo "# CONFIG_PAYLOAD_DEPTHCHARGE is not set" + echo "# CONFIG_PAYLOAD_UBOOT is not set" + echo "# CONFIG_PAYLOAD_TIANOCORE is not set" + } >> "${config_file}" elif [ "$PAYLOAD" != "/dev/null" ]; then - printf "# CONFIG_PAYLOAD_NONE is not set\n" >> ${config_file} - printf "# CONFIG_PAYLOAD_SEABIOS is not set\n" >> ${config_file} - printf "CONFIG_PAYLOAD_ELF=y\n" >> ${config_file} - printf "CONFIG_PAYLOAD_FILE=\"$PAYLOAD\"\n" >> ${config_file} + { + echo "# CONFIG_PAYLOAD_NONE is not set" + echo "# CONFIG_PAYLOAD_SEABIOS is not set" + echo "CONFIG_PAYLOAD_ELF=y" + echo "CONFIG_PAYLOAD_FILE=\"$PAYLOAD\"" + } >> "${config_file}" fi - if [ "$quiet" == "false" ]; then printf " $MAINBOARD ($customizing)\n"; fi - printf "$configoptions" >> ${config_file} + if [ "$quiet" == "false" ]; then echo " $MAINBOARD ($customizing)"; fi + echo "$configoptions" >> "${config_file}" - yes "" 2>/dev/null | $MAKE oldconfig $silent DOTCONFIG=${config_file} obj=${build_dir} objutil=$TARGET/sharedutils &> ${build_dir}/config.log - ret=$? - if [ $ret -eq 0 ]; then - if [ "$quiet" == "false" ]; then printf " $MAINBOARD config created.\n"; fi + # shellcheck disable=SC2086 + $MAKE olddefconfig $silent "DOTCONFIG=${config_file}" "obj=${build_dir}" "objutil=$TARGET/sharedutils" &> "${build_dir}/config.log" + if [ $? -eq 0 ]; then + $MAKE savedefconfig "$silent" DEFCONFIG="${defconfig_file}" DOTCONFIG="${config_file}" obj="${build_dir}" objutil="$TARGET/sharedutils" &> "${build_dir}/config.log" return 0 else - # Does this ever happen? - if [ "$quiet" == "false" ]; then printf "$MAINBOARD config creation FAILED!\nLog excerpt:\n"; fi - tail -n $CONTEXT $build_dir/config.log 2> /dev/null || tail -$CONTEXT $build_dir/config.log return 1 fi } function create_buildenv { - local MAINBOARD=$1 + local BUILD_NAME=$1 + local build_dir=$2 + local config_file=$3 - create_config $MAINBOARD + if [ -z "$config_file" ]; then + create_config "$BUILD_NAME" "$build_dir" + else + local new_config_file="${build_dir}/config.build" + cp "$config_file" "$new_config_file" + update_config "$BUILD_NAME" "$build_dir" "$new_config_file" + fi ret=$? # Allow simple "make" in the target directory - local MAKEFILE=$TARGET/${MAINBOARD}/Makefile + local MAKEFILE=$TARGET/${BUILD_NAME}/Makefile echo "# autogenerated" > $MAKEFILE echo "TOP=$ROOT" >> $MAKEFILE echo "BUILD=$TARGET" >> $MAKEFILE @@ -257,126 +300,166 @@ function create_buildenv function compile_target { - local MAINBOARD=$1 + local BUILD_NAME=$1 if [ "$quiet" == "false" ]; then printf " Compiling $MAINBOARD image$cpuconfig...\n"; fi CURR=$( pwd ) #stime=`perl -e 'print time();' 2>/dev/null || date +%s` - build_dir=$TARGET/${MAINBOARD} eval $BUILDPREFIX $MAKE $silent DOTCONFIG=${build_dir}/config.build obj=${build_dir} objutil=$TARGET/sharedutils \ &> ${build_dir}/make.log ret=$? cp .xcompile ${build_dir}/xcompile.build - cd $TARGET/${MAINBOARD} + cd ${build_dir} etime=`perl -e 'print time();' 2>/dev/null || date +%s` duration=$(( $etime - $stime )) - junit " <testcase classname='board${testclass/#/.}' name='$MAINBOARD' time='$duration' >" + junit " <testcase classname='board${testclass/#/.}' name='$BUILD_NAME' time='$duration' >" if [ $ret -eq 0 ]; then junit "<system-out>" junitfile make.log junit "</system-out>" printf "ok\n" > compile.status - printf "$MAINBOARD built successfully. (took ${duration}s)\n" + printf "$BUILD_NAME built successfully. (took ${duration}s)\n" else ret=1 junit "<failure type='BuildFailed'>" junitfile make.log junit "</failure>" printf "failed\n" > compile.status - printf "$MAINBOARD build FAILED after ${duration}s!\nLog excerpt:\n" + printf "$BUILD_NAME build FAILED after ${duration}s!\nLog excerpt:\n" tail -n $CONTEXT make.log 2> /dev/null || tail -$CONTEXT make.log failed=1 fi cd $CURR if [ $clean_work = "true" ]; then - rm -rf $TARGET/${MAINBOARD} + rm -rf ${build_dir} fi return $ret } -function build_target +function build_config { local MAINBOARD=$1 - local board_srcdir=$(mainboard_directory ${MAINBOARD}) + local build_dir=$2 + local BUILD_NAME=$3 + local config_file=$4 - if [ "`cat $TARGET/${MAINBOARD}/compile.status 2>/dev/null`" = "ok" -a \ + local board_srcdir=$(mainboard_directory "${MAINBOARD}") + + if [ "$(cat "${build_dir}/compile.status" 2>/dev/null)" = "ok" -a \ "$buildall" = "false" ]; then - printf "Skipping $MAINBOARD; (already successful)\n" + echo "Skipping $BUILD_NAME; (already successful)" return fi - HOSTCC='gcc' + export HOSTCC='gcc' - if [ $chromeos = true -a `grep -c "^[[:space:]]*select[[:space:]]*MAINBOARD_HAS_CHROMEOS\>" ${ROOT}/src/mainboard/${board_srcdir}/Kconfig` -eq 0 ]; then - echo "${MAINBOARD} doesn't support Chrome OS, skipping." + if [ "$chromeos" = true ] && [ "$(grep -c "^[[:space:]]*select[[:space:]]*MAINBOARD_HAS_CHROMEOS\>" "${ROOT}/src/mainboard/${board_srcdir}/Kconfig")" -eq 0 ]; then + echo "${BUILD_NAME} doesn't support Chrome OS, skipping." return fi - if [ -f src/mainboard/${board_srcdir}/abuild.disabled ]; then - echo "${MAINBOARD} disabled:" - cat src/mainboard/${board_srcdir}/abuild.disabled + if [ -f "src/mainboard/${board_srcdir}/abuild.disabled" ]; then + echo "${BUILD_NAME} disabled:" + cat "src/mainboard/${board_srcdir}/abuild.disabled" return fi - if [ "$quiet" == "false" ]; then printf "Building $MAINBOARD\n"; fi - mkdir -p $TARGET/${MAINBOARD} $TARGET/abuild - ABSPATH=`cd $TARGET/abuild; pwd` - XMLFILE=$ABSPATH/${MAINBOARD}.xml - rm -f ${XMLFILE} + if [ "$quiet" == "false" ]; then echo "Building $BUILD_NAME"; fi + mkdir -p "$TARGET/${BUILD_NAME}" "$TARGET/abuild" + ABSPATH="$(cd "$TARGET/abuild"; pwd)" + XMLFILE="$ABSPATH/${BUILD_NAME}.xml" + rm -f "${XMLFILE}" + stime=$(perl -e 'print time();' 2>/dev/null || date +%s) + create_buildenv "$BUILD_NAME" "$build_dir" "$config_file" + if [ $? -ne 0 ]; then + + junit "<failure type='BuildFailed'>" + junitfile "$build_dir/config.log" + junit "</failure>" + printf "failed\n" > compile.status + printf "$BUILD_NAME build configuration FAILED!\nLog excerpt:\n" + tail -n $CONTEXT "$build_dir/config.log" 2> /dev/null || tail -$CONTEXT "$build_dir/config.log" + + junit "</testcase>" + return + fi - stime=`perl -e 'print time();' 2>/dev/null || date +%s` - create_buildenv $MAINBOARD - required_arches=`egrep "^CONFIG_ARCH_(BOOTBLOCK|R.MSTAGE|VERSTAGE)" $TARGET/${MAINBOARD}/config.build | \ + required_arches=`egrep "^CONFIG_ARCH_(BOOTBLOCK|R.MSTAGE|VERSTAGE)" $TARGET/${BUILD_NAME}/config.build | \ sed "s,^CONFIG_ARCH_[^_]*_$[^=]*$=.*$,\1," |sort -u |tr 'A-Z\n\r' 'a-z '` missing_arches=`printf 'include .xcompile\nall: ; @echo $(foreach arch,'"$required_arches"',$(if $(filter $(arch),$(SUBARCH_SUPPORTED)),,$(arch)))' | make --no-print-directory -f -` if [ -n "$missing_arches" ]; then - printf "skipping $MAINBOARD because we're missing compilers for ($missing_arches)\n" + printf "skipping $BUILD_NAME because we're missing compilers for ($missing_arches)\n" return fi if [ $? -eq 0 -a $configureonly -eq 0 ]; then BUILDPREFIX= if [ "$scanbuild" = "true" ]; then - scanbuild_out=$TARGET/${MAINBOARD}-scanbuild + scanbuild_out=$TARGET/${BUILD_NAME}-scanbuild rm -rf ${scanbuild_out} BUILDPREFIX="scan-build -o ${scanbuild_out}tmp" fi - compile_target ${MAINBOARD} + compile_target ${BUILD_NAME} if [ "$scanbuild" = "true" ]; then mv ${scanbuild_out}tmp/* ${scanbuild_out} rmdir ${scanbuild_out}tmp fi fi - # Not calculated here because we still print it in compile_target - #etime=`perl -e 'print time();' 2>/dev/null || date +%s` - #duration=$(( $etime - $stime )) junit "</testcase>" } +# One target may build several configs +function build_target +{ + local MAINBOARD=$1 + local MAINBOARD_LC=$(echo "$MAINBOARD" | tr '[:upper:]' '[:lower:]') + + # look for config files in the config directory that match the boardname + if [ -n "$( find "$configdir" -maxdepth 1 -name "config.${MAINBOARD_LC}*" -print -quit )" ]; then + for config in "$configdir"/config."${MAINBOARD_LC}"*; do + BUILD_NAME="${config##*/}" + BUILD_NAME="${BUILD_NAME##config.}" + BUILD_NAME=$(echo "${BUILD_NAME}" | tr '[:lower:]' '[:upper:]') + echo "Building config $BUILD_NAME" + build_dir=$TARGET/${BUILD_NAME} + build_config "$MAINBOARD" "$build_dir" "$BUILD_NAME" "$config" + remove_target "$BUILD_NAME" + + done + else + echo "Building board $MAINBOARD (using default config)" + build_dir=$TARGET/${MAINBOARD} + + build_config "$MAINBOARD" "$build_dir" "$MAINBOARD" + remove_target "$MAINBOARD" + fi + +} + function remove_target { if [ "$remove" != "true" ]; then - return 0 + return fi - local MAINBOARD=$1 + local BUILD_NAME=$1 # Save the generated coreboot.rom file of each board. - if [ -r "$TARGET/${MAINBOARD}/coreboot.rom" ]; then - cp $TARGET/${MAINBOARD}/coreboot.rom \ - ${MAINBOARD}_coreboot.rom + if [ -r "$TARGET/${BUILD_NAME}/coreboot.rom" ]; then + cp "$TARGET/${BUILD_NAME}/coreboot.rom" \ + "${BUILD_NAME}_coreboot.rom" fi - printf "Removing build dir for board $MAINBOARD...\n" - rm -rf $TARGET/${MAINBOARD} + echo "Removing build dir for $BUILD_NAME..." + rm -rf "$TARGET/${BUILD_NAME}" - return 0 + return } function myhelp @@ -391,6 +474,7 @@ Options:\n" [-q|--quiet] print fewer messages [-a|--all] build previously succeeded ports as well [-r|--remove] remove output dir after build + [-d|--dir <dir>] directory containing config files [-t|--target <vendor/board>] attempt to build target vendor/board only [-p|--payloads <dir>] use payloads in <dir> to build images [-V|--version] print version number and exit @@ -457,11 +541,11 @@ cmdline="$* -c 1" getoptbrand="`getopt -V`" if [ "${getoptbrand:0:6}" == "getopt" ]; then # Detected GNU getopt that supports long options. - args=`getopt -l version,verbose,quiet,help,all,target:,payloads:,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,clean,outdir:,chromeos,xmlfile:,kconfig: -o Vvqhat:p:c:sJCl:rP:uyBLzo:xX:K: -- "$@"` || exit 1 + args=`getopt -l version,verbose,quiet,help,all,target:,payloads:,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,clean,outdir:,chromeos,xmlfile:,kconfig:,dir: -o Vvqhat:p:c:sJCl:rP:uyBLzo:xX:K:d: -- "$@"` || exit 1 eval set -- $args else # Detected non-GNU getopt - args=`getopt Vvqhat:p:c:sJCl:rP:uyBLzo:xX:K: $*` + args=`getopt Vvqhat:p:c:sJCl:rP:uyBLzo:xX:K:d: $*` set -- $args fi @@ -481,6 +565,7 @@ while true ; do -J|--junit) shift; mode=junit; rm -f $XMLFILE ;; -t|--target) shift; target="$1"; shift;; -a|--all) shift; buildall=true;; + -d|--dir) shift; configdir="$1"; shift;; -r|--remove) shift; remove=true;; -v|--verbose) shift; verbose=true; silent='V=1';; -q|--quiet) shift; quiet=true;; @@ -580,7 +665,6 @@ build_targets() local targets=${*-$(get_mainboards)} for MAINBOARD in $targets; do build_target ${MAINBOARD} - remove_target ${MAINBOARD} done } else @@ -657,7 +741,6 @@ if [ "$target" != "" ]; then exit 1 else build_target ${MAINBOARD} - remove_target ${MAINBOARD} test "$mode" != "text" && \ test -f $TARGET/abuild/${MAINBOARD}.xml && \ cat $TARGET/abuild/${MAINBOARD}.xml >> $REAL_XMLFILE

1 0

New patch to review for coreboot: mainboard & southbridge: Clear files that are just headers
by Martin Roth 30 Nov '16

30 Nov '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17657 -gerrit commit 9cce15f1bc7523e5b74c11ee1889fa62b1365b4c Author: Martin Roth <martinroth(a)google.com> Date: Wed Nov 30 08:51:27 2016 -0700 mainboard & southbridge: Clear files that are just headers These headers & comments indicating a lack of functionality don't help anything. We discourage copyrights and licenses on empty files, so just clear these. Change-Id: Id2ab060a2726cac6ab047d49a6e6b153f52ffe6d Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/mainboard/amd/inagua/acpi/superio.asl | 16 ---------------- src/mainboard/amd/olivehill/acpi/superio.asl | 16 ---------------- src/mainboard/amd/olivehill/acpi/thermal.asl | 16 ---------------- src/mainboard/amd/parmer/acpi/sata.asl | 16 ---------------- src/mainboard/amd/parmer/acpi/superio.asl | 16 ---------------- src/mainboard/amd/parmer/acpi/thermal.asl | 16 ---------------- src/mainboard/amd/south_station/acpi/superio.asl | 16 ---------------- src/mainboard/amd/thatcher/acpi/sata.asl | 16 ---------------- src/mainboard/amd/thatcher/acpi/superio.asl | 16 ---------------- src/mainboard/amd/thatcher/acpi/thermal.asl | 16 ---------------- src/mainboard/amd/torpedo/acpi/usb.asl | 14 -------------- src/mainboard/amd/union_station/acpi/superio.asl | 16 ---------------- src/mainboard/asrock/e350m1/acpi/superio.asl | 16 ---------------- src/mainboard/asrock/imb-a180/acpi/superio.asl | 16 ---------------- src/mainboard/asrock/imb-a180/acpi/thermal.asl | 16 ---------------- src/mainboard/asus/f2a85-m/acpi/sata.asl | 16 ---------------- src/mainboard/asus/f2a85-m/acpi/superio.asl | 16 ---------------- src/mainboard/asus/f2a85-m/acpi/thermal.asl | 16 ---------------- src/mainboard/bap/ode_e20XX/acpi/thermal.asl | 16 ---------------- src/mainboard/biostar/am1ml/acpi/thermal.asl | 16 ---------------- src/mainboard/gizmosphere/gizmo2/acpi/superio.asl | 16 ---------------- src/mainboard/gizmosphere/gizmo2/acpi/thermal.asl | 16 ---------------- src/mainboard/google/chell/acpi_tables.c | 15 --------------- src/mainboard/google/eve/acpi/ec.asl | 14 -------------- src/mainboard/google/eve/acpi/superio.asl | 14 -------------- src/mainboard/google/eve/acpi_tables.c | 14 -------------- src/mainboard/google/glados/acpi_tables.c | 15 --------------- src/mainboard/google/lars/acpi_tables.c | 15 --------------- src/mainboard/hp/abm/acpi/superio.asl | 16 ---------------- src/mainboard/hp/abm/acpi/thermal.asl | 16 ---------------- src/mainboard/hp/pavilion_m6_1035dx/acpi/sata.asl | 16 ---------------- src/mainboard/hp/pavilion_m6_1035dx/acpi/superio.asl | 16 ---------------- src/mainboard/hp/pavilion_m6_1035dx/acpi/thermal.asl | 16 ---------------- src/mainboard/intel/kunimitsu/acpi_tables.c | 15 --------------- src/mainboard/intel/stargo2/acpi/superio.asl | 16 ---------------- src/mainboard/intel/wtm2/acpi/superio.asl | 16 ---------------- src/mainboard/lenovo/g505s/acpi/sata.asl | 16 ---------------- src/mainboard/lenovo/g505s/acpi/thermal.asl | 16 ---------------- src/mainboard/msi/ms7721/acpi/sata.asl | 16 ---------------- src/mainboard/msi/ms7721/acpi/superio.asl | 16 ---------------- src/mainboard/msi/ms7721/acpi/thermal.asl | 16 ---------------- src/southbridge/amd/agesa/hudson/acpi/smbus.asl | 16 ---------------- src/southbridge/amd/pi/hudson/acpi/smbus.asl | 16 ---------------- 43 files changed, 676 deletions(-) diff --git a/src/mainboard/amd/inagua/acpi/superio.asl b/src/mainboard/amd/inagua/acpi/superio.asl index a39b397..e69de29 100644 --- a/src/mainboard/amd/inagua/acpi/superio.asl +++ b/src/mainboard/amd/inagua/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SuperIO device or functionality yet */ diff --git a/src/mainboard/amd/olivehill/acpi/superio.asl b/src/mainboard/amd/olivehill/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/amd/olivehill/acpi/superio.asl +++ b/src/mainboard/amd/olivehill/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/amd/olivehill/acpi/thermal.asl b/src/mainboard/amd/olivehill/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/amd/olivehill/acpi/thermal.asl +++ b/src/mainboard/amd/olivehill/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/amd/parmer/acpi/sata.asl b/src/mainboard/amd/parmer/acpi/sata.asl index 46daa0e..e69de29 100644 --- a/src/mainboard/amd/parmer/acpi/sata.asl +++ b/src/mainboard/amd/parmer/acpi/sata.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SATA functionality */ diff --git a/src/mainboard/amd/parmer/acpi/superio.asl b/src/mainboard/amd/parmer/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/amd/parmer/acpi/superio.asl +++ b/src/mainboard/amd/parmer/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/amd/parmer/acpi/thermal.asl b/src/mainboard/amd/parmer/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/amd/parmer/acpi/thermal.asl +++ b/src/mainboard/amd/parmer/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/amd/south_station/acpi/superio.asl b/src/mainboard/amd/south_station/acpi/superio.asl index a39b397..e69de29 100644 --- a/src/mainboard/amd/south_station/acpi/superio.asl +++ b/src/mainboard/amd/south_station/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SuperIO device or functionality yet */ diff --git a/src/mainboard/amd/thatcher/acpi/sata.asl b/src/mainboard/amd/thatcher/acpi/sata.asl index 46daa0e..e69de29 100644 --- a/src/mainboard/amd/thatcher/acpi/sata.asl +++ b/src/mainboard/amd/thatcher/acpi/sata.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SATA functionality */ diff --git a/src/mainboard/amd/thatcher/acpi/superio.asl b/src/mainboard/amd/thatcher/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/amd/thatcher/acpi/superio.asl +++ b/src/mainboard/amd/thatcher/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/amd/thatcher/acpi/thermal.asl b/src/mainboard/amd/thatcher/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/amd/thatcher/acpi/thermal.asl +++ b/src/mainboard/amd/thatcher/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/amd/torpedo/acpi/usb.asl b/src/mainboard/amd/torpedo/acpi/usb.asl index 54b36ca..e69de29 100644 --- a/src/mainboard/amd/torpedo/acpi/usb.asl +++ b/src/mainboard/amd/torpedo/acpi/usb.asl @@ -1,14 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/amd/union_station/acpi/superio.asl b/src/mainboard/amd/union_station/acpi/superio.asl index a39b397..e69de29 100644 --- a/src/mainboard/amd/union_station/acpi/superio.asl +++ b/src/mainboard/amd/union_station/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SuperIO device or functionality yet */ diff --git a/src/mainboard/asrock/e350m1/acpi/superio.asl b/src/mainboard/asrock/e350m1/acpi/superio.asl index a39b397..e69de29 100644 --- a/src/mainboard/asrock/e350m1/acpi/superio.asl +++ b/src/mainboard/asrock/e350m1/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SuperIO device or functionality yet */ diff --git a/src/mainboard/asrock/imb-a180/acpi/superio.asl b/src/mainboard/asrock/imb-a180/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/asrock/imb-a180/acpi/superio.asl +++ b/src/mainboard/asrock/imb-a180/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/asrock/imb-a180/acpi/thermal.asl b/src/mainboard/asrock/imb-a180/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/asrock/imb-a180/acpi/thermal.asl +++ b/src/mainboard/asrock/imb-a180/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/asus/f2a85-m/acpi/sata.asl b/src/mainboard/asus/f2a85-m/acpi/sata.asl index 46daa0e..e69de29 100644 --- a/src/mainboard/asus/f2a85-m/acpi/sata.asl +++ b/src/mainboard/asus/f2a85-m/acpi/sata.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SATA functionality */ diff --git a/src/mainboard/asus/f2a85-m/acpi/superio.asl b/src/mainboard/asus/f2a85-m/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/asus/f2a85-m/acpi/superio.asl +++ b/src/mainboard/asus/f2a85-m/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/asus/f2a85-m/acpi/thermal.asl b/src/mainboard/asus/f2a85-m/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/asus/f2a85-m/acpi/thermal.asl +++ b/src/mainboard/asus/f2a85-m/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/bap/ode_e20XX/acpi/thermal.asl b/src/mainboard/bap/ode_e20XX/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/bap/ode_e20XX/acpi/thermal.asl +++ b/src/mainboard/bap/ode_e20XX/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/biostar/am1ml/acpi/thermal.asl b/src/mainboard/biostar/am1ml/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/biostar/am1ml/acpi/thermal.asl +++ b/src/mainboard/biostar/am1ml/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl b/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl +++ b/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/thermal.asl b/src/mainboard/gizmosphere/gizmo2/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi/thermal.asl +++ b/src/mainboard/gizmosphere/gizmo2/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/google/chell/acpi_tables.c b/src/mainboard/google/chell/acpi_tables.c index f58228f..e69de29 100644 --- a/src/mainboard/google/chell/acpi_tables.c +++ b/src/mainboard/google/chell/acpi_tables.c @@ -1,15 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Google Inc. - * Copyright (C) 2015 Intel Corporation - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/google/eve/acpi/ec.asl b/src/mainboard/google/eve/acpi/ec.asl index 7782851..e69de29 100644 --- a/src/mainboard/google/eve/acpi/ec.asl +++ b/src/mainboard/google/eve/acpi/ec.asl @@ -1,14 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2016 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/google/eve/acpi/superio.asl b/src/mainboard/google/eve/acpi/superio.asl index 7782851..e69de29 100644 --- a/src/mainboard/google/eve/acpi/superio.asl +++ b/src/mainboard/google/eve/acpi/superio.asl @@ -1,14 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2016 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/google/eve/acpi_tables.c b/src/mainboard/google/eve/acpi_tables.c index 7782851..e69de29 100644 --- a/src/mainboard/google/eve/acpi_tables.c +++ b/src/mainboard/google/eve/acpi_tables.c @@ -1,14 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2016 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/google/glados/acpi_tables.c b/src/mainboard/google/glados/acpi_tables.c index f58228f..e69de29 100644 --- a/src/mainboard/google/glados/acpi_tables.c +++ b/src/mainboard/google/glados/acpi_tables.c @@ -1,15 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Google Inc. - * Copyright (C) 2015 Intel Corporation - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/google/lars/acpi_tables.c b/src/mainboard/google/lars/acpi_tables.c index ccf9f74..e69de29 100644 --- a/src/mainboard/google/lars/acpi_tables.c +++ b/src/mainboard/google/lars/acpi_tables.c @@ -1,15 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Google Inc. - * Copyright (C) 2015 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/hp/abm/acpi/superio.asl b/src/mainboard/hp/abm/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/hp/abm/acpi/superio.asl +++ b/src/mainboard/hp/abm/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/hp/abm/acpi/thermal.asl b/src/mainboard/hp/abm/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/hp/abm/acpi/thermal.asl +++ b/src/mainboard/hp/abm/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/sata.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/sata.asl index 46daa0e..e69de29 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/sata.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/sata.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SATA functionality */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/superio.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/superio.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/thermal.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/thermal.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/intel/kunimitsu/acpi_tables.c b/src/mainboard/intel/kunimitsu/acpi_tables.c index ccf9f74..e69de29 100644 --- a/src/mainboard/intel/kunimitsu/acpi_tables.c +++ b/src/mainboard/intel/kunimitsu/acpi_tables.c @@ -1,15 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Google Inc. - * Copyright (C) 2015 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ diff --git a/src/mainboard/intel/stargo2/acpi/superio.asl b/src/mainboard/intel/stargo2/acpi/superio.asl index 68a23e6..e69de29 100644 --- a/src/mainboard/intel/stargo2/acpi/superio.asl +++ b/src/mainboard/intel/stargo2/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* Values should match those defined in devicetree.cb */ diff --git a/src/mainboard/intel/wtm2/acpi/superio.asl b/src/mainboard/intel/wtm2/acpi/superio.asl index 301fcc7..e69de29 100644 --- a/src/mainboard/intel/wtm2/acpi/superio.asl +++ b/src/mainboard/intel/wtm2/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* Values should match those defined in devicetree.cb */ diff --git a/src/mainboard/lenovo/g505s/acpi/sata.asl b/src/mainboard/lenovo/g505s/acpi/sata.asl index 46daa0e..e69de29 100644 --- a/src/mainboard/lenovo/g505s/acpi/sata.asl +++ b/src/mainboard/lenovo/g505s/acpi/sata.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SATA functionality */ diff --git a/src/mainboard/lenovo/g505s/acpi/thermal.asl b/src/mainboard/lenovo/g505s/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/lenovo/g505s/acpi/thermal.asl +++ b/src/mainboard/lenovo/g505s/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/mainboard/msi/ms7721/acpi/sata.asl b/src/mainboard/msi/ms7721/acpi/sata.asl index 46daa0e..e69de29 100644 --- a/src/mainboard/msi/ms7721/acpi/sata.asl +++ b/src/mainboard/msi/ms7721/acpi/sata.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No SATA functionality */ diff --git a/src/mainboard/msi/ms7721/acpi/superio.asl b/src/mainboard/msi/ms7721/acpi/superio.asl index 6f95a8a..e69de29 100644 --- a/src/mainboard/msi/ms7721/acpi/superio.asl +++ b/src/mainboard/msi/ms7721/acpi/superio.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No Super I/O device or functionality yet */ diff --git a/src/mainboard/msi/ms7721/acpi/thermal.asl b/src/mainboard/msi/ms7721/acpi/thermal.asl index d769f9a..e69de29 100644 --- a/src/mainboard/msi/ms7721/acpi/thermal.asl +++ b/src/mainboard/msi/ms7721/acpi/thermal.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* No thermal zone functionality */ diff --git a/src/southbridge/amd/agesa/hudson/acpi/smbus.asl b/src/southbridge/amd/agesa/hudson/acpi/smbus.asl index f0b8983..e69de29 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/smbus.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/smbus.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* SMBus Support */ diff --git a/src/southbridge/amd/pi/hudson/acpi/smbus.asl b/src/southbridge/amd/pi/hudson/acpi/smbus.asl index f0b8983..e69de29 100644 --- a/src/southbridge/amd/pi/hudson/acpi/smbus.asl +++ b/src/southbridge/amd/pi/hudson/acpi/smbus.asl @@ -1,16 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* SMBus Support */

1 0

Patch merged into coreboot/master: soc/intel/skylake: Pass proper CPU flex ratio override to FSP
by gerrit＠coreboot.org 30 Nov '16

30 Nov '16

the following patch was just integrated into master: commit 79239b75a7eb6f1749c350848b2ba2c2ba1a5314 Author: Naresh G Solanki <naresh.solanki(a)intel.com> Date: Wed Nov 16 21:34:41 2016 +0530 soc/intel/skylake: Pass proper CPU flex ratio override to FSP In bootblock, cpu flex ratio is set to non-turbo max. In FSP UPD, if CpuRatioOverride is zero, then it tries to program cpu ratio to zero. Since it is different than the non-zero value programmed in bootblock, FSP gives reset. To avoid the reset, set FSP UPD for CPU flex ratio override to that value as set in bootblock. Change-Id: I8cae5530ec97cedfbd71771f291db6f55a9fd5c2 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> Reviewed-on: https://review.coreboot.org/17555 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See https://review.coreboot.org/17555 for details. -gerrit

1 0

Patch merged into coreboot/master: vendorcode/skykabylake: Update header to fsp v1.4.0
by gerrit＠coreboot.org 30 Nov '16

30 Nov '16

the following patch was just integrated into master: commit 09fa0391f55e7c854104ef09b6f0afee20f067a4 Author: Naresh G Solanki <naresh.solanki(a)intel.com> Date: Wed Nov 16 21:40:13 2016 +0530 vendorcode/skykabylake: Update header to fsp v1.4.0 Add header files as is from FSP build output without any adaptations. Change-Id: Ic4b33c42efe8c9dbe9f9e2b11bf6344c9487d86e Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> Reviewed-on: https://review.coreboot.org/17556 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See https://review.coreboot.org/17556 for details. -gerrit

1 0

Patch merged into coreboot/master: mb/intel/kblrvp: Add Variant board support for KBLRVP
by gerrit＠coreboot.org 30 Nov '16

30 Nov '16

the following patch was just integrated into master: commit a5b10417e41267e34126b806ae7653c488217ad5 Author: Barnali Sarkar <barnali.sarkar(a)intel.com> Date: Mon Nov 28 14:53:12 2016 +0530 mb/intel/kblrvp: Add Variant board support for KBLRVP Add support of Variant board model for existing intel/kblrvp, since there might be more RVP board supports under intel/kblrvp. Existing is for KBL RVP3 board. BUG=none BRANCH=none TEST=Built and boot Kaby Lake RVP3 Change-Id: I041a07a273dbb77e422d48591f06b5f1011cd9f7 Signed-off-by: Barnali Sarkar <barnali.sarkar(a)intel.com> Reviewed-on: https://review.coreboot.org/17630 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) See https://review.coreboot.org/17630 for details. -gerrit

1 0

Patch merged into coreboot/master: mb/intel/kblrvp: Use common lib spd_bin to get spd
by gerrit＠coreboot.org 30 Nov '16

30 Nov '16

the following patch was just integrated into master: commit d138871b16b85ff04c045ab7b11e4b2db87a09bf Author: Naresh G Solanki <naresh.solanki(a)intel.com> Date: Tue Nov 15 19:35:33 2016 +0530 mb/intel/kblrvp: Use common lib spd_bin to get spd Use common lib spd_bin to get spd. Change-Id: If94413fc36a98f7694f560955bbb80abefe32166 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> Reviewed-on: https://review.coreboot.org/17435 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See https://review.coreboot.org/17435 for details. -gerrit

1 0

Patch merged into coreboot/master: lib: Add library to handle SPD data in CBFS or DIMM
by gerrit＠coreboot.org 30 Nov '16

30 Nov '16

the following patch was just integrated into master: commit 335781ad53cd4988425e922cc24c966958484f0f Author: Naresh G Solanki <naresh.solanki(a)intel.com> Date: Wed Oct 26 19:43:14 2016 +0530 lib: Add library to handle SPD data in CBFS or DIMM Add library to: 1. add spd.bin in cbfs, generated from mainboard/spd/*.spd.hex files. 2. runtime get spd data with spd index as input. 3. fetch spd over smbus using early smbus functions. Change-Id: I44fe1cdb883dd1037484d4bb5c87d2d4f9862bf8 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> Reviewed-on: https://review.coreboot.org/17434 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) See https://review.coreboot.org/17434 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2016