coreboot-gerrit September 2015

coreboot-gerrit@coreboot.org

1 participants
859 discussions

New patch to review for coreboot: chromeec: Move keyboard backlight code into Chrome EC directory
by Duncan Laurie 01 Sep '15

01 Sep '15

Duncan Laurie (dlaurie(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11478 -gerrit commit 05ff05fecdb4c74e59b4f673a164f75fc03e1cc1 Author: Duncan Laurie <dlaurie(a)google.com> Date: Tue Sep 1 09:47:55 2015 -0700 chromeec: Move keyboard backlight code into Chrome EC directory Since more boards are starting to use the EC provided keyboard backlight interface move the code to a common place and allow it to get included in mainboards. Change-Id: I3f307bbce1a96cdd1c8224b1e89a63d6fedef738 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- src/ec/google/chromeec/acpi/ec.asl | 4 +++ src/ec/google/chromeec/acpi/keyboard_backlight.asl | 42 ++++++++++++++++++++++ src/mainboard/google/glados/acpi/ec.asl | 3 ++ src/mainboard/google/glados/acpi/mainboard.asl | 18 ---------- src/mainboard/google/link/acpi/ec.asl | 5 ++- src/mainboard/google/link/acpi/mainboard.asl | 19 ---------- src/mainboard/google/samus/acpi/ec.asl | 3 ++ src/mainboard/google/samus/acpi/mainboard.asl | 18 ---------- 8 files changed, 56 insertions(+), 56 deletions(-) diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 746060e..8b4f91d 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -420,6 +420,10 @@ Device (EC0) #include "als.asl" #endif +#ifdef EC_ENABLE_KEYBOARD_BACKLIGHT + #include "keyboard_backlight.asl" +#endif + #ifdef EC_ENABLE_PD_MCU_DEVICE #include "pd.asl" #endif diff --git a/src/ec/google/chromeec/acpi/keyboard_backlight.asl b/src/ec/google/chromeec/acpi/keyboard_backlight.asl new file mode 100644 index 0000000..608994e --- /dev/null +++ b/src/ec/google/chromeec/acpi/keyboard_backlight.asl @@ -0,0 +1,42 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2015 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc. + */ + +Scope (\_SB) +{ + /* + * Chrome EC Keyboard Backlight interface + */ + Device (KBLT) + { + Name (_HID, "GOOG0002") + Name (_UID, 1) + + /* Read current backlight value */ + Method (KBQC, 0, NotSerialized) + { + Return (\_SB.PCI0.LPCB.EC0.KBLV) + } + + /* Write new backlight value */ + Method (KBCM, 1, NotSerialized) + { + Store (Arg0, \_SB.PCI0.LPCB.EC0.KBLV) + } + } +} diff --git a/src/mainboard/google/glados/acpi/ec.asl b/src/mainboard/google/glados/acpi/ec.asl index 321b2ce..33a7471 100644 --- a/src/mainboard/google/glados/acpi/ec.asl +++ b/src/mainboard/google/glados/acpi/ec.asl @@ -21,6 +21,9 @@ #include <mainboard/google/glados/ec.h> #include <mainboard/google/glados/gpio.h> +/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE diff --git a/src/mainboard/google/glados/acpi/mainboard.asl b/src/mainboard/google/glados/acpi/mainboard.asl index 8e51259..efa7ddd 100644 --- a/src/mainboard/google/glados/acpi/mainboard.asl +++ b/src/mainboard/google/glados/acpi/mainboard.asl @@ -47,24 +47,6 @@ Scope (\_SB) { Name (_HID, EisaId ("PNP0C0C")) } - - /* Keyboard Backlight interface via EC */ - Device (KBLT) { - Name (_HID, "GOOG0002") - Name (_UID, 1) - - /* Read current backlight value */ - Method (KBQC, 0) - { - Return (\_SB.PCI0.LPCB.EC0.KBLV) - } - - /* Write new backlight value */ - Method (KBCM, 1) - { - Store (Arg0, \_SB.PCI0.LPCB.EC0.KBLV) - } - } } /* diff --git a/src/mainboard/google/link/acpi/ec.asl b/src/mainboard/google/link/acpi/ec.asl index d52e0e9..97bec3e 100644 --- a/src/mainboard/google/link/acpi/ec.asl +++ b/src/mainboard/google/link/acpi/ec.asl @@ -20,5 +20,8 @@ /* mainboard configuration */ #include "../ec.h" +/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + /* ACPI code for EC functions */ -#include "../../../../ec/google/chromeec/acpi/ec.asl" +#include <ec/google/chromeec/acpi/ec.asl> diff --git a/src/mainboard/google/link/acpi/mainboard.asl b/src/mainboard/google/link/acpi/mainboard.asl index 3470ff0..63169e5 100644 --- a/src/mainboard/google/link/acpi/mainboard.asl +++ b/src/mainboard/google/link/acpi/mainboard.asl @@ -85,23 +85,4 @@ Scope (\_SB) { VendorShort (ADDR) {0x4a} }) } - - // Keyboard Backlight interface via EC - Device (KBLT) { - Name (_HID, EisaId("GGL0002")) - Name (_UID, 1) - Name (_ADR, 0) - - // Read current backlight value - Method (KBQC, 0) - { - Return (\_SB.PCI0.LPCB.EC0.KBLV) - } - - // Write new backlight value - Method (KBCM, 1) - { - Store (Arg0, \_SB.PCI0.LPCB.EC0.KBLV) - } - } } diff --git a/src/mainboard/google/samus/acpi/ec.asl b/src/mainboard/google/samus/acpi/ec.asl index 41951d1..1147fcf 100644 --- a/src/mainboard/google/samus/acpi/ec.asl +++ b/src/mainboard/google/samus/acpi/ec.asl @@ -23,6 +23,9 @@ /* Enable EC backed ALS device in ACPI */ #define EC_ENABLE_ALS_DEVICE +/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE diff --git a/src/mainboard/google/samus/acpi/mainboard.asl b/src/mainboard/google/samus/acpi/mainboard.asl index 04f98a9..5a1ac57 100644 --- a/src/mainboard/google/samus/acpi/mainboard.asl +++ b/src/mainboard/google/samus/acpi/mainboard.asl @@ -37,24 +37,6 @@ Scope (\_SB) { Name(_HID, EisaId("PNP0C0C")) } - - // Keyboard Backlight interface via EC - Device (KBLT) { - Name (_HID, "GOOG0002") - Name (_UID, 1) - - // Read current backlight value - Method (KBQC, 0) - { - Return (\_SB.PCI0.LPCB.EC0.KBLV) - } - - // Write new backlight value - Method (KBCM, 1) - { - Store (Arg0, \_SB.PCI0.LPCB.EC0.KBLV) - } - } } /*

1 0

Patch merged into coreboot/master: cbfstool: off-by-one on the gcc version that provides _Static_assert
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit ab5754da6639f51ee2aec796f832ce4e3b164f82 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Tue Sep 1 18:20:20 2015 +0200 cbfstool: off-by-one on the gcc version that provides _Static_assert According to https://gcc.gnu.org/gcc-4.6/changes.html it's only in gcc 4.6, not 4.5, which I mistakenly believed. Change-Id: I8212e7921bd9d1436a0ba491cbe6c4d473228956 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: http://review.coreboot.org/11476 Reviewed-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Tested-by: build bot (Jenkins) See http://review.coreboot.org/11476 for details. -gerrit

1 0

New patch to review for coreboot: cbfstool: off-by-one on the gcc version that provides _Static_assert
by Patrick Georgi 01 Sep '15

01 Sep '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11476 -gerrit commit c8aa3222082cf4dc09fe2da6625ede0ca250ad7c Author: Patrick Georgi <pgeorgi(a)google.com> Date: Tue Sep 1 18:20:20 2015 +0200 cbfstool: off-by-one on the gcc version that provides _Static_assert According to https://gcc.gnu.org/gcc-4.6/changes.html it's only in gcc 4.6, not 4.5, which I mistakenly believed. Change-Id: I8212e7921bd9d1436a0ba491cbe6c4d473228956 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- util/cbfstool/cbfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbfstool/cbfs.h b/util/cbfstool/cbfs.h index d1b97c5..f738c60 100644 --- a/util/cbfstool/cbfs.h +++ b/util/cbfstool/cbfs.h @@ -88,7 +88,7 @@ struct cbfs_file { char filename[]; } __PACKED; -#if defined __GNUC__ && (__GNUC__ * 100 + __GNUC_MINOR__) >= 405 +#if defined __GNUC__ && (__GNUC__ * 100 + __GNUC_MINOR__) >= 406 _Static_assert(sizeof(struct cbfs_file) == 24, "cbfs_file size mismatch"); #endif

1 0

Patch merged into coreboot/master: cbfstool: guard _Static_assert
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit 57c67e5aa52426ee8665bc6e0706ac2abf625a13 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Sep 1 12:37:41 2015 +0200 cbfstool: guard _Static_assert This isn't required for correct execution, and doesn't need to be tested on every single compiler out there. Since GCC < 4.5 has no idea about _Static_assert, hide it there. Our build tests will make sure that the test is run before changes are submitted to master. Change-Id: I4141f4aa23b140d2d1017ca7b4dace5aa7db0c04 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/11475 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com> Reviewed-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> See http://review.coreboot.org/11475 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: implement decompression support for cbfstool extract
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit 23aeaff41b94af818191a8668a517abb04a7d516 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed Aug 26 13:01:10 2015 +0200 cbfstool: implement decompression support for cbfstool extract Change-Id: I5142b03d3c3e028eeb179f225848f762186f94a8 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/11363 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See http://review.coreboot.org/11363 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: add decompression wrappers
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit 61c822900e8907e28ef6dca326835692ae6d18ca Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed Aug 26 12:53:41 2015 +0200 cbfstool: add decompression wrappers ... and document the interface. Change-Id: I86a071a61fd6c1ef842f8ffe51f12f0cefdaf2fe Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/11362 Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Tested-by: build bot (Jenkins) See http://review.coreboot.org/11362 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: factor out parsing compression file attributes
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit a71c83fa5c3904b562bad939a3103387cd561c80 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed Aug 26 12:23:26 2015 +0200 cbfstool: factor out parsing compression file attributes cbfstool extract also needs it. Change-Id: I8302bb18c5f797eb0a43ec4e4269790f3d49a896 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/11361 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See http://review.coreboot.org/11361 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: support compressed files in cbfstool print
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit c82725c5b912a695b4582b34253029552932de69 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed Aug 26 12:13:03 2015 +0200 cbfstool: support compressed files in cbfstool print Display compressed and decompressed sizes, as well as the compression algorithm used, when a compressed file is encountered. Change-Id: I13c2332702c4a5bec379e1ebda72753e06f8e135 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/11359 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See http://review.coreboot.org/11359 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: allow compression at file header level
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit 8984a637c121d06a408a5f2b3b9d5233a7aa0e6e Author: Daisuke Nojiri <dnojiri(a)chromium.org> Date: Thu Jul 9 15:07:45 2015 -0700 cbfstool: allow compression at file header level Currently, compression is only allowed at subheader level (e.g. cbfs_stage, cbfs_payload_segment). This change adds compression field to each file's header so that any cbfs file can be compressed. With the necessary additions in coreboot and libpayload, the following sample code can load a compressed file: const char *name = "foo.bmp"; struct cbfs_file *file = cbfs_get_file(media, name); void *dst = malloc(ntohl(file->uncompressed_size)); dst = cbfs_get_file_content(media, name, type, file, dst); cbfs_stage and cbfs_payload_segment continue to support compression at subheader level because stages and payloads have to be decompressed to the load address, which is stored in the subheader. For these, file level compression should be turned off. Change-Id: I9a00ec99dfc68ffb2771bb4a3cc5ba6ba8a326f4 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Reviewed-on: http://review.coreboot.org/10935 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See http://review.coreboot.org/10935 for details. -gerrit

1 0

Patch merged into coreboot/master: cbfstool: add extended file attributes for cbfs_file
by gerrit＠coreboot.org 01 Sep '15

01 Sep '15

the following patch was just integrated into master: commit 2c61506630b8e76bed93b3a5ac0ab2089376f548 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Jul 15 20:49:00 2015 +0200 cbfstool: add extended file attributes for cbfs_file cbfs_file_first_attr(struct cbfs_file *) and cbfs_file_next_attr(struct cbfs_file *, struct cbfs_file_attribute *) help navigate through extended attributes. cbfs_add_file_attr(header, tag, size) adds a new file attribute to header. Change-Id: I325965286c44f31abd95df684d340cebb0e68b75 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Reviewed-on: http://review.coreboot.org/10934 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> See http://review.coreboot.org/10934 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2015