coreboot-gerrit August 2015

coreboot-gerrit@coreboot.org

1 participants
814 discussions

Patch set updated for coreboot: cbfstool: cbfs_add_entry() doesn't need to know filename or type
by Patrick Georgi 25 Aug '15

25 Aug '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11327 -gerrit commit 1eed6e81d519374b170d1dab9fc9b5dcb132d440 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Aug 25 13:53:42 2015 +0200 cbfstool: cbfs_add_entry() doesn't need to know filename or type They're passed as part of the header now. Change-Id: I7cd6296adac1fa72e0708b89c7009552e272f656 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/cbfstool/cbfs_image.c | 9 +++------ util/cbfstool/cbfs_image.h | 2 +- util/cbfstool/cbfstool.c | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 8297cf1..7066b99 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -532,24 +532,21 @@ static int cbfs_add_entry_at(struct cbfs_image *image, } int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, - const char *name, uint32_t type, uint32_t content_offset, + uint32_t content_offset, void *header, uint32_t header_size) { assert(image); assert(buffer); assert(buffer->data); - assert(name); - type = type; assert(!IS_TOP_ALIGNED_ADDRESS(content_offset)); + const char *name = ((struct cbfs_file *)header)->filename; + uint32_t entry_type; uint32_t addr, addr_next; struct cbfs_file *entry, *next; uint32_t need_size; - if (header_size == 0) - header_size = cbfs_calculate_file_header_size(name); - need_size = header_size + buffer->size; DEBUG("cbfs_add_entry('%s'@0x%x) => need_size = %u+%zu=%u\n", name, content_offset, header_size, buffer->size, need_size); diff --git a/util/cbfstool/cbfs_image.h b/util/cbfstool/cbfs_image.h index c1df911..02c4a2d 100644 --- a/util/cbfstool/cbfs_image.h +++ b/util/cbfstool/cbfs_image.h @@ -93,7 +93,7 @@ int cbfs_export_entry(struct cbfs_image *image, const char *entry_name, * Never pass this function a top-aligned address: convert it to an offset. * Returns 0 on success, otherwise non-zero. */ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, - const char *name, uint32_t type, uint32_t content_offset, + uint32_t content_offset, void *header, uint32_t header_size); /* Removes an entry from CBFS image. Returns 0 on success, otherwise non-zero. */ diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index cad8004..aac09b8 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -155,7 +155,7 @@ static int cbfs_add_integer_component(const char *name, header = cbfs_create_file_header(CBFS_COMPONENT_RAW, buffer.size, name); uint32_t header_size = cbfs_calculate_file_header_size(name); - if (cbfs_add_entry(&image, &buffer, name, CBFS_COMPONENT_RAW, + if (cbfs_add_entry(&image, &buffer, offset, header, header_size) != 0) { ERROR("Failed to add %llu into ROM image as '%s'.\n", (long long unsigned)u64val, name); @@ -222,7 +222,7 @@ static int cbfs_add_component(const char *filename, offset = convert_to_from_top_aligned(param.image_region, -offset); - if (cbfs_add_entry(&image, &buffer, name, type, offset, + if (cbfs_add_entry(&image, &buffer, offset, header, header_size) != 0) { ERROR("Failed to add '%s' into ROM image.\n", filename);

1 0

New patch to review for coreboot: cbfstool: passing a header is now mandatory for converters
by Patrick Georgi 25 Aug '15

25 Aug '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11330 -gerrit commit ef158379dcbd53f17d6b54375bc4518be62b7894 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Aug 25 20:17:14 2015 +0200 cbfstool: passing a header is now mandatory for converters Change-Id: Iea5377af735b06bcaefb999547a8896b1c70763a Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/cbfstool/cbfstool.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index ae75b91..feb7291 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -245,8 +245,7 @@ static int cbfstool_convert_mkstage(struct buffer *buffer, uint32_t *offset, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); - if (header) - header->len = htonl(output.size); + header->len = htonl(output.size); return 0; } @@ -277,8 +276,7 @@ static int cbfstool_convert_mkpayload(struct buffer *buffer, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); - if (header) - header->len = htonl(output.size); + header->len = htonl(output.size); return 0; } @@ -295,8 +293,7 @@ static int cbfstool_convert_mkflatpayload(struct buffer *buffer, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); - if (header) - header->len = htonl(output.size); + header->len = htonl(output.size); return 0; }

1 0

Patch set updated for coreboot: cbfstool: move cbfs_file header creation further up the call chain
by Patrick Georgi 25 Aug '15

25 Aug '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11326 -gerrit commit 361aa875a6caa721ffabc7c34293d653dbb0bbdd Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Aug 25 13:48:10 2015 +0200 cbfstool: move cbfs_file header creation further up the call chain The header is now created before the "converters" are run. Adding new capabilities (and fields to the header) will happen there, so we're close. Change-Id: I0556df724bd93816b435efff7d931293dbed918f Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/cbfstool/cbfs_image.c | 8 ++------ util/cbfstool/cbfs_image.h | 2 +- util/cbfstool/cbfstool.c | 14 +++++++++++--- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 84f4be6..8297cf1 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -533,12 +533,13 @@ static int cbfs_add_entry_at(struct cbfs_image *image, int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, const char *name, uint32_t type, uint32_t content_offset, - uint32_t header_size) + void *header, uint32_t header_size) { assert(image); assert(buffer); assert(buffer->data); assert(name); + type = type; assert(!IS_TOP_ALIGNED_ADDRESS(content_offset)); uint32_t entry_type; @@ -607,16 +608,11 @@ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, DEBUG("section 0x%x+0x%x for content_offset 0x%x.\n", addr, addr_next - addr, content_offset); - struct cbfs_file *header = - cbfs_create_file_header(type, buffer->size, name); - if (cbfs_add_entry_at(image, entry, buffer->data, content_offset, header, header_size) == 0) { - free(header); return 0; } - free(header); break; } diff --git a/util/cbfstool/cbfs_image.h b/util/cbfstool/cbfs_image.h index 432ea72..c1df911 100644 --- a/util/cbfstool/cbfs_image.h +++ b/util/cbfstool/cbfs_image.h @@ -94,7 +94,7 @@ int cbfs_export_entry(struct cbfs_image *image, const char *entry_name, * Returns 0 on success, otherwise non-zero. */ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, const char *name, uint32_t type, uint32_t content_offset, - uint32_t header_size); + void *header, uint32_t header_size); /* Removes an entry from CBFS image. Returns 0 on success, otherwise non-zero. */ int cbfs_remove_entry(struct cbfs_image *image, const char *name); diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 8672362..b01052b 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -151,8 +151,11 @@ static int cbfs_add_integer_component(const char *name, offset = convert_to_from_top_aligned(param.image_region, -offset); + struct cbfs_file *header = + cbfs_create_file_header(CBFS_COMPONENT_RAW, buffer.size, name); + uint32_t header_size = cbfs_calculate_file_header_size(name); if (cbfs_add_entry(&image, &buffer, name, CBFS_COMPONENT_RAW, - offset, 0) != 0) { + offset, header, header_size) != 0) { ERROR("Failed to add %llu into ROM image as '%s'.\n", (long long unsigned)u64val, name); goto done; @@ -202,9 +205,11 @@ static int cbfs_add_component(const char *filename, return 1; } + struct cbfs_file *header = + cbfs_create_file_header(type, buffer.size, name); uint32_t header_size = cbfs_calculate_file_header_size(name); - if (convert && convert(&buffer, &offset, NULL) != 0) { + if (convert && convert(&buffer, &offset, header) != 0) { ERROR("Failed to parse file '%s'.\n", filename); buffer_delete(&buffer); return 1; @@ -214,13 +219,16 @@ static int cbfs_add_component(const char *filename, offset = convert_to_from_top_aligned(param.image_region, -offset); - if (cbfs_add_entry(&image, &buffer, name, type, offset, header_size) + if (cbfs_add_entry(&image, &buffer, name, type, offset, + header, header_size) != 0) { ERROR("Failed to add '%s' into ROM image.\n", filename); + free(header); buffer_delete(&buffer); return 1; } + free(header); buffer_delete(&buffer); return 0; }

1 0

Patch set updated for coreboot: cbfstool: cbfs_add_entry() doesn't need to know filename or type
by Patrick Georgi 25 Aug '15

25 Aug '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11327 -gerrit commit 9baa99962f8e890cf9963056ac8a34accadde4d4 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Aug 25 13:53:42 2015 +0200 cbfstool: cbfs_add_entry() doesn't need to know filename or type They're passed as part of the header now. Change-Id: I7cd6296adac1fa72e0708b89c7009552e272f656 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/cbfstool/cbfs_image.c | 9 +++------ util/cbfstool/cbfs_image.h | 2 +- util/cbfstool/cbfstool.c | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 8297cf1..7066b99 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -532,24 +532,21 @@ static int cbfs_add_entry_at(struct cbfs_image *image, } int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, - const char *name, uint32_t type, uint32_t content_offset, + uint32_t content_offset, void *header, uint32_t header_size) { assert(image); assert(buffer); assert(buffer->data); - assert(name); - type = type; assert(!IS_TOP_ALIGNED_ADDRESS(content_offset)); + const char *name = ((struct cbfs_file *)header)->filename; + uint32_t entry_type; uint32_t addr, addr_next; struct cbfs_file *entry, *next; uint32_t need_size; - if (header_size == 0) - header_size = cbfs_calculate_file_header_size(name); - need_size = header_size + buffer->size; DEBUG("cbfs_add_entry('%s'@0x%x) => need_size = %u+%zu=%u\n", name, content_offset, header_size, buffer->size, need_size); diff --git a/util/cbfstool/cbfs_image.h b/util/cbfstool/cbfs_image.h index c1df911..02c4a2d 100644 --- a/util/cbfstool/cbfs_image.h +++ b/util/cbfstool/cbfs_image.h @@ -93,7 +93,7 @@ int cbfs_export_entry(struct cbfs_image *image, const char *entry_name, * Never pass this function a top-aligned address: convert it to an offset. * Returns 0 on success, otherwise non-zero. */ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, - const char *name, uint32_t type, uint32_t content_offset, + uint32_t content_offset, void *header, uint32_t header_size); /* Removes an entry from CBFS image. Returns 0 on success, otherwise non-zero. */ diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index b01052b..ae75b91 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -154,7 +154,7 @@ static int cbfs_add_integer_component(const char *name, struct cbfs_file *header = cbfs_create_file_header(CBFS_COMPONENT_RAW, buffer.size, name); uint32_t header_size = cbfs_calculate_file_header_size(name); - if (cbfs_add_entry(&image, &buffer, name, CBFS_COMPONENT_RAW, + if (cbfs_add_entry(&image, &buffer, offset, header, header_size) != 0) { ERROR("Failed to add %llu into ROM image as '%s'.\n", (long long unsigned)u64val, name); @@ -219,7 +219,7 @@ static int cbfs_add_component(const char *filename, offset = convert_to_from_top_aligned(param.image_region, -offset); - if (cbfs_add_entry(&image, &buffer, name, type, offset, + if (cbfs_add_entry(&image, &buffer, offset, header, header_size) != 0) { ERROR("Failed to add '%s' into ROM image.\n", filename);

1 0

Patch set updated for coreboot: cbfstool: pass cbfs_file header into "compress" functions
by Patrick Georgi 25 Aug '15

25 Aug '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11325 -gerrit commit 1173588efb92d22c155edaa1837c46e1c70aa8f8 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Aug 25 15:53:52 2015 +0200 cbfstool: pass cbfs_file header into "compress" functions These functions can do all kinds of things, such as converting an ELF image into SELF, or (in the future) compress or checksum entire files. This may require changing or adding fields to the header, so they need to have access to it. The header_size parameter that was provided (but never used) is equivalent to cbfs_file's offset field. Change-Id: I7c10ab15f3dff4412461103e9763a1d78b7be7bb Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/cbfstool/cbfstool.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index bf51956..8672362 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -116,7 +116,7 @@ static unsigned convert_to_from_top_aligned(const struct buffer *region, } typedef int (*convert_buffer_t)(struct buffer *buffer, uint32_t *offset, - uint32_t *header_size); + struct cbfs_file *header); static int cbfs_add_integer_component(const char *name, uint64_t u64val, @@ -204,7 +204,7 @@ static int cbfs_add_component(const char *filename, uint32_t header_size = cbfs_calculate_file_header_size(name); - if (convert && convert(&buffer, &offset, &header_size) != 0) { + if (convert && convert(&buffer, &offset, NULL) != 0) { ERROR("Failed to parse file '%s'.\n", filename); buffer_delete(&buffer); return 1; @@ -226,7 +226,7 @@ static int cbfs_add_component(const char *filename, } static int cbfstool_convert_mkstage(struct buffer *buffer, uint32_t *offset, - unused uint32_t *header_size) + struct cbfs_file *header) { struct buffer output; int ret; @@ -237,11 +237,13 @@ static int cbfstool_convert_mkstage(struct buffer *buffer, uint32_t *offset, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); + if (header) + header->len = htonl(output.size); return 0; } static int cbfstool_convert_mkpayload(struct buffer *buffer, - unused uint32_t *offset, unused uint32_t *header_size) + unused uint32_t *offset, struct cbfs_file *header) { struct buffer output; int ret; @@ -267,11 +269,13 @@ static int cbfstool_convert_mkpayload(struct buffer *buffer, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); + if (header) + header->len = htonl(output.size); return 0; } static int cbfstool_convert_mkflatpayload(struct buffer *buffer, - unused uint32_t *offset, unused uint32_t *header_size) + unused uint32_t *offset, struct cbfs_file *header) { struct buffer output; if (parse_flat_binary_to_payload(buffer, &output, @@ -283,6 +287,8 @@ static int cbfstool_convert_mkflatpayload(struct buffer *buffer, buffer_delete(buffer); // direct assign, no dupe. memcpy(buffer, &output, sizeof(*buffer)); + if (header) + header->len = htonl(output.size); return 0; }

1 0

New patch to review for coreboot: crossgcc: rename source file names from gcc-5.2.0/* to binutils-2.25/* in binutils riscv patches
by Jonathan A. Kollasch 25 Aug '15

25 Aug '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11329 -gerrit commit 7bad93b443fc6166cd28ff6a7e7805e0d7853768 Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Tue Aug 25 13:09:51 2015 -0500 crossgcc: rename source file names from gcc-5.2.0/* to binutils-2.25/* in binutils riscv patches Followup-To: I6f37748b4cf0852d292f8f5156fc27ab8fd481b6 Change-Id: Ib6599b2380b5f2efd92ae78b72b45f3d65681379 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- util/crossgcc/patches/binutils-2.25_riscv.patch | 32 ++++++++++++------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/util/crossgcc/patches/binutils-2.25_riscv.patch b/util/crossgcc/patches/binutils-2.25_riscv.patch index 70794fe..e4d3a9c 100644 --- a/util/crossgcc/patches/binutils-2.25_riscv.patch +++ b/util/crossgcc/patches/binutils-2.25_riscv.patch @@ -1,5 +1,5 @@ diff -urN empty/bfd/cpu-riscv.c binutils-2.25/bfd/cpu-riscv.c ---- gcc-5.2.0/bfd/cpu-riscv.c 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/bfd/cpu-riscv.c 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/bfd/cpu-riscv.c 2015-07-18 00:02:36.218287546 +0200 @@ -0,0 +1,80 @@ +/* BFD backend for RISC-V @@ -83,7 +83,7 @@ diff -urN empty/bfd/cpu-riscv.c binutils-2.25/bfd/cpu-riscv.c +const bfd_arch_info_type bfd_riscv_arch = +N (64, 64, 0, "riscv", TRUE, &arch_info_struct[0]); diff -urN empty/bfd/elfnn-riscv.c binutils-2.25/bfd/elfnn-riscv.c ---- gcc-5.2.0/bfd/elfnn-riscv.c 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/bfd/elfnn-riscv.c 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/bfd/elfnn-riscv.c 2015-07-18 00:02:36.218287546 +0200 @@ -0,0 +1,2995 @@ +/* RISC-V-specific support for NN-bit ELF. @@ -3082,7 +3082,7 @@ diff -urN empty/bfd/elfnn-riscv.c binutils-2.25/bfd/elfnn-riscv.c + +#include "elfNN-target.h" diff -urN empty/bfd/elfxx-riscv.c binutils-2.25/bfd/elfxx-riscv.c ---- gcc-5.2.0/bfd/elfxx-riscv.c 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/bfd/elfxx-riscv.c 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/bfd/elfxx-riscv.c 2015-07-18 00:02:36.218287546 +0200 @@ -0,0 +1,765 @@ +/* RISC-V-specific support for ELF. @@ -3851,7 +3851,7 @@ diff -urN empty/bfd/elfxx-riscv.c binutils-2.25/bfd/elfxx-riscv.c + return &howto_table[r_type]; +} diff -urN empty/bfd/elfxx-riscv.h binutils-2.25/bfd/elfxx-riscv.h ---- gcc-5.2.0/bfd/elfxx-riscv.h 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/bfd/elfxx-riscv.h 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/bfd/elfxx-riscv.h 2015-07-18 00:02:36.218287546 +0200 @@ -0,0 +1,34 @@ +/* RISC-V ELF specific backend routines. @@ -3889,7 +3889,7 @@ diff -urN empty/bfd/elfxx-riscv.h binutils-2.25/bfd/elfxx-riscv.h +extern reloc_howto_type * +riscv_elf_rtype_to_howto (unsigned int r_type); diff -urN empty/gas/config/tc-riscv.c binutils-2.25/gas/config/tc-riscv.c ---- gcc-5.2.0/gas/config/tc-riscv.c 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/gas/config/tc-riscv.c 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/gas/config/tc-riscv.c 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,2484 @@ +/* tc-riscv.c -- RISC-V assembler @@ -6377,7 +6377,7 @@ diff -urN empty/gas/config/tc-riscv.c binutils-2.25/gas/config/tc-riscv.c + pop_insert (riscv_pseudo_table); +} diff -urN empty/gas/config/tc-riscv.h binutils-2.25/gas/config/tc-riscv.h ---- gcc-5.2.0/gas/config/tc-riscv.h 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/gas/config/tc-riscv.h 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/gas/config/tc-riscv.h 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,102 @@ +/* tc-riscv.h -- header file for tc-riscv.c. @@ -6483,7 +6483,7 @@ diff -urN empty/gas/config/tc-riscv.h binutils-2.25/gas/config/tc-riscv.h + +#endif /* TC_RISCV */ diff -urN empty/include/elf/riscv.h binutils-2.25/include/elf/riscv.h ---- gcc-5.2.0/include/elf/riscv.h 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/include/elf/riscv.h 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/include/elf/riscv.h 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,143 @@ +/* RISC-V ELF support for BFD. @@ -6630,7 +6630,7 @@ diff -urN empty/include/elf/riscv.h binutils-2.25/include/elf/riscv.h + +#endif /* _ELF_RISCV_H */ diff -urN empty/include/opcode/riscv-opc.h binutils-2.25/include/opcode/riscv-opc.h ---- gcc-5.2.0/include/opcode/riscv-opc.h 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/include/opcode/riscv-opc.h 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/include/opcode/riscv-opc.h 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,1348 @@ +/* Automatically generated by parse-opcodes */ @@ -7982,7 +7982,7 @@ diff -urN empty/include/opcode/riscv-opc.h binutils-2.25/include/opcode/riscv-op +DECLARE_CAUSE("mtimeh", CAUSE_MTIMEH) +#endif diff -urN empty/include/opcode/riscv.h binutils-2.25/include/opcode/riscv.h ---- gcc-5.2.0/include/opcode/riscv.h 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/include/opcode/riscv.h 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/include/opcode/riscv.h 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,366 @@ +/* riscv.h. RISC-V opcode list for GDB, the GNU debugger. @@ -8352,7 +8352,7 @@ diff -urN empty/include/opcode/riscv.h binutils-2.25/include/opcode/riscv.h + +#endif /* _RISCV_H_ */ diff -urN empty/ld/emulparams/elf32lriscv-defs.sh binutils-2.25/ld/emulparams/elf32lriscv-defs.sh ---- gcc-5.2.0/ld/emulparams/elf32lriscv-defs.sh 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/ld/emulparams/elf32lriscv-defs.sh 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/ld/emulparams/elf32lriscv-defs.sh 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,39 @@ +# This is an ELF platform. @@ -8395,24 +8395,24 @@ diff -urN empty/ld/emulparams/elf32lriscv-defs.sh binutils-2.25/ld/emulparams/el + unset GOT +fi diff -urN empty/ld/emulparams/elf32lriscv.sh binutils-2.25/ld/emulparams/elf32lriscv.sh ---- gcc-5.2.0/ld/emulparams/elf32lriscv.sh 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/ld/emulparams/elf32lriscv.sh 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/ld/emulparams/elf32lriscv.sh 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,2 @@ +. ${srcdir}/emulparams/elf32lriscv-defs.sh +OUTPUT_FORMAT="elf32-littleriscv" diff -urN empty/ld/emulparams/elf64lriscv-defs.sh binutils-2.25/ld/emulparams/elf64lriscv-defs.sh ---- gcc-5.2.0/ld/emulparams/elf64lriscv-defs.sh 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/ld/emulparams/elf64lriscv-defs.sh 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/ld/emulparams/elf64lriscv-defs.sh 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1 @@ +. ${srcdir}/emulparams/elf32lriscv-defs.sh diff -urN empty/ld/emulparams/elf64lriscv.sh binutils-2.25/ld/emulparams/elf64lriscv.sh ---- gcc-5.2.0/ld/emulparams/elf64lriscv.sh 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/ld/emulparams/elf64lriscv.sh 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/ld/emulparams/elf64lriscv.sh 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,2 @@ +. ${srcdir}/emulparams/elf64lriscv-defs.sh +OUTPUT_FORMAT="elf64-littleriscv" diff -urN empty/ld/emultempl/riscvelf.em binutils-2.25/ld/emultempl/riscvelf.em ---- gcc-5.2.0/ld/emultempl/riscvelf.em 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/ld/emultempl/riscvelf.em 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/ld/emultempl/riscvelf.em 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,68 @@ +# This shell script emits a C file. -*- C -*- @@ -8484,7 +8484,7 @@ diff -urN empty/ld/emultempl/riscvelf.em binutils-2.25/ld/emultempl/riscvelf.em +LDEMUL_BEFORE_ALLOCATION=riscv_elf_before_allocation +LDEMUL_AFTER_ALLOCATION=gld${EMULATION_NAME}_after_allocation diff -urN empty/opcodes/riscv-dis.c binutils-2.25/opcodes/riscv-dis.c ---- gcc-5.2.0/opcodes/riscv-dis.c 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/opcodes/riscv-dis.c 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/opcodes/riscv-dis.c 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,590 @@ +/* RISC-V disassembler @@ -9078,7 +9078,7 @@ diff -urN empty/opcodes/riscv-dis.c binutils-2.25/opcodes/riscv-dis.c + fprintf (stream, _("\n")); +} diff -urN empty/opcodes/riscv-opc.c binutils-2.25/opcodes/riscv-opc.c ---- gcc-5.2.0/opcodes/riscv-opc.c 1970-01-01 01:00:00.000000000 +0100 +--- binutils-2.25/opcodes/riscv-opc.c 1970-01-01 01:00:00.000000000 +0100 +++ binutils-2.25/opcodes/riscv-opc.c 2015-07-18 00:02:36.222287541 +0200 @@ -0,0 +1,867 @@ +/* RISC-V opcode list

1 0

Patch merged into coreboot/master: Intel: Remove CACHE_MRC_BIN - 'selected' everywhere in Kconfig
by gerrit＠coreboot.org 25 Aug '15

25 Aug '15

the following patch was just integrated into master: commit df205067c976d917563a02fc6ebf1cff329a4097 Author: Martin Roth <martinroth(a)google.com> Date: Tue Aug 18 10:41:54 2015 -0600 Intel: Remove CACHE_MRC_BIN - 'selected' everywhere in Kconfig The Kconfig symbol CACHE_MRC_BIN was getting forced enabled everywhere it existed. Remove the Kconfig symbol and get rid of the #if statements surrounding the code. This fixes the Kconfig warning for Haswell & Broadwell chips: warning: (NORTHBRIDGE_INTEL_HASWELL && NORTHBRIDGE_INTEL_SANDYBRIDGE && NORTHBRIDGE_INTEL_SANDYBRIDGE_NATIVE && NORTHBRIDGE_INTEL_IVYBRIDGE && NORTHBRIDGE_INTEL_IVYBRIDGE_NATIVE && CPU_SPECIFIC_OPTIONS) selects CACHE_MRC_BIN which has unmet direct dependencies (CPU_INTEL_SOCKET_RPGA988B || CPU_INTEL_SOCKET_RPGA989) Change-Id: Ie0f0726e3d6f217e2cb3be73034405081ce0735a Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/11270 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11270 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Force localization of objdump to C
by gerrit＠coreboot.org 25 Aug '15

25 Aug '15

the following patch was just integrated into master: commit 1fff0d26f80c9f412a500f40b29bbbd88572febc Author: Martin Roth <martinroth(a)google.com> Date: Mon Aug 24 11:26:20 2015 -0600 xcompile: Force localization of objdump to C In testing other localization changes, I found that I couldn't build anymore because xcompile wasn't picking up my toolchain. I traced it to the regex comparison of '.*format $.[a-z0-9-]*$' to the string 'formato del fichero elf32-i386'. Forcing the localization of objdump to C before doing the comparison fixes the issue. Change-Id: I6bed5a9824807dd5bc5a38b711ab47e2af4b0c29 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/11304 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> See http://review.coreboot.org/11304 for details. -gerrit

1 0

Patch merged into coreboot/master: util/kconfig: add olddefconfig target
by gerrit＠coreboot.org 25 Aug '15

25 Aug '15

the following patch was just integrated into master: commit 56354d503d89c1e87b7b426a0ec31077b6af0e6e Author: Martin Roth <martinroth(a)google.com> Date: Tue Aug 18 14:30:27 2015 -0600 util/kconfig: add olddefconfig target There doesn't seem to have been an olddefconfig target in the coreboot version of the Kconfig makefile. It's listed in the .PHONY, but it doesn't seem like it's ever been there. This is useful for expanding a miniconfig saved with 'make savedefconfig'. Change-Id: I3798f8469135b58d32da68d4b0e434ab5351b501 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/11273 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/11273 for details. -gerrit

1 0

Patch merged into coreboot/master: x86: Get rid of empty loadable segment warning
by gerrit＠coreboot.org 25 Aug '15

25 Aug '15

the following patch was just integrated into master: commit dbb50c48f9f40f2f4d7960096f6b5462bfb3a39c Author: Martin Roth <martinroth(a)google.com> Date: Sat Aug 22 10:37:39 2015 -0600 x86: Get rid of empty loadable segment warning When the check for global symbols in romstage happens, if everything is good, a warning appears, telling us that the segment is empty. While the empty segment is good, the warning is distracting: "BFD: build/cbfs/fallback/romstage_null.debug: warning: Empty loadable segment detected, is this intentional ?" This change hides that particular warning, but shouldn't hide any other output from objcopy. Change-Id: If22489280712d02a61c3ee5e0cb2a53db87d6082 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: http://review.coreboot.org/11302 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/11302 for details. -gerrit

1 0

← Newer
1
...
35
36
37
38
39
40
41
...
82
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2015