coreboot-gerrit March 2015

coreboot-gerrit@coreboot.org

1 participants
2443 discussions

Patch set updated for coreboot: 113f39e build system: mips is a valid nickname for mipsel
by Patrick Georgi 30 Mar '15

30 Mar '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9146 -gerrit commit 113f39e0b72d3c7e4a204e700fef42c7a8d58ae3 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Sat Mar 28 15:49:46 2015 +0100 build system: mips is a valid nickname for mipsel Change-Id: I5829a96cbb0af0398113efbdf34dfa3d102bf4c8 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- util/xcompile/xcompile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index fc221b1..5809ec0 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -209,10 +209,11 @@ arch_config_x86() { } arch_config_mipsel() { - TARCH="mipsel" + TARCH="mips" TBFDARCHS="tradlittlemips littlemips" TCLIST="mipsel" TWIDTH="32" + TSUPP="mips mipsel" TABI="elf" }

1 0

Patch set updated for coreboot: 9e35688 Avoid 64bit math on MIPS platforms
by Patrick Georgi 30 Mar '15

30 Mar '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9162 -gerrit commit 9e35688d272ac80e4de9822ad7398ce6582fd580 Author: Vadim Bendebury <vbendeb(a)chromium.org> Date: Sat Nov 29 22:05:09 2014 -0800 Avoid 64bit math on MIPS platforms Low level 64 bit division and modulo functions are not available for MIPS platforms, but are required by the printk formatter. Modify the code to avoid 64 bit math when building for MIPS. In case the user does print a value exceeding 2^32, send a few junk characters to the output to indicate a corrupted value printed. [pg: add the printed sequence to the comment, so git grep can find it] BRANCH=none BUG=none TEST=startup code on Urara properly prints CBFS address values which are passed as 64 bit integers. Change-Id: Ie777019cd8d55c53d5e816fbacfe79893c3d64c7 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: 8347f914a9cceca017668f8387ba679c2c79e66d Original-Change-Id: I25b8a900b3ba4ec1da3446dcc5f03101d5cdb757 Original-Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/232294 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> --- src/console/vtxprintf.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index b515fb8..2fcefd2 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -10,6 +10,10 @@ #define call_tx(x) tx_byte(x, data) +#if !CONFIG_ARCH_MIPS +#define SUPPORT_64BIT_INTS +#endif + /* haha, don't need ctype.c */ #define isdigit(c) ((c) >= '0' && (c) <= '9') #define is_digit isdigit @@ -33,13 +37,25 @@ static int skip_atoi(const char **s) #define LARGE 64 /* use 'ABCDEF' instead of 'abcdef' */ static int number(void (*tx_byte)(unsigned char byte, void *data), - unsigned long long num, int base, int size, int precision, int type, + unsigned long long inum, int base, int size, int precision, int type, void *data) { char c,sign,tmp[66]; const char *digits="0123456789abcdefghijklmnopqrstuvwxyz"; int i; int count = 0; +#ifdef SUPPORT_64BIT_INTS + unsigned long long num = inum; +#else + unsigned long num = (long)inum; + + if (num != inum) { + /* Alert user to an incorrect result by printing #^!. */ + call_tx('#'); + call_tx('^'); + call_tx('!'); + } +#endif if (type & LARGE) digits = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";

1 0

Patch merged into coreboot/master: 3bc2999 mips: bring payload execution to current standards
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 3bc2999cb0b4c0857cd9548aba5abd6bde213282 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Mon Mar 30 14:13:23 2015 +0200 mips: bring payload execution to current standards Change-Id: Id7f438a95fc7c7b41ce3d0fb419b0b455f8367a9 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: http://review.coreboot.org/9167 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/9167 for details. -gerrit

1 0

Patch merged into coreboot/master: 6f723c2 mips: fix write_table
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 6f723c2692d72083011e45d8c6db924a49ad705e Author: Patrick Georgi <pgeorgi(a)google.com> Date: Mon Mar 30 14:06:33 2015 +0200 mips: fix write_table This replicates commit 3f7ad7b216b4021c7cb93201a94b0fae46f5e19e and commit 823edda98e6512d3f455b61549efea6fa68ee2b0 for mips. Change-Id: Id97e1fefa20cfa3bcb2cf0336b5a4ff7d9fe813b Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: http://review.coreboot.org/9166 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/9166 for details. -gerrit

1 0

Patch merged into coreboot/master: 146d05d imgtec/pistachio: Bring uart driver to modern standards
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 146d05da93c3cfdb97023ead2cb673a8d5de6b4f Author: Patrick Georgi <pgeorgi(a)google.com> Date: Mon Mar 30 13:08:18 2015 +0200 imgtec/pistachio: Bring uart driver to modern standards The console interface changed in upstream, and the driver didn't reflect that yet. This wasn't obvious because the driver wasn't compiled at all. Change-Id: Id18391e62e7ebd8f5fc929838ce27bf414e364f9 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: http://review.coreboot.org/9165 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/9165 for details. -gerrit

1 0

Patch merged into coreboot/master: 4697d09 emulation/imgvp-pistachio: Drop board
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 4697d09f1a6625e3d38ec7d92a18b3853c359fa8 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Mon Mar 30 13:29:45 2015 +0200 emulation/imgvp-pistachio: Drop board This doesn't even compile in downstream. Change-Id: Ic7b3736db86e8de155e0f37afa970ce5095396fa Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: http://review.coreboot.org/9164 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/9164 for details. -gerrit

1 0

Patch merged into coreboot/master: 6b65f0d mips: Simplify architecture specific Makefile.inc
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 6b65f0d8bd04041c24c1e9da8199c6e484192b5f Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Mon Mar 30 13:40:29 2015 +0200 mips: Simplify architecture specific Makefile.inc The mips Makefile was inherited from x86 and so included lots of stuff that is necessary on x86 but nowhere else. That cruft is now gone. It also adopts the non-x86 approach of handling linker scripts, hardcoding an include to ldoptions there, instead of manual concatenation (of just one file plus options). This is inspired by the commit listed below, but rewritten to match upstream, and split in smaller pieces to keep intent clear. Change-Id: Ibf0c7096f9425572d8f83837aa6a253fd91e212c Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Based-On-Change-Id: I50af7dacf616e0f8ff4c43f4acc679089ad7022b Based-On-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Based-On-Reviewed-on: https://chromium-review.googlesource.com/219170 Reviewed-on: http://review.coreboot.org/9163 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/9163 for details. -gerrit

1 0

Patch merged into coreboot/master: 10f86b0 build system: generalize src-to-obj
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 10f86b0bd8c294870dd3026d1dd55835303c416f Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Fri Mar 27 16:56:23 2015 +0100 build system: generalize src-to-obj It can now be used on any list of files instead of assuming to work on $($(class)-src). This is inspired by the commit listed below, but rewritten to match upstream, and split in smaller pieces to keep intent clear. Change-Id: Ib77afedd4c3f847963497beea503f5447a7c6e28 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Based-On-Change-Id: I50af7dacf616e0f8ff4c43f4acc679089ad7022b Based-On-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Based-On-Reviewed-on: https://chromium-review.googlesource.com/219170 Reviewed-on: http://review.coreboot.org/9161 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/9161 for details. -gerrit

1 0

Patch merged into coreboot/master: cbe2746 x86/smm: Move SMM configuration out of generic Makefile
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit cbe27469c1c5efe965fa830ce650fd882aebaec7 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Fri Mar 27 15:32:49 2015 +0100 x86/smm: Move SMM configuration out of generic Makefile It's x86 specific. This is inspired by the commit listed below, but rewritten to match upstream, and split in smaller pieces to keep intent clear. Change-Id: Iacb91b47c89041435dd27c2c9ad34a231adf21d2 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Based-On-Change-Id: I50af7dacf616e0f8ff4c43f4acc679089ad7022b Based-On-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Based-On-Reviewed-on: https://chromium-review.googlesource.com/219170 Reviewed-on: http://review.coreboot.org/9115 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/9115 for details. -gerrit

1 0

Patch merged into coreboot/master: 2459aee build system: provide generic compiler flag variables
by gerrit＠coreboot.org 30 Mar '15

30 Mar '15

the following patch was just integrated into master: commit 2459aeea0ba502b2d0734b8ba320b43a73d43d95 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Fri Mar 27 15:27:21 2015 +0100 build system: provide generic compiler flag variables Introduce generic-$(type)-ccopts and $(class)-generic-ccopts to declare compiler flags that apply to all files of a certain type or of a certain class. Then use them. This is inspired by the commit listed below, but rewritten to match upstream, and split in smaller pieces to keep intent clear. Change-Id: I655688e82a0cc5bad89b6f55dc217b9f66b64604 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Based-On-Change-Id: I50af7dacf616e0f8ff4c43f4acc679089ad7022b Based-On-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Based-On-Reviewed-on: https://chromium-review.googlesource.com/219170 Reviewed-on: http://review.coreboot.org/9114 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/9114 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2015