Isaac Christensen (isaac.christensen(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4552
-gerrit
commit f8779247beb69a8e6c6519074c866ca69f6c8e00
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Dec 21 21:39:37 2013 +0100
libpayload: Add ARM defconfig
make junit.xml tries to build it, but fails
(ARM port doesn't seem to be ready?)
Useful test case to demonstrate a failing
libpayload build.
Change-Id: Iba4fe551b48f631e6a3bd90eb07930fc70761332
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
payloads/libpayload/configs/defconfig-arm | 72 +++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/payloads/libpayload/configs/defconfig-arm b/payloads/libpayload/configs/defconfig-arm
new file mode 100644
index 0000000..55552b0
--- /dev/null
+++ b/payloads/libpayload/configs/defconfig-arm
@@ -0,0 +1,72 @@
+#
+# Automatically generated make config: don't edit
+# libpayload version: 0.2.0
+# Thu Aug 14 20:38:59 2014
+#
+
+#
+# Generic Options
+#
+# CONFIG_LP_EXPERIMENTAL is not set
+# CONFIG_LP_OBSOLETE is not set
+# CONFIG_LP_DEVELOPER is not set
+# CONFIG_LP_CHROMEOS is not set
+
+#
+# Architecture Options
+#
+CONFIG_LP_ARCH_ARMV7=y
+# CONFIG_LP_ARCH_X86 is not set
+# CONFIG_LP_MEMMAP_RAM_ONLY is not set
+
+#
+# Standard Libraries
+#
+CONFIG_LP_LIBC=y
+CONFIG_LP_CURSES=y
+CONFIG_LP_TINYCURSES=y
+# CONFIG_LP_PDCURSES is not set
+CONFIG_LP_CBFS=y
+CONFIG_LP_LZMA=y
+
+#
+# Console Options
+#
+# CONFIG_LP_SKIP_CONSOLE_INIT is not set
+CONFIG_LP_CBMEM_CONSOLE=y
+CONFIG_LP_SERIAL_CONSOLE=y
+# CONFIG_LP_SERIAL_SET_SPEED is not set
+# CONFIG_LP_SERIAL_ACS_FALLBACK is not set
+CONFIG_LP_VIDEO_CONSOLE=y
+# CONFIG_LP_COREBOOT_VIDEO_CONSOLE is not set
+CONFIG_LP_PC_KEYBOARD=y
+CONFIG_LP_PC_KEYBOARD_LAYOUT_US=y
+# CONFIG_LP_PC_KEYBOARD_LAYOUT_DE is not set
+
+#
+# Drivers
+#
+# CONFIG_LP_RTC_PORT_EXTENDED_VIA is not set
+CONFIG_LP_STORAGE=y
+# CONFIG_LP_STORAGE_64BIT_LBA is not set
+CONFIG_LP_STORAGE_ATA=y
+CONFIG_LP_STORAGE_ATAPI=y
+CONFIG_LP_USB=y
+CONFIG_LP_USB_OHCI=y
+CONFIG_LP_USB_EHCI=y
+CONFIG_LP_USB_XHCI=y
+CONFIG_LP_USB_HID=y
+CONFIG_LP_USB_HUB=y
+CONFIG_LP_USB_MSC=y
+CONFIG_LP_USB_GEN_HUB=y
+# CONFIG_LP_USB_PCI is not set
+CONFIG_LP_USB_MEMORY=y
+CONFIG_LP_USB_OHCI_BASE_ADDRESS=0x12120000
+CONFIG_LP_USB_EHCI_BASE_ADDRESS=0x12110000
+CONFIG_LP_USB_XHCI_BASE_ADDRESS=0x12000000
+# CONFIG_LP_BIG_ENDIAN is not set
+CONFIG_LP_LITTLE_ENDIAN=y
+# CONFIG_LP_IO_ADDRESS_SPACE is not set
+CONFIG_LP_ARCH_SPECIFIC_OPTIONS=y
+CONFIG_LP_COREBOOT_INFO_RANGE_BASE=0x10
+CONFIG_LP_COREBOOT_INFO_RANGE_SIZE=0x4000000
Isaac Christensen (isaac.christensen(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6668
-gerrit
commit 3e850587757c6628cbf2a7afb92515bc7f197a9d
Author: Isaac Christensen <isaac.christensen(a)se-eng.com>
Date: Thu Aug 14 13:08:29 2014 -0600
libpayload: add march flag for armv7
The cache functions for armv7 require 'march=armv7-a' to use
the 'isb' and 'dsb' instructions.
Change-Id: I3b7ad8fc7da8c3167b38fd1a325090fe49e4ca42
Signed-off-by: Isaac Christensen <isaac.christensen(a)se-eng.com>
---
payloads/libpayload/arch/armv7/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/arch/armv7/Makefile.inc b/payloads/libpayload/arch/armv7/Makefile.inc
index cd909bb..42d6ed2 100644
--- a/payloads/libpayload/arch/armv7/Makefile.inc
+++ b/payloads/libpayload/arch/armv7/Makefile.inc
@@ -27,7 +27,7 @@
## SUCH DAMAGE.
##
-CFLAGS += -ffixed-r8 -mfloat-abi=hard -marm -mabi=aapcs-linux
+CFLAGS += -ffixed-r8 -mfloat-abi=hard -marm -mabi=aapcs-linux -march=armv7-a
head.o-y += head.S
libc-y += main.c sysinfo.c
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4552
-gerrit
commit 2053277eb0b4d7860732815a393fcec15db565fc
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Dec 21 21:39:37 2013 +0100
libpayload: Add ARM defconfig
make junit.xml tries to build it, but fails
(ARM port doesn't seem to be ready?)
Useful test case to demonstrate a failing
libpayload build.
Change-Id: Iba4fe551b48f631e6a3bd90eb07930fc70761332
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
payloads/libpayload/configs/defconfig-arm | 72 +++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/payloads/libpayload/configs/defconfig-arm b/payloads/libpayload/configs/defconfig-arm
new file mode 100644
index 0000000..55552b0
--- /dev/null
+++ b/payloads/libpayload/configs/defconfig-arm
@@ -0,0 +1,72 @@
+#
+# Automatically generated make config: don't edit
+# libpayload version: 0.2.0
+# Thu Aug 14 20:38:59 2014
+#
+
+#
+# Generic Options
+#
+# CONFIG_LP_EXPERIMENTAL is not set
+# CONFIG_LP_OBSOLETE is not set
+# CONFIG_LP_DEVELOPER is not set
+# CONFIG_LP_CHROMEOS is not set
+
+#
+# Architecture Options
+#
+CONFIG_LP_ARCH_ARMV7=y
+# CONFIG_LP_ARCH_X86 is not set
+# CONFIG_LP_MEMMAP_RAM_ONLY is not set
+
+#
+# Standard Libraries
+#
+CONFIG_LP_LIBC=y
+CONFIG_LP_CURSES=y
+CONFIG_LP_TINYCURSES=y
+# CONFIG_LP_PDCURSES is not set
+CONFIG_LP_CBFS=y
+CONFIG_LP_LZMA=y
+
+#
+# Console Options
+#
+# CONFIG_LP_SKIP_CONSOLE_INIT is not set
+CONFIG_LP_CBMEM_CONSOLE=y
+CONFIG_LP_SERIAL_CONSOLE=y
+# CONFIG_LP_SERIAL_SET_SPEED is not set
+# CONFIG_LP_SERIAL_ACS_FALLBACK is not set
+CONFIG_LP_VIDEO_CONSOLE=y
+# CONFIG_LP_COREBOOT_VIDEO_CONSOLE is not set
+CONFIG_LP_PC_KEYBOARD=y
+CONFIG_LP_PC_KEYBOARD_LAYOUT_US=y
+# CONFIG_LP_PC_KEYBOARD_LAYOUT_DE is not set
+
+#
+# Drivers
+#
+# CONFIG_LP_RTC_PORT_EXTENDED_VIA is not set
+CONFIG_LP_STORAGE=y
+# CONFIG_LP_STORAGE_64BIT_LBA is not set
+CONFIG_LP_STORAGE_ATA=y
+CONFIG_LP_STORAGE_ATAPI=y
+CONFIG_LP_USB=y
+CONFIG_LP_USB_OHCI=y
+CONFIG_LP_USB_EHCI=y
+CONFIG_LP_USB_XHCI=y
+CONFIG_LP_USB_HID=y
+CONFIG_LP_USB_HUB=y
+CONFIG_LP_USB_MSC=y
+CONFIG_LP_USB_GEN_HUB=y
+# CONFIG_LP_USB_PCI is not set
+CONFIG_LP_USB_MEMORY=y
+CONFIG_LP_USB_OHCI_BASE_ADDRESS=0x12120000
+CONFIG_LP_USB_EHCI_BASE_ADDRESS=0x12110000
+CONFIG_LP_USB_XHCI_BASE_ADDRESS=0x12000000
+# CONFIG_LP_BIG_ENDIAN is not set
+CONFIG_LP_LITTLE_ENDIAN=y
+# CONFIG_LP_IO_ADDRESS_SPACE is not set
+CONFIG_LP_ARCH_SPECIFIC_OPTIONS=y
+CONFIG_LP_COREBOOT_INFO_RANGE_BASE=0x10
+CONFIG_LP_COREBOOT_INFO_RANGE_SIZE=0x4000000
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4552
-gerrit
commit 971abc3a4d58219fda3c173d15d98a0cb6653bf1
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Dec 21 21:39:37 2013 +0100
libpayload: Add ARM defconfig
make junit.xml tries to build it, but fails
(ARM port doesn't seem to be ready?)
Useful test case to demonstrate a failing
libpayload build.
Change-Id: Iba4fe551b48f631e6a3bd90eb07930fc70761332
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
payloads/libpayload/configs/defconfig-arm | 72 +++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/payloads/libpayload/configs/defconfig-arm b/payloads/libpayload/configs/defconfig-arm
new file mode 100644
index 0000000..55552b0
--- /dev/null
+++ b/payloads/libpayload/configs/defconfig-arm
@@ -0,0 +1,72 @@
+#
+# Automatically generated make config: don't edit
+# libpayload version: 0.2.0
+# Thu Aug 14 20:38:59 2014
+#
+
+#
+# Generic Options
+#
+# CONFIG_LP_EXPERIMENTAL is not set
+# CONFIG_LP_OBSOLETE is not set
+# CONFIG_LP_DEVELOPER is not set
+# CONFIG_LP_CHROMEOS is not set
+
+#
+# Architecture Options
+#
+CONFIG_LP_ARCH_ARMV7=y
+# CONFIG_LP_ARCH_X86 is not set
+# CONFIG_LP_MEMMAP_RAM_ONLY is not set
+
+#
+# Standard Libraries
+#
+CONFIG_LP_LIBC=y
+CONFIG_LP_CURSES=y
+CONFIG_LP_TINYCURSES=y
+# CONFIG_LP_PDCURSES is not set
+CONFIG_LP_CBFS=y
+CONFIG_LP_LZMA=y
+
+#
+# Console Options
+#
+# CONFIG_LP_SKIP_CONSOLE_INIT is not set
+CONFIG_LP_CBMEM_CONSOLE=y
+CONFIG_LP_SERIAL_CONSOLE=y
+# CONFIG_LP_SERIAL_SET_SPEED is not set
+# CONFIG_LP_SERIAL_ACS_FALLBACK is not set
+CONFIG_LP_VIDEO_CONSOLE=y
+# CONFIG_LP_COREBOOT_VIDEO_CONSOLE is not set
+CONFIG_LP_PC_KEYBOARD=y
+CONFIG_LP_PC_KEYBOARD_LAYOUT_US=y
+# CONFIG_LP_PC_KEYBOARD_LAYOUT_DE is not set
+
+#
+# Drivers
+#
+# CONFIG_LP_RTC_PORT_EXTENDED_VIA is not set
+CONFIG_LP_STORAGE=y
+# CONFIG_LP_STORAGE_64BIT_LBA is not set
+CONFIG_LP_STORAGE_ATA=y
+CONFIG_LP_STORAGE_ATAPI=y
+CONFIG_LP_USB=y
+CONFIG_LP_USB_OHCI=y
+CONFIG_LP_USB_EHCI=y
+CONFIG_LP_USB_XHCI=y
+CONFIG_LP_USB_HID=y
+CONFIG_LP_USB_HUB=y
+CONFIG_LP_USB_MSC=y
+CONFIG_LP_USB_GEN_HUB=y
+# CONFIG_LP_USB_PCI is not set
+CONFIG_LP_USB_MEMORY=y
+CONFIG_LP_USB_OHCI_BASE_ADDRESS=0x12120000
+CONFIG_LP_USB_EHCI_BASE_ADDRESS=0x12110000
+CONFIG_LP_USB_XHCI_BASE_ADDRESS=0x12000000
+# CONFIG_LP_BIG_ENDIAN is not set
+CONFIG_LP_LITTLE_ENDIAN=y
+# CONFIG_LP_IO_ADDRESS_SPACE is not set
+CONFIG_LP_ARCH_SPECIFIC_OPTIONS=y
+CONFIG_LP_COREBOOT_INFO_RANGE_BASE=0x10
+CONFIG_LP_COREBOOT_INFO_RANGE_SIZE=0x4000000
Isaac Christensen (isaac.christensen(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6665
-gerrit
commit 108370ba6019904b832e88da3e0cb079ba192e1b
Author: Isaac Christensen <isaac.christensen(a)se-eng.com>
Date: Thu Aug 14 12:23:24 2014 -0600
libpayload: change cb_range to lb_range
Patch 'coreboot_tables: reduce redundant data structures' (1f5487a)
added a new lb_range structure to coreboot and libpayload but the
original chromium patch added cb_range to libpayload instead. A followup
patch 'arm: libpayload: Add cache coherent DMA memory definition
and management' (b8fad3d) used the incorrect cb_range structure but
this wasn't caught since the current verification build doesn't
build libpayload for arm.
Change-Id: I7cedc66a4794bf4daa214f54be6e917f96418ff6
Signed-off-by: Isaac Christensen <isaac.christensen(a)se-eng.com>
---
payloads/libpayload/arch/armv7/coreboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/arch/armv7/coreboot.c b/payloads/libpayload/arch/armv7/coreboot.c
index e16c354..1397fc1 100644
--- a/payloads/libpayload/arch/armv7/coreboot.c
+++ b/payloads/libpayload/arch/armv7/coreboot.c
@@ -110,7 +110,7 @@ static void cb_parse_vdat(unsigned char *ptr, struct sysinfo_t *info)
static void cb_parse_dma(unsigned char *ptr)
{
- struct cb_range *dma = (struct cb_range *)ptr;
+ struct lb_range *dma = (struct lb_range *)ptr;
init_dma_memory(phys_to_virt(dma->range_start), dma->range_size);
}