Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6436
-gerrit
commit d71f496949bd4c4d16367819b958f19f17e67b35
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Fri Aug 1 20:30:21 2014 +1000
lenovo/t530: Be safe by disabling blink gpio hw with a writeout
This disables the blink hardware as it seems to be in the dump. This is
safer as it does not rely on 0 as the reset value when '0x00040000' is
the default according to the util/inteltool. As seen:
gpiobase+0x0018: 0x00040000 (GPO_BLINK) DIFF
Change-Id: Ia1fde108bf3752484f5e991600c435f776af0ced
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/mainboard/lenovo/t530/romstage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mainboard/lenovo/t530/romstage.c b/src/mainboard/lenovo/t530/romstage.c
index 3be1869..abad272 100644
--- a/src/mainboard/lenovo/t530/romstage.c
+++ b/src/mainboard/lenovo/t530/romstage.c
@@ -186,6 +186,7 @@ void main(unsigned long bist)
outl(0x3962a5ff, DEFAULT_GPIOBASE + GPIO_USE_SEL);
outl(0x8ebf6aff, DEFAULT_GPIOBASE + GP_IO_SEL);
outl(0x66917ebb, DEFAULT_GPIOBASE + GP_LVL);
+ outl(0x00000000, DEFAULT_GPIOBASE + GPO_BLINK);
outl(0x00002002, DEFAULT_GPIOBASE + GPI_INV);
outl(0x02ff08fe, DEFAULT_GPIOBASE + GPIO_USE_SEL2);
outl(0x1f47f7fd, DEFAULT_GPIOBASE + GP_IO_SEL2);
the following patch was just integrated into master:
commit 6ccc3465c3488411e6e743bb9a2822ac5902b6df
Author: Nicolas Reinecke <nr(a)das-labor.org>
Date: Sat Aug 23 01:06:33 2014 +0200
lenovo/t520: fix devicetree
SATA Port documentation
PCIe unused ports and documentation
T520 have no keyboard backlight
Change-Id: I517ff8519ea22a9a7a9b6e3136efd15d4a0f8fc4
Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org>
Reviewed-on: http://review.coreboot.org/6743
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
See http://review.coreboot.org/6743 for details.
-gerrit
Nicolas Reinecke (nr(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6743
-gerrit
commit c30f0cbb0a3e89e19902d721d7262d1312e06b4f
Author: Nicolas Reinecke <nr(a)das-labor.org>
Date: Sat Aug 23 01:06:33 2014 +0200
lenovo/t520: fix devicetree
SATA Port documentation
PCIe unused ports and documentation
T520 have no keyboard backlight
Change-Id: I517ff8519ea22a9a7a9b6e3136efd15d4a0f8fc4
Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org>
---
src/mainboard/lenovo/t520/devicetree.cb | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb
index 475e49c..c911d99 100644
--- a/src/mainboard/lenovo/t520/devicetree.cb
+++ b/src/mainboard/lenovo/t520/devicetree.cb
@@ -34,6 +34,7 @@ chip northbridge/intel/sandybridge
device domain 0 on
device pci 00.0 on end # host bridge
+ device pci 01.0 on end # NVIDIA Corporation GF119M [NVS 4200M]
device pci 02.0 on end # vga controller
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH
@@ -54,7 +55,7 @@ chip northbridge/intel/sandybridge
register "gpi1_routing" = "2"
register "gpi8_routing" = "2"
- # Enable SATA ports 0
+ # Enable SATA ports 0 (HDD bay) & 1 (ODD bay) & 2 (mSATA) & 3 (eSATA) & 4 (dock)
register "sata_port_map" = "0x1f"
# Set max SATA speed to 6.0 Gb/s
register "sata_interface_speed_support" = "0x3"
@@ -73,11 +74,14 @@ chip northbridge/intel/sandybridge
device pci 19.0 on end # Intel Gigabit Ethernet
device pci 1a.0 on end # USB2 EHCI #2
device pci 1b.0 on end # High Definition Audio
- device pci 1c.0 on end # PCIe Port #1
+ device pci 1c.0 off end # PCIe Port #1
device pci 1c.1 on end # PCIe Port #2 Integrated Wireless LAN
- device pci 1c.2 off end
- device pci 1c.3 on end # PCIe Port #3 Express Card
- device pci 1c.4 on end # PCIe Port #4 MMC/SDXC + IEEE1394
+ device pci 1c.2 off end # PCIe Port #3
+ device pci 1c.3 on end # PCIe Port #4 Express Card
+ device pci 1c.4 on end # PCIe Port #5 MMC/SDXC + IEEE1394
+ device pci 1c.5 off end # PCIe Port #6 Intel Ethernet PHY
+ device pci 1c.6 off end # PCIe Port #7 USB 3.0 only W520
+ device pci 1c.7 off end # PCIe Port #8
device pci 1d.0 on end # USB2 EHCI #1
device pci 1f.0 on #LPC bridge
chip ec/lenovo/pmh7
@@ -100,8 +104,6 @@ chip northbridge/intel/sandybridge
register "config2" = "0xa0"
register "config3" = "0xc2"
- register "has_keyboard_backlight" = "1"
-
register "beepmask0" = "0x00"
register "beepmask1" = "0x86"
register "has_power_management_beeps" = "0"
the following patch was just integrated into master:
commit 23aad4a83c3390dc39f7d1c1f5422f7ac54a80f3
Author: Nicolas Reinecke <nr(a)das-labor.org>
Date: Sat Aug 23 00:51:49 2014 +0200
lenovo/t520: fix usb config & documentation
Change-Id: I71398ab2d7ef5b9256795861dd2bebbb0cf32d5f
Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org>
Reviewed-on: http://review.coreboot.org/6742
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
See http://review.coreboot.org/6742 for details.
-gerrit
the following patch was just integrated into master:
commit e4340b52ced8bddc796d15cce4c1a154c98dcabd
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Fri Aug 15 15:58:36 2014 +0200
ec/lenovo/h8/acpi/systemstatus.asl: Fix typo in o*n* in comment
Change-Id: I655536f64faaa7e1600d4fec62ba80730e2cc45a
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/6674
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
See http://review.coreboot.org/6674 for details.
-gerrit