the following patch was just integrated into master:
commit ee16872921876c9fe0d295a96843c61e71caa942
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Jan 15 22:04:12 2014 +0100
libpayload/lpgcc: Add curses include path.
Without it payloads that need curses fail to build.
Change-Id: I4533238b547e4c2d9e0778fb7d314db35a9559df
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
See http://review.coreboot.org/4689 for details.
-gerrit
Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4692
-gerrit
commit f3af12a04c291dff30d93a481e8cde8d875db27a
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Jan 15 22:07:52 2014 +0100
nvramcui: Trim values when setting.
Values get space-padded by curses and then enum search fails to match them.
Rtrim to compensate for curses.
Change-Id: Iecf095f21cfade9425eaa039b67625615eb80481
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
payloads/nvramcui/nvramcui.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c
index 04367cd..daf153b 100644
--- a/payloads/nvramcui/nvramcui.c
+++ b/payloads/nvramcui/nvramcui.c
@@ -232,6 +232,10 @@ int main()
for (i = 0; i < numopts; i++) {
char *name = field_buffer(fields[2*i], 0);
char *value = field_buffer(fields[2*i+1], 0);
+ char *ptr;
+ for (ptr = value + strlen (value) - 1;
+ ptr >= value && *ptr == ' '; ptr--);
+ ptr[1] = '\0';
set_option_from_string(use_nvram, opttbl, value, name);
}
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4748
-gerrit
commit be996dee1a9667245a8bbf51c940f3186e1fd33c
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sun Jan 19 14:44:04 2014 +0100
boardstatus: Do not error out on unknown CPU/northbridge
On bot, stderr is unmonitored, so it make no sense to stop with an error.
Instead use some sensible guesses.
Change-Id: I6292e9fbf446b751471b95f86e7515c6680bddf3
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
util/board_status/to-wiki/towiki.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh
index c174527..fd0dcf0 100755
--- a/util/board_status/to-wiki/towiki.sh
+++ b/util/board_status/to-wiki/towiki.sh
@@ -317,8 +317,8 @@ EOF
cpu_nice="Intel® 2nd Gen (Sandybridge) Core i3/i5/i7"
socket_nice="Socket RPGA989";;
*)
- echo "unknown northbridge $northbridge" >&2;
- exit 1;;
+ cpu_nice="$northbridge"
+ socket_nice="$northbridge";;
esac
;;
INTEL_SOCKET_441)
@@ -366,13 +366,13 @@ EOF
cpu_nice="?"
socket_nice="?";;
*)
- echo "unknown northbridge $northbridge ($vendor/$board)" >&2;
- exit 1;;
+ cpu_nice="$northbridge"
+ socket_nice="$northbridge";;
esac
;;
*)
- echo "unknown CPU $cpu" >&2;
- exit 1;;
+ cpu_nice="$cpu"
+ socket_nice="$cpu";;
esac
echo "|- bgcolor=\"#$color\""
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4693
-gerrit
commit 34d441f1a8cedb7fb5446161559fe477c5497f4f
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Jan 15 22:09:25 2014 +0100
nvramcui: reboot at the end as TODO suggests
Use cf9 to reboot at the end.
Change-Id: I642a5ec89c864fb03bbcdf6e4fcbb1e28f3fc34c
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
payloads/nvramcui/nvramcui.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c
index daf153b..f0496c6 100644
--- a/payloads/nvramcui/nvramcui.c
+++ b/payloads/nvramcui/nvramcui.c
@@ -245,7 +245,8 @@ int main()
refresh();
endwin();
- /* TODO: reboot */
+ /* reboot */
+ outb (0x6, 0xcf9);
halt();
}
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4692
-gerrit
commit 15192cefd0b6250f4077a0868aeca4b1adf39081
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Jan 15 22:07:52 2014 +0100
nvramcui: Trim values when setting.
Values get space-padded by curses and then enum search fails to match them.
Rtrim to compensat for curses.
Change-Id: Iecf095f21cfade9425eaa039b67625615eb80481
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
payloads/nvramcui/nvramcui.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c
index 04367cd..daf153b 100644
--- a/payloads/nvramcui/nvramcui.c
+++ b/payloads/nvramcui/nvramcui.c
@@ -232,6 +232,10 @@ int main()
for (i = 0; i < numopts; i++) {
char *name = field_buffer(fields[2*i], 0);
char *value = field_buffer(fields[2*i+1], 0);
+ char *ptr;
+ for (ptr = value + strlen (value) - 1;
+ ptr >= value && *ptr == ' '; ptr--);
+ ptr[1] = '\0';
set_option_from_string(use_nvram, opttbl, value, name);
}