Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4563
-gerrit
commit 637a6ff12ed827756825d858427469093cb7027a
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Sun Dec 22 18:51:29 2013 -0500
cpu/allwinner/a10: Clarify the usage of SRAM during bootblock
We have 32KiB of usable SRAM right when we boot. The first 24KiB can
be loaded with our bootblock, while the other 8KiB can be used as
stack during the bootblock stage.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Change-Id: I48d3a37869031c3c1dbc1fab71204d473d64deeb
---
src/cpu/allwinner/a10/Kconfig | 10 +++++++---
src/cpu/allwinner/a10/Makefile.inc | 15 ++++++++-------
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/src/cpu/allwinner/a10/Kconfig b/src/cpu/allwinner/a10/Kconfig
index 639108a..3df1ceb 100644
--- a/src/cpu/allwinner/a10/Kconfig
+++ b/src/cpu/allwinner/a10/Kconfig
@@ -42,18 +42,22 @@ config ROMSTAGE_BASE
hex
default SYS_SDRAM_BASE
-# Keep the stack in SRAM
+# Keep the stack in SRAM block A2.
+# SRAM blocks A1 (0-16KiB) and A2 (16KiB-32KiB) are always accessible to the
+# CPU. This gives us 32KiB of SRAM to boot with. The BROM bootloader will use up
+# to 24KiB to load our bootblock, which leaves us the area from 24KiB to 32KiB
+# to use however we see fit.
config STACK_TOP
hex
default 0x00008000
config STACK_BOTTOM
hex
- default 0x00004000
+ default 0x00006000
config STACK_SIZE
hex
- default 0x00004000
+ default 0x00002000
## TODO Change this to some better address not overlapping bootblock when
## cbfstool supports creating header in arbitrary location.
diff --git a/src/cpu/allwinner/a10/Makefile.inc b/src/cpu/allwinner/a10/Makefile.inc
index 48f3110..9f7208a 100644
--- a/src/cpu/allwinner/a10/Makefile.inc
+++ b/src/cpu/allwinner/a10/Makefile.inc
@@ -21,15 +21,16 @@ get_bootblock_size= \
sed 's/[^0-9 ]//g')) \
$(shell echo $$(($(word 2, $(strip $(bb_s))))))
-# The boot ROM in the SoC will start loading code if a special boot0 header is
+# The boot ROM in the SoC will start loading code if a special BOOT0 header is
# found (at an offset of 8KiB in either NAND or SD), and the checksum is
-# correct. this header is normally added by the 'mxsunxiboot' tool. The file
-# passed to mksunxiboot should only include the bootblock due to size
-# limitations.
-# FIXME: Figure out how to safely integrate in coreboot.rom. For now, only copy
-# the first 15 KiB of coreboot.rom (This will not collide with stack)
+# correct. This header is normally added by the 'mxsunxiboot' tool. The boot ROM
+# will load at most 24KiB of data to SRAM, so limit the file size accordingly.
+# The BOOT0 header takes 32 bytes, so limit our file to 24KiB - 32 bytes.
+# FIXME: Figure out how to safely integrate in coreboot.rom.
+# FIXME: The file passed to mksunxiboot should only include the bootblock due
+# to size limitations.
$(obj)/BOOT0: $(obj)/coreboot.rom
@printf " BOOT0 $(subst $(obj)/,,$(^))\n"
touch $@
- dd if=$^ of=$^.tmp bs=1024 count=15
+ dd if=$^ of=$^.tmp bs=24544 count=1
-mksunxiboot $^.tmp $@
Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4565
-gerrit
commit c4601a822ea12681688f45840b03da6b52289368
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Sun Dec 22 21:30:21 2013 -0500
cpu/allwinner/a10: Refactor and document pinmux API
Include a function to multiplex more than one pin at a time. This
is useful for peripherals that have the same function number for
all their pins.
Since we now have two functions for muxing pins, also document
them.
Change-Id: I53997cc3a2586e3cf749cd672f69fb427659c67f
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
---
src/cpu/allwinner/a10/gpio.h | 3 +-
src/cpu/allwinner/a10/pinmux.c | 51 +++++++++++++++++++++++++-
src/mainboard/cubietech/cubieboard/bootblock.c | 7 ++--
3 files changed, 55 insertions(+), 6 deletions(-)
diff --git a/src/cpu/allwinner/a10/gpio.h b/src/cpu/allwinner/a10/gpio.h
index f285451..709f74b 100644
--- a/src/cpu/allwinner/a10/gpio.h
+++ b/src/cpu/allwinner/a10/gpio.h
@@ -46,6 +46,7 @@ struct a10_gpio {
u32 sdr_pad_pul;
} __attribute__ ((packed));
-void gpio_set_func(u8 port, u8 pin, u8 pad_func);
+void gpio_set_pin_func(u8 port, u8 pin, u8 pad_func);
+void gpio_set_multipin_func(u8 port, u32 pin_mask, u8 pad_func);
#endif /* __CPU_ALLWINNER_A10_PINMUX_H */
diff --git a/src/cpu/allwinner/a10/pinmux.c b/src/cpu/allwinner/a10/pinmux.c
index 2525de5..de87440 100644
--- a/src/cpu/allwinner/a10/pinmux.c
+++ b/src/cpu/allwinner/a10/pinmux.c
@@ -11,7 +11,14 @@
static struct a10_gpio *const gpio = (void *)GPIO_BASE;
-void gpio_set_func(u8 port, u8 pin, u8 pad_func)
+/**
+ * \brief Set the pad function of a single pin
+ *
+ * @param[in] port GPIO port of the pin (GPA -> GPS)
+ * @param[in] pin the pin number in the given port (1 -> 31)
+ * @param[in] pad_func The peripheral function to which to connect this pin
+ */
+void gpio_set_pin_func(u8 port, u8 pin, u8 pad_func)
{
u8 reg, bit;
u32 reg32;
@@ -28,3 +35,45 @@ void gpio_set_func(u8 port, u8 pin, u8 pad_func)
reg32 |= (pad_func & 0xf) << bit;
write32(reg32, &gpio->port[port].cfg[reg]);
}
+
+/**
+ * \brief Set the pad function of a group of pins
+ *
+ * Multiplex a group of pins to the same pad function. This is useful for
+ * peripherals that use the same function number for several pins. This function
+ * allows those pins to be set with a single call.
+ *
+ * Example:
+ * gpio_set_multipin_func(GPB, (1 << 23) | (1 << 22), 2);
+ *
+ * @param[in] port GPIO port of the pin (GPA -> GPS)
+ * @param[in] pin_mask 32-bit mask indicating which pins to re-multiplex. For
+ * each set bit, the corresponding pin will be multiplexed.
+ * @param[in] pad_func The peripheral function to which to connect the pins
+ */
+void gpio_set_multipin_func(u8 port, u32 pin_mask, u8 pad_func)
+{
+ int j;
+ u8 reg, bit;
+ u32 reg32, mask_offset;
+
+ if ((port > GPS))
+ return;
+
+ for (reg = 0; reg < 4; reg++) {
+ mask_offset = 8 * reg;
+ /* Don't run the inner loop if we're not touching any pins */
+ if (!(pin_mask & (0xff << mask_offset)))
+ continue;
+
+ reg32 = read32(&gpio->port[port].cfg[reg]);
+ for (j = 0; j < 8; j++) {
+ if (!(pin_mask & (1 << (j + mask_offset))))
+ continue;
+ bit = j * 4;
+ reg32 &= ~(0xf << bit);
+ reg32 |= (pad_func & 0xf) << bit;
+ }
+ write32(reg32, &gpio->port[port].cfg[reg]);
+ }
+}
diff --git a/src/mainboard/cubietech/cubieboard/bootblock.c b/src/mainboard/cubietech/cubieboard/bootblock.c
index 6e8b751..a91391c 100644
--- a/src/mainboard/cubietech/cubieboard/bootblock.c
+++ b/src/mainboard/cubietech/cubieboard/bootblock.c
@@ -18,8 +18,8 @@
| AHB_DIV_1 \
| AXI_DIV_1
-#define GPB22_UART0_TX_FUNC 2
-#define GPB23_UART0_RX_FUNC 2
+#define GPB_UART0_FUNC 2
+#define GPB_UART0_PINS ((1 << 22) | (1 << 23))
static void cubieboard_set_sys_clock(void)
{
@@ -57,8 +57,7 @@ static void cubieboard_setup_clocks(void)
static void cubieboard_setup_gpios(void)
{
/* Mux UART pins */
- gpio_set_func(GPB, 22, GPB22_UART0_TX_FUNC);
- gpio_set_func(GPB, 23, GPB23_UART0_RX_FUNC);
+ gpio_set_multipin_func(GPB, GPB_UART0_PINS, GPB_UART0_FUNC);
}
static void cubieboard_enable_uart(void)
Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4563
-gerrit
commit e606b4b0d25175dced10521ec8e1e52c54b3ce6e
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Sun Dec 22 18:51:29 2013 -0500
cpu/allwinner/a10: Clear the usage of SRAM during the bootblock
We have 32KiB of usable SRAM right when we boot. The first 24KiB can
be loaded with our bootblock, while the other 8KiB can be used as
stack during the bootblock stage.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Change-Id: I48d3a37869031c3c1dbc1fab71204d473d64deeb
---
src/cpu/allwinner/a10/Kconfig | 10 +++++++---
src/cpu/allwinner/a10/Makefile.inc | 15 ++++++++-------
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/src/cpu/allwinner/a10/Kconfig b/src/cpu/allwinner/a10/Kconfig
index 915578a..fcb1049 100644
--- a/src/cpu/allwinner/a10/Kconfig
+++ b/src/cpu/allwinner/a10/Kconfig
@@ -41,18 +41,22 @@ config ROMSTAGE_BASE
hex
default SYS_SDRAM_BASE
-# Keep the stack in SRAM
+# Keep the stack in SRAM block A2.
+# SRAM blocks A1 (0-16KiB) and A2 (16KiB-32KiB) are always accessible to the
+# CPU. This gives us 32KiB of SRAM to boot with. The BROM bootloader will use up
+# to 24KiB to load our bootblock, which leaves us the area from 24KiB to 32 KiB
+# to use however we see fit.
config STACK_TOP
hex
default 0x00008000
config STACK_BOTTOM
hex
- default 0x00004000
+ default 0x00006000
config STACK_SIZE
hex
- default 0x00004000
+ default 0x00002000
## TODO Change this to some better address not overlapping bootblock when
## cbfstool supports creating header in arbitrary location.
diff --git a/src/cpu/allwinner/a10/Makefile.inc b/src/cpu/allwinner/a10/Makefile.inc
index 48f3110..9f7208a 100644
--- a/src/cpu/allwinner/a10/Makefile.inc
+++ b/src/cpu/allwinner/a10/Makefile.inc
@@ -21,15 +21,16 @@ get_bootblock_size= \
sed 's/[^0-9 ]//g')) \
$(shell echo $$(($(word 2, $(strip $(bb_s))))))
-# The boot ROM in the SoC will start loading code if a special boot0 header is
+# The boot ROM in the SoC will start loading code if a special BOOT0 header is
# found (at an offset of 8KiB in either NAND or SD), and the checksum is
-# correct. this header is normally added by the 'mxsunxiboot' tool. The file
-# passed to mksunxiboot should only include the bootblock due to size
-# limitations.
-# FIXME: Figure out how to safely integrate in coreboot.rom. For now, only copy
-# the first 15 KiB of coreboot.rom (This will not collide with stack)
+# correct. This header is normally added by the 'mxsunxiboot' tool. The boot ROM
+# will load at most 24KiB of data to SRAM, so limit the file size accordingly.
+# The BOOT0 header takes 32 bytes, so limit our file to 24KiB - 32 bytes.
+# FIXME: Figure out how to safely integrate in coreboot.rom.
+# FIXME: The file passed to mksunxiboot should only include the bootblock due
+# to size limitations.
$(obj)/BOOT0: $(obj)/coreboot.rom
@printf " BOOT0 $(subst $(obj)/,,$(^))\n"
touch $@
- dd if=$^ of=$^.tmp bs=1024 count=15
+ dd if=$^ of=$^.tmp bs=24544 count=1
-mksunxiboot $^.tmp $@
Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4565
-gerrit
commit a08ad00d7856e04ea36d333f4bd087583602b14f
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Sun Dec 22 21:30:21 2013 -0500
cpu/allwinner/a10: Refactor and document pinmux API
Include a function to multiplex more than one pin at a time. This
is useful for peripherals that have the same function number for
all their pins.
Since we now have two functions for muxing pins, also document
them.
Change-Id: I53997cc3a2586e3cf749cd672f69fb427659c67f
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
---
src/cpu/allwinner/a10/gpio.h | 3 +-
src/cpu/allwinner/a10/pinmux.c | 51 +++++++++++++++++++++++++-
src/mainboard/cubietech/cubieboard/bootblock.c | 7 ++--
3 files changed, 55 insertions(+), 6 deletions(-)
diff --git a/src/cpu/allwinner/a10/gpio.h b/src/cpu/allwinner/a10/gpio.h
index f285451..709f74b 100644
--- a/src/cpu/allwinner/a10/gpio.h
+++ b/src/cpu/allwinner/a10/gpio.h
@@ -46,6 +46,7 @@ struct a10_gpio {
u32 sdr_pad_pul;
} __attribute__ ((packed));
-void gpio_set_func(u8 port, u8 pin, u8 pad_func);
+void gpio_set_pin_func(u8 port, u8 pin, u8 pad_func);
+void gpio_set_multipin_func(u8 port, u32 pin_mask, u8 pad_func);
#endif /* __CPU_ALLWINNER_A10_PINMUX_H */
diff --git a/src/cpu/allwinner/a10/pinmux.c b/src/cpu/allwinner/a10/pinmux.c
index 2525de5..de87440 100644
--- a/src/cpu/allwinner/a10/pinmux.c
+++ b/src/cpu/allwinner/a10/pinmux.c
@@ -11,7 +11,14 @@
static struct a10_gpio *const gpio = (void *)GPIO_BASE;
-void gpio_set_func(u8 port, u8 pin, u8 pad_func)
+/**
+ * \brief Set the pad function of a single pin
+ *
+ * @param[in] port GPIO port of the pin (GPA -> GPS)
+ * @param[in] pin the pin number in the given port (1 -> 31)
+ * @param[in] pad_func The peripheral function to which to connect this pin
+ */
+void gpio_set_pin_func(u8 port, u8 pin, u8 pad_func)
{
u8 reg, bit;
u32 reg32;
@@ -28,3 +35,45 @@ void gpio_set_func(u8 port, u8 pin, u8 pad_func)
reg32 |= (pad_func & 0xf) << bit;
write32(reg32, &gpio->port[port].cfg[reg]);
}
+
+/**
+ * \brief Set the pad function of a group of pins
+ *
+ * Multiplex a group of pins to the same pad function. This is useful for
+ * peripherals that use the same function number for several pins. This function
+ * allows those pins to be set with a single call.
+ *
+ * Example:
+ * gpio_set_multipin_func(GPB, (1 << 23) | (1 << 22), 2);
+ *
+ * @param[in] port GPIO port of the pin (GPA -> GPS)
+ * @param[in] pin_mask 32-bit mask indicating which pins to re-multiplex. For
+ * each set bit, the corresponding pin will be multiplexed.
+ * @param[in] pad_func The peripheral function to which to connect the pins
+ */
+void gpio_set_multipin_func(u8 port, u32 pin_mask, u8 pad_func)
+{
+ int j;
+ u8 reg, bit;
+ u32 reg32, mask_offset;
+
+ if ((port > GPS))
+ return;
+
+ for (reg = 0; reg < 4; reg++) {
+ mask_offset = 8 * reg;
+ /* Don't run the inner loop if we're not touching any pins */
+ if (!(pin_mask & (0xff << mask_offset)))
+ continue;
+
+ reg32 = read32(&gpio->port[port].cfg[reg]);
+ for (j = 0; j < 8; j++) {
+ if (!(pin_mask & (1 << (j + mask_offset))))
+ continue;
+ bit = j * 4;
+ reg32 &= ~(0xf << bit);
+ reg32 |= (pad_func & 0xf) << bit;
+ }
+ write32(reg32, &gpio->port[port].cfg[reg]);
+ }
+}
diff --git a/src/mainboard/cubietech/cubieboard/bootblock.c b/src/mainboard/cubietech/cubieboard/bootblock.c
index 6e8b751..a91391c 100644
--- a/src/mainboard/cubietech/cubieboard/bootblock.c
+++ b/src/mainboard/cubietech/cubieboard/bootblock.c
@@ -18,8 +18,8 @@
| AHB_DIV_1 \
| AXI_DIV_1
-#define GPB22_UART0_TX_FUNC 2
-#define GPB23_UART0_RX_FUNC 2
+#define GPB_UART0_FUNC 2
+#define GPB_UART0_PINS ((1 << 22) | (1 << 23))
static void cubieboard_set_sys_clock(void)
{
@@ -57,8 +57,7 @@ static void cubieboard_setup_clocks(void)
static void cubieboard_setup_gpios(void)
{
/* Mux UART pins */
- gpio_set_func(GPB, 22, GPB22_UART0_TX_FUNC);
- gpio_set_func(GPB, 23, GPB23_UART0_RX_FUNC);
+ gpio_set_multipin_func(GPB, GPB_UART0_PINS, GPB_UART0_FUNC);
}
static void cubieboard_enable_uart(void)