August 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add Emergency help red box to the intro
by Peter Marheine (Code Review) 21 Aug '23

21 Aug '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77292?usp=email ) Change subject: doc: Add Emergency help red box to the intro ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7570b7f0773ec0e43662272e642bc807c8210c2 Gerrit-Change-Number: 77292 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 20 Aug 2023 22:08:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add Macronix MX25L3255E
by Nicholas Chin (Code Review) 20 Aug '23

20 Aug '23

Attention is currently required from: Anastasia Klimchuk, Joseph C. Lehner. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57410?usp=email ) Change subject: flashchips: add Macronix MX25L3255E ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I65968771e22e6b823d2d6192c33f5b0cba25d5b9 Gerrit-Change-Number: 57410 Gerrit-PatchSet: 3 Gerrit-Owner: Joseph C. Lehner Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Joseph C. Lehner Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 20 Aug 2023 00:29:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Fix nesting of About flashrom group of menu items
by Anastasia Klimchuk (Code Review) 19 Aug '23

19 Aug '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77293?usp=email ) Change subject: doc: Fix nesting of About flashrom group of menu items ...................................................................... doc: Fix nesting of About flashrom group of menu items Adding the title to About flashrom index page allows the engine to recognise it as a group with a list of menu items inside, which is as expected. Without the title on the index page, all menu items inside About flashrom are inlined into the menu. Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/about_flashrom/index.rst 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/77293/1 diff --git a/doc/about_flashrom/index.rst b/doc/about_flashrom/index.rst index 11d845f..de36fc2 100644 --- a/doc/about_flashrom/index.rst +++ b/doc/about_flashrom/index.rst @@ -1,3 +1,6 @@ +About flashrom +============== + .. toctree:: :maxdepth: 1 -- To view, visit https://review.coreboot.org/c/flashrom/+/77293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716 Gerrit-Change-Number: 77293 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: doc: Add Emergency help red box to the intro
by Anastasia Klimchuk (Code Review) 19 Aug '23

19 Aug '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77292?usp=email ) Change subject: doc: Add Emergency help red box to the intro ...................................................................... doc: Add Emergency help red box to the intro Change-Id: Id7570b7f0773ec0e43662272e642bc807c8210c2 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/intro.rst 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/77292/1 diff --git a/doc/intro.rst b/doc/intro.rst index 254555a..b1fe99a 100644 --- a/doc/intro.rst +++ b/doc/intro.rst @@ -22,3 +22,13 @@ no "BIOS flashing"). .. todo:: Convert Technology page and add links here + +.. container:: danger, admonition + + **Emergency help** + + IMPORTANT: If something went wrong during flashing, do NOT turn off/reboot your computer. + Instead, let us help you recover. We can be contacted via `IRC <https://www.flashrom.org/contact.html#irc>`_ + (#flashrom on `libera.chat <irc://irc.libera.chat/#flashrom>`_, `webchat <https://web.libera.chat/#flashrom>`_), + `Discord <https://www.flashrom.org/contact.html#discord>`_, or `email <https://www.flashrom.org/contact.html#mailing-list-1>`_. + Please allow some time until someone responds, we're all volunteers. -- To view, visit https://review.coreboot.org/c/flashrom/+/77292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7570b7f0773ec0e43662272e642bc807c8210c2 Gerrit-Change-Number: 77292 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Add flashrom logo to index page
by Stefan Reinauer (Code Review) 19 Aug '23

19 Aug '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email ) Change subject: doc: Add flashrom logo to index page ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Gerrit-Change-Number: 77250 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 19 Aug 2023 03:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Copy logo files into flashrom repository
by Stefan Reinauer (Code Review) 19 Aug '23

19 Aug '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77249?usp=email ) Change subject: doc: Copy logo files into flashrom repository ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I38c1d820be92f2688c5fc4c63a150ab324d8b647 Gerrit-Change-Number: 77249 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 19 Aug 2023 03:58:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: Makefile: Remove a bashism when searching for sphinx-build
by Bart De Schuymer (Code Review) 18 Aug '23

18 Aug '23

Bart De Schuymer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email ) Change subject: Makefile: Remove a bashism when searching for sphinx-build ...................................................................... Makefile: Remove a bashism when searching for sphinx-build e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wongly set to yes. Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Signed-off-by: Bart De Schuymer <bdschuym(a)artinalgorithms.be> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/77288/1 diff --git a/Makefile b/Makefile index bc3eecb..bf01d0f 100644 --- a/Makefile +++ b/Makefile @@ -250,7 +250,7 @@ HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c) HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c) HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) -HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) &>/dev/null && echo yes || echo no) +HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) >/dev/null 2>/dev/null && echo yes || echo no) EXEC_SUFFIX := $(strip $(if $(filter $(TARGET_OS), DOS MinGW), .exe)) override CFLAGS += -Iinclude -- To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Gerrit-Change-Number: 77288 Gerrit-PatchSet: 1 Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Add favicon to config to display in the browser tab
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77285?usp=email ) Change subject: doc: Add favicon to config to display in the browser tab ...................................................................... doc: Add favicon to config to display in the browser tab Initial set of logo images had no ico file, so this patch adds ico files, which are just conversion from png to ico. Change-Id: I7238890833d84b3799e873c8a37b4176822ff9a4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/conf.py A doc/logo/flashrom_icon_color-16x16.ico A doc/logo/flashrom_icon_color-32x32.ico 3 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/77285/1 diff --git a/doc/conf.py b/doc/conf.py index 77aa29b..be9cc01 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -38,6 +38,7 @@ html_theme = 'alabaster' #html_static_path = ['_static'] +html_favicon = 'logo/flashrom_icon_color-32x32.ico' # -- Options for manual page output -------------------------------------------- diff --git a/doc/logo/flashrom_icon_color-16x16.ico b/doc/logo/flashrom_icon_color-16x16.ico new file mode 100644 index 0000000..6c8c777 --- /dev/null +++ b/doc/logo/flashrom_icon_color-16x16.ico Binary files differ diff --git a/doc/logo/flashrom_icon_color-32x32.ico b/doc/logo/flashrom_icon_color-32x32.ico new file mode 100644 index 0000000..d070e70 --- /dev/null +++ b/doc/logo/flashrom_icon_color-32x32.ico Binary files differ -- To view, visit https://review.coreboot.org/c/flashrom/+/77285?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7238890833d84b3799e873c8a37b4176822ff9a4 Gerrit-Change-Number: 77285 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: doc: Add flashrom logo to index page
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77250?usp=email ) Change subject: doc: Add flashrom logo to index page ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I realised my first version was displaying icon, but there is also a logo image, which is better for the home page. -- To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Gerrit-Change-Number: 77250 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 18 Aug 2023 10:41:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: doc: Add flashrom logo to index page
by Anastasia Klimchuk (Code Review) 18 Aug '23

18 Aug '23

Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen. Hello Alexander Goncharov, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77250?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: doc: Add flashrom logo to index page ...................................................................... doc: Add flashrom logo to index page Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/index.rst 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/77250/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44a35b16a29b850e2b49d6e75c52d80b17bf7f75 Gerrit-Change-Number: 77250 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2023