November 2023 - flashrom-gerrit

Change in flashrom[master]: dummyflasher.c: Use programmer logger functions
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46523 ) Change subject: dummyflasher.c: Use programmer logger functions ...................................................................... dummyflasher.c: Use programmer logger functions All but three log messages use the programmer logger. Change the three outliers that were using the chip logger accordingly. Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M dummyflasher.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/46523/1 diff --git a/dummyflasher.c b/dummyflasher.c index 6426ad2..d233db4 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -610,7 +610,7 @@ } for (i = 0; i < data->spi_ignorelist_size; i++) { if (writearr[0] == data->spi_ignorelist[i]) { - msg_cdbg("Ignoring ignorelisted SPI command 0x%02x\n", + msg_pdbg("Ignoring ignorelisted SPI command 0x%02x\n", data->spi_ignorelist[i]); /* Return success because the command does not fail, * it is simply ignored. @@ -1050,7 +1050,7 @@ * Search "total_size * 1024" in code. */ flash->chip->total_size = emu_data->emu_chip_size / 1024; - msg_cdbg("%s: set flash->total_size to %dK bytes.\n", __func__, + msg_pdbg("%s: set flash->total_size to %dK bytes.\n", __func__, flash->chip->total_size); /* Update the first count of each of the block_erasers. */ @@ -1061,7 +1061,7 @@ eraser->eraseblocks[0].count = 1; eraser->eraseblocks[0].size = emu_data->emu_chip_size; - msg_cdbg("%s: eraser.size=%d, .count=%d\n", + msg_pdbg("%s: eraser.size=%d, .count=%d\n", __func__, eraser->eraseblocks[0].size, eraser->eraseblocks[0].count); } -- To view, visit https://review.coreboot.org/c/flashrom/+/46523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Gerrit-Change-Number: 46523 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: it85spi.c: Kill off dead code system() hack
by Edward O'Callaghan (Code Review) 08 Dec '23

08 Dec '23

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46547 ) Change subject: it85spi.c: Kill off dead code system() hack ...................................................................... it85spi.c: Kill off dead code system() hack This is dead code sitting under a 'if 0' and is extremely hacky. One could argue this patch perhaps should include a update to documentation to stop powerd instead of keeping this rot around? BUG=none BRANCH=none TEST=builds Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 0 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/46547/1 diff --git a/it85spi.c b/it85spi.c index b998790..1d93a5b 100644 --- a/it85spi.c +++ b/it85spi.c @@ -114,15 +114,6 @@ if (it85xx_scratch_rom_reenter > 0) return; -#if 0 - /* FIXME: this a workaround for the bug that SMBus signal would - * interfere the EC firmware update. Should be removed if - * we find out the root cause. */ - ret = system("stop powerd >&2"); - if (ret) - msg_perr("Cannot stop powerd.\n"); -#endif - for (tries = 0; tries < MAX_TRY; ++tries) { /* Wait until IBF (input buffer) is not full. */ if (wait_for(KB_IBF, 0, MAX_TIMEOUT, @@ -165,9 +156,6 @@ static void it85xx_exit_scratch_rom(void) { -#if 0 - int ret; -#endif int tries; msg_pdbg("%s():%d was called ...\n", __func__, __LINE__); @@ -204,15 +192,6 @@ } else { msg_perr("%s():%d * Max try reached.\n", __func__, __LINE__); } - -#if 0 - /* FIXME: this a workaround for the bug that SMBus signal would - * interfere the EC firmware update. Should be removed if - * we find out the root cause. */ - ret = system("start powerd >&2"); - if (ret) - msg_perr("Cannot start powerd again.\n"); -#endif } static int it85xx_shutdown(void *data) -- To view, visit https://review.coreboot.org/c/flashrom/+/46547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806 Gerrit-Change-Number: 46547 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

4 8

[XS] Change in flashrom[main]: erasure_layout: Remove redundant `verify_range` call from `erase_write`
by Carly Zlabek (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Aarya, Anastasia Klimchuk, Vincent Fazio. Carly Zlabek has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79354?usp=email ) Change subject: erasure_layout: Remove redundant `verify_range` call from `erase_write` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Testing Summary: 3 types of testing: 1. Switching from 1 bios version to another 2. Erasing the entire chip 3. Programming a bios starting from empty chip contents Averages (seconds): Note: The summation of the individual parts compared to the total may differ by a couple seconds, the timing captures were not exactly back to back. Legacy Erase Path: - The field 'Verify erase' was lumped into `Erase relevant parts` in the New Erase Path test results 1. Read previous contents: 57.025 Erase relevant parts: 27.336 Verify erase: 2.655 Write time: 9.323 Verify write: 58.808 Total execution time: 157.591 2. Read previous contents: 0 Erase chip contents: 198.692 Verify erase: 32.804 Write time: 0 Verify write: 0 Total execution time: 241.46 3. Read previous contents: 56.980 Erase chip contents: 0 Verify erase: 0 Write time: 23.563 Verify write: 58.786 Total execution time: 141.540 New Erase Path: 1. Read previous contents: 56.802 Erase relevant parts: 25.697 Write time: 10.342 Verify write: 57.510 Verify contents: 58.718 Total execution time: 209.89 2. Erase chip contents: 141.953 Write to chip: 0.091 (artifact from timing capture location) Verify contents: 57.423 Total execution time: 200.929 3. Read previous contents: 57.110 Erase relevant parts: 0 (already empty) Write time: 25.206 Verify write: 57.502 Verify contents: 58.902 Total execution time: 199.37 New Erase Path Sans Redundant Verification: 1. Read previous contents: 56.991 Erase relevant parts: 25.679 Write time: 10.323 Verify contents: 58.799 Total execution time: 153.451 2. Erase chip contents: 143.002 Write to chip: 0.088 (artifact from timing capture location) Total execution time: 143.646 3. Read previous contents: 56.939 Erase relevant parts: 0 (already empty) Write time: 25.174 Verify contents: 58.692 Total execution time: 141.396 -- To view, visit https://review.coreboot.org/c/flashrom/+/79354?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5 Gerrit-Change-Number: 79354 Gerrit-PatchSet: 1 Gerrit-Owner: Carly Zlabek <carlyzlabek(a)gmail.com> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vincent Fazio <vfazio(a)gmail.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Vincent Fazio <vfazio(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Nov 2023 23:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: erasure_layout: Remove redundant `verify_range` call from `erase_write`
by Carly Zlabek (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Vincent Fazio. Hello Vincent Fazio, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/79354?usp=email to review the following change. Change subject: erasure_layout: Remove redundant `verify_range` call from `erase_write` ...................................................................... erasure_layout: Remove redundant `verify_range` call from `erase_write` Previously, verification would be unconditionally completed at the end of `erase_write` with the non-legacy erase path. Verification is already handled when writing and erasing chip data; in `flashrom_image_write` based on `flashctx` options, and in the erase loop of `erase_write` via `check_erased_range` calls, respectively. This unnecessary verification added a performance penalty that was not present with the legacy implementation. Now, this call to `verify_range` has been removed to improve performance and more closely reflect the verification done with the legacy path. This change was tested using the linux_spi programmer to erase and write to an MT25QL512 chip. Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5 Signed-off-by: Carly Zlabek <carlyzlabek(a)gmail.com> Signed-off-by: Vincent Fazio <vfazio(a)gmail.com> --- M erasure_layout.c 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/79354/1 diff --git a/erasure_layout.c b/erasure_layout.c index 0c31911..febfde1 100644 --- a/erasure_layout.c +++ b/erasure_layout.c @@ -385,13 +385,6 @@ *all_skipped = false; } - // verify write - ret = verify_range(flashctx, newcontents + region_start, region_start, region_end - region_start); - if (ret) { - msg_cerr("Verifying flash. Write failed for range %#"PRIx32" : %#"PRIx32", Abort.\n", - region_start, region_end); - goto _end; - } _end: memcpy(newcontents + region_start, old_start_buf, old_start - region_start); -- To view, visit https://review.coreboot.org/c/flashrom/+/79354?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5 Gerrit-Change-Number: 79354 Gerrit-PatchSet: 1 Gerrit-Owner: Carly Zlabek <carlyzlabek(a)gmail.com> Gerrit-Reviewer: Vincent Fazio <vfazio(a)gmail.com> Gerrit-Attention: Vincent Fazio <vfazio(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XL] Change in flashrom[main]: erasure_layout: Remove redundant `verify_range` call from `erase_write`
by Carly Zlabek (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Aarya, Anastasia Klimchuk. Carly Zlabek has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79324?usp=email ) Change subject: erasure_layout: Remove redundant `verify_range` call from `erase_write` ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Patchset 2 includes files containing test results to accompany the changes introduced in Patchset 1. -- To view, visit https://review.coreboot.org/c/flashrom/+/79324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I638835facd9311979c4991cc4ca41a4b9e174bd5 Gerrit-Change-Number: 79324 Gerrit-PatchSet: 2 Gerrit-Owner: Carly Zlabek <carlyzlabek(a)gmail.com> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vincent Fazio <vfazio(a)gmail.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 30 Nov 2023 20:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: pci2: add a second device private called data
by Luc Verhaegen (Code Review) 30 Nov '23

30 Nov '23

Luc Verhaegen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/29082?usp=email ) Change subject: pci2: add a second device private called data ...................................................................... Abandoned I have 0 interest in testing, supporting or maintaining this code, and i doubt whether any of the reviewers here is willing to get the hardware to properly test this code. -- To view, visit https://review.coreboot.org/c/flashrom/+/29082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7927773a88439ca3828d694785e58a4cf2b7795c Gerrit-Change-Number: 29082 Gerrit-PatchSet: 3 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: pci2: add device enable/disable
by Luc Verhaegen (Code Review) 30 Nov '23

30 Nov '23

Luc Verhaegen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/29081?usp=email ) Change subject: pci2: add device enable/disable ...................................................................... Abandoned I have 0 interest in testing, supporting or maintaining this code, and i doubt whether any of the reviewers here is willing to get the hardware to properly test this code. -- To view, visit https://review.coreboot.org/c/flashrom/+/29081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I79bbc5c4b0f571df692e0992f43b46da7ab3bf01 Gerrit-Change-Number: 29081 Gerrit-PatchSet: 3 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: pci2: add mmio bar map/unmap
by Luc Verhaegen (Code Review) 30 Nov '23

30 Nov '23

Luc Verhaegen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/29079?usp=email ) Change subject: pci2: add mmio bar map/unmap ...................................................................... Abandoned I have 0 interest in testing, supporting or maintaining this code, and i doubt whether any of the reviewers here is willing to get the hardware to properly test this code. -- To view, visit https://review.coreboot.org/c/flashrom/+/29079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1c67d51d853f751d13271bf83316ee2118c1c476 Gerrit-Change-Number: 29079 Gerrit-PatchSet: 3 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: add newer pci infrastructure
by Luc Verhaegen (Code Review) 30 Nov '23

30 Nov '23

Luc Verhaegen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/29078?usp=email ) Change subject: add newer pci infrastructure ...................................................................... Abandoned I have 0 interest in testing, supporting or maintaining this code, and i doubt whether any of the reviewers here is willing to get the hardware to properly test this code. -- To view, visit https://review.coreboot.org/c/flashrom/+/29078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I59af37cba5cb78014e0714c654db2501151f605e Gerrit-Change-Number: 29078 Gerrit-PatchSet: 3 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: pci2: add wiki printing support
by Luc Verhaegen (Code Review) 30 Nov '23

30 Nov '23

Luc Verhaegen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/29084?usp=email ) Change subject: pci2: add wiki printing support ...................................................................... Abandoned I have 0 interest in testing, supporting or maintaining this code, and i doubt whether any of the reviewers here is willing to get the hardware to properly test this code. -- To view, visit https://review.coreboot.org/c/flashrom/+/29084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8c839feda2ef3ec97183f1e06712881786622ebf Gerrit-Change-Number: 29084 Gerrit-PatchSet: 5 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2023