September 2023 - flashrom-gerrit

Change in flashrom[master]: dummyflasher.c: Use programmer logger functions
by Angel Pons (Code Review) 11 Apr '24

11 Apr '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46523 ) Change subject: dummyflasher.c: Use programmer logger functions ...................................................................... dummyflasher.c: Use programmer logger functions All but three log messages use the programmer logger. Change the three outliers that were using the chip logger accordingly. Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M dummyflasher.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/46523/1 diff --git a/dummyflasher.c b/dummyflasher.c index 6426ad2..d233db4 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -610,7 +610,7 @@ } for (i = 0; i < data->spi_ignorelist_size; i++) { if (writearr[0] == data->spi_ignorelist[i]) { - msg_cdbg("Ignoring ignorelisted SPI command 0x%02x\n", + msg_pdbg("Ignoring ignorelisted SPI command 0x%02x\n", data->spi_ignorelist[i]); /* Return success because the command does not fail, * it is simply ignored. @@ -1050,7 +1050,7 @@ * Search "total_size * 1024" in code. */ flash->chip->total_size = emu_data->emu_chip_size / 1024; - msg_cdbg("%s: set flash->total_size to %dK bytes.\n", __func__, + msg_pdbg("%s: set flash->total_size to %dK bytes.\n", __func__, flash->chip->total_size); /* Update the first count of each of the block_erasers. */ @@ -1061,7 +1061,7 @@ eraser->eraseblocks[0].count = 1; eraser->eraseblocks[0].size = emu_data->emu_chip_size; - msg_cdbg("%s: eraser.size=%d, .count=%d\n", + msg_pdbg("%s: eraser.size=%d, .count=%d\n", __func__, eraser->eraseblocks[0].size, eraser->eraseblocks[0].count); } -- To view, visit https://review.coreboot.org/c/flashrom/+/46523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia8668e05df2da739e6bb4c7d0fddad86e8d054a3 Gerrit-Change-Number: 46523 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: it85spi.c: Kill off dead code system() hack
by Edward O'Callaghan (Code Review) 08 Dec '23

08 Dec '23

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46547 ) Change subject: it85spi.c: Kill off dead code system() hack ...................................................................... it85spi.c: Kill off dead code system() hack This is dead code sitting under a 'if 0' and is extremely hacky. One could argue this patch perhaps should include a update to documentation to stop powerd instead of keeping this rot around? BUG=none BRANCH=none TEST=builds Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M it85spi.c 1 file changed, 0 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/46547/1 diff --git a/it85spi.c b/it85spi.c index b998790..1d93a5b 100644 --- a/it85spi.c +++ b/it85spi.c @@ -114,15 +114,6 @@ if (it85xx_scratch_rom_reenter > 0) return; -#if 0 - /* FIXME: this a workaround for the bug that SMBus signal would - * interfere the EC firmware update. Should be removed if - * we find out the root cause. */ - ret = system("stop powerd >&2"); - if (ret) - msg_perr("Cannot stop powerd.\n"); -#endif - for (tries = 0; tries < MAX_TRY; ++tries) { /* Wait until IBF (input buffer) is not full. */ if (wait_for(KB_IBF, 0, MAX_TIMEOUT, @@ -165,9 +156,6 @@ static void it85xx_exit_scratch_rom(void) { -#if 0 - int ret; -#endif int tries; msg_pdbg("%s():%d was called ...\n", __func__, __LINE__); @@ -204,15 +192,6 @@ } else { msg_perr("%s():%d * Max try reached.\n", __func__, __LINE__); } - -#if 0 - /* FIXME: this a workaround for the bug that SMBus signal would - * interfere the EC firmware update. Should be removed if - * we find out the root cause. */ - ret = system("start powerd >&2"); - if (ret) - msg_perr("Cannot start powerd again.\n"); -#endif } static int it85xx_shutdown(void *data) -- To view, visit https://review.coreboot.org/c/flashrom/+/46547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806 Gerrit-Change-Number: 46547 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

4 8

Change in flashrom[master]: chipset_enable.c: Remove futile attempt to disable lock
by Andy Pont (Code Review) 25 Nov '23

25 Nov '23

Andy Pont has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48643 ) Change subject: chipset_enable.c: Remove futile attempt to disable lock ...................................................................... chipset_enable.c: Remove futile attempt to disable lock For all recent Intel chipsets (and possibly others) the ability to disable the lock fails. This leads to confusing messages being presented to the user where unlocking fails but the flash update process works correctly. Remove the unlock attempt which had alreayd been marked in the source code comments as "futile". Signed-off-by: Andy Pont <andy.pont(a)sdcsystems.com> Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b --- M chipset_enable.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/48643/1 diff --git a/chipset_enable.c b/chipset_enable.c index 9205d0e..3ca6ba8 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -333,7 +333,6 @@ wanted |= (1 << 2); wanted |= (1 << 0); /* Set BIOS Write Enable */ - wanted &= ~(1 << 1); /* Disable lock (futile) */ /* Only write the register if it's necessary */ if (wanted != old) { -- To view, visit https://review.coreboot.org/c/flashrom/+/48643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b Gerrit-Change-Number: 48643 Gerrit-PatchSet: 1 Gerrit-Owner: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: dediprog: Fix SF600 4BA mode
by Patrick Rudolph (Code Review) 25 Nov '23

25 Nov '23

Hello Patrick Rudolph, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/34629 to review the following change. Change subject: dediprog: Fix SF600 4BA mode ...................................................................... dediprog: Fix SF600 4BA mode Flash chips greater than 16MiB require 4BA mode support. Current master doesn't support such mode as the SF600 uses PROTOCOL_V3. Fix protocol version check to support 4BA on PROTOCOL_V3, too. Tested on SF600 V:7.2.45 Able to read and write "IS25WP256" (32768 kB, SPI). Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M dediprog.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/34629/1 diff --git a/dediprog.c b/dediprog.c index 3566109..add478d 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1160,7 +1160,7 @@ if (dediprog_devicetype == DEV_SF100 && protocol() == PROTOCOL_V1) spi_master_dediprog.features &= ~SPI_MASTER_NO_4BA_MODES; - if (protocol() == PROTOCOL_V2) + if (protocol() >= PROTOCOL_V2) spi_master_dediprog.features |= SPI_MASTER_4BA; if (register_spi_master(&spi_master_dediprog) || dediprog_set_leds(LED_NONE)) -- To view, visit https://review.coreboot.org/c/flashrom/+/34629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d3089693fbd2f8f7717a8f71be242be131ce707 Gerrit-Change-Number: 34629 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

4 7

[M] Change in flashrom[main]: doc: Add first version of code of conduct
by Stefan Reinauer (Code Review) 30 Sep '23

30 Sep '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78203?usp=email ) Change subject: doc: Add first version of code of conduct ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Icd82ba79687da3a2698d84f5cbfe824fbab0c426 Gerrit-Change-Number: 78203 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 30 Sep 2023 14:22:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: doc: Convert release notes for v1.3
by Alexander Goncharov (Code Review) 30 Sep '23

30 Sep '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78116?usp=email ) Change subject: doc: Convert release notes for v1.3 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78116?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5b66a957249c3025715eff2b00f1be9eb0d36096 Gerrit-Change-Number: 78116 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 30 Sep 2023 13:54:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) 30 Sep '23

30 Sep '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email ) Change subject: doc: Add code of conduct ...................................................................... Abandoned different approach, see CB:78203 -- To view, visit https://review.coreboot.org/c/flashrom/+/76455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic4c646bc47d5db4d064a411d60a44f16559dfcee Gerrit-Change-Number: 76455 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: doc: Add first version of code of conduct
by Anastasia Klimchuk (Code Review) 30 Sep '23

30 Sep '23

Attention is currently required from: Thomas Heijligen. Hello Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/78203?usp=email to look at the new patch set (#2). Change subject: doc: Add first version of code of conduct ...................................................................... doc: Add first version of code of conduct As a starting point, copying coreboot's one in the absence of our own. coreboot's CoC exists for some time and is known to work, so it's a good starting point. We can iterate on this and make upgrades and amendments that make sense for flashrom community. Meanwhile we can share code of conduct with coreboot. We do have the same servers and infrastructure anyway. Change-Id: Icd82ba79687da3a2698d84f5cbfe824fbab0c426 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A doc/about_flashrom/code_of_conduct.rst M doc/about_flashrom/index.rst M doc/about_flashrom/team.rst 3 files changed, 144 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/78203/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Icd82ba79687da3a2698d84f5cbfe824fbab0c426 Gerrit-Change-Number: 78203 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: doc: Add code of conduct
by Anastasia Klimchuk (Code Review) 30 Sep '23

30 Sep '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/78203?usp=email ) Change subject: doc: Add code of conduct ...................................................................... doc: Add code of conduct For now link to coreboot's one, in the absence of our own. It is always possible to create our own later, if desired, but meanwhile we can share code of conduct with coreboot. We do have the same servers and infrastructure anyway. Change-Id: Icd82ba79687da3a2698d84f5cbfe824fbab0c426 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A doc/about_flashrom/code_of_conduct.rst M doc/about_flashrom/index.rst M doc/about_flashrom/team.rst 3 files changed, 144 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/78203/1 diff --git a/doc/about_flashrom/code_of_conduct.rst b/doc/about_flashrom/code_of_conduct.rst new file mode 100644 index 0000000..da94e29 --- /dev/null +++ b/doc/about_flashrom/code_of_conduct.rst @@ -0,0 +1,140 @@ +=============== +Code of Conduct +=============== + +This code of conduct outlines our rules and expectations for everybody +participating in the flashrom community. + +flashrom community etiquette +============================ + +We have a friendly and productive atmosphere on our mailing lists, +development / code review tools, real time chat rooms and when we meet in +person. Our principles evolve around the following: + +* It's not the user's fault if something goes wrong. +* Attempt collaboration before conflict. +* People who intentionally insult others (users, developers, corporations, + other projects, or the flashrom project itself) will be dealt with. See + policy below. +* We are dealing with hardware with lots of undocumented pitfalls. It is quite + possible that you did everything right, but flashrom still won't work for you. + +Refrain from insulting anyone or the group they belong to. Remember that +people might be sensitive to other things than you are. + +Most of our community members are not native English speakers, thus +misunderstandings can (and do) happen. Assume that others are friendly +and may have picked less-than-stellar wording by accident as long as +you possibly can. + +Reporting Issues +================ + +If you have a grievance due to conduct in this community, we're sorry +that you have had a bad experience, and we want to hear about it so +we can resolve the situation. + +Please contact members of our arbitration team (listed below) promptly +and directly, in person (if available) or by email: They will listen +to you and react in a timely fashion. + +If you feel uncomfortable, please don't wait it out, ask for help, +so we can work on setting things right. + +For transparency there is no alias or private mailing list address for +you to reach out to, since we want to make sure that you know who will +and who won't read your message. + +However since people might be on travel or otherwise be unavailable +at times, please reach out to multiple persons at once, especially +when using email. + +The team will treat your messages confidential as far as the law permits. +For the purpose of knowing what law applies, the list provides the usual +country of residence of each team member. + +Unacceptable Behavior +===================== + +Unacceptable behaviors include: intimidating, harassing, abusive, +discriminatory, derogatory or demeaning speech or actions by any +participant in our community online, at all related events and in +one-on-one communications carried out in the context of community +business. Community event venues may be shared with members of the public; +please be respectful to all patrons of these locations. + +Examples of behaviors we do not accept in our community: + +* harmful or prejudicial verbal or written comments related to gender, + sexual orientation, race, religion, disability; +* inappropriate physical contact, and unwelcome sexual advances; +* deliberate intimidation, stalking or following; +* harassing photography or recording; +* sustained disruption of talks or other events. + +Using this code of conduct aggressively against other people in the +community might also be harassment. Be considerate when enforcing the code +of conduct and always try to listen to both sides before passing judgment. + +Consequences of Unacceptable Behavior +===================================== + +Unacceptable behavior from any community member, including sponsors and +those with decision-making authority, will not be tolerated. + +Anyone asked to stop unacceptable behavior is expected to comply +immediately. + +If a community member engages in unacceptable behavior, the community +organizers may take any action they deem appropriate, up to and including +a temporary ban or permanent expulsion from the community without warning +(and without refund in the case of a paid event). + +Community organizers can be members of the arbitration team, or organizers +of events and online communities. + +Addressing Grievances +===================== + +If you feel you have been falsely or unfairly accused of violating this +Code of Conduct, you should notify the arbitration team with a concise +description of your grievance. + +Legal action +============ + +Threatening or starting legal action against the project, sibling +projects hosted on coreboot.org infrastructure, project or infrastructure +maintainers leads to an immediate ban from coreboot.org and related +systems. + +The ban can be reconsidered, but it's the default action because the +people who pour lots of time and money into the projects aren't interested +in seeing their resources used against them. + +Scope +========== + +We expect all community participants (contributors, paid or otherwise; +sponsors; and other guests) to abide by this Code of Conduct in all +community venues, online and in-person, as well as in all one-on-one +communications pertaining to community business. + +Contact info +============ + +Our arbitration team consists of the following people + +* Stefan Reinauer <stefan.reinauer(a)coreboot.org> (USA) +* Patrick Georgi <patrick(a)coreboot.org> (Germany) +* Ronald Minnich <rminnich(a)coreboot.org> (USA) +* Martin Roth <martin(a)coreboot.org> (USA) + +License and attribution +======================= + +This Code of Conduct is distributed under +a `Creative Commons Attribution-ShareAlike +license <http://creativecommons.org/licenses/by-sa/3.0/>`_. It is based +on the `Citizen Code of Conduct <https://web.archive.org/web/20200330154000/http://citizencodeofconduct.org/>`_ diff --git a/doc/about_flashrom/index.rst b/doc/about_flashrom/index.rst index de36fc2..49c9849 100644 --- a/doc/about_flashrom/index.rst +++ b/doc/about_flashrom/index.rst @@ -5,3 +5,4 @@ :maxdepth: 1 team + code_of_conduct diff --git a/doc/about_flashrom/team.rst b/doc/about_flashrom/team.rst index 9d002bb..2c593ec 100644 --- a/doc/about_flashrom/team.rst +++ b/doc/about_flashrom/team.rst @@ -6,8 +6,8 @@ All contributors and users who have a Gerrit account can send patches, add comments to patches and vote +1..-1 on patches. -All contributors and users are expected to follow Development guidelines, -Code of Conduct and Friendliness guidelines. +All contributors and users are expected to follow Development guidelines and +:doc:`code_of_conduct`. There are two special groups in Gerrit. @@ -55,7 +55,7 @@ * From time to time show up in real-time channel(s) and/or dev meetings. -* Follow the Code of Conduct and Friendliness guidelines, be a good example for others. +* Follow the :doc:`code_of_conduct`, be a good example for others. * Bonus point: if you work in a [software] company, educate and help contributors from your company with upstream culture and dev guidelines. -- To view, visit https://review.coreboot.org/c/flashrom/+/78203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Icd82ba79687da3a2698d84f5cbfe824fbab0c426 Gerrit-Change-Number: 78203 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[main]: erasure_layout: Fix double invocation of erasers
by Anastasia Klimchuk (Code Review) 30 Sep '23

30 Sep '23

Attention is currently required from: Aarya, Alexander Goncharov, Sam McNally. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email ) Change subject: erasure_layout: Fix double invocation of erasers ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > I still encounter an error. Added comments and logs in the issue tracker. Thank you! I added one comment to the ticket. If you give me the images I can debug too! I think these are two different issues. The issue this patch is solving is that every block was erased twice: but the end result was correct, so end user would not notice the issues (and verification works too). While I think there are two different issues, I would debug yours as well before deciding to submit this one: just in case. In general, this patch is useful, and also the next one (unit test), I would really want to get it through and have the test running on jenkins. -- To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28 Gerrit-Change-Number: 77747 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 30 Sep 2023 10:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2023