flashrom-gerrit September 2023

flashrom-gerrit@flashrom.org

1 participants
127 discussions

[XS] Change in flashrom[master]: flashchips: Add WP features for Winbond W25X20
by Sergii Dmytruk (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Vasily Galkin. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77530?usp=email ) Change subject: flashchips: Add WP features for Winbond W25X20 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This "patch series"="relation chain" is currently shown as "Merge conflict" in Gerrit. […] It's better to rebase. As long as `Change-Id:` in commit messages remain the same Gerrit will recognize new revisions of already pushed commits. -- To view, visit https://review.coreboot.org/c/flashrom/+/77530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82c0cc52ca2a78d27f513234cc12d3e09d8905a5 Gerrit-Change-Number: 77530 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vasily Galkin Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 01 Sep 2023 13:09:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vasily Galkin Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashchips: Add WP features for Winbond W25X20
by Vasily Galkin (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer. Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77530?usp=email ) Change subject: flashchips: Add WP features for Winbond W25X20 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This "patch series"="relation chain" is currently shown as "Merge conflict" in Gerrit. They are "spurious" - unrelated chip change in flashchips.c, easily handled by autorebasing (tested locally). Should I rebase this on master tip, or it is fine to keep in in current state? I'm new to Gerrit, so I'm not sure if rebasing is "harmless" or would initate new review round (that wound be unneeded in this case, since no manual tunings would be done during rebasing) -- To view, visit https://review.coreboot.org/c/flashrom/+/77530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82c0cc52ca2a78d27f513234cc12d3e09d8905a5 Gerrit-Change-Number: 77530 Gerrit-PatchSet: 1 Gerrit-Owner: Vasily Galkin Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 01 Sep 2023 12:49:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Anastasia Klimchuk (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Angel Pons, Neil Armstrong, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263?usp=email ) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/50263/comment/97bf5ab7_7641479a : PS4, Line 7: flashchips: add definition of the XT25F02E SPI NOR flash > Which programmer did you use? The programmer is here CB:50264 Maybe Neil will come back and finish the programmer patch ;) https://review.coreboot.org/c/flashrom/+/50263/comment/86e435d5_f8a17a88 : PS4, Line 8: > Please add a link to the datasheet. Done Patchset: PS4: > Hello Neil, sorry there was a really long delay for this patch :( Are you still interested? There ar […] Not sure whether Neil will come back or not, I rebased the patch, added link to the datasheet and updated `printlock` and `unlock` to use functions for BP1. I found the answer to my question about the programmer in the earlier comments (yes). Patchset: PS5: I rebased the patch and updated as needed. If anyone on the patch could review/approve that would be fantastic, thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/50263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 5 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 01 Sep 2023 10:18:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Anastasia Klimchuk (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Neil Armstrong, Thomas Heijligen. Anastasia Klimchuk has uploaded a new patch set (#5) to the change originally created by Neil Armstrong. ( https://review.coreboot.org/c/flashrom/+/50263?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Angel Pons, Verified+1 by build bot (Jenkins) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... flashchips: add definition of the XT25F02E SPI NOR flash This adds definition of the XT25F02E 2MBit SPI NOR Flash from XTX Technology Limited. Tested (Probe, Erase, Write, Read) with a VL805 USB3.0 bridge. Datasheet: https://datasheet.lcsc.com/lcsc/2006091008_XTX-XT25F02EDTIGT_C596313.pdf Signed-off-by: Neil Armstrong <narmstrong(a)baylibre.com> Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M flashchips.c M include/flashchips.h 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/50263/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/50263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 5 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add EON EN25T80 and EN25T80
by Anastasia Klimchuk (Code Review) 01 Sep '23

01 Sep '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/66438?usp=email ) Change subject: flashchips: Add EON EN25T80 and EN25T80 ...................................................................... Abandoned Contributor left, we have no datasheets and no testing information -- To view, visit https://review.coreboot.org/c/flashrom/+/66438?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie62a08bed242b5b006e4bb2f86eb70c871bd5ed9 Gerrit-Change-Number: 66438 Gerrit-PatchSet: 1 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Name of user not set (Code Review) 01 Sep '23

01 Sep '23

Name of user not set #1005084 has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77581?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... flashchips: Add support for MXIC MX25U25643G It is similar to the MX25U25635F and shares its RDID. Tested by ch341a programmer : read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… Change-Id: Id6c4254a02800f04c091009d19a628435fc20fce Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/77581/1 diff --git a/flashchips.c b/flashchips.c index ce68e95..b0092e1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10207,7 +10207,7 @@ { .vendor = "Macronix", - .name = "MX25U25635F", + .name = "MX25U25635F/MX25U25643G", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25U25635F, diff --git a/include/flashchips.h b/include/flashchips.h index 6e191eb..dbe7cdb 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -529,7 +529,7 @@ #define MACRONIX_MX25U3235E 0x2536 /* Same as MX25U6435F */ #define MACRONIX_MX25U6435E 0x2537 /* Same as MX25U6435F */ #define MACRONIX_MX25U12835E 0x2538 /* Same as MX25U12835F */ -#define MACRONIX_MX25U25635F 0x2539 +#define MACRONIX_MX25U25635F 0x2539 /* Same as MX25U25643G */ #define MACRONIX_MX25U51245G 0x253a #define MACRONIX_MX25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ #define MACRONIX_MX25L6495F 0x9517 -- To view, visit https://review.coreboot.org/c/flashrom/+/77581?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6c4254a02800f04c091009d19a628435fc20fce Gerrit-Change-Number: 77581 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005084 Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Anastasia Klimchuk (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77563?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: xianzheng, seems like you made a mistake, you shouldn't be removing lines in a patch like this -- To view, visit https://review.coreboot.org/c/flashrom/+/77563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibff2780dcb86ffb7790e0204385e6350f136f21d Gerrit-Change-Number: 77563 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Name of user not set #1005084 Gerrit-Comment-Date: Fri, 01 Sep 2023 04:41:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2023