November 2017 - flashrom-gerrit

Change in flashrom[master]: README: Update packaging section for Git repositories
by Stefan Reinauer (Code Review) Nov. 30, 2017

Nov. 30, 2017

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22454 ) Change subject: README: Update packaging section for Git repositories ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22454 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d9c56be8c1381b175ce7695c53f31b1767d9d17 Gerrit-Change-Number: 22454 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 17:45:29 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi25: Revise decision when to enter/exit 4BA mode
by David Hendricks (Code Review) Nov. 22, 2017

Nov. 22, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22422 ) Change subject: spi25: Revise decision when to enter/exit 4BA mode ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/22422 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877fe817f801fc54bd0ee2ce4e3ead324cbb3673 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 06:23:21 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag
by David Hendricks (Code Review) Nov. 22, 2017

Nov. 22, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag ...................................................................... Patch Set 5: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/22421/5/spi25.c File spi25.c: https://review.coreboot.org/#/c/22421/5/spi25.c@380 PS5, Line 380: "Please report a bug at flashrom(a)flashrom.org\n"); > Not a bug, I forgot about the block erasers (again)... or we could How so? If you're referring to chip erase commands, those are handled using spi_simple_write_cmd() which doesn't call this function, so we should be good there at least. -- To view, visit https://review.coreboot.org/22421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 06:23:20 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: spi: Move ICH BBAR quirk out of the way
by David Hendricks (Code Review) Nov. 22, 2017

Nov. 22, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22396 ) Change subject: spi: Move ICH BBAR quirk out of the way ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/22396 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbac513c5339e8aff624870252133284ef85ab73 Gerrit-Change-Number: 22396 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Nov 2017 05:40:00 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: add W25Q128JV.M
by build bot (Jenkins) (Code Review) Nov. 22, 2017

Nov. 22, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22567 ) Change subject: flashchips: add W25Q128JV.M ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/792/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/904/ : SUCCESS -- To view, visit https://review.coreboot.org/22567 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef Gerrit-Change-Number: 22567 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Nov 2017 19:05:37 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: add W25Q128JV.M
by David Hendricks (Code Review) Nov. 22, 2017

Nov. 22, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22567 ) Change subject: flashchips: add W25Q128JV.M ...................................................................... Patch Set 1: Code-Review-2 needs testing -- To view, visit https://review.coreboot.org/22567 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef Gerrit-Change-Number: 22567 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2017 19:04:49 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: add W25Q128JV.M
by David Hendricks (Code Review) Nov. 22, 2017

Nov. 22, 2017

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/22567 Change subject: flashchips: add W25Q128JV.M ...................................................................... flashchips: add W25Q128JV.M This copies the W25Q128.V entry and tweaks it for the W25Q128JV.M. The chips ending with 'M' have additional instructions for high-speed operation. Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M flashchips.c M flashchips.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/22567/1 diff --git a/flashchips.c b/flashchips.c index a1ad445..67b1918 100644 --- a/flashchips.c +++ b/flashchips.c @@ -14760,6 +14760,47 @@ { .vendor = "Winbond", + .name = "W25Q128JV.M", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q128JV_M, + .total_size = 16384, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + /* TODO: May need dual/quad read operations, depending on QE enable bit */ + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", .name = "W25Q256.V", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/flashchips.h b/flashchips.h index 62eb9a5..045c45d 100644 --- a/flashchips.h +++ b/flashchips.h @@ -900,6 +900,7 @@ #define WINBOND_NEX_W25Q32_V 0x4016 /* W25Q32BV; W25Q32FV in SPI mode (default) */ #define WINBOND_NEX_W25Q64_V 0x4017 /* W25Q64BV, W25Q64CV; W25Q64FV in SPI mode (default) */ #define WINBOND_NEX_W25Q128_V 0x4018 /* W25Q128BV; W25Q128FV in SPI mode (default) */ +#define WINBOND_NEX_W25Q128JV_M 0x7018 /* W25Q128JV.M */ #define WINBOND_NEX_W25Q256_V 0x4019 /* W25Q256FV */ #define WINBOND_NEX_W25Q20_W 0x5012 /* W25Q20BW */ #define WINBOND_NEX_W25Q40_W 0x5013 /* W25Q40BW */ -- To view, visit https://review.coreboot.org/22567 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef Gerrit-Change-Number: 22567 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: chipset_enable: Mark SiS 630 as tested OK
by build bot (Jenkins) (Code Review) Nov. 21, 2017

Nov. 21, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22522 ) Change subject: chipset_enable: Mark SiS 630 as tested OK ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/903/ : SUCCESS -- To view, visit https://review.coreboot.org/22522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Gerrit-Change-Number: 22522 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 22:29:39 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: chipset_enable: Mark SiS 630 as tested OK
by Nico Huber (Code Review) Nov. 21, 2017

Nov. 21, 2017

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/22522 ) Change subject: chipset_enable: Mark SiS 630 as tested OK ...................................................................... chipset_enable: Mark SiS 630 as tested OK Tested on an Elitegroup P6STMT with an SST39SF020A parallel flash [1]. [1] https://mail.coreboot.org/pipermail/flashrom/2017-November/015193.html Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/22522 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve David Hendricks: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 3437792..a499ba0 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1614,7 +1614,7 @@ {0x1039, 0x0530, OK, "SiS", "530", enable_flash_sis530}, {0x1039, 0x0540, NT, "SiS", "540", enable_flash_sis540}, {0x1039, 0x0620, NT, "SiS", "620", enable_flash_sis530}, - {0x1039, 0x0630, NT, "SiS", "630", enable_flash_sis540}, + {0x1039, 0x0630, OK, "SiS", "630", enable_flash_sis540}, {0x1039, 0x0635, NT, "SiS", "635", enable_flash_sis540}, {0x1039, 0x0640, NT, "SiS", "640", enable_flash_sis540}, {0x1039, 0x0645, NT, "SiS", "645", enable_flash_sis540}, -- To view, visit https://review.coreboot.org/22522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Gerrit-Change-Number: 22522 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: chipset_enable: Mark SiS 630 as tested OK
by David Hendricks (Code Review) Nov. 21, 2017

Nov. 21, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22522 ) Change subject: chipset_enable: Mark SiS 630 as tested OK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Gerrit-Change-Number: 22522 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 17:25:49 +0000 Gerrit-HasComments: No

1 0