February 2018 - flashrom-gerrit

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Márton Miklós (Code Review) Feb. 28, 2018

Feb. 28, 2018

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23865/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@7 PS1, Line 7: Sure: This patch utilizes a regular expression to check if we are compiling under mingw environment rather than comparing the uname output to a predefined string (MINGW32_NT-5.1). In newer Windows based mingw enviroments the uname returns different version number so the platform will not be detected properly and the compilation will fail. I have tested it only on Windows 7 (where the uname returns INGW32_NT-6.1), however the regex should match the MINGW64 environments too see: https://regexr.com/3lgp9 -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Feb 2018 20:26:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Paul Menzel (Code Review) Feb. 28, 2018

Feb. 28, 2018

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/23865/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@7 PS1, Line 7: Fixed Imperative mood: Fix https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@8 PS1, Line 8: Could you describe your fix? -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Feb 2018 20:11:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Márton Miklós (Code Review) Feb. 28, 2018

Feb. 28, 2018

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23865/1/Makefile File Makefile: https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes) > I'm not familiar with the syntax. […] Kind of. It is a regexp check inspired by this: https://stackoverflow.com/questions/31111360/how-to-use-regular-expression-… -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:21:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by Nico Huber (Code Review) Feb. 26, 2018

Feb. 26, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23865/1/Makefile File Makefile: https://review.coreboot.org/#/c/23865/1/Makefile@104 PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes) I'm not familiar with the syntax. Is it bashism? -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 13:55:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: WIP: dediprog: implement updated command spec
by David Hendricks (Code Review) Feb. 25, 2018

Feb. 25, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23836 ) Change subject: WIP: dediprog: implement updated command spec ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 06:22:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: WIP: dediprog: implement updated command spec
by David Hendricks (Code Review) Feb. 25, 2018

Feb. 25, 2018

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23836 to look at the new patch set (#2). Change subject: WIP: dediprog: implement updated command spec ...................................................................... WIP: dediprog: implement updated command spec This is a work-in-progress to update the command spec for Dediprog SF100/SF600 programmers. For now the new bulk read and write command packet format is hacked in and will be cleaned up once things are working and I get clarification about which firmware versions implement them. The latest spec (FW >= 7.2.30?) updates read and write packets. - Read packets have two more bytes: 11: B4Addr: address len (3 or 4) 12: Dummy cycle /2 - Write packets have four more bytes: 11, 12: 16 HSBs of page size 13, 14: 16 LSBs of page size Note, however, that 11 and 12 appear to be the LSBs rather than HSBs, with byte 11 being the lowest order byte. The patch seems to work in this state. Now we just need to clean it up and see what the cut-off is between firmware versions for compatibility. Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M dediprog.c 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/23836/2 -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by build bot (Jenkins) (Code Review) Feb. 25, 2018

Feb. 25, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1167/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/978/ : SUCCESS -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 01:11:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ...
by David Hendricks (Code Review) Feb. 25, 2018

Feb. 25, 2018

Hello Miklós Márton, I'd like you to do a code review. Please visit https://review.coreboot.org/23865 to review the following change. Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. ...................................................................... Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too. Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/23865/1 diff --git a/Makefile b/Makefile index 5bd7158..755fe86 100644 --- a/Makefile +++ b/Makefile @@ -97,7 +97,11 @@ # HOST_OS is only used to work around local toolchain issues. HOST_OS ?= $(shell uname) -ifeq ($(HOST_OS), MINGW32_NT-5.1) + +# Use a regexp to check if we are building in a mingw enviroment. +# uname returns MINGW32_NT-5.1 on XP, MINGW32_NT-6.1 on Windows 7 +# the regexp should support 64 bit variant of mingw if exists +ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes) # Explicitly set CC = gcc on MinGW, otherwise: "cc: command not found". CC = gcc endif -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>

1 0

Change in flashrom[master]: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, ...
by David Hendricks (Code Review) Feb. 25, 2018

Feb. 25, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Seems pretty straightforward. Let's get this merged soon. https://review.coreboot.org/#/c/23864/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23864/1//COMMIT_MSG@7 PS1, Line 7: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain We'll need to fix up the commit message before merging. https://review.coreboot.org/#/c/23864/1//COMMIT_MSG@8 PS1, Line 8: Missing Signed-off-by line -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 01:06:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, ...
by build bot (Jenkins) (Code Review) Feb. 25, 2018

Feb. 25, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23864 ) Change subject: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1166/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/977/ : SUCCESS -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 00:59:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0