February 2018 - flashrom-gerrit

Change in flashrom[master]: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, ...
by David Hendricks (Code Review) 26 Feb '18

26 Feb '18

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/23864 Change subject: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain ...................................................................... buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f --- M buspirate_spi.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/23864/1 diff --git a/buspirate_spi.c b/buspirate_spi.c index b6554ac..4c90fbc 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -436,6 +436,10 @@ /* Set SPI config: output type, idle, clock edge, sample */ bp_commbuf[0] = 0x80 | 0xa; + if (pullup == 1) { + bp_commbuf[0] &= ~(1 << 3); + msg_pdbg("Pull-ups enabled, so using HiZ pin output! (Open-Drain mode)\n"); + } ret = buspirate_sendrecv(bp_commbuf, 1, 1); if (ret) return 1; -- To view, visit https://review.coreboot.org/23864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f Gerrit-Change-Number: 23864 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: Add "gingerly" flashing mode for the unreliable ISP environments
by build bot (Jenkins) (Code Review) 25 Feb '18

25 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23840 ) Change subject: Add "gingerly" flashing mode for the unreliable ISP environments ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1165/ : SUCCESS -- To view, visit https://review.coreboot.org/23840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Gerrit-Change-Number: 23840 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 25 Feb 2018 10:11:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add "gingerly" flashing mode for the unreliable ISP environments
by Mike Banon (Code Review) 25 Feb '18

25 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23840 to look at the new patch set (#2). Change subject: Add "gingerly" flashing mode for the unreliable ISP environments ...................................................................... Add "gingerly" flashing mode for the unreliable ISP environments Some in-system-programming environments are very unreliable, e.g. when you connect a SOIC8 test clip to the flash chip of WR841ND v9 wireless router: because the low power SOC of this router becomes powered and is constantly trying to boot, the router's flash chip is correctly detected only 30% of times, and when it is detected just 30% of the operations are successful - the rest result in zeroes or garbage data being read from / written to a flash chip. While in this new mode called "-g" / "--gingerly", flashrom will be constantly probing for a flash chip until it is correctly detected - and then, depending on the operation selected by a user, at the moments of chip availability it will be reading or writing by the small chunks of 256 bytes maximum size, verifying each small chunk and retrying the operation until the verification becomes successful. Constant probing between the small chunk operations is also being done - to avoid a possible situation where we have got two identical blocks of zeroes while reading a chunk and erroneously accepted it. Currently this mode is active only for those SPI25 chips which are ".write = spi_chip_write_256" and ".read = spi_chip_read", but later could be expanded to more functions to become useful for more chips. Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- M cli_classic.c M flash.h M libflashrom.c M libflashrom.h M spi25.c 5 files changed, 120 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/23840/2 -- To view, visit https://review.coreboot.org/23840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Gerrit-Change-Number: 23840 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add ZD25D20
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23702 ) Change subject: flashchips: Add ZD25D20 ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1164/ : SUCCESS -- To view, visit https://review.coreboot.org/23702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Gerrit-Change-Number: 23702 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 01:38:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add ZD25D20
by David Hendricks (Code Review) 22 Feb '18

22 Feb '18

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/23702 ) Change subject: flashchips: Add ZD25D20 ...................................................................... flashchips: Add ZD25D20 This adds another Zetta Device chip, the ZD25D20. Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-on: https://review.coreboot.org/23702 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 1d45810..1ab4986 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16332,6 +16332,44 @@ { .vendor = "Zetta Device", + .name = "ZD25D20", + .bustype = BUS_SPI, + .manufacture_id = ZETTADEVICE_ID, + .model_id = ZETTADEVICE_ZD25D20, + .total_size = 256, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 8} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Zetta Device", .name = "ZD25D40", .bustype = BUS_SPI, .manufacture_id = ZETTADEVICE_ID, diff --git a/flashchips.h b/flashchips.h index 8c07628..452f776 100644 --- a/flashchips.h +++ b/flashchips.h @@ -958,6 +958,7 @@ #define WINBOND_W49V002FA 0x32 #define ZETTADEVICE_ID 0xBA /* Zetta Device */ +#define ZETTADEVICE_ZD25D20 0x2012 #define ZETTADEVICE_ZD25D40 0x2013 #endif /* !FLASHCHIPS_H */ -- To view, visit https://review.coreboot.org/23702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Gerrit-Change-Number: 23702 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add ZD25D20
by David Hendricks (Code Review) 22 Feb '18

22 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23702 ) Change subject: flashchips: Add ZD25D20 ...................................................................... Patch Set 4: Code-Review+2 Manually rebased to resolve hunk in flashchips.h where the preceding line changed. -- To view, visit https://review.coreboot.org/23702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Gerrit-Change-Number: 23702 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 01:36:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add ZD25D20
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23702 ) Change subject: flashchips: Add ZD25D20 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1163/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/976/ : SUCCESS -- To view, visit https://review.coreboot.org/23702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Gerrit-Change-Number: 23702 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 01:35:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add ZD25D20
by David Hendricks (Code Review) 22 Feb '18

22 Feb '18

Hello Stefan Tauner, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23702 to look at the new patch set (#4). Change subject: flashchips: Add ZD25D20 ...................................................................... flashchips: Add ZD25D20 This adds another Zetta Device chip, the ZD25D20. Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23702/4 -- To view, visit https://review.coreboot.org/23702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf805252647be44e28296a161d2e6160710bcc71 Gerrit-Change-Number: 23702 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add "gingerly" flashing mode for the unreliable ISP environments
by Mike Banon (Code Review) 21 Feb '18

21 Feb '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23840 ) Change subject: Add "gingerly" flashing mode for the unreliable ISP environments ...................................................................... Patch Set 1: My problem was described at this forum thread - https://forum.openwrt.org/viewtopic.php?id=73100 . Now, thanks to this new mode I'm finally able to successfully read the internal flash memory installed on that router, several times with matching checksums - all without desoldering! :) Hopefully it will be useful to other ISP people who don't like soldering - as the last resort option. Using CH341A it takes about 12 minutes to read in this mode. Flashing should also work - the code is almost identical - but I am going to try it a bit later when I would have slightly more free time and courage ;) -- To view, visit https://review.coreboot.org/23840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Gerrit-Change-Number: 23840 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 23:38:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add "gingerly" flashing mode for the unreliable ISP environments
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23840 ) Change subject: Add "gingerly" flashing mode for the unreliable ISP environments ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1162/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/975/ : SUCCESS -- To view, visit https://review.coreboot.org/23840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f18276d9fb7233d082720cb29d154f31c77100 Gerrit-Change-Number: 23840 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 23:22:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018