February 2018 - flashrom-gerrit

Change in flashrom[master]: board_enable: Whitelist several ThinkPad laptops
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23781 ) Change subject: board_enable: Whitelist several ThinkPad laptops ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/23781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I772f8e109c56a5fd40f6b1aff0f592b915669c17 Gerrit-Change-Number: 23781 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:31:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Be optionally seriously pedantic
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23806 ) Change subject: Be optionally seriously pedantic ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Minor formatting issue, otherwise LGTM. https://review.coreboot.org/#/c/23806/1/Makefile File Makefile: https://review.coreboot.org/#/c/23806/1/Makefile@46 PS1, Line 46: \ : -Wno-unused-parameter weird formatting? -- To view, visit https://review.coreboot.org/23806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie731bdd2af95fb9eb2ee12c34e7e1998a113cd93 Gerrit-Change-Number: 23806 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:30:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Zettadevice ZD25D40
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23701 ) Change subject: flashchips: Add Zettadevice ZD25D40 ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/23701/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23701/2//COMMIT_MSG@14 PS2, Line 14: Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> > Remove the blank line, and move the Change-Id even above the Signed-off-by line. Done https://review.coreboot.org/#/c/23701/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/23701/2/flashchips.h@960 PS2, Line 960: #define ZETTADEVICE_ID 0xBA /* Zetta Device */ > 0xba says the datasheet (0x9f is the rdid instruction?) Yep, silly error on my part. Should be fixed now. -- To view, visit https://review.coreboot.org/23701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Gerrit-Change-Number: 23701 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:14:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Zettadevice ZD25D40
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23701 ) Change subject: flashchips: Add Zettadevice ZD25D40 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1155/ : SUCCESS -- To view, visit https://review.coreboot.org/23701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Gerrit-Change-Number: 23701 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:13:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Zettadevice ZD25D40
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23701 to look at the new patch set (#4). Change subject: flashchips: Add Zettadevice ZD25D40 ...................................................................... flashchips: Add Zettadevice ZD25D40 This introduces the Zettadevice manufacturer ID and adds support for the ZD25D40 chip. Based on PR20 from Github. Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 42 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/23701/4 -- To view, visit https://review.coreboot.org/23701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Gerrit-Change-Number: 23701 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Zettadevice ZD25D40
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23701 ) Change subject: flashchips: Add Zettadevice ZD25D40 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1154/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/971/ : SUCCESS -- To view, visit https://review.coreboot.org/23701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Gerrit-Change-Number: 23701 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:12:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Zettadevice ZD25D40
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23701 to look at the new patch set (#3). Change subject: flashchips: Add Zettadevice ZD25D40 ...................................................................... flashchips: Add Zettadevice ZD25D40 This introduces the Zettadevice manufacturer ID and adds support for the ZD25D40 chip. Based on PR20 from Github. Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece --- M flashchips.c M flashchips.h 2 files changed, 42 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/23701/3 -- To view, visit https://review.coreboot.org/23701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Gerrit-Change-Number: 23701 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Winbond W25P80/16/32 support
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23700 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1153/ : SUCCESS -- To view, visit https://review.coreboot.org/23700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23700 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:09:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Winbond W25P80/16/32 support
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/23700 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... flashchips: Add Winbond W25P80/16/32 support This adds support for W25P80/16/32 chips. Most notably these chips only have two erase commands - one for 64KiB "sectors" and one for chip erase. Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-on: https://review.coreboot.org/23700 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M flashchips.h 2 files changed, 89 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 54c4943..0d85142 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15430,6 +15430,92 @@ }, { + .vendor = "Winbond", + .name = "W25P80", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25P80, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", + .name = "W25P16", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25P16, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2048 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", + .name = "W25P32", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25P32, + .total_size = 4096, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4096 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + { .vendor = "Winbond", .name = "W29C512A/W29EE512", .bustype = BUS_PARALLEL, diff --git a/flashchips.h b/flashchips.h index 6a7b0ae..f487248 100644 --- a/flashchips.h +++ b/flashchips.h @@ -890,6 +890,9 @@ * byte of device ID is related to log(bitsize). */ #define WINBOND_NEX_ID 0xEF /* Winbond (ex Nexcom) serial flashes */ +#define WINBOND_NEX_W25P80 0x2014 +#define WINBOND_NEX_W25P16 0x2015 +#define WINBOND_NEX_W25P32 0x2016 #define WINBOND_NEX_W25X10 0x3011 #define WINBOND_NEX_W25X20 0x3012 #define WINBOND_NEX_W25X40 0x3013 -- To view, visit https://review.coreboot.org/23700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23700 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Winbond W25P80/16/32 support
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23700 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/23700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23700 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:09:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018