February 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add Winbond W25P80/16/32 support
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23700 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/23700/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/23700/2/flashchips.h@916 PS2, Line 916: #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ > Should be placed above, i.e. […] Done -- To view, visit https://review.coreboot.org/23700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23700 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:09:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Winbond W25P80/16/32 support
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23700 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1152/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/970/ : SUCCESS -- To view, visit https://review.coreboot.org/23700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23700 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:07:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Winbond W25P80/16/32 support
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

Hello Stefan Tauner, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23700 to look at the new patch set (#3). Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... flashchips: Add Winbond W25P80/16/32 support This adds support for W25P80/16/32 chips. Most notably these chips only have two erase commands - one for 64KiB "sectors" and one for chip erase. Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/23700/3 -- To view, visit https://review.coreboot.org/23700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23700 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: flashchips: Add Winbond W25P80/16/32 support
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has abandoned this change. ( https://review.coreboot.org/23822 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/23822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23822 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: flashchips: Add Winbond W25P80/16/32 support
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23822 ) Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1151/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/969/ : SUCCESS -- To view, visit https://review.coreboot.org/23822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23822 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 00:55:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[staging]: flashchips: Add Winbond W25P80/16/32 support
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/23822 Change subject: flashchips: Add Winbond W25P80/16/32 support ...................................................................... flashchips: Add Winbond W25P80/16/32 support This adds support for W25P80/16/32 chips. Most notably these chips only have two erase commands - one for 64KiB "sectors" and one for chip erase. Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/23822/1 diff --git a/flashchips.c b/flashchips.c index 54c4943..0d85142 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15430,6 +15430,92 @@ }, { + .vendor = "Winbond", + .name = "W25P80", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25P80, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", + .name = "W25P16", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25P16, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2048 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", + .name = "W25P32", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25P32, + .total_size = 4096, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4096 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + { .vendor = "Winbond", .name = "W29C512A/W29EE512", .bustype = BUS_PARALLEL, diff --git a/flashchips.h b/flashchips.h index 6a7b0ae..f487248 100644 --- a/flashchips.h +++ b/flashchips.h @@ -890,6 +890,9 @@ * byte of device ID is related to log(bitsize). */ #define WINBOND_NEX_ID 0xEF /* Winbond (ex Nexcom) serial flashes */ +#define WINBOND_NEX_W25P80 0x2014 +#define WINBOND_NEX_W25P16 0x2015 +#define WINBOND_NEX_W25P32 0x2016 #define WINBOND_NEX_W25X10 0x3011 #define WINBOND_NEX_W25X20 0x3012 #define WINBOND_NEX_W25X40 0x3013 -- To view, visit https://review.coreboot.org/23822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Ie09ba8e28fee35c42e17ca05219dc673413de93b Gerrit-Change-Number: 23822 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: Be optionally seriously pedantic
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23806 ) Change subject: Be optionally seriously pedantic ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1150/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/968/ : SUCCESS -- To view, visit https://review.coreboot.org/23806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie731bdd2af95fb9eb2ee12c34e7e1998a113cd93 Gerrit-Change-Number: 23806 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 12:36:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Be optionally seriously pedantic
by Nico Huber (Code Review) 18 Feb '18

18 Feb '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23806 Change subject: Be optionally seriously pedantic ...................................................................... Be optionally seriously pedantic This allows to easily test flashrom with numerous compiler warnings enabled. A new variable "PEDANTIC" is introduced which disables the feature by default, but can be overriden on the CLI. Additionally a new phony target "pedantic" is introduced which disables -Werror, enables the pedantic warnings and calls the default target recursively. It also has 'clean' as prerequisite to create consistent output. --- TODO: - make it possible to execute other targets with make pedantic(?) (something like "make pedantic target=djgpp-dos") - refine warnings used Change-Id: Ie731bdd2af95fb9eb2ee12c34e7e1998a113cd93 Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- M Makefile 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/23806/1 diff --git a/Makefile b/Makefile index 26f978f..143382a 100644 --- a/Makefile +++ b/Makefile @@ -32,11 +32,22 @@ RANLIB ?= ranlib WARNERROR ?= yes +PEDANTIC ?= no ifeq ($(WARNERROR), yes) CFLAGS += -Werror endif +ifeq ($(PEDANTIC), yes) +CFLAGS += -std=c99 --pedantic -Wextra -fstrict-aliasing\ + -Wmissing-include-dirs -Winit-self -Wswitch-enum \ + -Wundef -Wbad-function-cast -Wcast-qual -Wcast-align -Wconversion \ + -Wstrict-prototypes -Wmissing-declarations -Wredundant-decls\ + \ + -Wno-unused-parameter + # -Wno-missing-field-initializers -Wno-sign-conversion +endif + # Determine the destination processor architecture override ARCH := $(strip $(shell LC_ALL=C $(CC) -E arch.h|grep -v '^\#')) @@ -248,6 +259,7 @@ PROGRAMMER_OBJS = udelay.o programmer.o all: pciutils features $(PROGRAM)$(EXEC_SUFFIX) + @echo $(CFLAGS) # Set the flashrom version string from the highest revision number # of the checked out flashrom files. @@ -671,8 +683,13 @@ @echo Created $(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2 djgpp-dos: clean - make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip WARNERROR=no OS_ARCH=DOS + $(MAKE) CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip WARNERROR=no OS_ARCH=DOS -.PHONY: all clean distclean compiler pciutils features export tarball dos featuresavailable +pedantic: export WARNERROR=no +pedantic: export PEDANTIC=yes +pedantic: clean + $(MAKE) + +.PHONY: all clean distclean compiler pciutils features export tarball dos featuresavailable pedantic -include $(OBJS:.o=.d) -- To view, visit https://review.coreboot.org/23806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie731bdd2af95fb9eb2ee12c34e7e1998a113cd93 Gerrit-Change-Number: 23806 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Add support for EN29LV800(A/B/C) (was: Confirm EN29LV800 bus, timing, ...
by build bot (Jenkins) (Code Review) 18 Feb '18

18 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23805 ) Change subject: Add support for EN29LV800(A/B/C) (was: Confirm EN29LV800 bus, timing, and page size) ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/967/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1149/ : SUCCESS -- To view, visit https://review.coreboot.org/23805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22b6f18c366144d2e48bc1e2919cfebb3e65e168 Gerrit-Change-Number: 23805 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 18 Feb 2018 12:26:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for EN29LV800(A/B/C) (was: Confirm EN29LV800 bus, timing, ...
by Nico Huber (Code Review) 18 Feb '18

18 Feb '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23805 Change subject: Add support for EN29LV800(A/B/C) (was: Confirm EN29LV800 bus, timing, and page size) ...................................................................... Add support for EN29LV800(A/B/C) (was: Confirm EN29LV800 bus, timing, and page size) This is based on TJ's patches from 2010, see http://patchwork.coreboot.org/patch/883/ http://patchwork.coreboot.org/patch/884/ I have rebased and combined them, added voltages, corrected the names and verified the erase block layouts. Someone else needs to review/change the parallel-specific parts, because i have no idea about all those jedec vs. 3-byte vs. shifted problems (and i actually do not want to know :P). >From e30a0ec21ad12c54ff8a9751005103559122a180 Mon Sep 17 00:00:00 2001 From: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Date: Tue, 2 Aug 2011 16:33:21 +0200 Subject: [PATCH] Add support for EN29LV800(A/B/C) Change-Id: I22b6f18c366144d2e48bc1e2919cfebb3e65e168 Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- M flashchips.c M flashchips.h 2 files changed, 66 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/23805/1 diff --git a/flashchips.c b/flashchips.c index b6296c5..f1e0ee4 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3517,6 +3517,70 @@ { .vendor = "Eon", + .name = "EN29LV800(A/B/C)B", + .bustype = BUS_PARALLEL, + .manufacture_id = EON_ID, + .model_id = EON_EN29LV800B, + .total_size = 1024, + .page_size = 1024, + .feature_bits = FEATURE_ADDR_AAA | FEATURE_EITHER_RESET, + .tested = TEST_UNTESTED, + .probe = probe_jedec, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { + {16 * 1024, 1}, + {8 * 1024, 2}, + {32 * 1024, 1}, + {64 * 1024, 15}, + }, + .block_erase = erase_sector_jedec, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = erase_chip_block_jedec, + }, + }, + .write = NULL, + .read = read_memmapped, + .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, -55R, others 2.7-3.6V */ + }, + + { + .vendor = "Eon", + .name = "EN29LV800(A/B/C)T", + .bustype = BUS_PARALLEL, + .manufacture_id = EON_ID, + .model_id = EON_EN29LV800T, + .total_size = 1024, + .page_size = 1024, + .feature_bits = FEATURE_ADDR_AAA | FEATURE_EITHER_RESET, + .tested = TEST_UNTESTED, + .probe = probe_jedec, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { + {64 * 1024, 15}, + {32 * 1024, 1}, + {8 * 1024, 2}, + {16 * 1024, 1}, + }, + .block_erase = erase_sector_jedec, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = erase_chip_block_jedec, + }, + }, + .write = NULL, + .read = read_memmapped, + .voltage = {3000, 3600}, /* 3.0-3.6V for type -70R, -55R, others 2.7-3.6V */ + }, + + { + .vendor = "Eon", .name = "EN29F002(A)(N)B", .bustype = BUS_PARALLEL, .manufacture_id = EON_ID, diff --git a/flashchips.h b/flashchips.h index de3c79d..c44972a 100644 --- a/flashchips.h +++ b/flashchips.h @@ -256,6 +256,8 @@ #define EON_EN29F040A 0x7F04 #define EON_EN29LV010 0x7F6E #define EON_EN29LV040A 0x7F4F /* EN29LV040(A) */ +#define EON_EN29LV800B 0x7F5B /* EN29LV800(A/B/C) bottom */ +#define EON_EN29LV800T 0x7FDA /* EN29LV800(A/B/C) top */ #define EON_EN29F002T 0x7F92 /* Same as EN29F002A */ #define EON_EN29F002B 0x7F97 /* Same as EN29F002AN */ -- To view, visit https://review.coreboot.org/23805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I22b6f18c366144d2e48bc1e2919cfebb3e65e168 Gerrit-Change-Number: 23805 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018