February 2018 - flashrom-gerrit

Change in flashrom[master]: WIP: dediprog: implement updated command spec
by David Hendricks (Code Review) 21 Feb '18

21 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23836 ) Change subject: WIP: dediprog: implement updated command spec ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 15:42:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: WIP: dediprog: implement updated command spec
by build bot (Jenkins) (Code Review) 21 Feb '18

21 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23836 ) Change subject: WIP: dediprog: implement updated command spec ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1158/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/973/ : SUCCESS -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 15:41:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: WIP: dediprog: implement updated command spec
by David Hendricks (Code Review) 21 Feb '18

21 Feb '18

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/23836 Change subject: WIP: dediprog: implement updated command spec ...................................................................... WIP: dediprog: implement updated command spec This is a work-in-progress to update the command spec for Dediprog SF100/SF600 programmers. For now the new bulk read and write command packet format is hacked in and will be cleaned up once things are working and I get clarification about which firmware versions implement them. Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M dediprog.c 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/23836/1 diff --git a/dediprog.c b/dediprog.c index 2f5b441..fce067a 100644 --- a/dediprog.c +++ b/dediprog.c @@ -387,7 +387,7 @@ return 0; } -static void fill_rw_cmd_payload(uint8_t *data_packet, unsigned int count, uint8_t dedi_spi_cmd, unsigned int *value, unsigned int *idx, unsigned int start) { +static void fill_rw_cmd_payload(uint8_t *data_packet, unsigned int count, uint8_t dedi_spi_cmd, unsigned int *value, unsigned int *idx, unsigned int start, int is_read) { /* First 5 bytes are common in both generations. */ data_packet[0] = count & 0xff; data_packet[1] = (count >> 8) & 0xff; @@ -402,6 +402,15 @@ data_packet[7] = (start >> 8) & 0xff; data_packet[8] = (start >> 16) & 0xff; data_packet[9] = (start >> 24) & 0xff; + if (is_read) { + data_packet[10] = 0x00; + data_packet[11] = 0x00; + } else { + data_packet[10] = 0x00; + data_packet[11] = 0x00; + data_packet[12] = 0x01; + data_packet[13] = 0x00; + } } else { *value = start % 0x10000; *idx = start / 0x10000; @@ -435,9 +444,9 @@ return 0; /* Command packet size of protocols: new 10 B, old 5 B. */ - uint8_t data_packet[is_new_prot() ? 10 : 5]; + uint8_t data_packet[is_new_prot() ? 12 : 5]; unsigned int value, idx; - fill_rw_cmd_payload(data_packet, count, READ_MODE_STD, &value, &idx, start); + fill_rw_cmd_payload(data_packet, count, READ_MODE_STD, &value, &idx, start, 1); int ret = dediprog_write(CMD_READ, value, idx, data_packet, sizeof(data_packet)); if (ret != sizeof(data_packet)) { @@ -577,9 +586,9 @@ return 0; /* Command packet size of protocols: new 10 B, old 5 B. */ - uint8_t data_packet[is_new_prot() ? 10 : 5]; + uint8_t data_packet[is_new_prot() ? 14 : 5]; unsigned int value, idx; - fill_rw_cmd_payload(data_packet, count, dedi_spi_cmd, &value, &idx, start); + fill_rw_cmd_payload(data_packet, count, dedi_spi_cmd, &value, &idx, start, 0); int ret = dediprog_write(CMD_WRITE, value, idx, data_packet, sizeof(data_packet)); if (ret != sizeof(data_packet)) { msg_perr("Command Write SPI Bulk failed, %s!\n", libusb_error_name(ret)); -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add Zettadevice ZD25D40
by Nico Huber (Code Review) 20 Feb '18

20 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23701 ) Change subject: flashchips: Add Zettadevice ZD25D40 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/23701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece Gerrit-Change-Number: 23701 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 14:48:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: git-hooks: Fix install script for various git versions
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22971 ) Change subject: git-hooks: Fix install script for various git versions ...................................................................... Patch Set 2: Code-Review+2 `make gitconfig` seems like a reasonable approach, too -- To view, visit https://review.coreboot.org/22971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Gerrit-Change-Number: 22971 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 03:53:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: dmi: Don't print dmidecode shell error
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23802 ) Change subject: dmi: Don't print dmidecode shell error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/23802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9 Gerrit-Change-Number: 23802 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 02:34:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Whitelist Lenovo Thinkpad X220
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23225 ) Change subject: Whitelist Lenovo Thinkpad X220 ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/23225/4//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23225/4//COMMIT_MSG@10 PS4, Line 10: i it -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:34:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Whitelist Lenovo Thinkpad X220
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23225 ) Change subject: Whitelist Lenovo Thinkpad X220 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1157/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/972/ : SUCCESS -- To view, visit https://review.coreboot.org/23225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd667da8209a664469c1a909a549d2b625714a78 Gerrit-Change-Number: 23225 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:34:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: board_enable: Whitelist several ThinkPad laptops
by build bot (Jenkins) (Code Review) 20 Feb '18

20 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23781 ) Change subject: board_enable: Whitelist several ThinkPad laptops ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1156/ : SUCCESS -- To view, visit https://review.coreboot.org/23781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I772f8e109c56a5fd40f6b1aff0f592b915669c17 Gerrit-Change-Number: 23781 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 01:32:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: board_enable: Whitelist several ThinkPad laptops
by David Hendricks (Code Review) 20 Feb '18

20 Feb '18

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/23781 ) Change subject: board_enable: Whitelist several ThinkPad laptops ...................................................................... board_enable: Whitelist several ThinkPad laptops Newly whitelisted laptops include: * ThinkPad R400 * ThinkPad T500 * ThinkPad W500 * Libiquity Taurinus X200 Change-Id: I772f8e109c56a5fd40f6b1aff0f592b915669c17 Signed-off-by: Leah Rowe <leah(a)libreboot.org> Reviewed-on: https://review.coreboot.org/23781 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M board_enable.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved David Hendricks: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index b6e17ef..f2952c7 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2428,14 +2428,18 @@ {0x8086, 0x7190, 0, 0, 0x8086, 0x7110, 0, 0, "^SE440BX-2$", NULL, NULL, P3, "Intel", "SE440BX-2", 0, NT, intel_piix4_gpo27_lower}, {0x1022, 0x7468, 0, 0, 0x1022, 0x7460, 0, 0, NULL, "iwill", "dk8_htx", P3, "IWILL", "DK8-HTX", 0, OK, w83627hf_gpio24_raise_2e}, {0x8086, 0x27A0, 0x8086, 0x27a0, 0x8086, 0x27b8, 0x8086, 0x27b8, NULL, "kontron", "986lcd-m", P3, "Kontron", "986LCD-M", 0, OK, board_kontron_986lcd_m}, + {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad R400", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad R400", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad T400", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T400", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad T500", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T500", 0, OK, p2_whitelist_laptop}, {0x8086, 0x1E22, 0x17AA, 0x21F6, 0x8086, 0x1E55, 0x17AA, 0x21F6, "^ThinkPad T530", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T530", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27a0, 0x17aa, 0x2015, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60(s)", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad W500", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad W500", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad X200", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X200", 0, OK, p2_whitelist_laptop}, {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^Lenovo X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, {0x8086, 0x1E22, 0x17AA, 0x21FA, 0x8086, 0x1E55, 0x17AA, 0x21FA, "^ThinkPad X230", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X230", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x17AA, 0x2017, 0x8086, 0x27B9, 0x17AA, 0x2009, "^ThinkPad X60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X60(s)", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^Taurinus X200", "Libiquity", "Taurinus X200", P2, "Libiquity", "ThinkPad X200", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2411, 0x8086, 0x2411, 0x8086, 0x7125, 0x0e11, 0xb165, NULL, NULL, NULL, P3, "Mitac", "6513WU", 0, OK, board_mitac_6513wu}, {0x8086, 0x8186, 0x8086, 0x8186, 0x8086, 0x8800, 0, 0, "^MSC Vertriebs GmbH$", NULL, NULL, P2, "MSC", "Q7-TCTC", 0, OK, p2_not_a_laptop}, {0x8086, 0x7190, 0, 0, 0x8086, 0x7110, 0, 0, "^MS-6163 (i440BX)$", NULL, NULL, P3, "MSI", "MS-6163 (MS-6163 Pro)", 0, OK, intel_piix4_gpo14_raise}, -- To view, visit https://review.coreboot.org/23781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I772f8e109c56a5fd40f6b1aff0f592b915669c17 Gerrit-Change-Number: 23781 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018