September 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add Sanyo LE25FU206/A and LE25FU106B
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28813 to look at the new patch set (#2). Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ...................................................................... flashchips: Add Sanyo LE25FU206/A and LE25FU106B As per user `The_Raven Raven` on the mailing list. Change-Id: I6c26aafdca232110986334e85297d73d513600dc Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 96 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/28813/2 -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Mark Atmel AT45DB081D as tested.
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28825 Change subject: flashchips: Mark Atmel AT45DB081D as tested. ...................................................................... flashchips: Mark Atmel AT45DB081D as tested. As per `The_Raven Raven` on the mailing list. Change-Id: I225984b9e2589713f25d0f9b49eb1c3abdcff3cd Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/28825/1 diff --git a/flashchips.c b/flashchips.c index fbb2b63..1756f09 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2791,7 +2791,7 @@ /* does not support EWSR nor WREN and has no writable status register bits whatsoever */ /* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */ .feature_bits = FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_at45db, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I225984b9e2589713f25d0f9b49eb1c3abdcff3cd Gerrit-Change-Number: 28825 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark PMC Pm25LD040 as tested
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28823 Change subject: flashchips: Mark PMC Pm25LD040 as tested ...................................................................... flashchips: Mark PMC Pm25LD040 as tested As per `The_Raven Raven` on the mailing list. Change-Id: Ied8d07c54f8a222dbe05503f859f82bba27d8336 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/28823/1 diff --git a/flashchips.c b/flashchips.c index 1fe63c2..aad8df6 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10888,7 +10888,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ied8d07c54f8a222dbe05503f859f82bba27d8336 Gerrit-Change-Number: 28823 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Winbond W25Q40BW as tested.
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28824 Change subject: flashchips: Mark Winbond W25Q40BW as tested. ...................................................................... flashchips: Mark Winbond W25Q40BW as tested. As per `The_Raven Raven` on the mailing list. The tested chip was `W25Q40.W`, but it was later renamed to `W25Q40BW` when the `W25Q40EW` was added. Change-Id: I624adef2c5b4dd83f0ce93d6069e315fc407db19 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/28824/1 diff --git a/flashchips.c b/flashchips.c index aad8df6..fbb2b63 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15485,7 +15485,7 @@ .page_size = 256, /* OTP: 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I624adef2c5b4dd83f0ce93d6069e315fc407db19 Gerrit-Change-Number: 28824 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25U8032E
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28821 Change subject: flashchips: Add Macronix MX25U8032E ...................................................................... flashchips: Add Macronix MX25U8032E As per `The_Raven Raven` on the mailing list. Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/28821/1 diff --git a/flashchips.c b/flashchips.c index 62f8119..cb81292 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8439,6 +8439,47 @@ { .vendor = "Macronix", + .name = "MX25U8032E", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25U8032E, + .total_size = 1024, + .page_size = 256, + /* OTP: 512B total; enter 0xB1, exit 0xC1 */ + /* QPI enable 0x35, disable 0xF5 (0xFF et al. work too) */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 32} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + /* TODO: security register */ + .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {1650, 2000}, + }, + + { + .vendor = "Macronix", .name = "MX25U1635E", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/flashchips.h b/flashchips.h index f640495..4497afe 100644 --- a/flashchips.h +++ b/flashchips.h @@ -487,6 +487,7 @@ #define MACRONIX_MX25L1635D 0x2415 #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ #define MACRONIX_MX66L51235F 0x201a /* MX66L51235F */ +#define MACRONIX_MX25U8032E 0x2534 #define MACRONIX_MX25U1635E 0x2535 #define MACRONIX_MX25U3235E 0x2536 /* Same as MX25U6435F */ #define MACRONIX_MX25U6435E 0x2537 /* Same as MX25U6435F */ -- To view, visit https://review.coreboot.org/28821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Gerrit-Change-Number: 28821 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Sanyo LE25FU406C as tested
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28822 Change subject: flashchips: Mark Sanyo LE25FU406C as tested ...................................................................... flashchips: Mark Sanyo LE25FU406C as tested As per `The_Raven Raven` on the mailing list. Change-Id: I1dba38d03c826a53bff3ddad0aa536032c5532a1 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/28822/1 diff --git a/flashchips.c b/flashchips.c index cb81292..1fe63c2 100644 --- a/flashchips.c +++ b/flashchips.c @@ -11789,7 +11789,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PR, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/28822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1dba38d03c826a53bff3ddad0aa536032c5532a1 Gerrit-Change-Number: 28822 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark AMIC A25L40PU as tested
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28818 Change subject: flashchips: Mark AMIC A25L40PU as tested ...................................................................... flashchips: Mark AMIC A25L40PU as tested As per Stefan Szwarnowski on the mailing list. Change-Id: I574094bdb83611a3cda2fcc455bcf9aed3774011 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/28818/1 diff --git a/flashchips.c b/flashchips.c index 4b934bc..abe7858 100644 --- a/flashchips.c +++ b/flashchips.c @@ -871,7 +871,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PR, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid4, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I574094bdb83611a3cda2fcc455bcf9aed3774011 Gerrit-Change-Number: 28818 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark GigaDevice GD25Q128C as tested
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28819 Change subject: flashchips: Mark GigaDevice GD25Q128C as tested ...................................................................... flashchips: Mark GigaDevice GD25Q128C as tested As per Tomasz Walach on the mailing list. Change-Id: Ib0d7485c7221f92ec13995c58065a48e08f57cd8 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/28819/1 diff --git a/flashchips.c b/flashchips.c index abe7858..768447f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6398,7 +6398,7 @@ /* OTP: 1536B total; read 0x48; write 0x42, erase 0x44 */ /* QPI: enable 0x38, disable 0xFF */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0d7485c7221f92ec13995c58065a48e08f57cd8 Gerrit-Change-Number: 28819 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark PMC Pm25LD020 as tested
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28820 Change subject: flashchips: Mark PMC Pm25LD020 as tested ...................................................................... flashchips: Mark PMC Pm25LD020 as tested As per `The_Raven Raven` on the mailing list. Change-Id: I16d5a207599b434fe52b42709e42f1f32a8e6698 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/28820/1 diff --git a/flashchips.c b/flashchips.c index 768447f..62f8119 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10809,7 +10809,7 @@ .total_size = 256, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I16d5a207599b434fe52b42709e42f1f32a8e6698 Gerrit-Change-Number: 28820 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Mark Winbond W25Q256.V as tested
by Angel Pons (Code Review) Sept. 30, 2018

Sept. 30, 2018

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28816 Change subject: flashchips: Mark Winbond W25Q256.V as tested ...................................................................... flashchips: Mark Winbond W25Q256.V as tested As per Richard Hughes via the mailing list. Change-Id: Ic562a65d1a7d394f9d2c3980833d10a87bd9358a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/28816/1 diff --git a/flashchips.c b/flashchips.c index 7610b24..4b934bc 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15366,7 +15366,7 @@ /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_EXT_ADDR | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/28816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic562a65d1a7d394f9d2c3980833d10a87bd9358a Gerrit-Change-Number: 28816 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0